grpc
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

services: fix lint on toString (#4481) 

BinlogHelper does not override toString so print something else that
is more descriptive.
This commit is contained in:
zpencer 2018-05-18 12:54:17 -07:00 committed by GitHub
parent 850249f9ca
commit ad370d807b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
services/src/main/java/io/grpc/services/BinlogHelper.java
View File

@ -404,27 +404,33 @@ final class BinlogHelper {
} }
if (methodOrSvc.equals("*")) { if (methodOrSvc.equals("*")) {
if (globalLog != null) { if (globalLog != null) {
logger.log(Level.SEVERE, "Ignoring duplicate entry: " + configuration); logger.log(Level.SEVERE, "Ignoring duplicate entry: {0}", configuration);
continue; continue;
} }
globalLog = binLog; globalLog = binLog;
logger.info("Global binlog: " + globalLog); logger.log(Level.INFO, "Global binlog: {0}", binlogOptionStr);
} else if (isServiceGlob(methodOrSvc)) { } else if (isServiceGlob(methodOrSvc)) {
String service = MethodDescriptor.extractFullServiceName(methodOrSvc); String service = MethodDescriptor.extractFullServiceName(methodOrSvc);
if (perServiceLogs.containsKey(service)) { if (perServiceLogs.containsKey(service)) {
logger.log(Level.SEVERE, "Ignoring duplicate entry: " + configuration); logger.log(Level.SEVERE, "Ignoring duplicate entry: {0}", configuration);
continue; continue;
} }
perServiceLogs.put(service, binLog); perServiceLogs.put(service, binLog);
logger.info(String.format("Service binlog: service=%s log=%s", service, binLog)); logger.log(
Level.INFO,
"Service binlog: service={0} config={1}",
new Object[] {service, binlogOptionStr});
} else { } else {
// assume fully qualified method name // assume fully qualified method name
if (perMethodLogs.containsKey(methodOrSvc)) { if (perMethodLogs.containsKey(methodOrSvc)) {
logger.log(Level.SEVERE, "Ignoring duplicate entry: " + configuration); logger.log(Level.SEVERE, "Ignoring duplicate entry: {0}", configuration);
continue; continue;
} }
perMethodLogs.put(methodOrSvc, binLog); perMethodLogs.put(methodOrSvc, binLog);
logger.info(String.format("Method binlog: method=%s log=%s", methodOrSvc, binLog)); logger.log(
Level.INFO,
"Method binlog: method={0} config={1}",
new Object[] {methodOrSvc, binlogOptionStr});
} }
} }
} }