grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grpc-js: Remove redundant calls to setCredentials

This commit is contained in:
Michael Lumish 2022-10-14 10:27:38 -07:00
parent 8a312e63b7
commit 59a2cbceeb
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/grpc-js/src/client-interceptors.ts
View File

@ -198,8 +198,6 @@ export interface InterceptingCallInterface {
sendMessage(message: any): void; sendMessage(message: any): void;
startRead(): void; startRead(): void;
halfClose(): void; halfClose(): void;
setCredentials(credentials: CallCredentials): void;
} }
export class InterceptingCall implements InterceptingCallInterface { export class InterceptingCall implements InterceptingCallInterface {
@ -337,9 +335,6 @@ export class InterceptingCall implements InterceptingCallInterface {
} }
}); });
} }
setCredentials(credentials: CallCredentials): void {
this.nextCall.setCredentials(credentials);
}
} }
function getCall(channel: Channel, path: string, options: CallOptions): Call { function getCall(channel: Channel, path: string, options: CallOptions): Call {
@ -371,9 +366,6 @@ class BaseInterceptingCall implements InterceptingCallInterface {
getPeer(): string { getPeer(): string {
return this.call.getPeer(); return this.call.getPeer();
} }
setCredentials(credentials: CallCredentials): void {
this.call.setCredentials(credentials);
}
// eslint-disable-next-line @typescript-eslint/no-explicit-any // eslint-disable-next-line @typescript-eslint/no-explicit-any
sendMessageWithContext(context: MessageContext, message: any): void { sendMessageWithContext(context: MessageContext, message: any): void {
let serialized: Buffer; let serialized: Buffer;

12
packages/grpc-js/src/client.ts
View File

@ -321,9 +321,6 @@ export class Client {
* before calling the CallInvocationTransformer, and we need to create the * before calling the CallInvocationTransformer, and we need to create the
* call after that. */ * call after that. */
emitter.call = call; emitter.call = call;
if (callProperties.callOptions.credentials) {
call.setCredentials(callProperties.callOptions.credentials);
}
let responseMessage: ResponseType | null = null; let responseMessage: ResponseType | null = null;
let receivedStatus = false; let receivedStatus = false;
const callerStackError = new Error(); const callerStackError = new Error();
@ -449,9 +446,6 @@ export class Client {
* before calling the CallInvocationTransformer, and we need to create the * before calling the CallInvocationTransformer, and we need to create the
* call after that. */ * call after that. */
emitter.call = call; emitter.call = call;
if (callProperties.callOptions.credentials) {
call.setCredentials(callProperties.callOptions.credentials);
}
let responseMessage: ResponseType | null = null; let responseMessage: ResponseType | null = null;
let receivedStatus = false; let receivedStatus = false;
const callerStackError = new Error(); const callerStackError = new Error();
@ -582,9 +576,6 @@ export class Client {
* before calling the CallInvocationTransformer, and we need to create the * before calling the CallInvocationTransformer, and we need to create the
* call after that. */ * call after that. */
stream.call = call; stream.call = call;
if (callProperties.callOptions.credentials) {
call.setCredentials(callProperties.callOptions.credentials);
}
let receivedStatus = false; let receivedStatus = false;
const callerStackError = new Error(); const callerStackError = new Error();
call.start(callProperties.metadata, { call.start(callProperties.metadata, {
@ -681,9 +672,6 @@ export class Client {
* before calling the CallInvocationTransformer, and we need to create the * before calling the CallInvocationTransformer, and we need to create the
* call after that. */ * call after that. */
stream.call = call; stream.call = call;
if (callProperties.callOptions.credentials) {
call.setCredentials(callProperties.callOptions.credentials);
}
let receivedStatus = false; let receivedStatus = false;
const callerStackError = new Error(); const callerStackError = new Error();
call.start(callProperties.metadata, { call.start(callProperties.metadata, {