grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1852 from murgatroid99/grpc-js_bind_creds_typecheck 

grpc-js: Tighten server.bindAsync creds typecheck
This commit is contained in:
Michael Lumish 2021-07-19 13:15:29 -07:00 committed by GitHub
parent 19f8da1b34 af1676a5a5
commit bd1571fa94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/grpc-js/src/server.ts
View File

@ -237,8 +237,8 @@ export class Server {
throw new TypeError('port must be a string');
}
if (creds === null || typeof creds !== 'object') {
throw new TypeError('creds must be an object');
if (creds === null || !(creds instanceof ServerCredentials)) {
throw new TypeError('creds must be a ServerCredentials object');
}
if (typeof callback !== 'function') {

6
packages/grpc-js/test/test-server.ts
View File

@ -116,7 +116,11 @@ describe('Server', () => {
assert.throws(() => {
server.bindAsync('localhost:0', null as any, noop);
}, /creds must be an object/);
}, /creds must be a ServerCredentials object/);
assert.throws(() => {
server.bindAsync('localhost:0', grpc.credentials.createInsecure() as any, noop);
}, /creds must be a ServerCredentials object/);
assert.throws(() => {
server.bindAsync(