grpc
/
grpc-node
mirror of https://github.com/grpc/grpc-node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #622 from JustinBeckwith/isfun 

refactor: drop usage of _.isFunction
This commit is contained in:
Michael Lumish 2018-11-12 17:02:55 -08:00 committed by GitHub
parent 494b97ac1a a58c178119
commit d4f97546a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/grpc-native-core/src/client.js
View File

@ -449,7 +449,7 @@ Client.prototype.resolveCallInterceptors = function(method_definition, intercept
Client.prototype.makeUnaryRequest = function(path, serialize, deserialize,
argument, metadata, options,
callback) {
if (_.isFunction(options)) {
if (typeof options === 'function') {
callback = options;
if (metadata instanceof Metadata) {
options = {};
@ -457,7 +457,7 @@ Client.prototype.makeUnaryRequest = function(path, serialize, deserialize,
options = metadata;
metadata = new Metadata();
}
} else if (_.isFunction(metadata)) {
} else if (typeof metadata === 'function') {
callback = metadata;
metadata = new Metadata();
options = {};
@ -470,7 +470,7 @@ Client.prototype.makeUnaryRequest = function(path, serialize, deserialize,
}
if (!((metadata instanceof Metadata) &&
(options instanceof Object) &&
(_.isFunction(callback)))) {
(typeof callback === 'function'))) {
throw new Error('Argument mismatch in makeUnaryRequest');
}
@ -552,7 +552,7 @@ Client.prototype.makeUnaryRequest = function(path, serialize, deserialize,
Client.prototype.makeClientStreamRequest = function(path, serialize,
deserialize, metadata,
options, callback) {
if (_.isFunction(options)) {
if (typeof options === 'function') {
callback = options;
if (metadata instanceof Metadata) {
options = {};
@ -560,7 +560,7 @@ Client.prototype.makeClientStreamRequest = function(path, serialize,
options = metadata;
metadata = new Metadata();
}
} else if (_.isFunction(metadata)) {
} else if (typeof metadata === 'function') {
callback = metadata;
metadata = new Metadata();
options = {};
@ -573,7 +573,7 @@ Client.prototype.makeClientStreamRequest = function(path, serialize,
}
if (!((metadata instanceof Metadata) &&
(options instanceof Object) &&
(_.isFunction(callback)))) {
(typeof callback === 'function'))) {
throw new Error('Argument mismatch in makeClientStreamRequest');
}