Merge pull request #2812 from Poor12/add-event-for-federated-resource-quota

Add event for federatedResourceQuota
This commit is contained in:
karmada-bot 2022-11-22 11:58:05 +08:00 committed by GitHub
commit afd1c074c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 10 deletions

View File

@ -26,6 +26,7 @@ import (
policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1" policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1"
workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1" workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1"
"github.com/karmada-io/karmada/pkg/events"
"github.com/karmada-io/karmada/pkg/util" "github.com/karmada-io/karmada/pkg/util"
"github.com/karmada-io/karmada/pkg/util/helper" "github.com/karmada-io/karmada/pkg/util/helper"
"github.com/karmada-io/karmada/pkg/util/names" "github.com/karmada-io/karmada/pkg/util/names"
@ -61,20 +62,12 @@ func (c *StatusController) Reconcile(ctx context.Context, req controllerruntime.
return controllerruntime.Result{}, nil return controllerruntime.Result{}, nil
} }
workList := &workv1alpha1.WorkList{}
if err := c.List(ctx, workList, &client.ListOptions{
LabelSelector: labels.SelectorFromSet(labels.Set{
util.FederatedResourceQuotaNamespaceLabel: quota.Namespace,
util.FederatedResourceQuotaNameLabel: quota.Name,
}),
}); err != nil {
klog.Errorf("Failed to list workList created by federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err)
}
if err := c.collectQuotaStatus(quota); err != nil { if err := c.collectQuotaStatus(quota); err != nil {
klog.Errorf("Failed to collect status from works to federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err) klog.Errorf("Failed to collect status from works to federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err)
c.EventRecorder.Eventf(quota, corev1.EventTypeWarning, events.EventReasonCollectFederatedResourceQuotaStatusFailed, err.Error())
return controllerruntime.Result{Requeue: true}, err return controllerruntime.Result{Requeue: true}, err
} }
c.EventRecorder.Eventf(quota, corev1.EventTypeNormal, events.EventReasonCollectFederatedResourceQuotaStatusSucceed, "Collect status of FederatedResourceQuota(%s) succeed.", req.NamespacedName.String())
return controllerruntime.Result{}, nil return controllerruntime.Result{}, nil
} }

View File

@ -22,6 +22,7 @@ import (
clusterv1alpha1 "github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1" clusterv1alpha1 "github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1"
policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1" policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1"
workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1" workv1alpha1 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha1"
"github.com/karmada-io/karmada/pkg/events"
"github.com/karmada-io/karmada/pkg/util" "github.com/karmada-io/karmada/pkg/util"
"github.com/karmada-io/karmada/pkg/util/helper" "github.com/karmada-io/karmada/pkg/util/helper"
"github.com/karmada-io/karmada/pkg/util/names" "github.com/karmada-io/karmada/pkg/util/names"
@ -65,8 +66,10 @@ func (c *SyncController) Reconcile(ctx context.Context, req controllerruntime.Re
if err := c.buildWorks(quota, clusterList.Items); err != nil { if err := c.buildWorks(quota, clusterList.Items); err != nil {
klog.Errorf("Failed to build works for federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err) klog.Errorf("Failed to build works for federatedResourceQuota(%s), error: %v", req.NamespacedName.String(), err)
c.EventRecorder.Eventf(quota, corev1.EventTypeWarning, events.EventReasonSyncFederatedResourceQuotaFailed, err.Error())
return controllerruntime.Result{Requeue: true}, err return controllerruntime.Result{Requeue: true}, err
} }
c.EventRecorder.Eventf(quota, corev1.EventTypeNormal, events.EventReasonSyncFederatedResourceQuotaSucceed, "Sync works for FederatedResourceQuota(%s) succeed.", req.NamespacedName.String())
return controllerruntime.Result{}, nil return controllerruntime.Result{}, nil
} }

View File

@ -66,6 +66,18 @@ const (
EventReasonDescheduleBindingSucceed = "DescheduleBindingSucceed" EventReasonDescheduleBindingSucceed = "DescheduleBindingSucceed"
) )
// Define events for FederatedResourceQuota.
const (
// EventReasonSyncFederatedResourceQuotaFailed indicates that Sync work failed.
EventReasonSyncFederatedResourceQuotaFailed = "SyncWorkFailed"
// EventReasonSyncFederatedResourceQuotaSucceed indicates that Sync work succeed.
EventReasonSyncFederatedResourceQuotaSucceed = "SyncWorkSucceed"
// EventReasonCollectFederatedResourceQuotaStatusFailed indicates that aggregate status failed.
EventReasonCollectFederatedResourceQuotaStatusFailed = "AggregateStatusFailed"
// EventReasonCollectFederatedResourceQuotaStatusSucceed indicates that aggregate status succeed.
EventReasonCollectFederatedResourceQuotaStatusSucceed = "AggregateStatusSucceed"
)
// Define events for resource templates. // Define events for resource templates.
const ( const (
// EventReasonApplyPolicyFailed indicates that apply policy for resource failed. // EventReasonApplyPolicyFailed indicates that apply policy for resource failed.