knative
/
docs
mirror of https://github.com/knative/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add link to image in Dockerhub (#747) 

* Add link to image in Dockerhub

Mainly for consistency with other samples.

* also README

* Fixes indentation issue causing build test failure

* fix bullet list indentation

* attempt #2 -- fixing build failure
This commit is contained in:
Steren 2019-01-15 10:18:31 -08:00 committed by Knative Prow Robot
parent b6732c9216
commit 2078ae3723
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
serving/samples/helloworld-go/Dockerfile
View File

@ -1,5 +1,6 @@
# Use the offical Golang image to create a build artifact.
# This is based on Debian and sets the GOPATH to /go.
# https://hub.docker.com/_/golang
FROM golang as builder
# Copy local code to the container image.

2
serving/samples/helloworld-go/README.md
View File

@ -61,6 +61,7 @@ recreate the source files from this folder.
```docker
# Use the offical Golang image to create a build artifact.
# This is based on Debian and sets the GOPATH to /go.
# https://hub.docker.com/_/golang
FROM golang as builder
# Copy local code to the container image.
@ -136,7 +137,6 @@ folder) you're ready to build and deploy the sample app.
```
1. Now that your service is created, Knative will perform the following steps:
- Create a new immutable revision for this version of the app.
- Network programming to create a route, ingress, service, and load balance
for your app.