knative
/
docs
mirror of https://github.com/knative/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify Node.js package.json (#825) 

* Simplify Node.js package.json 

Since this is a Hello World, I do not think we need the `homepage`, `bugs` and `repository` attributes of package.json, but instead I suggest to keep it short in order to show the actual simplicity of the sample

* README missed the dependencies
This commit is contained in:
Steren 2019-01-30 10:11:21 -08:00 committed by RichieEscarez
parent 85159ad8a8
commit 996a43d378
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
serving/samples/helloworld-nodejs/README.md
View File

@ -74,7 +74,10 @@ recreate the source files from this folder.
"start": "node app.js"
},
"author": "",
"license": "Apache-2.0"
"license": "Apache-2.0",
"dependencies": {
"express": "^4.16.4"
}
}
```

8
serving/samples/helloworld-nodejs/package.json
View File

@ -6,16 +6,8 @@
"scripts": {
"start": "node app.js"
},
"repository": {
"type": "git",
"url": "git+https://github.com/knative/docs.git"
},
"author": "",
"license": "Apache-2.0",
"bugs": {
"url": "https://github.com/knative/serving/issues"
},
"homepage": "https://github.com/knative/serving#readme",
"dependencies": {
"express": "^4.16.4"
}