Commit Graph

723 Commits

Author SHA1 Message Date
Luke Kingland 9a0335de7d
src: exported client constructor with options (#883)
* update root and version structure and help text

* fix: limit openshift int test with tag

* refactor: commands to use simplifed, unified constructor

* fix ineffectual assignment lint error

* cleanup

* add repository to run command

* callout for forthcoming s2i builder impl

* lint errors

* re-add the deferred client factory

* remove setNamespaceFlag now that it is persistent

* avoid side-effect of global-mutating deploy tests

* reduce line-by-line difference for PR ease

* simplificaiton of tests and comment lines for further PR ease purposes

* reduce inconsequential differences for ease of PR

* tests to RootCommandConfig

* review comment updates

* fix lint errors

* replace stdlib Setenv in tests

Using t.Setenv will require an update to go1.17, which is out of scope
for this PR.

* pass ClientFactory throughout

* explicitly empty test command args

See https://github.com/spf13/cobra/pull/155

Errors can still be encountered when, for example, using precomiled
tests.  Explicitly setting constructed command args to the empty slice
ensures we avoid hitting any futher edge cases.
2022-03-30 00:58:46 +00:00
Thomas Risberg 9a6aaa5474
Support using 'func invoke' for springboot templates (#920)
* Support using 'func invoke' for springboot templates

- add README notes for using 'func invoke' to springboot templates
- update ce-type used for cloudevents template tests

* Re-generate zz_filesystem_generated.go after rebase
2022-03-23 09:31:18 -07:00
Matej Vasek c766e75a77
Improve template ZIP generation (#917)
* Improve template ZIP generation

Use only 755 and 644 mod permission.
The exec bit is really the only one that we care about.

Also other bits may be set differently on developer machines depending
on its configuration, this would affect generation reproducibility.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Add explanatory comment

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-23 07:47:26 -07:00
knative-automation ccadf1bb0a
Update community files (#919)
Signed-off-by: Knative Automation <automation@knative.team>
2022-03-23 06:01:17 -07:00
Matej Vasek 669329f02f
Improve error handling (#916)
* replaced plain `==` by `error.Is()`
* wrapping some more errors using `fmt.Errorf()`

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-22 17:18:17 -07:00
Thomas Risberg 03e53287d1
Update springboot http template (#914)
- http should match cloudevents template
- update Spring Boot version
- update README for cloudevents template
2022-03-22 08:31:12 -07:00
Matej Vasek 3a7f388035
Improve error messages (#913)
* Improve error messages

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* incorporate review suggestion

Co-authored-by: Lance Ball <lball@redhat.com>

Co-authored-by: Lance Ball <lball@redhat.com>
2022-03-21 08:24:47 -07:00
Roland Huß 56d93cfd9c
Adding code of conduct to reference knative/community's CoC (#911) 2022-03-21 07:22:46 -07:00
knative-automation 51a4011ad8
Update community files (#910)
Signed-off-by: Knative Automation <automation@knative.team>
2022-03-18 10:54:19 -07:00
Matej Vasek cad0a04276
Enabled previously disabled git tests for Window (#909)
* Recreate git repo from scratch

Recreated the repo by `git init --bare` and commited template there all
over again.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Enable previously disabled tests for Windows

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Use git HTTP protocol not file protocol in tests

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: cleanup

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-17 03:20:48 -07:00
Lance Ball 7b001a198a
doc: add documentation for using podman remotely (#907)
* doc: add documentation for using podman remotely

This commit adds more documentation for using podman, specifically in this
case, connecting to and using a remote podman service from a Mac computer.

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup

Signed-off-by: Lance Ball <lball@redhat.com>
2022-03-16 14:46:47 -07:00
Luke Kingland 9dec4c20ee
differentiate repository and repositories (#900) 2022-03-16 14:01:59 -07:00
Luke Kingland 564a34b3f5
fix: full clone of template repos on add (#904)
* full clone remote repos on write

* use filepath to parse path
2022-03-16 11:40:00 -07:00
Zbynek Roubalik c60079d792
🐛 allow adding environment variables without a cluster connection (#893)
* allow adding environment variables without a cluster connection

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

* add tests

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

* use k8s clientcmd

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
2022-03-16 07:20:00 -07:00
Lance Ball 166313b541
improve template comments for Node.js and TypeScript (#902)
* improve template comments for Node.js and TypeScript

See: https://github.com/knative-sandbox/kn-plugin-func/issues/572

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: add zz_ file

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: whitespace

Signed-off-by: Lance Ball <lball@redhat.com>
2022-03-15 15:36:59 -07:00
Zbynek Roubalik 5de9e193b8
parameter `-P` is not needed in grep in pre-commit hook (#895)
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
2022-03-14 06:33:18 -07:00
knative-automation 265786dfc2
Update community files (#892)
Signed-off-by: Knative Automation <automation@knative.team>
2022-03-14 02:24:17 -07:00
salaboy 57909f71fe
Updating to latest spring cloud release and refactoring code (#838)
* updating to latest spring cloud release and refactoring code

* new health endpoints

* implementing simplified echo function in template

* adding banner

* adding NL at EOF

* updating native to release

* fixing trailing whitespace

* adding invocation back

* adding Newline

* whitespaces

* fix lint and regenerate

* regenerate zz filesystem after rebase
2022-03-11 07:22:32 -08:00
knative-automation e5039891eb
Update community files (#890)
Signed-off-by: Knative Automation <automation@knative.team>
2022-03-10 22:13:32 -08:00
Matej Vasek fa17dc9e4b
Update wrt switch from pkger to custom ZIP pkging (#889)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-09 17:39:46 -08:00
Matej Vasek ff06ed426a
Update developer documentation. (#888)
* Update developer documentation.

Update documentation for template generation.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Apply suggestions from code review

Co-authored-by: Lance Ball <lball@redhat.com>

Co-authored-by: Lance Ball <lball@redhat.com>
2022-03-09 12:25:50 -08:00
Matej Vasek fe6d9f7d70
Improve cleanup recipes in Makefile (#887)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-09 12:17:49 -08:00
Matej Vasek f29805ad27
Fix formatting for template zip generator (#886)
* Fix formatting for template zip generator

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: style

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-09 07:32:50 -08:00
Luke Kingland 25524a1f84
fix: bind verbose flag to root (#884) 2022-03-08 11:02:06 -08:00
Matej Vasek 917a8efdb2
Hint to user when ssh server key is not known (#885)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-08 10:08:05 -08:00
Matej Vasek 2d23c9cd1f
Fixup writer Write() return value (#882)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-07 06:22:35 -08:00
Matej Vasek cc049952bb
Generate templates zip unconditionally (#879)
* Improve formant performance in template generation

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Improve memory footprint of template generation

Use streamlined generation which is limiting need for in memory buffers.
Might be imprtant if we had big files in templates.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Generate templates unconditionally

Rationale:
The way we create prerequisites (the find command) we cannot detect deleted files.
The generation is fast (around 500ms) so we can afford that.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Test embbeded templates content on push to main

This has to run prior to `make test` because the `test` recipe
enforces generation of the templates zip.
This would prevent test from being run against git commited templates
zip.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Optimization don't use unnecessary io.Pipe

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-06 14:28:35 -08:00
Lance Ball 6d7ab83aed
Make `func invoke` print any response it receives. (#881)
* Make `func invoke` print any response it receives.

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: improve test

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: check Write() return value

Signed-off-by: Lance Ball <lball@redhat.com>
2022-03-06 14:25:35 -08:00
Luke Kingland 5a122c31e6
src: promote verbosity to constructor arg (#869)
* update root and version structure and help text

* fix: limit openshift int test with tag

* src: verbosity to constructor param

* fix misspelling

* fix merge error
2022-03-04 11:19:36 -08:00
Matej Vasek 1e4d52be33
Relax permission check only to owner exec perm (#878)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-03 05:54:06 -08:00
knative-automation d672afc19f
Update community files (#877)
Signed-off-by: Knative Automation <automation@knative.team>
2022-03-02 14:45:07 -08:00
Luke Kingland 043a00d12b
src: update root and version structure and help text (#865)
* update root and version structure and help text

* test root command help output

* fix trailing whitespace
2022-03-02 11:58:44 -08:00
Matej Vasek c4a7e095de
Use custom zip embedding not pkger (#835)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-02 06:41:43 -08:00
Luke Kingland 2bd5254f19
feat: command help text template preprocessing (#875) 2022-03-02 03:56:43 -08:00
Luke Kingland 3f30c91116
fix: use full root name for cmd help prefixes (#873) 2022-03-02 02:18:42 -08:00
knative-automation 02fa79e8e9
Update actions (#871)
Signed-off-by: Knative Automation <automation@knative.team>
2022-03-01 18:01:42 -08:00
Matej Vasek 8dd90bff19
Fix OpenShift credential loader (#876)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-03-01 17:59:42 -08:00
Senthilnathan M efb7996da7
printing helpful shorthand command (#816)
* printing helpful shorthand command

* Addressed review comments

* Resolved rebase conflicts

* Using cmd.Root().Name() for getting the executable name
2022-03-01 11:56:42 -08:00
salaboy b97fe9c4ec
Adding sample function in go template (#840)
* adding sample function in go template

* adding simple echo, using the correct signature

* fixing readme
2022-03-01 07:38:42 -08:00
Matej Vasek bea34d21a0
Mark OpenShift test as an integration test (#870)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-02-28 08:58:09 -08:00
Fabian Lopez 60dbeacc46
added git related flags for remote builds (#844)
* added git related flags for remote builds

* fix dependency issues

* remove context cancel

* add # split for git url

* account for the use of git args with local build type

* fix error message for build type
2022-02-28 03:56:07 -08:00
Matej Vasek 663fd29b76
Windows unit test fixes (#860)
* force run of `make test`

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix git file:// URIs

When using file:// forward slashes should be used.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix parsing of FS path from URI path

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* disable some test on Windows

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: style

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* disable some test on Windows

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix some tests for Windows

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* disable some test on Windows

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-02-27 17:53:07 -08:00
Jefferson Ramos 8702515d91
test: url for invoke test (#863) 2022-02-24 02:32:38 -08:00
Helio Frota efc3b208cb
fix: minor typos in docs (#862) 2022-02-23 07:25:39 -08:00
Matej Vasek 4fec4afca1
Custom improvements for OpenShift (#825)
* Custom improvements for OpenShift

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: osh cred loader

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: style

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: dns-err detec for fallback in cluster dial

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-02-22 10:17:04 -08:00
knative-automation fba018962e
Update actions (#843)
Signed-off-by: Knative Automation <automation@knative.team>
2022-02-22 09:48:03 -08:00
Lance Ball ad42f3a258
chore: update manifest.yamls (#846)
* chore: update manifest.yamls

In a couple of cases, the `invoke` parameter was missing. And there was an
outdated use of a typescript buildpack in the typescript/cloudevent templates.

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: I should set VSCode to autosave on focus change

Signed-off-by: Lance Ball <lball@redhat.com>
2022-02-22 09:10:04 -08:00
Matej Vasek 5fad42ba55
Update python builder version (#845)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-02-22 08:17:03 -08:00
Luke Kingland 64091fbc39
build pkged.go directly with make (#841)
Also removes the dependency on a modern bash when building on a stock OS
X box (which ships with a 15-year old version).
2022-02-21 11:06:03 -08:00
Matej Vasek f25724ad71
Fix podman guide (#836)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-02-17 05:58:12 -08:00