This change prevents the incremental build messages that loop while
building from continuing during subsequent deploy phases by providing a
cancelable context to the `printBuildActivity()` function parameters.
Fixes: https://github.com/knative-sandbox/kn-plugin-func/issues/974
Signed-off-by: Lance Ball <lball@redhat.com>
* check namespace; add to func.yaml on first deploy; added tests and mock kubeconfig for testing
* change func args because only f.Namespace is used instead of the whole struct
* func comment
* misspell
* fix tests
* warning in stderr
* use context.Background
* add fake kubeconfig for new test
This commit updates both the Node.js and TypeScript cloudevents
templates to use the most recent version of the CloudEvents module, and
bumps transitive dependencies that needed updates via `npm audit fix`.
Signed-off-by: Lance Ball <lball@redhat.com>
* --image can be given with digest, created parser and edited some help text to reflect this
* fixed small stuff
* tests for deploy with --image
* move parser to file, static test should be kept active
* updated some error mesgs; now prints a warning if flags not set explicitly, if set to a wrong value, return an error; updated tests to fit new error messages
* --image flag message edit
* removed warning; instead print info about disabled push a build unconditionally
* func deploy should display namespace
* Modified e2e to consider namespace
* Added Namespace field in DeploymentResult struct
* Modified unit test for client deploy
* e2e fix
* feat!: change 'version' to 'specVersion'
Changes `func create` to write the last migration value to func.yaml
when a new function is created, and modifies the name in the func.yaml
file to be 'specVersion' instead of 'version' to help reduce confusion.
Adds a migration, and a LastMigration() utility function.
Fixes: https://github.com/knative-sandbox/kn-plugin-func/issues/861
Signed-off-by: Lance Ball <lball@redhat.com>
* fixup: remove DefaultVersion
Signed-off-by: Lance Ball <lball@redhat.com>
* fixup: review feedback
Signed-off-by: Lance Ball <lball@redhat.com>
* fixup: review feedback
Signed-off-by: Lance Ball <lball@redhat.com>
* Better input handling for non-tty
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Make cred-helper 'not implemented' non fatal error
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fix: close opened file
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fix: symlink handling for build context upload
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* doc: fix some func.yaml fields
Addresses recent changes in func.yaml processing. Not all fields
for the file are documented. I'm not sure if they all should be.
Signed-off-by: Lance Ball <lball@redhat.com>
* fixup whitespace
Signed-off-by: Lance Ball <lball@redhat.com>
* Fix docker client lifecycle
Avoid premature Close() of docker client.
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Guard for usage of docker client after close
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* spelling
* feat: full build options on deploy
* increase e2e lifecycle test timeout to 45m
* remove redundant flag shorthand b
* map flags for parsing
* feat: detect built image staleness and utilize on run command
* write directly to sha256 rather than buffer
* client test cleanup
* remove superfluous test println
* ensure runtime dir
* close file opened when testing
* fix typos
* typos and missing test case
Lance Ball