knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bump kubernetes minimum version to v1.17.0 (#1880) 

* Bump kubernetes minimum version to v1.17.0

This patch bumps up defaultMinimumVersion to v1.17.0

As per https://github.com/knative/community/issues/245#issuecomment-718316003,
v0.19(next release)'s minimum version is v1.17.

* Fix unit test
This commit is contained in:
Kenjiro Nakayama 2020-11-02 23:23:36 +09:00 committed by GitHub
parent 72451e0d59
commit d24e6ce616
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
version/version.go
View File

@ -30,7 +30,7 @@ const (
// the Kubernetes minimum version required by Knative.
KubernetesMinVersionKey = "KUBERNETES_MIN_VERSION"
defaultMinimumVersion = "v1.16.0"
defaultMinimumVersion = "v1.17.0"
)
func getMinimumVersion() string {

8
version/version_test.go
View File

@ -41,16 +41,16 @@ func TestVersionCheck(t *testing.T) {
wantError bool
}{{
name: "greater version (patch)",
actualVersion: &testVersioner{version: "v1.16.2"},
actualVersion: &testVersioner{version: "v1.17.2"},
}, {
name: "greater version (minor)",
actualVersion: &testVersioner{version: "v1.17.0"},
actualVersion: &testVersioner{version: "v1.18.0"},
}, {
name: "same version",
actualVersion: &testVersioner{version: "v1.16.0"},
actualVersion: &testVersioner{version: "v1.17.0"},
}, {
name: "same version with build",
actualVersion: &testVersioner{version: "v1.16.0+k3s.1"},
actualVersion: &testVersioner{version: "v1.17.0+k3s.1"},
}, {
name: "smaller version",
actualVersion: &testVersioner{version: "v1.14.3"},