Commit Graph

424 Commits

Author SHA1 Message Date
amitmukati-2604 07a01a3861 Adding changes to build JWA on pull_request (kubeflow/kubeflow#6992)
* Adding changes to build JWA on pull_request

* Adding changes to build JWA on pull_request
2023-03-21 11:05:41 +00:00
Elena Zioga f3cacadbb2 web-apps: Remove all the Rok references (kubeflow/kubeflow#7020)
* web-apps(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-14 15:58:33 +00:00
Midhun Nair 78e067e594 Fix: Strip unwanted space in custom image name (kubeflow/kubeflow#7026) 2023-03-14 15:40:25 +00:00
Mathew Wicks e3725c98d8 clean up default `spawner_ui_config.yaml` (kubeflow/kubeflow#6736) 2023-03-08 07:45:12 +00:00
Elena Zioga 40cd9ad78e web-apps(front): Fix typos (kubeflow/kubeflow#7017)
* jwa(front): Fix typo

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix typos

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 17:58:36 +00:00
Elena Zioga e7a1d7d288 vwa: Remove all the Rok references (kubeflow/kubeflow#6984)
* vwa(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(build): Update Dockerfile

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 10:22:35 +00:00
Elena Zioga 85f262abb9 jwa: Remove all the Rok references (kubeflow/kubeflow#6985)
* jwa(front): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(back): Remove rok references

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-03-06 10:06:35 +00:00
Elena Zioga f465180f05 jwa(front): JWA shows a weird long value for memory when restoring notebook from snapshot (kubeflow/kubeflow#6897)
* web-apps(front): Introduce MemoryValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce unit tests for the MemoryValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Use MemoryValue class for memory column

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Make quantityToScalar() use only Number()

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Update quantityToScalar() import

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Update quantityToScalar() import

Signed-off-by: Elena Zioga <elena@arrikto.com>

---------

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-02-24 12:33:24 +00:00
Elena Zioga daf78aaf85 web-apps(front): Fix the action component (kubeflow/kubeflow#6967)
* Fix the action component to properly show the tooltip of the
  start-stop action button in JWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-02-22 09:25:41 +00:00
dependabot[bot] fe21ffe649 build(deps): bump github.com/prometheus/client_golang from 1.11.0 to 1.11.1 in /components/tensorboard-controller (kubeflow/kubeflow#6956)
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:45:06 +00:00
dependabot[bot] 89e0b98ac3 build(deps): bump github.com/prometheus/client_golang from 1.11.0 to 1.11.1 in /components/notebook-controller (kubeflow/kubeflow#6955)
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prometheus/client_golang/compare/v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:44:06 +00:00
dependabot[bot] 5c74a8acb5 build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6908)
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:43:06 +00:00
dependabot[bot] 54f0518c1c build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /components/crud-web-apps/tensorboards/frontend (kubeflow/kubeflow#6907)
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:42:06 +00:00
dependabot[bot] c1df60efda build(deps): bump json5 from 1.0.1 to 1.0.2 in /components/crud-web-apps/jupyter/frontend (kubeflow/kubeflow#6880)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:38:06 +00:00
dependabot[bot] e884dec019 build(deps): bump json5 from 1.0.1 to 1.0.2 in /components/crud-web-apps/volumes/frontend (kubeflow/kubeflow#6881)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-16 13:37:07 +00:00
dependabot[bot] 814b8fc991 build(deps): bump json5 from 1.0.1 to 1.0.2 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (kubeflow/kubeflow#6878)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-14 14:35:25 +00:00
dependabot[bot] 84a3188564 build(deps): bump json5 from 1.0.1 to 1.0.2 in /components/crud-web-apps/tensorboards/frontend (kubeflow/kubeflow#6877)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-14 14:34:26 +00:00
Kimonas Sotirchos a99af12eea Add approvers to the frontends (kubeflow/kubeflow#6929)
* Add approvers to the frontends

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Add owners to common frontend code

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

---------

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-02-13 17:23:24 +00:00
Suraj Kota 6bcb843d8f Support Pod Defaults in Tensorboard Web App (kubeflow/kubeflow#6924)
* support Pod Defaults in Tensorboard Web App

* flint files
2023-02-13 16:31:24 +00:00
Orfeas Kourkakis b5e0deec09 cdb-angular: Show KF version (kubeflow/kubeflow#6918)
* cdb-angular: Modify README.md port-forward instructions

Add instructions to port-forward Profiles KFAM service.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Modify SnackBar service to use config parameter

Modify SnackBarService to:

 - Accept as a parameter a config object that will be able to include
   all possible configurations MatSnackBarService
 - Inject MAT_SNACK_BAR_DEFAULT_OPTIONS. This allows a structured way
   for every WA to provide to the service a default configuration
   app-wide for values like like HorizontalPosition and duration.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb(front): Use Kubeflow common library

Build CDB using components from Kubeflow's common libary.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Introduce backend service and ErrorInterceptor

 - Introduce backend service to handle requests to the backend
 - Use snackBar service by KF common library
 - Introduce ErrorInterceptor to hanlde errors in a uniform way.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(back): Remove "kubeflowVersion" from API

Remove the "kubeflowVersion from Workgroup's API "/env-info"
endpoint since it was using CRDs which are deprecated.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(back): Modify KF build version during runtime

By default, the version displayed in the dashboard's sidebar is the
ENV variable `BUILD_VERSION` defined during build time. With this
change, the `/api/workgroup/env-info` endpoint may now return the
build's label, version, and id which will be displayed instead of the
BUILD_VERSION. These values are assigned during runtime and can be
defined through the deployment's `KF_DASHBOARD_BUILD_LABEL`,
`KF_DASHBOARD_VERSION` and `KF_DASHBOARD_BUILD_ID` ENV variables.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* cdb-angular(front): Show KF version in the left sidebar

Show KF version at the bottom of the left sidebar navigation menu.
Variables that are used to show the KF version get their default values
during build time but may be modified during runtime by the
depoloyment's ENV vars fetched from the request at
'/api/workflow/env-info'.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* twa(front): Update the use of SnackBarService

Update the use of SnackBarService in order to pass required data via a
`config` object.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix flaky filtering unit test

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-02-13 16:16:25 +00:00
Orfeas Kourkakis 6a02712226 vwa(front): Prevent PVCs from being deleted when there is a corresponding notebook (kubeflow/kubeflow#6899)
* vwa(back): Append notebooks using each PVC

Append notebooks using each PVC when getting and parsing all PVCs.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Create custom delete action column

Create custom delete column component that extends ActionComponent from
Kubeflow common code and adds the following functionalities:

* Disable the button when a row's notebooks array is not empty
* Display an appropriate message including the notebooks' names

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add delete button component in index page

Implement custom delete column in the table in VWA's index page.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add Used by column in volumes table

Add a Used by column in volumes table of VWA's index page in order to
link to the notebooks that are using each PVC.

Refs arrikto/dev#2017

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix integration tests

Update mock request for PVCs

Refs arrikto/dev#2017
Refs arrikto/dev#2135

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix format error

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

---------

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-30 10:02:05 +00:00
apoger d2c76a0739 Implement a culling controller for Notebooks (kubeflow/kubeflow#6807)
* Implement a culling controller for notebooks

Changes:

 * Move the idleness/culling logic into a separate controller
   as part of the Notebooks Controller/Operator.

 * Introduce an "notebooks.kubeflow.org/last_activity_check_timestamp".
   annotation in each Notebook CR to keep the timestamp of the last
   performed idleness check

The controller can then compare this timestamp with the current time to
ensure that notebooks will get reconciled every IDLENESS_CHECK_PERIOD
minutes.

The culling-controller will:

* reconcile only notebooks CRs
* set/update culling annotations
  - 'notebooks.kubeflow.org/last_activity'
  - 'notebooks.kubeflow.org/last_activity_check_timestamp'
* perform idleness checks every 'IDLENESS_CHECK_PERIOD' minutes
  and set the 'kubeflow-resource-stopped' annotation, if a notebook
  needs to be culled.

Refs: kubeflow/kubeflow#6767

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* review: Remove culling annotations when Pod is not found

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* review: Improve logs

Add a log message at the beginning of the reconciliation loop
to make it clear that a Reconcile was called for a notebook.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Run the controller locally

* Introduce make rule for running the controller locally with
  culling enabled

* Introduce a dev_culling_authorization_policy which must be
  applied when testing the culling-controller locally

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update README instructions

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2023-01-26 13:32:10 +00:00
Orfeas Kourkakis a49617c883 twa(front): Add UI tests with Cypress (kubeflow/kubeflow#6896)
* twa(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Update README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* twa(front): Add UI tests with Cypress

Add UI tests with Cypress to check that:
 - New Tensorboard form dialog has proper default values and updates
   accordingly when its radio button value changes.
 - Index page
    * renders every tensorboard name into the table
    * renders correctly Status icon for every tensorboard
    * disables CONNECT button when tensorboard's status not ready

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(twa): Add UI tests to TWA's frontend action

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-26 09:37:10 +00:00
Orfeas Kourkakis c75943512f jwa(front): Fix ENV vars bug in details page (kubeflow/kubeflow#6903)
Fix bug where extracting the ENV vars from PodDefaults for a notebook
would fail when one of the PodDefaults didn't contain any ENV variables.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-25 17:44:52 +00:00
apoger 4b8d292194 make: Build KF images in parallel (kubeflow/kubeflow#6873)
Currently there is a single build-all rule in the top-level Makefile
under components/ dir that calls all sub-makefiles for building all
images in a serial manner. This makes the whole proccess very time-consuming
as we can't use the "-j" option of make to run jobs in parallel.

Changes to the top-level Makefile for building all KF images:

- create a single rule for each directory containing a sub-makefile

- have each directory rule as a dependency to the build-all rule in the
  central Makefile

Similarly, the central makefile for building all the example-notebook-servers images
calls each sub-Makefile for each of the notebook servers in a serial manner.

Changes to the central Makefile for building all notebook-server-images:

- Split the single target rule into multiple rules which perform recursive make
  calls (sub-makefiles) to build all the notebook-server-images.

- Use the variable MAKE for recursive make commands instead of explicit 'make'
  command:
  - https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2023-01-23 10:03:53 +00:00
Suraj Kota 144fa6805f Support Pod Defaults in Tensorboard controller (kubeflow/kubeflow#6874)
* support poddefaults in tensorboard controller

* initilize empty map
2023-01-18 15:22:21 +00:00
Elena Zioga 89d4f97303 [wa-actual-links-in-tables] Make links in our table component actual links (kubeflow/kubeflow#6864)
* web-apps(front): Import @angular/router package

Import @angular/router package to use routerLink directive.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Introduce LinkValue class

Introduce a distinct class for our external and internal links.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Modify unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Remove isLink property from PropertyValue class

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Make links actual links

Make JWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Make links actual links

Make VWA's main table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-18 14:19:21 +00:00
Kimonas Sotirchos 01ebea0665 rstudio: Update version to properly handle X-Forwarded headers (kubeflow/kubeflow#6890)
Update the RStudio image to be able to handle multiple values in the
X-Forwarded-{Proto,Host} headers. The server should care about the first
values which are the ones the user's browser is using

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
2023-01-18 09:14:20 +00:00
Orfeas Kourkakis c7e03bbaba jwa(front): Add UI tests with Cypress (kubeflow/kubeflow#6891)
* jwa(front): Add integration tests with Cypress

 - Upgrade Cypress to version ^10.10.0
 - Add integration tests with Cypress to check that:
   * Index page renders every Notebook name into the table
   * Index page shows correct Status icon for all notebooks

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* fixup! gh-actions(jwa): Add UI tests to JWA's frontend workflow

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-16 11:03:00 +00:00
Tasos Alexiou a14539b57c jwa(front): Auto update mount path (kubeflow/kubeflow#6875)
* jwa(front): Add missing generateName form control

Add missing generateName form control when creating the metadata
form group from a PVC.

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Update volume's mount path when name changes

Extend VolumeMountComponent class and update volume's mount path
when it is not dirty and name is changed. This feature affects only
the data volumes and not the workspace volume.

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Add UI tests for volume's mount path input

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>

Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
2023-01-11 14:38:16 +00:00
Elena Zioga 6c284d5271 twa(front): Install prettier and add gh action (kubeflow/kubeflow#6850)
* twa(front): Add script file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Install Prettier

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Format code

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add formatting/linting to TWA's frontend workflow

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2023-01-03 13:38:24 +00:00
Orfeas Kourkakis cf5301b10a vwa(front): Add UI tests with Cypress (kubeflow/kubeflow#6862)
* web-apps(front): Remove Protractor files

Remove Protractor files since it's not used anywhere in the common
code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add Cypress attributes

Add more attributes and modify some existing ones for elements to be
selectable during UI tests with Cypress.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Install Cypress

 - Install Cypress & npm scripts for UI tests
 - Remove Protractor files
 - Update README.md with UI tests instructions

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add UI tests with Cypress

 - Add Cypress attributes for elements to be selectable during
   UI tests.
 - Add UI tests with Cypress to check that:
    * New Volume form dialog has proper values
    * Index page table contains all PVC names received
    * Index page table status icons are correctly shown
    * Index page table browse buttons are correctly shown

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add UI tests to VWA's frontend workflow

Add UI tests to VWA's frontend workflow. These tests should run in
Ubuntu 20.04 since Ubuntu 20.04 includes both Chrome and Firefox
installations by default.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix formatting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2023-01-03 13:11:24 +00:00
Elena Zioga 388fdee390 web-apps(front): Install prettier and create a frontend workflow (kubeflow/kubeflow#6853)
* web-apps(front): Add script

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Install Prettier

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Format code

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Create a workflow for code formatting/linting and unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-23 13:49:14 +00:00
apoger 8f1a9df4a8 Fix Makefiles/Workflows/Manifests for the example-notebook-server images (kubeflow/kubeflow#6860)
* Set REGISTRY prefix when building notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Fix publish workflows for nb-server images when a PR is merged

Whenever a PR is merged:

* Build/Push notebook-server images with TAG=$(shell git describe --tags --always --dirty)

* Build/Push notebook-server images with TAG=latest when the target branch is master

* Build/Push notebook-server images with TAG=$(cat releasing/version/VERSION) when
  Version changes

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update manifests to use latest tag for notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-21 07:43:12 +00:00
Orfeas Kourkakis 3dec176271 web-apps(front): Sort events & conditions tables by date (kubeflow/kubeflow#6858)
* web-apps(front): Sort tables according to input

Configure tableConfig with new fields (column and order) that the table
will use to sort items during initialization.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Sort conditions table by timestamp

Initialize conditions table sorted by Last Transition Time column, with
the most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Sort events by timestamp

Initialize events table in EVENTS tab by Created at column, with the
most recent ones being on top.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix format errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:50:19 +00:00
Orfeas Kourkakis d5216c7d2a jwa(front): Link to VWA details page (kubeflow/kubeflow#6857)
* web-apps(front): Create lib-urls component

Create a URLs component in Kubeflow common library which takes a
list of URLs and their corresponding name and exposes them
horizontally in a div.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add unit test for lib-urls

Add a unit test for lib-urls component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Remove column Volumes from index page

Remove Volumes column from the table in JWA's index page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Link to a Volume details from JWA details page

 - Expose all volumes from a notebook, not only PVCs.
 - Expose the volumes grouped by type, having PVCs link to their
   corresponding volume details page in VWA, using lib-urls
   component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Implement lib-urls in VWA details page

Implement lib-urls component in the OVERVIEW tab of VWA's volume
details page to avoid duplicate code.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Use common link styles

Use common link styles in configurations component.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:49:18 +00:00
Orfeas Kourkakis cfe32e59c2 web-apps(front): Fix namespace selector bug (kubeflow/kubeflow#6845)
Fix a bug in the namespace selectors of JWA, VWA and TWA. In order to
show the namespace selector, they only checked if there is no
env.production variable available. This resulted in the selector not
showing even if there was no dashboard which is not expected.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-20 16:47:18 +00:00
apoger 6b3fd05ea2 Update KF manifests and gh-action workflows to use the tag=`latest` (kubeflow/kubeflow#6854)
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

review changes

* build images with the latest tag only when a PR
  is merged to master branch

* revert changes  in manifests/workflows for the
  notebook-server images

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-20 15:59:18 +00:00
Orfeas Kourkakis afed933c2c jwa(front): Add details page functionalities & unit tests (kubeflow/kubeflow#6822)
* jwa(front): Add buttons to Notebook details page

In this commit:

 - Add buttons for Connect, Start/Stop, Delete actions.
 - Create Actions Service to handle button actions and implement it
   in all components that use these buttons.
 - Small CSS tweak in title toolbar component in order for
   buttons to be aligned horizontally.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Handle query parameters in Notebook page

Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the
Notebook details page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* web-apps(front): Add default values in lib-conditions-table fields

Add default values for lastTransitionTime, reason & message fields
in order to prevent the table's Sorting functionality returning
error due to null values.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add unit tests for notebook-page component

In this commit, add unit tests in order to:
 - Show only the proper tab according to query parameters passed.
 - Switch tabs according to query parameters passed.
 - Update disabled field of buttons according to notebook status.
 - Update start/stop button according to notebook status.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* jwa(front): Add unit tests for OVERVIEW tab component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-15 11:54:21 +00:00
Orfeas Kourkakis 64a757de75 vwa(front): Handle query parameters and add unit tests (kubeflow/kubeflow#6835)
* vwa(front): Handle query parameters in Volume details page

Add query parameter handling for each tab in order for the user to
be able to navigate directly to the tab of choice inside the Volume
details page.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add unit tests for volume-details-page component

Add unit tests in order to:
 - Show only the proper tab according to query parameters passed.
 - Switch tabs according to query parameters passed.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Add unit tests for overview component

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* gh-actions(vwa): Add frontend tests

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

* vwa(front): Fix linting errors

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-15 11:51:21 +00:00
apoger 54ab6a815e Fix workflows for publishing images only when PR is merged (kubeflow/kubeflow#6842)
* Fix docker-publish workflows

* Remove workflow that builds/push all images

* Remove redundant files from manifests
2022-12-15 09:51:21 +00:00
Elena Zioga 0cb36aedf4 jwa(front): Rework the create page (kubeflow/kubeflow#6826)
* jwa(front): Fix panel.ts file

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Modify form name component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Add a helper tooltip in section component

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Rework the Create page

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Fix linting errors

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-15 09:06:22 +00:00
Elena Zioga c2cda2bb50 web-apps(front): Add text bellow the spinner component (kubeflow/kubeflow#6844)
Extend spinner component by adding some text below the spinner in order
to inform users why we're spinning about.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-14 10:54:29 +00:00
apoger 0e3834305f notebook-controller: Extend tests for using images of each PR (kubeflow/kubeflow#6830)
* Introduce intergration test workflow for notebook-controller

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Publish Docker image only when PR is merged

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Remove kind & manifest gh-action workflows

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update tag in manifests to v1.6.0

This change is required as images with v1.5.0 do not
exist in Dockerhub.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 14:16:28 +00:00
apoger be85f9f1bb tensorboard-controller: Extend tests for using images of each PR (kubeflow/kubeflow#6831)
* Introduce intergration test workflow for tensorboard-controller

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Publish Docker image only when PR is merged

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Remove kind & manifest gh-action workflows

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* Update tag in manifests to v1.6.0

This change is required as images with v1.5.0 do not
exist in Dockerhub.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 14:12:28 +00:00
apoger e327bfc8d7 crud-web-apps: Extend tests for using images of each PR (kubeflow/kubeflow#6832)
* jwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for JWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* twa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for TWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* vwa: Extend tests for using images of each PR

Changes:

* Introduce intergration test workflow for VWA
* Publish Docker image only when PR is merged
* Remove kind & manifest gh-action workflows
* Update tag in manifests to v1.6.0
  - This change is required as images with tag v1.5.0 do not
    exist in "docker.io/kubeflownotebookswg" registry.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
2022-12-12 12:23:27 +00:00
Elena Zioga dd0a681457 web-apps(front): Enable source maps in WAs (kubeflow/kubeflow#6787)
* jwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Add source maps in the browser

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-09 14:12:11 +00:00
Elena Zioga 524b1e4b10 twa(front): Fix unit tests (kubeflow/kubeflow#6824)
* twa(front): Update @angular/common package

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Fix unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

* gh-actions: Add GH action to run TWA unit tests

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
2022-12-09 10:44:11 +00:00
Orfeas Kourkakis bfb48f8e71 vwa(front): Add YAML tab to Volume details page (kubeflow/kubeflow#6823)
Add tab to show the full yaml of the PVC.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
2022-12-09 10:43:11 +00:00
amitmukati-2604 cf9cb073d0 Adding support for linux/ppc64le in CI for tensorboard-web-app multi-arch docker images. (kubeflow/kubeflow#6810) 2022-12-09 09:16:11 +00:00