In order to maintain consistency and compatibility, explicitly convert the 'username' variable to a string using the str() function before returning it. This ensures that the function consistently provides a string representation of the username, addressing potential variations in the original data type.
https://github.com/kubeflow/kubeflow/issues/7456
Update authn.py
Update notebook_template.yaml
* Handle edge case when node capacity is undefined gracefully
* Change log message to capacity
* No need to make the message a warning
* Resolve flake8 issue
* ensure closing bracket matches indentation of opening bracket
* Fix flake8 issues from other files
Filebrowser recently release v2.25.0.
Until now, we couldn't use v2.24.0, which brings chunked uploads, due to an issue with Cloudflare environments.
This got fixed in v2.25.0, so that chunked uploads should now work for every user: https://github.com/filebrowser/filebrowser/releases/tag/v2.25.0
The change introduced by kubeflow/kubeflow#6736 removed the default GPU vendors
list, which causes an issue when trying to select a vendor from the dropdown menu
if the vendors list is not configured.
This commit can be reverted if proper documentation is provided for users/distributions
to configure the dropdown menu.
Fixes#7273
* build: minor doc improvement triggering build pipe
* fix: viewer-spec.yaml
Two fields are either not correctly indented or named incorrectly
* fix: add volumes definition required by controller
* feat: use filebrowser:v2.24.2 enabling tus uploads
* Add pvcviewer support to volumes backend
* Modifying volumes manifests for pvcviewer support
* viewer-spec is now valid
* Add frontend integration
* Fix flake8 errors
* Use material spinners to display wait times
* Default PVCViewer SA to default-editor
* fix: remove superfluous space in docker builds (kubeflow/kubeflow#7224)
* Update role_binding.yaml
roleRef.name now matches role.metadata.name
* Remove invalid creationTimestamp: null fields
* Use commonLabels over labels
to comply with old kustomize version being used in integration tests
* Use vars in favor of replacements
* web-apps(front): Define theme and typography
In this commit:
* Create a styles folder that contains all sccs files.
* Define the generic theme and typography.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use the style of the specified body-1 level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use the styles of the specified title and headline levels
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use primary color in snackbar component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Change back button
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use the style of the specified title level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use primary color
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Use the style of the specified title level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix typo
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Use primary color
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix formatting
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix ui test
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* Integrating volumes viewer into volumes ui backend
* Integrating volumes viewer into volumes ui frontend
* Modified the volume viewer's manifests to be in accordance with the volumes viewer changes
* Bootstrapping/creating VolumesViewer Controller
* Changed/reverted image definitions
* Fixed code style issues
* Run prettier on index-default.component.ts
* Reverted accidental method call change back to getSelectedNamespace2
* Reverted package-lock.json
* Now using the VOLUME_VIEWER_IMAGE env variable in the viewer's podTemplate
* Set readinessProbe.initialDelaySeconds=2 for new viewers
* Removed downward api references in favor of Python variable expansion
* Revised crd schema
- Now includes a status.URL field
- Reverted changes to status.py to minimize diff
* Providing NAME as a possible var for var expansion
* Return and use the VolumesViewer.Status.URL
* Reconcile status while deletion ongoing
* Restored empty line to get file off diff
* Reducing diff on get.py
* Run prettier
* Updated OWNERS/README
* Changes to schema comments / renaming
* Improved test performance and reliability
By cleaning up resources created by tests in afterEach()
Also: Pod watch now only triggers for non-terminating RUNNING/PENDING pods, reducing the number of reconciliation calls
* Renaming VolumesViewer -> PVCViewer as discussed in community meeting
* Moving changes to volumes frontend to another PR as discussed in community meeting
* Renaming file names
* Renaming PVCViewerSpec.PodTemplate -> PodSpec
* Renaming PVCViewerSpec.Service -> Networking
* Adding the Spec.PVC field and validating/defaulting webhooks
* Adding the option to load a default podSpec from file
* Introduced PVCViewer.Status.Conditions
* Validator requires the PVC to be used in podSpec
* Added tests for the validating webhook
* Removed debug log message
* Updating manifests to work with new webhooks
* Updating documentation
* Refactored manager according to specs
* Modifying pvcviewer OWNERS
* Makefile & renaming comp -> pvcviewer-controller
* Changing nameprefix to pvcviewer-
* Setting imagePullPolicy: IfNotPresent
* Adding a base directory
* Generating TLS certs for make run
* Adding a log time encoder
* web-apps(front): Fix status case
* Fix the status case to properly show the warning icon when the status
phase is warning.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Modify status-icon component
* Modify the status-icon component to follow the status cases.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Modify status component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Introduce status-info component
* Have an admonition in the details page of each Notebook with a
detailed message on the current status.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(back): Extend process_status function
The process_status parses the status by:
- Checking the .status.containerState.
- Checking the .status.conditions, since they have the one-liner reason
and a message.
- If none of the above exist, it will use the Events emitted for the
notebook.
- In case it deduces the status from an Event and it's not available
anymore, it uses a generic message.
Also, add a 10 second delay to the backend logic where we display a
spinner and a generic message to prevent a warning icon from appearing
immediately after a notebook is initialized.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(back): Extend getNotebook request
* Extend the getNotebook request to also include the processed status
information in the Notebook details page.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Extend the frontend
Extend the frontend by:
- Adding an admonition with a detailed message on the current status
bellow the notebook name.
- Adding the processed_status field.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix unit tests
Fix unit tests accordingly.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa: Don't show the popup when a notebook is being stopped
* Use the waiting status, which also uses the spinner, when a notebook
is being stopped.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Update lib-status-icon
Signed-off-by: Elena Zioga <elena@arrikto.com>
* fixup! jwa(back): Extend getNotebook request
* fixup! jwa(back): Extend process_status function
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(back): Create list_events function
Create list_events(namespace, field_selector) function for listing
events of each resource.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(back): Utilize list_events for listing notebook events
Utilize list_events function for listing notebook events in notebook.py
file.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(back): Utilize list_events for listing pvc events
Utilize list_events function for listing pvc events in pvc.py file.
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix the size input value
The size form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix the access-mode input value
The access mode form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix the name input value
The name form input was not showing the correct value, once the frontend
got the ConfigMap defaults. We should be updating the intermediate FormControl
when the data from the ConfigMap arrives at the frontend.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use 5Gi everywhere
All new volumes will have a default value of 5Gi. This includes the 'Add
new volume' button for both the workspace and data volumes.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Add UI tests with Cypress
Add integration tests with Cypress to ensure that the form will have the
correct values once it gets the ConfigMap.
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
Prafful Mishra