60 KiB
Kubernetes SIG-Node CI subgroup notes
12/29/2021
Cancelled - year-end holiday break
12/22/2021
- Device plugin: https://github.com/kubernetes/test-infra/issues/24557
- Put on hold to be able to repro. But can repro locally now. So can skip tests for now
- Memory (kubelet) down again:
![][image12]
12/15/2021
- https://github.com/kubernetes/test-infra/issues/24618#issuecomment-993808136
- Follow up:
- GCEPD: follow up to exclude from more tabs
- https://github.com/kubernetes/kubernetes/issues/106720,
- https://github.com/kubernetes/kubernetes/issues/106719,
- https://testgrid.k8s.io/sig-node-containerd#containerd-e2e-ubuntu
- https://testgrid.k8s.io/sig-node-containerd#cos-cgroupv2-containerd-e2e
- https://testgrid.k8s.io/sig-node-containerd#image-validation-cos-e2e
- https://testgrid.k8s.io/sig-node-containerd#image-validation-ubuntu-e2e
- https://testgrid.k8s.io/sig-node-containerd#e2e-ubuntu
- https://testgrid.k8s.io/sig-node-cos#soak-cos-gce
- https://testgrid.k8s.io/sig-node-cos#e2e-cos
- https://testgrid.k8s.io/sig-node-cos#e2e-cos-ip-alias
- https://testgrid.k8s.io/sig-node-cos#e2e-cos-proto
- https://testgrid.k8s.io/sig-node-cos#e2e-cos-serial
- https://testgrid.k8s.io/sig-node-cos#e2e-cos-slow
- Create issue for: https://testgrid.k8s.io/sig-node-containerd#cos-cgroupv2-containerd-node-e2e-serial (https://github.com/kubernetes/kubernetes/issues/107062)
- Create issue for: https://testgrid.k8s.io/sig-node-containerd#node-kubelet-containerd-eviction https://github.com/kubernetes/kubernetes/issues/107063
- NPD: https://testgrid.k8s.io/sig-node-node-problem-detector#ci-npd-e2e-node https://github.com/kubernetes/kubernetes/issues/107067
- Check for https://testgrid.k8s.io/sig-node-cos#e2e-cos-alpha-features
- Check if we have an issue for this: https://testgrid.k8s.io/sig-node-presubmits#pr-node-kubelet-serial https://github.com/kubernetes/test-infra/issues/24557
- GCEPD: follow up to exclude from more tabs
12/09/2021
-
ehashman
- PR: https://github.com/kubernetes/test-infra/pull/24595
- There are some tests I don’t want to migrate as part of this PR with special configs: e.g. CPU manager, hugepages, etc. but are failing so no point in running them
- Ideally, since these are serial, would like to see all tests using the same config moved under a single job
- Presubmits need to be done separately
- Will file issues for split work (presumbits)
-
ruiwen-zhao
- Summary API test flaky on kubelet-gce-e2e-swap-ubuntu since the beginning of test job history
- Same test passes on -fedora testgrid
- Agreed: cancelling Thursday alternate time meeting due to lack of attendance.
- We will only meet Wednesdays from now on.
- https://github.com/kubernetes/community/pull/6285
12/01/2021
-
ehashman
- Serial lane is green!!!
- Perf (memory chart) - let’s see if trend continues next week
- We looked and it looks stable since code freeze (~11/17)
- Next week is our alternate Thursday time
- If we do not see substantial attendance compared to Wednesday meeting, we will revert back to Wednesdays only going forward
11/24/2021
-
ehashman
- https://github.com/kubernetes/kubernetes/issues/106635
- Still failing, all fixes need 1.23 backports at this point, so let’s remove these from the serial lane until we can fix them next release
Perf (memory chart) - let’s see if trend continues next week
![][image13]
11/17/2021
-
ehashman
- GPU tests started failing again, sigh
- Danielle has a PR that will hopefully prevent this in the future
- We probably shouldn’t run with real GPUs (i.e. special hardware) in our regular serial lane
- Is it off docker?
- Containerd job currently broken - moved to community infra but has a config issue
- Cut a bug for https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-serial-containerd
- Do we have an equivalent job for crio?
- Don’t think so, we should definitely add one, add both to release-informing when sufficiently green
- GPU tests started failing again, sigh
-
mmiranda96
- Probably safe now, only noticed two failures yesterday.
-
aditi
- Just added the log to be sure about the reason for flake
- Can increase the grace period/decrease sleep time based on the finding
-
aditi
- https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-features-1.19
- https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-1.19
- Let’s wait for SIG Release to remove their job first
-
ehashman
- Okay to merge during test freeze?
- +1’s from Danielle and David
- +1 from Sergey.
11/11/2021
- https://github.com/kubernetes/kubernetes/issues/106204
- Release blocker?
-
danielle
- Lets drop the dependency on GPUs and reduce some maintenance for ourselves. Also apparently the device tests were broken in the same way GPU tests originally were (but we missed it bc of [Flaky])
-
aditi
- Thoughts on adding credential provider to node e2e?
- Status of node serial
- Let’s make it green by removing flakes out
10/26/2021
-
manugupt1
- Re-run all the tests through the pod-spec.
- Move all the unit-tests that I ran as an e2e test without pod-spec.
-
SergeyKanzhelev
https://github.com/kubernetes/test-infra/search?q=cos-stable2
-> cos-93-lts
10/20/2021
-
fromani
- Memory manager tests have implicit dep on memory fragmentation (or lack thereof)
- ContainerRuntimeRestart - fails for timeout, but we WANT to saturate the node with pods (that’s the whole point of the test!)
- How do we keep these tests while keeping it reliable (no false negatives)?
- Separate lanes seem a bit excessive, any other idea?
- Wait for the PR to reduce amount of allocated hugepages under the test
- If the PR will fix flakes, remove the separated lane, otherwise remove the test from serial lane with notes why it needs a separate lane
-
Updated the test-infra PR to include a skip value with `--skip="\[Flaky\]|\[Serial\]"`imran
Just need to merge and proceed with the next set of steps. -
mmiranda96
-
jlebon
- Danielle will take a look
- Fromani will have a look as well
- What about cloud-init?
- Cloud ignition is an alternative - needs to be adapted
- Have a way to prepare all the binaries upfront?
- Danielle will take a look
-
mmiranda96
- PR: https://github.com/kubernetes/test-infra/pull/24064
- Not sure if the current swap config will work on COS.
- https://github.com/kubernetes/test-infra/blob/cc714da33d7ba85672aa4c7f58e0b3993155176d/jobs/e2e_node/swap/crio_swap1g.ign
-
ehashman
- Let’s hold another one in november and then if poor attendance again, cancel
10/14/2021
-
mmiranda96
- From the logs, it appears that the cluster is never created. Node operations are no-ops. Is the cluster expected to be existent before the tests run?
-
mmiranda96
- How can we run tests in machines with swap enabled?
- https://github.com/kubernetes/test-infra/tree/master/jobs/e2e_node/swap
10/06/2021
-
bobbypage
-
Amit @amwat will provide a bit of context on kubetest2 migration plans and how it relates to node e2e testing
-
ref: https://github.com/kubernetes/enhancements/issues/2464
CI jobs very first layer Image for prow job \- has many tools on it already
-
- all these tools are deprecated and in maintenance mode. Tools evolved from bash script and became unmaintainable
- kubetest2 is designed to be extensible and will replace it.
- PLuggable on where to test (GCE, AWS, Kind, etc.)
- Pluggable on what to test
Thousands of jobs using old tools. The process of switching all the jobs will be slow. Some of the jobs will be moved to kubetest2. Presubmits and release blocking jobs are the first target.
Mainly: awareness of the project. Feature requests must go to kubetest2 now.
Most significant impacting change - node tester. kubetest2 will use a makefile as a source of truth. make test_e2e lets you run tests, but kubetest is not using it. kubetest2 will change this and will only use makefile. Dealing with test infra will be mostly when bugs are encountered, no need to deal with it any longer.
Danielle: some tests needs more features
Amwat: yes, can be added in node tester
Timeline?
Amwat: scoped to presubmits and release blocking - 1.24 is a target version. At least jobs will start be running. No timeline for other jobs.
-
SergeyKanzhelev
- File an issue for the future
- Revert to image family for now
- Find somebody to investigate
-
SergeyKanzhelev
-
mmiranda96
- Issue on kops for last year event: https://github.com/kubernetes/kops/issues/9920
- No - Kubernetes has explicitly opted out of Hacktoberfest project wide. The quality of contributions we’ve historically gotten have been very low and created a lot of extra cleanup work for maintainers.
09/29/2021
-
SergeyKanzhelev
./_output/local/go/bin/ginkgo --dryRun -v ./_output/local/go/bin/e2e_node.test | sed $'s,\x1b\\[[0-9;]*[a-zA-Z],,g' > ./tmp/e2e_node.test.txt
-
bobbypage
- Moved to 10/06
-
arnaud
- Migrate away from GCP projects:
- k8s-jkns-pr-node-e2e: https://cs.k8s.io/?q=k8s-jkns-pr-node-e2e&i=nope&files=&excludeFiles=&repos=
- cri-containerd-node-e2e: https://cs.k8s.io/?q=cri-containerd-node-e2e&i=nope&files=&excludeFiles=&repos=
- K8s-cri-containerd: house of bucket gs://cri-containerd-testing : https://cs.k8s.io/?q=cri-containerd-staging&i=nope&files=&excludeFiles=&repos=
- Action: ehashman to create an issue for SIG Node in test-infra for the SIG to move the project with steps for a new contributor to pick up, cc Arnaud
- Example PR: https://github.com/kubernetes/test-infra/pull/23777/files
- Migrate away from GCP projects:
-
Why serial run on every PR?
09/22/2021
-
mmiranda96
- Update list of features manually to make progress on the alpha job cleanup.
- Work on updating tags for jobs
-
ehashman
- GCP accounts for node contributors - need a list of use cases
- Dani to drive when she returns from PTO?
-
Sergey
09/15/2021
-
alukiano
- The feature should be deprecated under 1.23
- The feature tests took the most time of the serial lane, for comparison with DynamicKubeletConfig serial lane takes ~3h, without ~1h
- We can create a separate lane for deprecated features(I know we do not like an idea about the separate lane)
- Let’s prioritize removing the feature
- Need unified approach for kubelet configuration
- DynamicKubeletConfig flakes are often due to the feature being unreliable/kubelet not restarting
- Action: Elana to file an issue to detail work that needs to be done to move tests off DynamicKubeletConfig, assign Danielle and cc Sergey
-
arnaud
- In-scope :
- Sig-node-presubmits : https://testgrid.k8s.io/sig-node-presubmits
- Sig-node-kubelet : https://testgrid.k8s.io/sig-node-kubelet
- Node https://github.com/kubernetes/k8s.io/issues/1527
- One question remaining; Danielle thinks these haven’t been used in 2+ years
- Action: Danielle to comment on issue with update on Arnaud’s question and recent findings
- In-scope :
-
ehashman
- Danielle: there are some optimizations we can do, including eviction tests, GPU tests, etc. to be less wasteful
- Fromani: agreed. Only few tests actually benefit from availability of GPU devices (and they need to be changed accordingly)
- Action: Sergey to follow up on combining node pool with the rest of the project
- Danielle: there are some optimizations we can do, including eviction tests, GPU tests, etc. to be less wasteful
-
mmiranda96
- Action: Elana to add a comment discussing the period/presubmit split and suggested steps forward for the job
- https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-alpha
- Bugs triage: https://github.com/orgs/kubernetes/projects/59
09/09/2021
-
SergeyKanzhelev
-
https://github.com/kubernetes/kubernetes/issues/36621aditi
The node performance testing doc points to these tests
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/node-performance-testing.md
Interested in refactoring the doc with current status of node perf tests and refactoring of tests as well. - Why tests https://github.com/kubernetes/kubernetes/blob/master/test/e2e/node/kubelet_perf.go are not run in kubelet-serial?
- Do we need these ^^^ or https://testgrid.k8s.io/sig-node-kubelet#node-performance-test will be enough?
-
Imran Pochi
- Since test requires special config, we want a separate tab. Let’s add [Special] tag and make sure “features” do not pick up these “[Special]” tag
-
ehashman
- Some folks definitely can’t attend the Wednesday time
- Many people don’t realize this meeting exists
- Action: ehashman to set up reminder for the next Thursday meeting
- Done - for the rest of 2021
09/01/2021
-
mmiranda96
-
danielle
-
[mmiranda96] Requesting review for kubernetes/test-infra#23215-
ehashman
- Seems like an oversight https://groups.google.com/g/kubernetes-sig-node
- AI: create a task in github
-
danielle
-
rphillips
- E2e is coming as separate PR later to make release this week available
08/25/2021 Cancelled due to hosts unavailability
08/18/2021
-
mmiranda96
- AI: create issue to review other NPD tests.
-
mmiranda96
- Mike: investigate and find the test grid. + create an issue.
-
SergeyKanzhelev
- 18 is the number of projects used.
- The best way to improve utilization is less test jobs or faster tests inside the job
-
alukiano
- Runs serial and conformance tests
- Prepare a PR to skip serial and conformance tests https://github.com/kubernetes/test-infra/pull/23295
08/12/2021
[mkmir] Working on kubernetes/test-infra#23131, but I can’t seem to find a way to locally run a ProwJob without connecting to GCE. Any suggestions?- Lock contention tests failing on features-master, reverted https://github.com/kubernetes/kubernetes/issues/104307
- Probably need to label this [Serial], remove the separate job
- Test labels: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md#kinds-of-tests
- AI: Imran:
- Add [Serial] tag
- Validate that test is passing in Serial https://testgrid.k8s.io/sig-node-kubelet#pr-node-kubelet-serial
- PR that adds a job needs to be reverted
-
ehashman
- Didn’t get time to submit a PR, good thing for a new contributor to work/pair on
- We want to move “pr-*” jobs out of the sig-node-kubelet tab to a new sig-node-presubmits tab
- Maybe look at any other tabs that could be consolidated (e.g. sig-node-containerd and sig-node-containerd-io)
- Remove release-blocking jobs
- Any volunteers?
- Imran may reach out
- Aditi + matthyx to volunteer
- Action: Elana to create an issue
- https://github.com/kubernetes/test-infra/issues/23231
-
ehashman
- https://monitoring.prow.k8s.io/d/wSrfvNxWz/boskos-resource-usage?panelId=9&fullscreen&orgId=1&from=now-90d&to=now
- Do we even need single-test jobs like https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-lock-contention ?
- Suggested action: someone should audit all sig-node periodics and suggest jobs that can be consolidated/removed
- AI: Sergey to find out what this quota means
- Action: Elana to create issue to track
- https://github.com/kubernetes/test-infra/issues/23232
- CI signal:
-
ehashman
- Hoping to triage and assign new bugs regularly as part of weekly triage meeting
08/04/2021
-
dims
-
ehashman
- Pr- tests - move to separate dashboard
- Remove release blocking ones (previous releases) from kubelet
-
ehashman
-
mmiranda96
-
ehashman
-
Thomas and Qiutong
- https://github.com/kubernetes/kubernetes/issues/93338
- Action: Qiutong to investigate a reproducer test
-
ehashman
- We are not missing a lot of signal (very few are flaky)
- Manu will take it
- Serial tests updates?
- Couple PRs are out - de-flaking tests that were temporary marked as such
- AI on fromanirh to rebase and remove the “Flake” label
- https://github.com/kubernetes/kubernetes/pull/103408
- https://github.com/kubernetes/kubernetes/pull/103297
- Not running to completion https://github.com/kubernetes/kubernetes/issues/104038
- We really shouldn’t call klog.Fatalf in the tests, it’s causing the massive stack traces
- Couple PRs are out - de-flaking tests that were temporary marked as such
07/28/2021
-
mmiranda96
-
ehashman
- https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+milestone%3Av1.22+label%3Asig%2Fnode+
- Action: mark known failures in serial tests as Flaky so we can try to get the job green
-
alukiano
- Need to talk to release team to add a known issue to the release notes
07/21/2021
-
haircommander
-
fromani
- The k8s e2e test suite has a fair amount of tests which need device plugin, because they exercise device manager -directly or indirectly.
We mostly use SRIOV devices, because SRIOV devices are just the cheapest and easiest supported device to get, so this is why we wrote the tests in k8s to consume them.
But we don't have device plugin support on CI. We do have gpus-enabled machine, but it's a subset and should be used sparingly (e.g. not every PR should use them. Or can we just use gpus every time? I expect no for cost reasons, but worth mentioning).
So today a large amount of tests just skip on CI. This is especially evident in the serial lane and in the resource management area
In RH we actually have machines with SRIOV devices which run the e2e testsuite, but this is of course suboptimal for a number of reasons; a much better state for everyone would be to actually have some device plugins in u/s CI.
There are some options we can discuss as community:- 1. use sample plugin
- 2. fake sriov devices (I can elaborate on this if there is interest
- 3. just use GPUs?
- 4. Just bump the spec of the CI machines to have SRIOV devices?
- The k8s e2e test suite has a fair amount of tests which need device plugin, because they exercise device manager -directly or indirectly.
-
mkmir
- it tests only GA, non-optional features or APIs (uses feature sysctl)
- it works for all providers (doesn’t work for Windows and other non-sysctl OS)
- https://github.com/kubernetes/kubernetes/pull/101190
-
ehashman
-
SergeyKanzhelev
07/14/2021
-
Sergey
- NodeConformance historically tried to be two things:
- A set of e2e tests that you just needed a single node to run
- Conformance-like test for nodes
-
ehashman
- For CRI conformance-like tests, label them CRIValidation -- NodeAgnostic?
- For the set of e2e tests you just need a single node to run, let’s come up with a new name -- needs a name (anything in test/e2e_node) (SingleNodeTest or KubeletLocal)
- Note: some tests may overlap between both sets
- Action: add a plan to cover splitting the use cases for current tests
- Action: send out NodeConformance plan, soliciting feedback
- NodeConformance historically tried to be two things:
-
ehashman
-
fromani
07/08/2021
-
ehashman
- SIG-Architecture Agenda and Meeting Notes
- Historical issue https://github.com/kubernetes/kubernetes/issues/59001
- Suggestion: Remove “Conformance” from the name
- Not just CRI.
- Conformance requires entire cluster. NodeConformance just require kubelet - need to discuss what we want in scope of NodeConformance tests.
- NodeConformance run as presubmits
-
ehashman
- https://groups.google.com/g/kubernetes-dev/c/u1LMXHcKhbg/m/Lp81VX7eAgAJ
- #100788 https://github.com/kubernetes/kubernetes/issues/100788 [sig-node][NodeConformance] when querying /stats/summary should report resource usage through the stats api
- #99437 https://github.com/kubernetes/kubernetes/issues/99437 [Flake][sig-node] Pods should run through the lifecycle of Pods and PodStatus
- #75355 https://github.com/kubernetes/kubernetes/issues/75355 [Flaky test] [k8s.io] Pods should support pod readiness gates [NodeFeature:PodReadinessGate]
- #99979 https://github.com/kubernetes/kubernetes/issues/99979 [flaky test]: [sig-node] Probing container should be ready immediately after startupProbe succeeds
-
fromani
- same status as next week (please review the pending fixes to the serial lane! :) )
- Critical pod test PR: https://github.com/kubernetes/kubernetes/pull/103408
- Need to investigate the DynamicConfig failures we experienced recently
- Acknowledge the podreadinessgate flake, but still dunno how to reproduce, suggestions welcome!
- same status as next week (please review the pending fixes to the serial lane! :) )
-
alukiano
06/30/2021
-
fromani
- Managed to find time to fix the serial lane:
- Recent serial lane run: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103297/pull-kubernetes-node-kubelet-serial/1410231408982495232/
- Merged: https://github.com/kubernetes/kubernetes/pull/103265
- In review:
- Next up: eviction test lane (no ETA atm)
- More async work to be done here
- Managed to find time to fix the serial lane:
- Bug scrub follow-up
- Added some new bugs to the board after having scrubbed bugs, including some issues for adding test coverage
- Issues are now in a more manageable state, but we have so many
- Suggestion: bug board + everything else board will be optimal, need to figure out the columns (triage/waiting/accepted/in progress/done?)
- Hopefully moving forward we can do regular incoming issue triage as part of these meetings
- Bot to help with automation for boards?
- GitHub still doesn’t have support
- Contribex is working on it
- NodeConformance status
- Assigned to Sergey, worked on bug scrub so hasn’t had a chance to look since last meeting
- NodeFeature status?
- mmiranda has submitted PR: https://github.com/kubernetes/test-infra/pull/22677
- Starting with duplicating selectors in test-infra, then we can start making test changes
-
Sergey
- https://github.com/kubernetes/kubernetes/issues/64523
- Is there logic we can reuse to automatically detect this?
- Not afaik - usually determined by querying debugging endpoint and looking at the memory dumps
- Resource utilization regressions now being tracked in perf-tests: https://github.com/kubernetes/perf-tests/issues/1789
- How to find reviewers for various PRs?
- Action: Swati to add item to next week’s SIG Node meeting to discuss with wider SIG
06/23/2021
- Discuss removing NodeFeature flags in favour of Feature: https://github.com/kubernetes/kubernetes/issues/94289
- Mike Miranda to drive
- Need to update labels in both test-infra and k/k
- What is the difference between NodeConformance and Conformance?
- Filed bug for documentation: https://github.com/kubernetes/community/issues/5859
- Serial tests
- No progress
-
ehashman
- NASA needs more mentors: https://docs.google.com/spreadsheets/d/1y6HKIsThphzpaG2a-Vgsc66b36ckM_TIPqGJ6GeVUGI/edit#gid=0
Attendees:
![][image14]
06/16/2021
Attendees:
![][image15]
- Discuss removing NodeFeature flags in favour of Feature: https://github.com/kubernetes/kubernetes/issues/94289
- What is the difference between NodeConformance and Conformance?
-
ehashman
- Serial tests
- Eviction tests were holding everything. They are split away and needs attention. Odin has a PR ready - increase open files limit
- Some serial tests are failing
- AI: Francesco: follow up from serial tests failure investigation
06/10/2021
Attendees:
-
Sergey
Agenda:
-
pacoxu
Ci-kubernetes-node-kubelet-conformance keeps failing: https://github.com/kubernetes/kubernetes/issues/97130 (shoud be fixed by [sig-node] Remove failing, unused NodeConformance job kubernetes/test-infra#22454 )
- Serial tests update https://github.com/kubernetes/kubernetes/issues/102148
-
fromani
-
paco
- Filed https://github.com/kubernetes/kubernetes/issues/102782 to track eviction
-
- Failing Node Conformance tests?
- New issue filed as https://github.com/kubernetes/test-infra/issues/22250 - possible duplicate of the existing 2 issues
- PR up to remove the tests at https://github.com/kubernetes/test-infra/pull/22454
- Swati to further investigate
06/02/2021
Agenda:
-
fromani \- cannot attend the mtg \- just status update
- Kubelet + test logs uploaded https://github.com/fromanirh/k8smisc/tree/main/e2e_node (lacking a better place; suggestions?)
- Spending time analyzing the logs, will update about findings (and send PRs :) )
- Everyone is welcome to ping me anytime on slack to talk about this (/run more tests/upload logs)
-
APAC friendly time: https://doodle.com/poll/sfeh699qt44mrzv6 Cannot see responses...
05/25/2021
Agenda:
-
fromani
- Got cpu time to run test locally and collect logs
- First experimental run done (failed with timeout)
- Doing runs with the same parameter the node-kubelet-serial lane is using
- Will collect and publish logs on https://github.com/fromanirh/k8smisc/tree/main/e2e_node (lacking a better place; suggestions?)
- Will deep dive in the logs after published - so we can go in parallel
- Ping me on k8s/cncf slack chans (@fromani) for any question/comment/chat about the issue
- Ping me or file issues against the repo above so we don’t miss/forget
- PRs potentially helping with them:
- File handles limit increase https://github.com/kubernetes/kubernetes/pull/102169
- Fix that allows to upload artifacts https://github.com/kubernetes/kubernetes/pull/102209
- More logs are coming (kubelet.log)
- Add ability to run tests on PR
05/19/2021
Attendees:
![][image16]
Agenda:
- Meeting time for asia?
- Code coverage dashboard in OSS: https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit&include-filter-by-regex=pkg%2Fkubelet
- Examples:
- pkg/kubelet/container/runtime.go
- pkg/kubelet/certificate/bootstrap/bootstrap.go
-
Elana
-
Matthias
-
Elana
-
Francesco
- Examples:
- Discuss “Serial” https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-serial
- Timeouts under tests may need adjustment
- We already adjusted global timeout
- Just run locally with higher timeout and see what is failing
- Action [Artyom] file issue https://github.com/kubernetes/kubernetes/issues/102148
- Francesco - best effort - can run tests locally
- Aditi, Mike, Matthias to help
-
Aditi
- Policy is no new flags, add to KubeletConfig
- Raise at full SIG Node
05/12/2021
Agenda:
-
Triage: https://github.com/orgs/kubernetes/projects/43?card_filter_query=no%3Aassignee
-
Artyom
- Writing e2e test may be a good (difficult) first issue
-
Francesco
-
A
-
Still failing:
- Node conformance (docker)
-
S
-
- Serial jobs are still failing
-
A
- Artyom to open a new issue
-
- Orphans clean up
- Node conformance (docker)
05/04/2021 Cancel for KubeCon
04/28/2021 Short sync up
Attendees:
![][image17]
Agenda:
- Follow ups - need to move to the next week:
- Kubetest2 updates David
- NodeConformance Qiutong
- Serial clean up - Francesco, actually there is a PR: https://github.com/kubernetes/test-infra/pull/21828
-
fromani
- Shared global state between tests
- Any objections to move away from it?
- Storing state of the kubelet
- Ideally each e2e test has it’s own state
-
ehashman
- Currently don’t have any perf/scalability tests for upstream kubelet resource utilization (CPU/memory)
04/21/2021
Attendees:
- Sergey
- Elana
- Artyom
Agenda:
- triage
04/14/2021
Attendees:
- fromani
- ehashman
- Sergey Kanzhelev
- David Porter
- Amim Knabben
- Qiutong Song
- Madhav Jivrajani
- Jiaming Xu
Agenda:
- Kubetest2 updates: https://github.com/kubernetes-sigs/kubetest2/pull/103/
- David: currently using kubetest1, moving to kubetest2. Feedback: kubetest has some flags that do not match “make”-way to run tests. PR is moving to the “make”-way to run tests. David’s concern: there will be some need to migrate all tests, but do not see big value in doing it.
- Elana: it will be useful to have a writeup with the justification.
- Francesco: want to take a look and learn more as a consumer of tests.
- Q: is this part of a process to make the node e2e test more like the other e2e tests?
- A: no, it’s just a new interface to call the same tests
- Action: David to ask for justification, estimation of migration effort
- Should we move [sig-storage] tests from https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-master to some place under https://testgrid.k8s.io/sig-storage-kubernetes?
- Amim: prefer to keep tests, maybe remove flaky tests
- Sergey: need a mechanism to notify those teams
- Move [sig-network] tests from https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-master to some place under https://testgrid.k8s.io/sig-network
- Fix infra issue at: https://testgrid.k8s.io/sig-node-critical#kubelet-NodeConformance
- Qiutong to take a look
- Clean-up https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-serial
- Francesco: will try.
- Multi-zone tests: https://github.com/kubernetes/test-infra/pull/21777
- Elana: looks like cloud provider specific
- Sergey: to look at what these tests suppose to test-cover
04/07/2021
Attendees:
- Elana Hashman
- Sergey Kanzhelev
- Alukiano
- Tao
- Qiutong
Agrenda:
- Artem will start looking at fake NUMA flag.
03/30/2021 Cancelled
03/24/2021
Agenda
https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+milestone%3Av1.21+label%3Asig%2Fnode
Discussing https://github.com/kubernetes/kubernetes/pull/99336:
- Overall feeling is that it’s too late for unknown unknowns introduced by this PR.
- 1.18 cherry-picking is not Node team problem, more release team problem. Maybe release team will need an exception.
03/17/2021
Attendees
Agenda
-
ehashman
Direction long term is not to test the whole matrix on presubmits, but have a good signal with failures easy to investigate by contributors. Maybe PR needs to be replaced with a single job with both runtimes.
Action: determine a long-term plan to merge all node presubmits into one job, using a name that doesn’t reveal the underlying runtimes. (e.g. cleanup ubuntu-containerd* tests)
Timeframe: dependent on a presubmit policy, maybe will happen next release cycle (1.22)
- https://github.com/kubernetes/kubernetes/issues/94289
- Sergey: list all the tags and decide what to do about it
- https://github.com/kubernetes/kubernetes/issues/96524
- Sergey’s todo.
03/10/2021
Attendees
- ehashman
- fromanirh
- swsehgal
Agenda
- Deflake of sig-node-alpha tab https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-alpha
- It’s done!!
03/03/2021
Attendees
Agenda
- Containerd tests. TODO: insert links
- Triage
-
alukiano
02/24/2021.
Attendees (7 on call):
![][image18]
- Containerd plan https://github.com/kubernetes/test-infra/issues/18570
- Questions about https://github.com/kubernetes/test-infra/pull/20937 and node-kubelet-serial tests (https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-serial)
- Announcement: node n-2 version skew tests to be discussed at SIG Arch tomorrow: https://groups.google.com/g/kubernetes-sig-architecture/c/QX-4qq2krm0/m/998T3cJUBQAJ
Product triage: https://github.com/orgs/kubernetes/projects/49
- Feature PRs missing from board that happen to have sig/testing label
- Action: needs-rebase isn’t auto-applied, bot needs to be pestered. File issue to proactively apply without resetting stale counter
02/17/2021
- Triage https://github.com/orgs/kubernetes/projects/43
- SIG-labels for all tests
- Morgan as approver
-
fromani
Product triage: https://github.com/orgs/kubernetes/projects/49
02/08/2021
Sergey
![][image19]
Triage: https://github.com/orgs/kubernetes/projects/43
- Suggest MHBauer to approver. Elana to reach out
02/01/2021 [skipping]
01/25/2021
Agenda:
Aditi
- Test plan for containerd https://github.com/kubernetes/test-infra/issues/18570
Some test analysis here https://docs.google.com/spreadsheets/d/1mN1fG0dq6t7dZTzl-g9fFNwFqD8XdbbKlr5D3R7BRzc/edit#gid=0
Some answers we want https://github.com/kubernetes/test-infra/issues/18570#issue comment-764576223 - Aditi: Updated action items here https://github.com/kubernetes/test-infra/issues/18570#issuecomment-767024601
Sergey
https://github.com/kubernetes/k8s.io/issues/956#issuecomment-764847132?
- Need for deflaking tests. “Pause” job and SSH access
- Sometime hard to understand what failed and why PR validation failed
knabben
- Deflake of these tabs:
- Node-kubelet-orphans (partial)
- Node-kubelet-alpha
ehashman
- Non-CI PR triage: Node board https://github.com/orgs/kubernetes/projects/49
- Action (ehashman): will add note cards to columns of project board to explain how it works
- Action (ehashman): will draft doc on HOW-TO node review for community repo, tag attendees, and leave open for lazy consensus/feedback
Meeting time
- Action: Sergey to send doodle for maybe moving this meeting? Mondays frequently conflict.
01/11/2021
Attendees (7 on the call):
Agenda:
- triage
01/04/2021
Attendees:
Agenda:
knabben
- Node s/gci/cos/g tab rename - https://github.com/kubernetes/test-infra/pull/20351
- Adds a --restart-kubelet flag on Node E2E tests - PTAL https://github.com/kubernetes/kubernetes/pull/97028/
Sergey
Volunteers to help with this effort
Victor Pickard (Red Hat), nick=vpickard, vpickard@redhat.com
Jay Pipes (AWS), nick=jaypipes, gh=jaypipes, jaypipes@gmail.com
Balaji (AWS), nick=srisaranbalaji, gh=SaranBalaji90, srisaranbalaji@gmail.com
Morgan Bauer (IBM), slack=mhb, gh=mhbauer, mail=mbauer@us.ibm.com
Ning Liao (Google), nick=nliao, mail=ningliao@google.com
David Porter (Google), nick=davidporter; mail=porterdavid@google.com
Hanfei Lin (Google), nick=hanfeil; mail=hanfeil@google.com
Hugo Huang (Google), nick=tangent; mail=tangent@google.com
Roy Yang(Google), nick=roy; mail=royyang@google.com
Aaron Crickenberger (Google), nick=spiffxp, spiffxp@gmail.com
nick=Archer
Ed Bartosh (Intel), slack=Ed, github=bart0sh eduard.bartosh@intel.com
Daniel Mangum (upbound.io), nick=hasheddan
Chirag Tayal (PayPal) nick=ctayal, chiragtayal@gmail.com
Zhi Feng(Airbnb), nick=Zhi, helenfengzhi@gmail.com
Dims, nick=dims, davanum@gmail.com
Jacob Blain Christen (Rancher Labs), nick=dweomer; mail=dweomer5@gmail.com
Artyom Lukianov(Red Hat), nick(github)=cynepco3hahue,nick(slack)=alukiano,mail=alukiano@redhat.com
Swati Sehgal (Red Hat), slack=swsehgal; mail swsehgal@redhat.com
Jorge Alarcon, nick=alejandrox1, alarcj137@gmail.com
Sascha Grunert (SUSE), nick=sascha, sgrunert@suse.com
Srini Brahmaroutu(IBM), slack=srbrahma, gh=brahmaroutu, mail=srbrahma@us.ibm.com
Tim Pepper (VMware), slack=tpepper, gh=tpepper, mail=tpepper@vmware.com
John Taylor (IBM), mail=jtaylor1@uk.ibm.com
Francesco Romani (Red Hat), nick=fromani; mail=fromani@redhat.com
Karan Goel (Google), nick=karan; mail=karangoel@google.com
Sergey Kanzhelev (Google), nick=SergeyKanzhelev; mail=skanzhelev@google.com
Mike Carlise (Salesforce), nick=micarlise, mail=micarlise@gmail.com
Matt Merkes (AWS), nick=merkes, mail=matt.merkes@gmail.com
Amim Knabben (Loadsmart), nick=knabben, mail=amim.knabben@gmail.com
Swati Sehgal (Red Hat), nick(slack)=swsehgal, nick(github)= swatisehgal, mail = swsehgal@redhat.com
Harshal Patil (Red Hat), slack=Harshal, gh=harche, mail=harpatil@redhat.com
Elana Hashman (Red Hat), nick=ehashman, mail=ehashman@redhat.com
Paco Xu(DaoCloud), nick=paco,mail=paco.xu@daocloud.io