Kubetest2 - Add --skip-regex logic

This will move the logic from build_jobs.py into kubetest2 itself.
This way we can rely on this logic from scenario scripts and other places that arent directly set by build_jobs.py.
This commit is contained in:
Peter Rifel 2021-06-22 08:23:44 -05:00
parent fd8fe534f9
commit 5f13d2d945
No known key found for this signature in database
GPG Key ID: BC6469E5B16DB2B6
2 changed files with 97 additions and 0 deletions

View File

@ -0,0 +1,93 @@
/*
Copyright 2021 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package tester
import (
"regexp"
"strings"
)
const (
skipRegexBase = "[Slow]|[Serial]|[Disruptive]|[Flaky]|[Feature:.+]|[HPA]|[Driver:.nfs]|Dashboard|RuntimeClass|RuntimeHandler"
)
func (t *Tester) setSkipRegexFlag() error {
// Temporarily removing for testing in the PR
// TODO: uncomment before merging
/*if t.SkipRegex != "" {
return nil
}*/
cluster, err := t.getKopsCluster()
if err != nil {
return err
}
skipRegex := skipRegexBase
networking := cluster.Spec.Networking
switch {
case networking.Kubenet != nil, networking.Canal != nil, networking.Weave != nil, networking.Cilium != nil:
skipRegex += "|Services.*rejected.*endpoints"
}
if networking.Cilium != nil {
// https://github.com/cilium/cilium/issues/10002
skipRegex += "|TCP.CLOSE_WAIT"
// https://github.com/cilium/cilium/issues/15361
skipRegex += "|external.IP.is.not.assigned.to.a.node"
// https://github.com/cilium/cilium/issues/14287
skipRegex += "|same.port.number.but.different.protocols|same.hostPort.but.different.hostIP.and.protocol"
} else if networking.Calico != nil {
skipRegex += "|Services.*functioning.*NodePort"
} else if networking.Kuberouter != nil {
skipRegex += "|load-balancer|hairpin|affinity\\stimeout|service\\.kubernetes\\.io|CLOSE_WAIT"
} else if networking.Kubenet != nil {
skipRegex += "|Services.*affinity"
}
if cluster.Spec.CloudProvider == "aws" {
if strings.Contains(cluster.Spec.KubernetesVersion, "v1.21.") {
// TODO(rifelpet): Remove once k8s tags has been created that include
// https://github.com/kubernetes/kubernetes/pull/101443
skipRegex += "|Invalid.AWS.KMS.key"
}
if strings.Contains(cluster.Spec.KubernetesVersion, "v1.22.") {
// TODO(rifelpet): Remove once volume limits tests have been fixed
// https://github.com/kubernetes/kubernetes/issues/79660#issuecomment-854884112
skipRegex += "|Volume.limits.should.verify.that.all.nodes.have.volume.limits"
}
}
igs, err := t.getKopsInstanceGroups()
if err != nil {
return err
}
for _, ig := range igs {
if strings.Contains(ig.Spec.Image, "arm64") {
skipRegex += "|Simple.pod.should.handle.in-cluster.config"
break
}
}
// Ensure it is valid regex
if _, err := regexp.Compile(skipRegex); err != nil {
return err
}
t.SkipRegex = skipRegex
return nil
}

View File

@ -351,6 +351,10 @@ func (t *Tester) execute() error {
return err
}
if err := t.setSkipRegexFlag(); err != nil {
return err
}
return t.Test()
}