kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove duplicate security-group overrides

This commit is contained in:
Justin Santa Barbara 2018-10-02 12:46:55 -07:00
parent 81cadec4ca
commit 789b7c9f28
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/model/firewall.go
View File

@ -461,6 +461,8 @@ func (b *KopsModelContext) GetSecurityGroups(role kops.InstanceGroupRole) ([]Sec
var groups []SecurityGroupInfo var groups []SecurityGroupInfo
done := make(map[string]bool)
// Build groups that specify a SecurityGroupOverride // Build groups that specify a SecurityGroupOverride
allOverrides := true allOverrides := true
for _, ig := range b.InstanceGroups { for _, ig := range b.InstanceGroups {
@ -474,6 +476,13 @@ func (b *KopsModelContext) GetSecurityGroups(role kops.InstanceGroupRole) ([]Sec
} }
name := fi.StringValue(ig.Spec.SecurityGroupOverride) name := fi.StringValue(ig.Spec.SecurityGroupOverride)
// De-duplicate security groups
if done[name] {
continue
}
done[name] = true
t := &awstasks.SecurityGroup{ t := &awstasks.SecurityGroup{
Name: ig.Spec.SecurityGroupOverride, Name: ig.Spec.SecurityGroupOverride,
ID: ig.Spec.SecurityGroupOverride, ID: ig.Spec.SecurityGroupOverride,