kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

AWS LaunchConfiguration error handling fix 

We would loop forever on an unexpected error.
This commit is contained in:
Justin Santa Barbara 2018-01-25 08:34:12 -05:00
parent 46a6d256d3
commit 9919254205
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
upup/pkg/fi/cloudup/awstasks/launchconfiguration.go
View File

@ -317,8 +317,9 @@ func (_ *LaunchConfiguration) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *La
maxAttempts := 10 maxAttempts := 10
for { for {
attempt++ attempt++
_, err = t.Cloud.Autoscaling().CreateLaunchConfiguration(request)
glog.V(8).Infof("AWS CreateLaunchConfiguration %s", aws.StringValue(request.LaunchConfigurationName))
_, err = t.Cloud.Autoscaling().CreateLaunchConfiguration(request)
if err == nil { if err == nil {
break break
} }
@ -335,8 +336,9 @@ func (_ *LaunchConfiguration) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *La
continue continue
} }
glog.V(4).Infof("ErrorCode=%q, Message=%q", awsup.AWSErrorCode(err), awsup.AWSErrorMessage(err)) glog.V(4).Infof("ErrorCode=%q, Message=%q", awsup.AWSErrorCode(err), awsup.AWSErrorMessage(err))
return fmt.Errorf("error creating AutoscalingLaunchConfiguration: %v", err)
} }
return fmt.Errorf("error creating AutoscalingLaunchConfiguration: %v", err)
} }
e.ID = fi.String(launchConfigurationName) e.ID = fi.String(launchConfigurationName)