Commit Graph

1547 Commits

Author SHA1 Message Date
Jan Chaloupka 50e4974848 kubectl describe: print toleration tolerating everything
An empty key with operator Exists matches all keys, values
and effects which means this will tolerate everything:
tolerations:
- operator: "Exists"

as stated in https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/.

However, the current printTolerationsMultilineWithIndent implementation ignores
this case. As the toleration is valid, there's no reason
to skip it when writing the list of all pod's tolerations.

Kubernetes-commit: 0bd9a4c6c5ba4fbbc8439effddc99004ddd6b232
2020-05-12 15:59:52 +02:00
Maciej Szulik b0e673d0df Fix create cronjob help message
Kubernetes-commit: b2b59527964a3629f5d50e4b724aa027b4c36cc5
2020-05-12 10:35:50 +02:00
Kubernetes Publisher 19fd05792d Merge pull request #88723 from wawa0210/kubectl_taint_short_forms
Support kubectl more flexible matching method to match whether the current resource type is node

Kubernetes-commit: 7814f3aaf7ae2f84d1bc1f7443e4d892b94a1759
2020-04-28 12:40:44 +00:00
Kubernetes Publisher 7f4cfa94a9 Merge pull request #89992 from zhouya0/remove_cobra_command_from_options
Remove *cobra.command from options

Kubernetes-commit: 95bb85378ddd8a31d1a794540ec627640dbe8584
2020-04-27 20:35:14 +00:00
Kubernetes Publisher 5189bed8cc Merge pull request #85806 from beautytiger/dev-191202-urlspace
fix: add space in front of url in command desc

Kubernetes-commit: ca8db0b396b989bcf9b08c452b0da347303337c6
2020-04-27 20:35:12 +00:00
Kubernetes Publisher 6874454206 Merge pull request #90448 from soltysh/issue87851
Fix run command when waiting for pods

Kubernetes-commit: b68bf25531b9b9ed0be6ea60fb00a30042fc8a44
2020-04-25 00:32:12 +00:00
Maciej Szulik d727dabb7d waitForPod should use different exitCondition depending on restart policy
Kubernetes-commit: 6f1484256db9579361d218aef7f7960446fd541d
2020-04-24 13:04:42 +02:00
wojtekt 5b27ac0ca2 Fix the flaky kubectl tests at scale
Kubernetes-commit: 98058a1b68da3726e1110dc8bba3838459d03b29
2020-04-23 22:05:55 +02:00
Kubernetes Publisher eb899df9a1 Merge pull request #87405 from gavinfish/kubectl_pkg_cmd_set
Staticcheck: vendor/k8s.io/kubectl/pkg/cmd/set and .../edit

Kubernetes-commit: 653396da21c98c2b48c59b832edcb3404c608dc6
2020-04-23 10:11:53 +00:00
Kubernetes Publisher 331c786cb4 Merge pull request #89803 from marun/fix-kubectl-run-restart-help
kubectl: Update run's --restart help to reflect generator removal

Kubernetes-commit: 8364e1f0d2fc1c1c7700b1754a18920a7a8e611d
2020-04-23 02:48:29 +00:00
Kubernetes Publisher 6896409bdb Merge pull request #90364 from soltysh/issue87851
Re-use podAttachTimeout when waiting for pod readiness

Kubernetes-commit: 1b57bd7e1fce60d0d99fd3163b68adbbe05cd3fb
2020-04-22 22:46:53 +00:00
Maciej Szulik 6a446d6097 Re-use podAttachTimeout when waiting for pod readiness
Kubernetes-commit: c2bb76ebc902ea5172aa56db78d1fb59f4f88bec
2020-04-22 17:01:13 +02:00
Jie Shen 5b17a56c1b Use utils.net to parse ports instead of atoi (#89120)
Kubernetes-commit: 363bb3914296d5330dce29631fb6003c335cfcf7
2020-04-22 06:49:46 +00:00
Kubernetes Publisher 3dfa195a75 Merge pull request #89505 from knight42/fix/kubectl-explain-crd
fix(kubectl): explain crds whose resource name is the same as builtin objects

Kubernetes-commit: 4362bf7919f20c0f0ab49a740e466a4835059b42
2020-04-21 10:46:23 +00:00
Kubernetes Publisher 5c6d6fa24d Merge pull request #90227 from gosoon/bugfix
kubectl: fix the Scheduled eventTime is <unknown> when printing event

Kubernetes-commit: 5157383b8436fd9e97a674ba6ae795d37efcc345
2020-04-20 18:46:44 +00:00
Kubernetes Publisher cae9b17d8f Merge pull request #90243 from soltysh/issue90074
Revert "stop defaulting kubeconfig to http://localhost:8080"

Kubernetes-commit: e95106106b1e24056a98fd08740b5c5e6a00f8d7
2020-04-19 06:49:55 +00:00
Maciej Szulik e6776b41f6 Fix kubectl version test to tolerate Run error coming from default
localhost:8080

Kubernetes-commit: 34865774a89db5f5b8684d5dd1042f6f4c2b21d0
2020-04-17 17:50:24 +02:00
gosoon d47103fdcc kubectl: fix the Scheduled eventTime is <unknown> when use kubectl describe pod xxx
Kubernetes-commit: 798f677aaca0b28f22c09ba6b536c84bec6f5d2f
2020-04-17 19:58:27 +08:00
Kubernetes Publisher 44044e1c83 Merge pull request #89674 from superbrothers/fix-kubectl-alpha-debug
Fix missing a shorthand for container flag of kubectl alpha debug

Kubernetes-commit: 6652347ceea958c0004ce959e8fd3137ff5ef064
2020-04-17 10:45:29 +00:00
Brian Pursley b4594b0812 Added kubectl apply check to prevent using --dry-run=server with --force
Kubernetes-commit: 99f6dca1a8d1ea64d22a68263c77bcafd6fedc48
2020-04-16 21:23:36 -04:00
Jordan Liggitt be12c7c870 Print and describe failed CSRs
Kubernetes-commit: 6b61cb290786688e3f994f4776f3a672c8f30fbb
2020-04-16 01:05:46 -04:00
Kubernetes Publisher 6f34ae560e Merge pull request #89861 from rccrdpccl/bugfix/error-message-for-get-non-namespaced-resources
Change not found output when getting non namespaced resources

Kubernetes-commit: 190ae06518c33bff173a0ac6d115b38fbfe882a5
2020-04-15 22:45:58 +00:00
Kubernetes Publisher 69d71c4991 Merge pull request #89913 from zhouya0/fix_kubectl_version_should_print_version_info
Fix kubectl version should print version info without config file

Kubernetes-commit: db999c96343c10e83d72ff4bb82e775f09edf0a6
2020-04-15 18:48:30 +00:00
Kubernetes Publisher fc82a03c79 Merge pull request #89818 from verb/cli-debug-typed
kubectl debug: support different kinds

Kubernetes-commit: 495b0ddfaaec93fce726ffee7acabfb55d56327b
2020-04-15 14:44:57 +00:00
Kubernetes Publisher 3a34febffb Merge pull request #89570 from zhouya0/fix_describe_job_nil_pointer
Fix kubectl describe job event test nil pointer

Kubernetes-commit: 69e9c6bb055da48de38a4f576fe9d8e7c7f78dc7
2020-04-15 14:44:55 +00:00
Kubernetes Publisher 35098e8b21 Merge pull request #82181 from tipok/master
fix BusyBox sed

Kubernetes-commit: 1d772e3b368c51b08f28250cea2673bc021a00d4
2020-04-14 23:14:06 +00:00
Kubernetes Publisher 33fb6c9168 Merge pull request #89479 from knight42/fix/zsh-completion-file-flag
fix(kubectl): remove trailing space when completing file path

Kubernetes-commit: c32b93aa2bc20aab9249df02ac50279b48847edc
2020-04-13 22:58:46 +00:00
Aylei c73a3aa1bf Add debug by copy support for kubectl alpha debug command
Signed-off-by: Aylei <rayingecho@gmail.com>

Update staging/src/k8s.io/kubectl/pkg/cmd/debug/debug.go

Co-Authored-By: Lee Verberne <lee@verb.is>

Apply suggestions from code review

Co-Authored-By: Lee Verberne <lee@verb.is>

Kubernetes-commit: cfece3edfe8a726fc5dc65ef89b89021316837c7
2020-04-13 01:58:36 +08:00
Kubernetes Publisher 1e031af268 Merge pull request #89666 from julianvmodesto/kubectl-scale-dry-run
Support kubectl scale --dry-run=server|client

Kubernetes-commit: 4bba193bea805300dd64f73c89eafaf016770e7a
2020-04-11 18:44:38 +00:00
Kubernetes Publisher 7238af1c33 Merge pull request #89833 from liggitt/json-raw
preserve integers decoding raw JSON values

Kubernetes-commit: ec00b4fcc2d0ad494275558e780606b1d9b3e469
2020-04-10 03:54:30 +00:00
Kubernetes Publisher 9dec2972b2 Merge pull request #89551 from zlabjp/restore-kubectl-prune-multiple-namespaces
Restore the ability to `kubectl apply --prune` without -n flag

Kubernetes-commit: 897c10e7b26e715642b367e0c47bccd69ba3c4c6
2020-04-09 07:49:43 -07:00
zhouya0 425b3d2e14 Remove *cobra.command from options
Kubernetes-commit: 1ef5732c436463f405b8224c6885a50716bfc39b
2020-04-09 12:15:43 +08:00
zhouya0 9d73fd8f3c Fix kubectl version should print version info
Kubernetes-commit: 948f4de2dbba3affca2de460d836158cbde5db78
2020-04-07 15:18:38 +08:00
Jordan Liggitt 16257eeb48 k8s.io/kube-openapi v0.0.0-20200403204345-e1beb1bd0f35
fix client-side validation to allow a value of 0 for a number field

Kubernetes-commit: 8b9165839f1f592262c6ac657649b0acff66d1e4
2020-04-03 14:10:50 -04:00
Lee Verberne 63b6f85e5d kubectl debug: add support for debugging nodes
When called with a node target, `kubectl debug` will create a run-once
pod in the target node's namespaces.

Kubernetes-commit: 7e63cc8b9d592abbb8a659205555e67b57080837
2020-04-03 18:36:32 +02:00
Lee Verberne c401716d75 kubectl debug: support different kinds
This is a refactor ahead of adding support for supporting `kubectl debug` of nodes.

Kubernetes-commit: 8414d180feb9ddb0d4b9b80ea8e570dcacf98703
2020-04-03 14:31:18 +02:00
Maru Newby 2cd642e11a kubectl: Update run's --restart help to reflect generator removal
PR #87077 ensured that only pods would created by `kubectl run`. This
change updates the help text for the `--restart` parameter to no longer
reference the removed job and deployment generators.

Kubernetes-commit: ab8b69b54eed552845c0548a30909f97ceaf0457
2020-04-02 21:30:25 -07:00
Julian V. Modesto 0d395d7c98 Make client-side apply safer
- Remove the ServerDryRun field and delegate it entirely to the resource.Helper
- Use resource.Helper for deletions (as in `kubectl apply --force`)
instead of using the pruner's method that uses a dynamic client
- Reduce the resource.Helpers and times we check for server-side dry-run
in apply

Kubernetes-commit: f0eb68c0cfcff6d50d9d5ec278f96820e3cb3f9a
2020-04-02 18:26:32 -04:00
Kazuki Suda 736b43aee9 Fix missing a shorthand for container flag of kubectl alpha debug
Kubernetes-commit: fca1027dd6d69ca7c5b3dd54059c29b2c8d04762
2020-03-31 12:15:17 +09:00
Julian V. Modesto 489b062728 Support kubectl scale --dry-run=server|client
Kubernetes-commit: efed958779d564357a9965fccf43f64ee1feb972
2020-03-30 17:33:15 -04:00
Benjamin Danon fe86de7a63 Fix the newName field name in the page
Kubernetes-commit: c39c64ffdaf677d09c412e7447b5bf400394068b
2020-03-29 00:23:47 +01:00
Benjamin Danon 2c37c8fc35 Fix the newName field name in the example
Kubernetes-commit: 77ca434ec378d607fee83dc790eb8981d5beb4e7
2020-03-29 00:15:47 +01:00
zhouya0 9e97ec383e Fix kubectl describe job event test nil pointer
Kubernetes-commit: a576a3c7070c9aeb1da1878e0ca956190979f03a
2020-03-27 19:07:18 +08:00
Tatsuhiro Tsujikawa e7bb62301f Restore the ability to `kubectl apply --prune` without -n flag
Before https://github.com/kubernetes/kubernetes/pull/83084, `kubectl
apply --prune` can prune resources in all namespaces specified in
config files.  After that PR got merged, only a single namespace is
considered for pruning.  It is OK if namespace is explicitly specified
by --namespace option, but what the PR does is use the default
namespace (or from kubeconfig) if not overridden by command line flag.
That breaks the existing usage of `kubectl apply --prune` without
--namespace option.  If --namespace is not used, there is no error,
and no one notices this issue unless they actually check that pruning
happens.  This issue also prevents resources in multiple namespaces in
config file from being pruned.

kubectl 1.16 does not have this bug.  Let's see the difference between
kubectl 1.16 and kubectl 1.17.  Suppose the following config file:

```yaml
apiVersion: v1
kind: ConfigMap
metadata:
  creationTimestamp: null
  name: foo
  namespace: a
  labels:
    pl: foo
data:
  foo: bar
---
apiVersion: v1
kind: ConfigMap
metadata:
  creationTimestamp: null
  name: bar
  namespace: a
  labels:
    pl: foo
data:
  foo: bar
```

Apply it with `kubectl apply -f file`.  Then comment out ConfigMap foo
in this file.  kubectl 1.16 prunes ConfigMap foo with the following
command:

$ kubectl-1.16 apply -f file -l pl=foo --prune
configmap/bar configured
configmap/foo pruned

But kubectl 1.17 does not prune ConfigMap foo with the same command:

$ kubectl-1.17 apply -f file -l pl=foo --prune
configmap/bar configured

With this patch, kubectl once again can prune the resource as before.

Kubernetes-commit: 7af3b01f24edfde34e42640ee565a5a6bb66ce26
2020-03-27 01:11:36 +00:00
Kubernetes Publisher 3a103510c0 Merge pull request #89942 from dims/update-fsnotify-to-pick-up-bug-fixes
Updating dependency github.com/fsnotify/fsnotify to version v1.4.9

Kubernetes-commit: b3837f858adfc13952736fd076717ec525e96dc9
2020-04-09 02:49:34 +00:00
Davanum Srinivas 745c13fecf Updating dependency github.com/fsnotify/fsnotify to version v1.4.9
Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Kubernetes-commit: eee5235d2509df063189e08e150cc2c8213b54ed
2020-04-07 20:50:27 -04:00
Kubernetes Publisher e65caf9645 Merge pull request #89919 from mortenhauberg/remove-double-kubectl-from-output
Remove double `kubectl` from deprecation warning

Kubernetes-commit: 39da2c0e9c2f05aae10d287ecaf91daa55535a91
2020-04-08 07:02:02 +00:00
Morten Hauberg 84b55fb518 Remove double `kubectl` from output
Kubernetes-commit: 5fe57c61482611361502544f36e9df3d17898449
2020-04-07 12:54:26 +02:00
Kubernetes Publisher 09953ef519 Merge pull request #89848 from seans3/kubectl-apply-fix
Even with build error, kubectl apply should apply all valid resources

Kubernetes-commit: c1f1b1bceb8e6dfbc0083617a25f17dd8d57340b
2020-04-06 02:46:01 +00:00
Sean R. Sullivan 34abefcfa8 Even with build error, kubectl apply should apply all valid resources
Kubernetes-commit: 748ad74245778a93a68652cd7e804d6a1e13ad9d
2020-04-03 19:50:25 -07:00