linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Modifying Contribution Guidelines for PRs (#2587) 

This PR modifies the Linkerd2 Contribution Guidelines. It adds a request that
PRs include instructions on how to test changes, and to include a screenshot if
there is a UI change.
This commit is contained in:
Carol A. Scott 2019-03-28 16:09:09 -07:00 committed by GitHub
parent 93e7654eba
commit 45aa10dcc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CONTRIBUTING.md
View File

@ -34,6 +34,9 @@ Do you have an improvement?
2. We will try to respond to your issue promptly.
3. Fork this repo, develop and test your code changes. See the project's [README](README.md) for further information about working in this repository.
4. Submit a pull request against this repo's `master` branch.
- Include instructions on how to test your changes.
- If you are making a change to the user interface (UI), include a
screenshot of the UI before and after your changes.
5. Your branch may be merged once all configured checks pass, including:
- The branch has passed tests in CI.
- A review from appropriate maintainers (see [MAINTAINERS.md](MAINTAINERS.md) and [GOVERNANCE.md](GOVERNANCE.md))