open-feature
/
java-sdk
mirror of https://github.com/open-feature/java-sdk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

registerHooks -> addHooks. Fixes #9

This commit is contained in:
Justin Abrahms 2022-05-27 20:53:37 -07:00
parent f5546691a3
commit 3594044d05
No known key found for this signature in database
GPG Key ID: 599E2E12011DC474
6 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/src/main/java/dev/openfeature/javasdk/FlagEvaluationLifecycle.java
View File

@ -3,6 +3,6 @@ package dev.openfeature.javasdk;
import java.util.List; import java.util.List;
public interface FlagEvaluationLifecycle { public interface FlagEvaluationLifecycle {
void registerHooks(Hook... hooks); void addHooks(Hook... hooks);
List<Hook> getClientHooks(); List<Hook> getClientHooks();
} }

2
lib/src/main/java/dev/openfeature/javasdk/OpenFeatureAPI.java
View File

@ -38,7 +38,7 @@ public class OpenFeatureAPI {
return new OpenFeatureClient(this, name, version); return new OpenFeatureClient(this, name, version);
} }
public void registerHooks(Hook... hooks) { public void addHooks(Hook... hooks) {
this.apiHooks.addAll(Arrays.asList(hooks)); this.apiHooks.addAll(Arrays.asList(hooks));
} }

2
lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java
View File

@ -29,7 +29,7 @@ public class OpenFeatureClient implements Client {
} }
@Override @Override
public void registerHooks(Hook... hooks) { public void addHooks(Hook... hooks) {
this.clientHooks.addAll(Arrays.asList(hooks)); this.clientHooks.addAll(Arrays.asList(hooks));
} }

4
lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java
View File

@ -27,7 +27,7 @@ class DeveloperExperienceTest {
OpenFeatureAPI api = OpenFeatureAPI.getInstance(); OpenFeatureAPI api = OpenFeatureAPI.getInstance();
api.setProvider(new NoOpProvider()); api.setProvider(new NoOpProvider());
Client client = api.getClient(); Client client = api.getClient();
client.registerHooks(exampleHook); client.addHooks(exampleHook);
Boolean retval = client.getBooleanValue(flagKey, false); Boolean retval = client.getBooleanValue(flagKey, false);
verify(exampleHook, times(1)).finallyAfter(any(), any()); verify(exampleHook, times(1)).finallyAfter(any(), any());
assertFalse(retval); assertFalse(retval);
@ -40,7 +40,7 @@ class DeveloperExperienceTest {
OpenFeatureAPI api = OpenFeatureAPI.getInstance(); OpenFeatureAPI api = OpenFeatureAPI.getInstance();
api.setProvider(new NoOpProvider()); api.setProvider(new NoOpProvider());
Client client = api.getClient(); Client client = api.getClient();
client.registerHooks(clientHook); client.addHooks(clientHook);
Boolean retval = client.getBooleanValue(flagKey, false, null, Boolean retval = client.getBooleanValue(flagKey, false, null,
FlagEvaluationOptions.builder().hook(evalHook).build()); FlagEvaluationOptions.builder().hook(evalHook).build());
verify(clientHook, times(1)).finallyAfter(any(), any()); verify(clientHook, times(1)).finallyAfter(any(), any());

10
lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java
View File

@ -42,12 +42,12 @@ public class FlagEvaluationSpecTests {
Hook h1 = mock(Hook.class); Hook h1 = mock(Hook.class);
Hook h2 = mock(Hook.class); Hook h2 = mock(Hook.class);
OpenFeatureAPI api = OpenFeatureAPI.getInstance(); OpenFeatureAPI api = OpenFeatureAPI.getInstance();
api.registerHooks(h1); api.addHooks(h1);
assertEquals(1, api.getApiHooks().size()); assertEquals(1, api.getApiHooks().size());
assertEquals(h1, api.getApiHooks().get(0)); assertEquals(h1, api.getApiHooks().get(0));
api.registerHooks(h2); api.addHooks(h2);
assertEquals(2, api.getApiHooks().size()); assertEquals(2, api.getApiHooks().size());
assertEquals(h2, api.getApiHooks().get(1)); assertEquals(h2, api.getApiHooks().get(1));
} }
@ -67,8 +67,8 @@ public class FlagEvaluationSpecTests {
Client c = _client(); Client c = _client();
Hook m1 = mock(Hook.class); Hook m1 = mock(Hook.class);
Hook m2 = mock(Hook.class); Hook m2 = mock(Hook.class);
c.registerHooks(m1); c.addHooks(m1);
c.registerHooks(m2); c.addHooks(m2);
List<Hook> hooks = c.getClientHooks(); List<Hook> hooks = c.getClientHooks();
assertEquals(2, hooks.size()); assertEquals(2, hooks.size());
assertTrue(hooks.contains(m1)); assertTrue(hooks.contains(m1));
@ -142,7 +142,7 @@ public class FlagEvaluationSpecTests {
Client c = _client(); Client c = _client();
Hook clientHook = mock(Hook.class); Hook clientHook = mock(Hook.class);
Hook invocationHook = mock(Hook.class); Hook invocationHook = mock(Hook.class);
c.registerHooks(clientHook); c.addHooks(clientHook);
c.getBooleanValue("key", false, null, FlagEvaluationOptions.builder() c.getBooleanValue("key", false, null, FlagEvaluationOptions.builder()
.hook(invocationHook) .hook(invocationHook)
.build()); .build());

4
lib/src/test/java/dev/openfeature/javasdk/HookSpecTests.java
View File

@ -195,7 +195,7 @@ public class HookSpecTests {
List<String> evalOrder = new ArrayList<String>(); List<String> evalOrder = new ArrayList<String>();
OpenFeatureAPI api = OpenFeatureAPI.getInstance(); OpenFeatureAPI api = OpenFeatureAPI.getInstance();
api.setProvider(new NoOpProvider()); api.setProvider(new NoOpProvider());
api.registerHooks(new Hook<Boolean>() { api.addHooks(new Hook<Boolean>() {
@Override @Override
public Optional<EvaluationContext> before(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints) { public Optional<EvaluationContext> before(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints) {
evalOrder.add("api before"); evalOrder.add("api before");
@ -220,7 +220,7 @@ public class HookSpecTests {
}); });
Client c = api.getClient(); Client c = api.getClient();
c.registerHooks(new Hook<Boolean>() { c.addHooks(new Hook<Boolean>() {
@Override @Override
public Optional<EvaluationContext> before(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints) { public Optional<EvaluationContext> before(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints) {
evalOrder.add("client before"); evalOrder.add("client before");