open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updating Jaeger tags based on spec (#1513) 

* Updating Jaeger tags based on spec

* updating changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
This commit is contained in:
Eddy Nakamura 2020-11-11 21:54:48 -03:00 committed by GitHub
parent 6157364796
commit be72b17570
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md
View File

@ -2,6 +2,10 @@
## Unreleased
* Jaeger tags used for InstrumentationLibrary changed from library.name,
library.version to otel.library.name, otel.library.version respectively.
([#1513](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1513))
## 0.8.0-beta.1
Released 2020-Nov-5

4
src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs
View File

@ -95,10 +95,10 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
var activitySource = activity.Source;
if (!string.IsNullOrEmpty(activitySource.Name))
{
PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("library.name", JaegerTagType.STRING, vStr: activitySource.Name));
PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("otel.library.name", JaegerTagType.STRING, vStr: activitySource.Name));
if (!string.IsNullOrEmpty(activitySource.Version))
{
PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("library.version", JaegerTagType.STRING, vStr: activitySource.Version));
PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("otel.library.version", JaegerTagType.STRING, vStr: activitySource.Version));
}
}

2
test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs
View File

@ -327,7 +327,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Tests.Implementation
// The last tag should be library.name in this case
tag = tags[tags.Length - 1];
Assert.Equal(JaegerTagType.STRING, tag.VType);
Assert.Equal("library.name", tag.Key);
Assert.Equal("otel.library.name", tag.Key);
Assert.Equal(nameof(CreateTestActivity), tag.VStr);
var logs = jaegerSpan.Logs.ToArray();