Commit Graph

682 Commits

Author SHA1 Message Date
Reiley Yang fd0cc21b39
Update the custom processor project (#996)
* update the processor project

* simply code

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 21:20:43 -07:00
Reiley Yang 79acec1bc6
Add custom exporter project (#1004)
* Add custom exporter project'

* manually resolve merge conflict

* update codecov ignore list
2020-08-04 21:03:43 -07:00
Alan West 362c1fe8b9
Add gRPC attributes for ASP.NET Core (#803)
* Change gRPC test project name and namespace

* Use SpanAttributeConstants in GrpcClientTests

* Add test for Grpc.AspNetCore instrumentation

* Add gRPC attributes for ASP.NET Core

* Prevent parallel execution of gRPC client and server test suites

* Add wait logic from AspNetCore tests ensuring end callback gets invoked

* Partial class for gRPC test to resolve test conflicts

Co-authored-by: Michael Goin <michaelgoin@gmail.com>

* Make "grpc" a const

* Set http.status_code attribute even on a gRPC invocation

* Fix GrpcFixture

* Add checks for http.* attributes to ASP.NET Core gRPC test

* Fix merge snafu

* Update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Michael Goin <michaelgoin@gmail.com>
2020-08-04 20:21:17 -07:00
Eddy Nakamura c3500d2ff1
Enable FxCop - part 01 (#997)
* Enable FxCop

* removing useless toString()

* Enable FxCop - 1

* updating order

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 20:04:28 -07:00
Reiley Yang 0bcf363e0d
Add custom sampler project (#1001)
* add custom sampler project

* add comment
2020-08-04 19:58:13 -07:00
Eddy Nakamura 8948470937
Creating CompositePropagator (#923)
* Creating CompositePropagator

Adding ActivityContext to interface

Adding tests

Updating CompositePropagator + tests

updating comments

Improving performance when size is 0

updating tests

updating default tracestate for empty

MikeGoldsmith review

adding more tests to exemplify usage

Feature/composite propagator refactor (#1)

* Added TestPropagator and switched a couple tests to use it.

* removing extra classes

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>

updating changelog and constructor

MikeGoldsmith comments

updating logic

* checking value

* adding inverted test

* updating tests

* removing tracecontext and b3 tests

* testing only aspnet to merge

* Revert "testing only aspnet to merge"

This reverts commit 43ca7d074b.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 17:26:56 -07:00
Eddy Nakamura 53a579f507
Updating exporters to use TagObjects instead of Tags (#1000)
* Update ZipkinExporter to use TagObjects instead of Tags

* Updating JaegerExporter to use TagObjects

* Updating OtlpExporter to use TagObjects

* removing unused using

* Removing duplicated logic

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 17:10:29 -07:00
Reiley Yang 4f8c351420
minor clean up (#1002)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 14:51:59 -07:00
Eddy Nakamura 5cdfd30284
Updating ActivityProcessor (#975)
* Updating ActivityProcessor

updating tests

updating tests - 2

updating merge

updating tests - 3

updating tests - 4

using inrange instead of equal

updating tests

* updating to inRange

* following docs.microsoft

* updating tests and changelog

* Adding in changelog custom behavior

* Removing duplicated IDisposable

* forcing dispose

* updating tests

* moving to single instead of equal one

* returning to default

* setting more time to pass tests

* forcing dispose

* reiley's suggestions

* reverting order

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 14:40:30 -07:00
Eddy Nakamura da8cd0d5c8
Adding array of primitives to TelemetrySpan (#999)
* Adding array of primitives to TelemetrySpan

* updating tests

* removing baggage methods
2020-08-04 13:57:48 -07:00
Cijo Thomas 80edb939e4
HttpStatusCode as int instead of string (#998)
* HttpStatusCode to use int

* foramt

* format

* Cops arrested me
2020-08-04 09:17:03 -07:00
Reiley Yang bde64f2b6a
use absolute path for project includes (#993)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 07:23:47 -07:00
Eddy Nakamura 8f3fa541d0
Updating todos (#991)
* Updating todos

* updating isremote from propagators and from tests

* removing isremote validation when isvalid is false
2020-08-04 07:02:03 -07:00
Mikel Blanchard 9f660cc652
Send ActivityLinks to Jaeger as JaegerSpanRefType.FOLLOWS_FROM. (#970)
* Send ActivityLinks to Jaeger as JaegerSpanRefType.FOLLOWS_FROM.

* Markdown lint.

* Update CHANGELOG.md with PR link.

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Markdown lint attempt 2.

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-03 18:05:49 -07:00
Reiley Yang ca368e9748
treat warning as warning for debug build (#990) 2020-08-03 17:31:49 -07:00
Reiley Yang 90c5b3af11
Improve docs structure (#983)
* improve docs structure

* revert line ending

* adopt .net5-preview-8

* remove unused using
2020-08-03 16:46:48 -07:00
Alan West dfe5f91d1d
Add UseExporter config option to AspNetCore example app (#976)
* Add UseExporter command line option to AspNetCore example app

* Use appsettings.json

* Remove unused using
2020-08-03 14:48:34 -07:00
Cijo Thomas d2c93610e8
Update to preview 8 of DiagnosticSource and associated changes - part1 (#954)
* Initial make build fix commit

* change Link public API to accept ActivityTagsCollection

* Add more SetAttribute overload to support int bool float and bool

* changelog

* Replace AddTag with SetTag in Activity

* disable a test for temporary progress

* reformat

* url fix

* Update Diagnosticourcepackage

* version fix

* ActivityTagsCollection

* console exporter fix

* one basic test

* minor
2020-08-03 11:25:24 -07:00
Eddy Nakamura c6d020b49f
Adding XML comments - part 01 (#955)
* enabling cs1591 for OT project

Adding some xml comments - 1

Adding some xml comments - 2

changing some references to semantic

updating returns message from aggregator

Adding more comments

Adding dispose comments

undoing some changes

commenting rule

uncomment rule

* renaming from isdisposing to disposing

* updating comments

* cijo's comments

* updating texts

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-02 09:20:41 -07:00
Eddy Nakamura b74194757f
updating workflows (#973)
* updating workflows

* updating dotnet core workflow
2020-08-02 07:40:29 -07:00
Eddy Nakamura a326550305
Minor improvements to OT (#972)
Adding copyright header to files, and other changes

adding headers

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-02 06:48:58 -07:00
Reiley Yang 2e4b081f6d
Consolidate package version (#971)
* consolidate package version for src folder

* fix CI

* clean up

* clean up test package version

* clean up

* fix nits

* clean up using
2020-08-02 06:20:44 -07:00
Reiley Yang c612b40da4
Improve project props management (#966)
* improve project props management

* use less strict version

* add comment

* workaround redis test

* reduce the scope of change

* Revert "reduce the scope of change"

This reverts commit 059ef3a6ef956978c61b101ed5914203b214c2a0.

* revert

* try to fix docker

* try to fix docker

* manually update the sln file
2020-08-01 18:23:53 -07:00
Reiley Yang e384444981
clean up (#959)
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-07-31 20:59:12 -07:00
Reiley Yang aa86dfe219
Add Sdk.SuppressInstrumentation (#960)
* add Sdk.SuppressInstrumentation

* simplify the code

* fix comments

* add XML comment

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-07-31 20:42:16 -07:00
Liudmila Molkova 8468380afa
Another attempt to fix links example (#965)
* Another attempt on links scenario

Fixes example for links.
If `default(ActivityContext)` is provided, it creates a child of `Current` or orphan under the hood.

* Update README.md

* Update README.md

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-07-31 20:34:44 -07:00
Eddy Nakamura c68061fa0c
dotnet-format check (#958)
* dotnet-format check

updating name

updating order

Update dotnet-format.yml

updating job name

Updating files based on dotnet-format

updating sanitycheck

updating os

* updating workflows

* adding path to editorconfig

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-07-31 18:46:08 -07:00
Peter Wiese a3e6b0364f
HTTP client instrumentation was incorrectly putting the text representation of an HTTP status code into http.status_code. (#964)
Other changes
- HTTP 100-200 status codes should map to OK.

see https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
2020-07-31 17:05:41 -07:00
Reiley Yang 637874f49e
Doc skeleton (#943)
* skeleton doc

* fix nits
2020-07-30 23:01:35 -07:00
Reiley Yang 3333957c12
Runtime context API (#948)
* runtime context API

* fix comments

* rename

* changelog

* changelog
2020-07-30 20:45:28 -07:00
Eddy Nakamura d03dff2435
Bugfix/test event source (#952)
* Trying to fix eventsource testing failing sometimes

clear messages after finish

* moving to finally
2020-07-30 10:11:52 -07:00
Liudmila Molkova 70c410771a
Clarify Activity parent in links example (readme) (#946)
* Clarify parent id in links scenario

Server activity had parent equal to one of the links - this is confusing, changed to default context (new trace) as likely this activity has no parent.

* Update README.md

* review comments

* fix lint

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-30 09:50:47 -07:00
Eddy Nakamura 21d18e1662
Testing EventSource (#944)
Validating EventSource

adding more tests, updating wrong namespace

updating spaces

merging invariantString to prevent duplication

removing extra space

merging exception extensions

Adding comments

updating project and tests

updating eventsourcetest

breaking tests

Revert "breaking tests"

This reverts commit 7c23b46316c9dc84d5b66c1e0498498a4b0b3ac7.
2020-07-30 06:38:41 -07:00
Eddy Nakamura 052a09bebc
Merging ToInvariantString (#945)
* Merging ToInvariantString

* updating encoding

* removing merged method
2020-07-29 14:24:50 -07:00
Eddy Nakamura 3f01bdc108
Improving code coverage (#939)
Adding tests for zpages and hosting extensions

Testing enableConnectionLevelAttributes from SqlClient

updating assert

Adding tests for SqlClientInstrumentationOptions

removing extra test

undoing changes

updating changelog

renaming file to be complicant with other exporters

renaming files and adding more tests
2020-07-28 21:46:44 -07:00
Reiley Yang b25d741182
Add a small section on how to run markdownlint locally (#938)
* add a small section on how to run markdownlint locally

* uppercase
2020-07-27 22:42:47 -07:00
Mikel Blanchard 3169107c3b
A single AddHttpClientInstrumentation extension. (#935)
* A single AddHttpClientInstrumentation extension.

* Updating changelog.

* Cleaned up unit test.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-27 22:42:09 -07:00
Eddy Nakamura 38f86a9452
Enabling CodeCoverage (#937)
* Enabling CodeCoverage

* adding end line
2020-07-27 20:30:19 -07:00
Eddy Nakamura f9c0fb9006
Updating ADO pipeline (#930)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-27 17:56:32 +01:00
Reiley Yang 4f3e18704e
remove vscode settings (#933)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-27 08:57:02 -07:00
Cijo Thomas 871d56cd66
Fix inconsistent naming for Extension methods (#931)
* Fix inconsistent naming by changing OpenTelemetryBuilderExtensions to TracerProviderBuilderExtensions.

* Fix renamins
2020-07-27 08:46:27 -07:00
Reiley Yang 421612ee2a
add link to the contribution graph (#932) 2020-07-27 08:35:30 -07:00
Reiley Yang 755f727df0
Add sanity check for non-ASCII character and trailing spaces (#927)
* add CI sanity check for non-ASCII encoding and trailing spaces

* check TAB too

* fix ordering

* rename sanity to sanitycheck
2020-07-27 07:52:26 -07:00
Eddy Nakamura 14255acb6d
Trigger pipeline when tag (#926)
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-07-25 06:44:57 -07:00
Reiley Yang 12c2e03941
fix broken instruction (#924) 2020-07-24 17:10:23 -07:00
Reiley Yang cc331fab76
docfx improvement (#922)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-24 16:08:38 -07:00
Cijo Thomas 33a52efb0c
Harmless commit to trigger CI. (#921) 2020-07-24 15:50:16 -07:00
Eddy Nakamura 4904972539
Merging itextFormat (#920)
* Merging itextFormat

* removing unused eventsource that was used for spancontext

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-24 15:39:41 -07:00
Cijo Thomas 920b0ed8d2
Provide MeterProvider to replace MeterFactory to be in sync with spec. (#919)
* Provide MeterProvider to replace MeterFactory to be in sync with spec.

* move OpenTelemetrymetrics to metrics folder

* Update examples/Console/TestPrometheusExporter.cs

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Sdk.CreateTracerProvider CreateMeterProvider

* move Sdk to root

* makr Sdk static

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2020-07-24 15:27:21 -07:00
Eddy Nakamura e4160635b3
Adding nuget/myget badges (#913)
* Adding nuget/myget badges

* updating label from myget

* updating label again

* Update README.md

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-24 12:27:22 -07:00