Commit Graph

20 Commits

Author SHA1 Message Date
Timothy Mothra 55556af592
fix analysis issues: CA2000 (#4038) 2022-12-22 13:59:59 -08:00
Timothy Mothra 64f1d74561
fix analysis issues: CA2007 (part2) (#4018)
* fix analysis issues: CA2007

* remove duplicate

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2022-12-15 16:31:49 -08:00
Vishwesh Bankwar 2fce583b9c
[HttpClient] Remove `http.host` and add `net.peer.name` & `net.peer.port` to match spec (#3832) 2022-11-11 12:49:30 -05:00
Mikel Blanchard 399fbcfaab
[Http Instrumentation] Unify exposed public API (#3793)
* Expose the same Http API for all targets.

* CHANGELOG stub.

* Merge updates.

* CHANGELOG updates.

* CHANGELOG cleanup.

* Working on tests.

* Test fix.

* Cleanup.

* HttpClient tests passing.

* Tests passing.

* Tests passing.

* README updates.

* Cleanup.

* Lint

Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
2022-11-02 11:48:23 -07:00
Vishwesh Bankwar d21e609f00
[Http] Update enrich callbacks for http (#3792) 2022-10-21 11:34:17 -07:00
Yun-Ting Lin dd8809900a
AspNetCore/Http Instrumentation to leverage native Activity Status. (#3555) 2022-08-10 15:51:17 -04:00
Utkarsh Umesan Pillai eb42939cd5
Rename Baggage Header name to baggage (#2003)
* Rename Baggage Header name to baggage

* Updated CHANGELOG.md
2021-04-20 16:42:37 -07:00
Mikel Blanchard 932c2587d2
Status Improvements (#1579)
* Send StatusCode as a string. Send error flag in Zipkin & Jaeger when StatusCode == Error.

* Missed one spot.

* Removed code setting otel.status_description to http status description.

* Unit test fixup.

* Update CHANGELOG.

* Updated http instrumentation CHANGELOG.

* Code review.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 23:39:28 -08:00
Cijo Thomas b1dcc14ee1
Fix HttpWebRequest test issue (#1460) 2020-11-04 12:05:36 -08:00
Eddy Nakamura 6e7e4b7ed4
Enable enrich for HttpWebRequest (#1407)
* Enable enrich for HttpWebRequest

* updating changelog

* renaming strings and changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-10-27 13:20:15 -07:00
Eddy Nakamura c7429d25c9
Normalizing format (#1289)
updating gitattributes

updating

updating

updating

Revert "Normalizing format"

This reverts commit b571e430a73f65605481ef0a622a372bc8a787ae.

Updating everything to utf-8

applying lf

Revert "applying lf"

This reverts commit a54947f24ba69eecc931525f2a69647040fdc28d.

updating config

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-19 09:45:29 -07:00
Eddy Nakamura c025116c3e
Replacing Tags for TagObjects and AddTag for SetTag (#1227)
* Replacing Tags for TagObjects and AddTag for SetTag

updating tests

updating tests

* removing toString from stackExchange test method

* tentative to solve redis test failure

* updating tests

* updating test

* checking for only one element

* Trying GetTagValue extension in http-in unit test projects.

* Grpc now uses GetTagValue.

* Updated new unit tests to use SetTag.

* Updated Http instrumentation for GetTagValue.

* Update Sql instrumentation to use GetTagValue.

* Updated Redis instrumentation to use GetTagValue.

* Removed references from test projects that weren't needed.

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-06 10:13:08 -07:00
Cijo Thomas f679960e03
Update diagnosticsource to rc1 (#1203)
* Step1 of updating to Rc1 of diagnostic source

* Update parent.spanid to parent.traceid as traceid will be default for root.

* add samplingatributes to activity tags

* updating to isremote=true

* updating tests

* changelogs

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2020-08-31 17:22:45 -07:00
Mikel Blanchard d11dc0a962
CorrelationContext -> Baggage (#1106)
* Baggage context part 1.

* A little cleanup.

* Return strings instead of objects. Removed default value in ctor because it generates a compiler warning about struct default constructor being used.

* Updated SDK & API projects for BaggageContext.

* Fixed broken areas, except for CorrelationContext tests.

* First round of tests and bug fixes.

* FIxed up HTTP instrumentation tests.

* Fixed up shim tests.

* More tests and improvements.

* Fixed broken test.

* Test coverage and bug fixes.

* Deterministic GetHashCode + tests.

* Added a link to the baggage api.

* Updated CHANGELOG.

* Renamed BaggageContext -> Baggage.

* CHANGELOG update.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-27 16:03:38 -07:00
Cijo Thomas 7807c810cc
Instrumentation to store context object into Activity.CustomProperty (#1128)
* Modify instrumentations to populate context object only if Activity.IsAllDataRequested is set

* AspNetCore tests

* Asp.Net tests

* httpclient tet

* httpwebrequest test

* sqlclient tests

* grpc test

* changelog

* move inside alldatarequested

* remove test which validate customproperty population in propagation only mode

* cop caught

* fix test
2020-08-21 13:10:52 -07:00
Mikel Blanchard 8bd8641e3e
Instrumentation raw objects should be sent as custom properties (#1099)
* Added raw objects available to instrumentation as Activity custom properties.

* Updated CHANGELOGs.

* Added "OTel" prefix to custom properties. Moved to constants.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-18 21:28:51 -07:00
Mikel Blanchard 0d00b8df1c
Shared test cleanup. (#1100)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-18 21:11:15 -07:00
Mikel Blanchard dcaea5bd45
Baggage + CorrelationContext improvements by Eddy & Mike (#1048)
* Support W3C Baggage spec.

* Moved baggage propagation to its own ITextFormat. Removed IsInjected.

* updating some tests

* creating nw files

* updating files

* buildable in release

* adding baggage tests

* updating tests

* updating default textformat for http instrumentation

* Removed a few null checks.

* Removed DistributedContext. Drive CorrelationContext off of Activity.Baggage.

* updating issues after merge

* updating based on sanity check

* updating baggage test

* updating tests

* reiley's comments

* move to using

* Updates for http-in and http-out. Updated CHANGELOGs.

* Adding tests.

* updating correlation context

* Added test for TraceContextFormat + BaggageFormat used together.

* Fixed broken tests.

* Code review.

* Test fixup.

* updating order

* updating tests

* updating tests, adding dispose, clearing objects

* updating changelog

* Use "Baggage" instead of "baggage" as the header name.

* Added some basic support for the Baggage limits specified in the spec.

* Fixed and improved ITextFormat log messages.

* Rename TextFormatContext -> PropagationContext.

* Updated ITextFormat implementations so they don't double-extract.

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-18 15:39:59 -07:00
Cijo Thomas 80edb939e4
HttpStatusCode as int instead of string (#998)
* HttpStatusCode to use int

* foramt

* format

* Cops arrested me
2020-08-04 09:17:03 -07:00
Eddy Nakamura 2dd8daa1e4
Splitting Instrumentation Projects (#890)
updating README

updating sql integration test

updating yml

updating dockerfile

updating readme

updating global.asax

updating version and readme

removing unused reference, adding properties folder to be similar to OT project

adding zipkin docker in comments

updating to standard2.1

removing unused usings

updating aspnet/aspnetcore methods naming

applying cijo's suggestions

updating projects to compile semantic file, updating comments

Splitting Instrumentation Projects

updating README

updating sql integration test

updating yml

updating dockerfile

updating readme

updating global.asax

updating version and readme

removing unused reference, adding properties folder to be similar to OT project

adding zipkin docker in comments

updating to standard2.1

removing unused usings

applying cijo's suggestions
2020-07-23 11:50:57 -07:00