Commit Graph

385 Commits

Author SHA1 Message Date
Paulo Janotti 8ed37a6f59
Organize StyleCop Settings and enable StyleCop on Tests (#715)
* Enable StyleCop rules for Test projects

This enables most of the StyleCop for test projects cleaning up any
errors as appropriate.

* Enable StyleCop rules for Test projects

This enables most of the StyleCop for test projects cleaning up any
errors as appropriate.

* Add line break at end of ruleset files

* Correct multi-line parameter after rebase
2020-06-10 12:12:13 -07:00
Cijo Thomas c7333e49fe
Update to newer build of diagnosticsouce (#718) 2020-06-09 12:23:59 -07:00
Reiley Yang f256db8bc8
Make the SDK compile on .NET Framework 4.5.2 (#717)
* make the SDK compile on .NET Framework 4.5.2

* add comments
2020-06-09 11:55:12 -07:00
Reiley Yang 9347d43c18
Adding Mikel as an approver (#711)
* add Mikel as an approver

* update corp info

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
2020-06-04 20:15:45 +01:00
Paulo Janotti 601ded5b6b
Treat warnings as errors for test projects (#714) 2020-06-03 18:10:37 -07:00
Paulo Janotti 296e0ff3a7
Add Probability Sampler for Activity (#702)
* Merging changes in OpenTelemetrySdk

* Renames from span to activity
2020-06-02 15:03:29 -07:00
HarnidhK 0867c66a0f
Display span information on Z page (#491)
* Classes scaffolding for zPages

Implemented Http Server to create HTML that displays span count using SimpleSpanProcessor

* incorporating review comments

- made ContentType const in zpages stats builder
- modified return statements in zpages exporter
- removed implementation folder from ZPages.csproj
- changed default uri for zpages test application
- changed data type of spanCount to long, and doing Interlocked.Increment when span starts

* fixing minor error

* Delete Exporters.csproj

Fix for https://github.com/open-telemetry/opentelemetry-dotnet/issues/480

* Delete Exporters.csproj

Fix for https://github.com/open-telemetry/opentelemetry-dotnet/issues/480

* displaying span status on zpages

* Adding Span Error Count and fixing build failure

* Adding Span Latency to zpages http server

* Adding class for storing span information

* Adding methods for calculating latency, count and error count values in last hour and last minutes

* Building HTML for zpage and adding timer for calculating metrics

* Implementation changes

- Added ZPages Span Processor
- Changed the logic for metrics calculation

* Update src/OpenTelemetry.Exporter.ZPages/Implementation/ZPagesStatsBuilder.cs

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

* Incoroporating Review Comments

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-06-01 23:15:41 -07:00
Alexey Zimarev 4ed65d3ddd
Small refactoring of the Prometheus exporter (#707)
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-06-01 17:47:40 -07:00
Mikel Blanchard 96e1eb9f30
HttpWebRequest ActivitySource (#694)
* Updated HttpWebRequestDiagnosticSource to use the new .NET 5 ActivitySource API.

* Code review part 1 and string allocation reduction.

* Code review part 2 added ExceptionInitializingInstrumentation event.

* Code review feedback 3.

* Code review feedback 4.

* Updated unit tests and some code review feedback.

* Updated to JaegerActivityExporter since it was just merged.

* Refactored http tag value caching so that it can be shared in dependencies project.

* Code review.

* Noticed a couple comments needed to be updated.

* Added Activity.IsAllDataRequested logic.

* Code review.

* Reverted change to OpenTelemetrySdk.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-06-01 17:28:30 -07:00
Kirill Taran dcedf02ec5
Typo fix (#710) 2020-05-31 21:48:09 +01:00
Yiwen Wang ace469d42b
Add test for MeterFactory (#691)
* Add test for MeterFactory

* Try remove file header diff

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-05-29 20:39:56 +01:00
Paulo Janotti 021736f7e9
Remove SpanID from sampling parameters (#706) 2020-05-29 20:14:11 +01:00
Paulo Janotti acaec5d9ab
Fix localization issue for Probabilistic Sampler description (#700) 2020-05-26 17:51:47 +01:00
Illia Maier 4aefc62df8
Catch exceptions in flush timer and write to EventSource (#696)
* Catch exceptions in flush timer and write to EventSource

* Fix naming

* Revert OpenTelemetryApiEventSource naming fix

* Remove whitespace changes

* Add missing header

* Change error handling

* Fix
2020-05-25 07:00:23 +01:00
Paulo Janotti cab77a9bef
Add a Jaeger Activity Exporter (#693)
* Add a Jaeger Activity Exporter

* Fix a comment and code doc

* Fix code doc
2020-05-23 06:10:36 -07:00
Cijo Thomas 577ae6cce3
Added sampler to Activity - v1 (#683)
* Added sampler to Activity
2020-05-20 22:47:07 -07:00
Yiwen Wang 5ed0e452d1
Make sure default meter will also be collected (#689)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-05-20 22:18:44 -07:00
Reiley Yang 9125da5626
Adding Cijo as a maintainer (#685)
* add Cijo as the maintainer

* manually resolve merge conflict

* remove extra empty line introduced by auto merge
2020-05-20 21:56:02 -07:00
Cijo Thomas 4032287120
Move test from Impl to Implementation folder (#688) 2020-05-20 20:55:39 +01:00
Reiley Yang 326f11bff0
Adding Paulo as an approver (#686)
* add Paulo as the approver

* update CODEOWNERS

* fix nit

* Add OTLP for Activity Exporter  (#679)

* Add OTLP Exporter for Activity

* Initial PR feedback

* Check ID format and use DisplayName

* Skip the activity instances that could not be translated

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>

* Rename Adapter to Instrumentation per latest spec (#681)

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
2020-05-20 12:40:33 -07:00
Paulo Janotti 32f0151fae
Rename Adapter to Instrumentation per latest spec (#681)
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
2020-05-19 21:55:24 +01:00
Paulo Janotti 0c01cc77a6
Add OTLP for Activity Exporter (#679)
* Add OTLP Exporter for Activity

* Initial PR feedback

* Check ID format and use DisplayName

* Skip the activity instances that could not be translated

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-05-19 21:34:58 +01:00
Paulo Janotti 1b1902e356
Disable Code Coverage from `dotnet test` on Windows (#682)
* Disable code coverage on Windows

* Update CONTRIBUTING.md
2020-05-18 17:21:42 -07:00
Sergey Kanzhelev 4334115f58
suggest Reiley as a triager (#677) 2020-05-15 07:30:24 +01:00
Sergey Kanzhelev 0083907600
added two files lost in #648 (#678) 2020-05-14 16:17:52 -07:00
Sergey Kanzhelev 5251c461f5
Sergey moved to Google (#676) 2020-05-14 14:34:26 -07:00
Cijo Thomas 44b3a438d7
Step 1 - Use new Activity to Replace OT Span (#660) 2020-05-13 20:21:28 +01:00
Cijo Thomas 92963a384d
Update to DiagnosticSource 5.0 preview4 (#667)
* Step 0 - Update to DiagnosticSource 5.0 preview5 from non nuget.org feed.

* use preview 4 as that contains the change we are after
2020-05-07 15:55:31 -07:00
Cijo Thomas 30f841b2ef
Remove year from Copyright header (#671)
* Remove year from Copyright header

* some projects were unloaded and hence change didnt apply. this commit fixed it
2020-05-07 11:53:43 -07:00
Paulo Janotti d31d485067
Fix code coverage (#666)
* Fix code coverage

Update tools and fix command.

* Disable code coverage on AzurePipelines
2020-05-06 17:11:38 -07:00
Mike Goldsmith e11de97b25
Remove stackdriver exporter (#665) 2020-05-06 21:18:44 +01:00
Mike Goldsmith c731b7b38a
remove lightstep exporter (#663) 2020-05-06 12:34:38 -07:00
Mikel Blanchard 4729e8c154
Fixed up some inconsistency in the meta showing up in package managers. (#659)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-05-04 14:22:32 -07:00
Reiley Yang 011b21054f
Remove application insights exporter (#658)
* remove application insights exporter

* switch example to use zipkin

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-05-04 13:49:49 -07:00
Reiley Yang ecb6928bb2
Clean up Contributing.md (#655)
* clean up contributing doc

* fixed a missing period

* clarify tags

* minor tweak

* address comments

* Update CONTRIBUTING.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

* Update CONTRIBUTING.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-05-04 13:42:15 -07:00
Mikel Blanchard f4e18d5141
Tweaked the PR template so it uses github "fixes" keyword by default. (#657)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-05-02 12:43:26 -07:00
Mikel Blanchard e3b684f055
Removed TargetsForTfmSpecificBuildOutput from Jaeger project, it is no longer needed. (#656) 2020-05-02 12:31:22 -07:00
Paulo Janotti efef61278b
[Tiny] Fix 'dotnet test OpenTelemetry.sln' out of Windows (#654)
* Fix 'dotnet test OpenTelemetry.sln' out of Windows

The test requires VS to run but even with mono it fails at run time since it references types that only exist on Windows .NET Framework.

The workaround is to not include the test runner outside of Windows, this shows a warning when the command is run outside of Windows.

* Remove extra white space

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-30 21:46:40 -07:00
Paulo Janotti dacae6d50f
Update OpenTelemetry Protocol Exporter (#643)
* Update OpenTelemetry Protocol Exporter

Update the OTLP to version 0.3.0 of the proto files.

* Revert change to library resources

* Rename UseOpenTelemetryProtocol to UseOtlpExporter

* Rename UseOtlpExporter to UseOpenTelemetryProtocolExporter
2020-04-30 15:27:17 -07:00
Reiley Yang 2816263dd7
Clean up README.md (#648)
* clean up README.md

* fix typo

* Update README.md

Co-Authored-By: Paulo Janotti <pjanotti@splunk.com>

* remove dev specific instruction

* add exporter specific docs

* add a separate doc on custom exporters/samplers

* clean up

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
2020-04-30 13:40:01 -07:00
Cijo Thomas 3b506f8cd9
Modify Metric record to not use generic. (#640)
* Modify Metric to not have generic. Instead create separate classes for long and double

* refactor exporter to extract common code into method

* minor

* Fix prometheus serialization
2020-04-28 17:16:56 -07:00
John Du Hart 32829d4043
HTTP adapters: Correct span names to match convention (#633)
* HTTP adapters: correct span names per conventions

* Move HTTP span prefix to a constant class

* Copyright header

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-04-27 16:52:09 -07:00
Cijo Thomas 833bde4421
Modify Metric record to better represent Metric and its timeseries. (#635)
* Modify Metric to better match record with description and list of metricdata.

* Add or Modify tests

* remove generic

* Revert "remove generic"

This reverts commit 4799c01224.
2020-04-27 16:40:01 -07:00
Cijo Thomas f333287509
Add ProxyMeter to MeterFactoryBase which invokes real Meter if provided. (#631)
* Add ProxyMeter to MeterFactoryBase which invokes real Meter if provided.

* remove unwanted copy of a test file.

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-27 16:26:10 -07:00
Cijo Thomas e56ee5d46b
SpanCreationOptions.Attributes changed to IEnumerable from IDictionary (#626)
* Remove non-working example from readme

* revert unintended changes

* SpanCreationOptions.Attributes changed to IEnumerable
Fix 588

* try tareks suggestion

* Fix builds

* revert unwanted changes

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-27 16:04:31 -07:00
Mikel Blanchard 78324b98df
Moved TestServer to OpenTelemetry.Tests and renamed TestHttpServer. Linked into Benchmarks, ZipkinTraceExporterTests, & OpenTelemetry.Adapter.Dependencies.Tests. (#634)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-27 15:36:41 -07:00
Sergey Kanzhelev 8c36d6b3c9
propose to add Cijo as an approver (#636) 2020-04-27 14:18:47 -07:00
Long Mai 09f008b037
refactor: rename to OpenTelemetry.Extensions.Hosting from OpenTelemetry.Hosting (#623)
* refactor: sln, csproj, and dir to Extensions.Hosting from Hosting

* refactor: ref Microsoft.Extensions.Hosting.Abstractions instead of concrete

* refactor: ns to Extensions.Hosting from Hosting

* docs: OpenTelemetry.Extensions.Hosting rename from OpenTelemetry.Hosting

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-27 14:08:39 -07:00
Cijo Thomas 85d92f3896
Ad gh items. (#629) 2020-04-27 12:24:40 -07:00
Cijo Thomas 93fa3f9ff5
Small improvements to readme and comments. (#628)
* Additional comments, minor changes.

* improve readme

* Update src/OpenTelemetry/Trace/Export/BatchingSpanProcessor.cs

Co-Authored-By: Bruno Garcia <bruno@brunogarcia.com>

* Update src/OpenTelemetry/Trace/Export/BatchingSpanProcessor.cs

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
2020-04-23 14:17:50 -07:00