Commit Graph

13 Commits

Author SHA1 Message Date
Paulo Janotti 8ed37a6f59
Organize StyleCop Settings and enable StyleCop on Tests (#715)
* Enable StyleCop rules for Test projects

This enables most of the StyleCop for test projects cleaning up any
errors as appropriate.

* Enable StyleCop rules for Test projects

This enables most of the StyleCop for test projects cleaning up any
errors as appropriate.

* Add line break at end of ruleset files

* Correct multi-line parameter after rebase
2020-06-10 12:12:13 -07:00
Cijo Thomas 30f841b2ef
Remove year from Copyright header (#671)
* Remove year from Copyright header

* some projects were unloaded and hence change didnt apply. this commit fixed it
2020-05-07 11:53:43 -07:00
Mikel Blanchard 0c92b3e054
OpenTelemetry.Collector.Dependencies: HttpHandlerDiagnosticListener error description lost (#487)
* Fixed HttpHandlerDiagnosticListener so it doesn't clear status description after it sets it. Updated JaegerExporter to send ot.status_code & ot.status_description.

* Code review.

* Code review.
2020-02-17 11:22:03 -08:00
Liudmila Molkova 633dda37bd
Convert ISpan to abstract class and rename to TelemetrySpan (#464) 2020-01-27 15:28:55 -08:00
Liudmila Molkova 5ead3908ba
Make ITracer an abstract class and rename to tracer (#402) 2019-12-18 12:22:42 -08:00
Liudmila Molkova 5090cf777b
Add convenience methods to start active span (#305)
* first

* Add friendly API to start active spans

* update readme and add test

* rename benchmarks

* Remove StartActiveRootSpan - this is rare case

* Move active spans creation to extensions, WithSpan has flag to control lifetime

* tests pass

* cleanup

* a few more tests

* test

* docs

* I hate stylecop

* fix broken test

* Dispose spans on end (when span lifetime is the same as scope lifetime)
2019-10-25 07:11:09 -10:00
Liudmila Molkova bf0e3df820
Move advanced span creation options to new class to simply API (#304)
* Move advanced span creation options to new class to simply API

* docs

* fix tests
2019-10-23 11:23:55 -07:00
Bruno Garcia 0610a5b530 Span creation takes Func<IEnumerable<Links>> to optimize on NoOp (#282)
* wip

* ref: Take func for Links

* ref: Avoid allocation when no links

* ref: Allocate only if necessary

* fix some unit tests

* ref: Overload taking IEnumerable

* fix: overload

* ref: use overload with enumerator

* ref; use enumerator overload

* fix: Cast double to long to match expected

* ref: Use .Any()

* ref: Pass null thru for IEnumerable

* test: SpanTest

* ref: Align params

* ref: Use List<Link> in Span

* ref: Got cough being lazy

* fix: Ludimila fixes my shitty code

* ref: including max value

Co-Authored-By: Liudmila Molkova <lmolkova@microsoft.com>

* ref: remove redundant list allocation
2019-10-21 19:17:30 -07:00
Bruno Garcia d48e702286 ref: Move using outside namespace (#277) 2019-10-12 10:03:45 -07:00
Liudmila Molkova afb1381bbd
Remove span builder (#268)
* Remove SpanBuilder

* tests

* more tests and readme

* review feedback
2019-10-11 15:47:19 -07:00
Peter Wiese 84cdde8d5c Support explicit timestamps for OpenTracing ISpanBuilder and ISpan operations (#256) 2019-10-02 13:20:37 -07:00
Liudmila Molkova 754c80a702 Remove ILink interface (#245) 2019-10-01 11:04:58 -04:00
Peter Wiese 541390ffb1 Initial implementation of the OpenTracing bridge. (#197)
This is, where possible, a direct port of the current Java shim. There are some holes/TODOS. Notably:

-Missing the Binary injection/extraction of the span context. This doesn't exist with the current implementation of OpenTracing yet.
-Missing explicit timestamps for calls to OpenTracing ISpan::Log.
-Missing explicit timestamps for calls to OpenTracing ISpan::Finish
-Various calls to set/get baggage are not implemented. Requires OpenTelemetry DistributedContext to be finalized.

Other oddities worth nothing:

-The SpanBuilderShim has some conditional code for calling OpenTel SetCreateChild(true|false)
-The ScopeManagerShim is actively tracking scopes returned by calls to OpenTel WithSpan and associated those with the OpenTel ISpan used when calling WithSpan.

I tested this shim against an ASP.NET Core 3 Preview 8 service wired up with OpenTracing netcore and grpc collectors and exporting to Jaeger backend.

The included tests are unit tests only; no E2E tests.
2019-09-06 15:41:32 -07:00