Commit Graph

18 Commits

Author SHA1 Message Date
Eddy Nakamura a3bf19d450
Removing Todos (#1029)
* Removing Todos

renaming parameter

adding tests

updating spanbuilderShim

updating to internal

renaming to spanAttributes

solving build issue

adding spec reference

Continue Refactoring TracerProvider. (#1035)

* optimize the flow

* fix instrumenataion

* move mroe things to provider ctor

* move logic arounds

Co-authored-by: Reiley Yang <reyang@microsoft.com>

changing to class and following spec to replace value

replacing from default to null

updating package

adding xunit.runner

renaming method

* removing duplicated files

* adding some tests and updating to default constructor

* removing to be compliant to spec

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-11 07:50:53 -07:00
Reiley Yang bde64f2b6a
use absolute path for project includes (#993)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 07:23:47 -07:00
Reiley Yang 2e4b081f6d
Consolidate package version (#971)
* consolidate package version for src folder

* fix CI

* clean up

* clean up test package version

* clean up

* fix nits

* clean up using
2020-08-02 06:20:44 -07:00
Eddy Nakamura 21d18e1662
Testing EventSource (#944)
Validating EventSource

adding more tests, updating wrong namespace

updating spaces

merging invariantString to prevent duplication

removing extra space

merging exception extensions

Adding comments

updating project and tests

updating eventsourcetest

breaking tests

Revert "breaking tests"

This reverts commit 7c23b46316c9dc84d5b66c1e0498498a4b0b3ac7.
2020-07-30 06:38:41 -07:00
Eddy Nakamura 5b34e3b3f8
Adding metapackages (#810)
Adding IsPackable to test.props, updating test nuget versions

updating projects, adding options parameter

Applying suggestions

Apply suggestions from code review

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

code review - cijo

removing aspnetcore "metapackage"

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-15 23:31:57 -07:00
Eddy Nakamura 0973b3ea0a
Enable netcoreapp2.1 (#780)
updating yml

Revert "updating yml"

This reverts commit 391f3baadbca0de4b3e2d78b35db38eb7e7bddbc.

installing dotnet 2.1 and 3.1

updating yml to enable multiple dotnet versions

adding matrix condition

disable dotnet 2.1 for windows

removing unused package reference

Revert "removing unused package reference"

This reverts commit 0d898aa044f916743da613a83539f568bff3ad49.

updating yml

adding cov.yml to sln

Add resources to instrumentation (#779)

* Add resources to instrumentation

* Unit test activitysourcedapter

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

disabling ubuntu-latest to codecoverage

removing extra steps

adding codecov.yml

moving file

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-08 11:42:51 -07:00
Eddy Nakamura 232e82eb02
github actions (#752)
moving folder

updating test to Tests.dll and folder to get less files

updating folder again

adding other versions to test

Adding linux and renaming

updating ubuntu version

updating yml linux

adding variables and using matrix

adding strategy to matrix

updating variables

new test

updating variables

updating variables

updating test packages

trying to add cache option

testing cache on windows

removing cache folder and trying to optmize files

updating

adding more workflows to test parallel

updating windows one job pipeline

updating

renaming

updating

updating test

adding verbose and breaking one test to double check

reverting test, adding new line, removing verbose from parallel

Update dotnet-core.yml

Update dotnet-core.yml

updating fetch depth

fetching all

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-01 13:04:22 -07:00
Alexey Yakovlev 2953cd1025
Added .NET 4.6 target to the Jaeger exporter (#748)
* Added .NET 4.6 target.

* Added net46 target.

* Update test/OpenTelemetry.Exporter.Jaeger.Tests/OpenTelemetry.Exporter.Jaeger.Tests.csproj

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
2020-06-27 07:21:27 -07:00
Paulo Janotti d31d485067
Fix code coverage (#666)
* Fix code coverage

Update tools and fix command.

* Disable code coverage on AzurePipelines
2020-05-06 17:11:38 -07:00
Mikel Blanchard 94c412ef35
Switched back to a local fork of ApacheThrift in JaegerExporter. (#627)
* Switched back to a local fork of Thrift to fix issues introduced consuming the official package.

* Code review.
2020-04-23 00:43:55 -07:00
Eddy Nakamura 31c7c65a45
Removing ruleset from projects (#615)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-20 17:22:43 -07:00
Eddy Nakamura df264b5852
Adding test.ruleset to test projects (#611)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-04-20 15:41:30 -07:00
Mikel Blanchard d5b4248261
JaegerExporter: Performance Improvements (#494)
* Initial work.

* First complete version of Jaeger with perf improvements.

* Added JaegerExporter benchmarks.

* More performance revisions.

* ValueTask perf improvements.

* Missed a couple tasks.

* Removed null check against struct.

* Tweaked how structs are used.

* Figured out why the structs were eating more memory. Fixed up unit tests.

* Reverted change to ToJaegerSpan extension signature.

* Fixed JaegerUdpBatcher not calling CloseAsync in dispose, fixed SpanExporters not being disposed.

* Reference System.Threading.Tasks.Extensions for net46 & netstandard2.0 builds of Thirft to add in ValueTask.

* Removed the fork of Thrift in favor of the official package.

* Increased number of spans per iteration in jaeger benchmarks. Switched ApacheThrift to PrivateAssets=all in jaeger exporter project.

* New algorithm for memory management.

* Fixed double-allocation of tags.

* Immutable structs. Added cancellationToken to IJaegerClient interface.

* Added lists that can be backed be pooled buffers.

* Everything in implementation folder is now internal.

* Return ref from PooledList indexer.

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-02-26 14:49:39 -08:00
Liudmila Molkova 40a51b69bc
Move test infra to .NET Core 3.0 (#403)
* Add W3C TraceContext validation test app

* fix linux build

* some fixes

* Use ASP.NET Core test app as W3C test suite example

* broken solution

* remove new project

* move tests to 3.0

* update minver

* fix http tests to force 2.0

* minver is in common props, remove from projects

* move lightstep tests to 3.1
2019-12-19 13:46:57 -08:00
Sergey Kanzhelev 605760cf5a
Rename Abstractions to Api (#317)
* Rename Abstractions to Api

* fixed Api casing
2019-10-28 16:17:08 -07:00
Peter Wiese ea2a24492c Don't reference Thrift as NuGet package from the Jaeger exporter. (#193)
* Don't reference Thrift as NuGet package from the Jaeger exporter.

Include Thrift.dll in the lib directory of the export package.

See https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#project-to-project-references for a description of these MSBuild items.

Here is the generated .nuspec file for the Jaeger exporter now.

```xml

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>OpenTelemetry.Exporter.Jaeger</id>
    <version>0.2.0-alpha.16</version>
    <authors>OpenTelemetry authors</authors>
    <owners>OpenTelemetry authors</owners>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <license type="expression">Apache-2.0</license>
    <licenseUrl>https://licenses.nuget.org/Apache-2.0</licenseUrl>
    <projectUrl>https://opentelemetry.io/</projectUrl>
    <iconUrl>https://opentelemetry.io/img/logos/opentelemetry-icon-color.png</iconUrl>
    <description>Package Description</description>
    <tags>Tracing OpenTelemetry Management Monitoring Jaeger distributed-tracing</tags>
    <repository type="git" url="https://github.com/pcwiese/opentelemetry-dotnet.git" commit="5c5f2fc191c8a5b1a5b419bbe2b530fee1a567f4" />
    <dependencies>
      <group targetFramework=".NETFramework4.6">
        <dependency id="OpenTelemetry.Abstractions" version="0.2.0-alpha.16" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.0">
        <dependency id="OpenTelemetry.Abstractions" version="0.2.0-alpha.16" exclude="Build,Analyzers" />
      </group>
    </dependencies>
  </metadata>
  <files>
    <file src="bin\Debug\net46\Thrift.dll" target="lib\net46\Thrift.dll" />
    <file src="Z:\src\opentelemetry-dotnet\src\OpenTelemetry.Exporter.Jaeger\bin\Debug\net46\OpenTelemetry.Exporter.Jaeger.dll" target="lib\net46\OpenTelemetry.Exporter.Jaeger.dll" />
    <file src="Z:\src\opentelemetry-dotnet\src\OpenTelemetry.Exporter.Jaeger\bin\Debug\net46\OpenTelemetry.Exporter.Jaeger.xml" target="lib\net46\OpenTelemetry.Exporter.Jaeger.xml" />
    <file src="bin\Debug\netstandard2.0\Thrift.dll" target="lib\netstandard2.0\Thrift.dll" />
    <file src="Z:\src\opentelemetry-dotnet\src\OpenTelemetry.Exporter.Jaeger\bin\Debug\netstandard2.0\OpenTelemetry.Exporter.Jaeger.dll" target="lib\netstandard2.0\OpenTelemetry.Exporter.Jaeger.dll" />
    <file src="Z:\src\opentelemetry-dotnet\src\OpenTelemetry.Exporter.Jaeger\bin\Debug\netstandard2.0\OpenTelemetry.Exporter.Jaeger.xml" target="lib\netstandard2.0\OpenTelemetry.Exporter.Jaeger.xml" />
  </files>
</package>

```

* Reference Thrift directly from the Jaeger exporter test project
2019-08-26 10:25:42 -07:00
Bruno Garcia d1e66e1e0b Build all targets in all platforms. (#155)
* build all targets in all platforms
Resolves #154

* Tests for netfx run only on Windows

* AppInsights can build x-plat

* fix: TFMs for Jaeger
2019-07-24 10:46:09 -07:00
PS-EGHornbostel 8e1d8fa47e Jaeger exporter implementation (#132)
* Fix visual studio dotnet core build task

* Added CNCF Jaeger exporter support

https://github.com/open-telemetry/opentelemetry-dotnet/issues/77

* possible fix for win32 build issue.

* Fix windows build by adding Thrift source

* Fix yet more windows build issues.

* fix another style issue.

* fix reference to System.Net.Http

* remove unnecessary conditional framework reference.

* Update lib/Thrift/Transports/Client/TStreamClientTransport.cs

Co-Authored-By: Bruno Garcia <github@brunogarcia.com>

* Update lib/Thrift/Transports/Client/TStreamClientTransport.cs

Co-Authored-By: Bruno Garcia <github@brunogarcia.com>

* Added the conditional for netstandard2.0

* remove IDisposable TODO comments.

* Update src/OpenTelemetry.Exporter.Jaeger/Implimentation/EmitBatchArgs.cs

Co-Authored-By: Bruno Garcia <github@brunogarcia.com>

* Add readme with thrift fork info.

* cleanup after merge.

* WIP remove thrift code

* Use prepackaged Apache Thrift assembly

* wrap EmitBatch

* Revert "wrap EmitBatch "

This reverts commit 9aaa1388ba.

* Revert "Use prepackaged Apache Thrift assembly"

This reverts commit fa5fbd8e6c.

* Revert "Use prepackaged Apache Thrift assembly"

This reverts commit fa5fbd8e6c.

* Revert "WIP remove thrift code"

This reverts commit bbbcf470e8.

* Add missing ConfigureAwait(false) to Thrift async calls.

* Added Thrift fork differences to README.md

* WIP Jaeger Unit tests

* Fix build after merge.

* WIP Jaeger Unit tests - Span conversion to Jaeger Thrift format

* WIP Jaeger Unit tests - Span conversion to Jaeger Thrift format - cleanup

* Clean up merge issues

* WIP

* WIP cleanup

* more testing WIP

* use pattern matching for attribute conversion

* WIP cleanup after timestamp removal.

* WIP

* WIP UDP integration test

* Update src/OpenTelemetry.Exporter.Jaeger/Implimentation/Batch.cs

Co-Authored-By: Bruno Garcia <github@brunogarcia.com>

* remove solution-explorer

* add to gitignore

* refactored List<T> to IEnumerable<T>

* Fix unit test bug

* Add integration test

* cleanup

* fix unix epoch conversion

* Update Thrift expected payload in unit test.

* fix build issues

* fix typo

* fix solution
2019-07-23 19:47:52 -07:00