Commit Graph

611 Commits

Author SHA1 Message Date
Eddy Nakamura a3bf19d450
Removing Todos (#1029)
* Removing Todos

renaming parameter

adding tests

updating spanbuilderShim

updating to internal

renaming to spanAttributes

solving build issue

adding spec reference

Continue Refactoring TracerProvider. (#1035)

* optimize the flow

* fix instrumenataion

* move mroe things to provider ctor

* move logic arounds

Co-authored-by: Reiley Yang <reyang@microsoft.com>

changing to class and following spec to replace value

replacing from default to null

updating package

adding xunit.runner

renaming method

* removing duplicated files

* adding some tests and updating to default constructor

* removing to be compliant to spec

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-11 07:50:53 -07:00
Reiley Yang f44952a610
clean up TracerProviderSdk (#1045)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-11 06:29:59 -07:00
Cijo Thomas 7a57b84b90
Change benchmark to depend on opentelemetry project only (#1044) 2020-08-11 04:18:41 -07:00
Reiley Yang fb5eec094d
mini bencmark (#1039)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-10 22:49:32 -07:00
Reiley Yang fbf0d8459a
update SDK changelog (#1040)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-10 22:32:34 -07:00
Reiley Yang 852c06f68c
remove unused files (#1041) 2020-08-10 22:30:52 -07:00
Reiley Yang 52a37b94dc
Update changelog format (#1038)
* clean up API changelog

* use consistent wording
2020-08-10 20:24:59 -07:00
Reiley Yang ce0bf3f723
rename AddActivitySource to AddSource, use params (#1036) 2020-08-10 18:02:50 -07:00
Cijo Thomas 8af9b326c6
Continue Refactoring TracerProvider. (#1035)
* optimize the flow

* fix instrumenataion

* move mroe things to provider ctor

* move logic arounds

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2020-08-10 15:18:19 -07:00
Cijo Thomas 6e53eb2056
MicroService example to depend on project reference. (#1031) 2020-08-10 10:36:25 -07:00
Alan West bd738f0447
End-to-end example applications (#936)
* Suite of example applications demonstrating context propagation with RabbitMQ

* Put System.* namespaces first

* Newline at EOF

* Fix markdownlint errors

* markdownlint fix

* Refactor WorkerService separating OpenTelemetry related logic from RabbitMQ boilerplate

* Refactor WebApi separating OpenTelemetry related logic from RabbitMQ boilerplate

* Use environment variables for RabbitMQ user/pass

* Add some comments

* Fix RabbitMQ default user/pass

* Use correct ActivityKind

* Add attributes following messaging specification

* Clearing a path through the RabbitMQ jungle

* Log something when sending/receiving a message

* Code style clean up

* Default logging to info level

* Create queue if it does not exist

* Rename controller to SendMessageController

* Refine the readme

* MarkdownCop

* Fix merge snafu

* Add null checks on activity

* Add a missed null check

* Use AddOpenTelemetry in ConfigureServices

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-09 23:59:10 -07:00
Cijo Thomas 47a6fe7621
Refactor TracerProvider to make configuration easy. (#1027)
* Refactor TracerProvider to make configuration easy.

* build break fix

* MyExporter change

* format

* sql build fix

* fix

* test fix
2020-08-09 00:48:00 -07:00
Reiley Yang 5f2e8d0cd9
Rename noop (#1025)
* s/NoOp/Noop/g

* workaround

* rename NoOp files to Noop
2020-08-07 14:25:59 -07:00
Reiley Yang e43356abd7
Fix double shutdown (#1017)
* fix double shutdown

* add consistency

* nit
2020-08-07 10:36:27 -07:00
Cijo Thomas 1b01f3c98e
Add doc to sln (#1022) 2020-08-07 09:46:02 -07:00
Cijo Thomas 9566c055be
Use DisplayName instead of OperationName in ZipkinExporter (#1020) 2020-08-07 08:33:34 -07:00
Reiley Yang c4484a7ace
Initial ideal how to refactor provider (#1008)
* initial ideal how to refactor provider

* dumping more ideas

* more improvements

* update example

* improve perf when no sampler is specified

* put more examples

* composite processor

* update the tutorial

* more check

* nit

* update tutorial
2020-08-06 15:35:33 -07:00
Mikel Blanchard 73bff75ef6
Default Sampler update + ParentOrElse fix (#1013)
* Updated default sampler to match the spec. Fixed broken ParentOrElseSampler.

* Fixed http-in instrumentation creating Activity objects with invalid parents.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-05 15:35:11 -07:00
Eddy Nakamura 1758e32222
Renaming BroadcastActivity (#1015)
* Renaming BroadcastActivity

* updating issue number

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-05 15:08:30 -07:00
Reiley Yang b3710a4079
fix console output format (#1014) 2020-08-05 14:57:54 -07:00
Eddy Nakamura c10c39fa75
Updating Exporters to understand the array of primitives (#1012)
* Updating Exporters to understand the array of primitives

code review - 1

updating tests

* updating tests

* code review - 2

* code review - 3
2020-08-05 12:39:13 -07:00
Eddy Nakamura 1c15164b14
Updating CodeCoverage and deterministic build (#1010)
* Testing CodeCoverage

solving build issue

updating file to debug

updating function

updating script

updating filters

removing upload

removing unused tag

* updating order

* adding blank line

* Update .github/workflows/dotnet-core-cov.yml

Co-authored-by: Reiley Yang <reyang@microsoft.com>

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-05 10:33:40 -07:00
Eddy Nakamura e79c3eee97
Enable FxCop - part 02 (#1009)
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-05 09:39:47 -07:00
Alan West 8077bab538
Update changelog with more details for gRPC support (#1011)
* Update changelog

* Move 'are's around and remove an 'is'

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-05 08:17:23 -07:00
Cijo Thomas d0e84840cd
Leverage ActivityListener.AutoGenerateRootContextTraceId (#1007)
* Leverage ActivityListener.AutoGenerateRootContextTraceId

* test

* More test

* changelog

* remove duplicated test logic

* markdown fix

* space
2020-08-05 07:59:05 -07:00
Rajkumar Rangaraj 7030026c88
StartSpan should not generate active span by default (#994)
* Modified StartSpan, added RootSpan

* Update changelog

* Fix changelog

* Added test

* Resolve conflict

* Update changelog

* update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 23:03:30 -07:00
Reiley Yang 67607b79f4
demonstrate SuppressInstrumentation in exporter tutorial (#1006) 2020-08-04 22:41:09 -07:00
Reiley Yang 46bb3f1ec7
Minor improvement on ActivityProcessor (#1005)
* minor improvement on ActivityProcessor

* fix typo
2020-08-04 22:17:56 -07:00
Alan West 099c3c76a0
Make SuppressInstrumentation an IDisposable (#988)
* Make SuppressInstrumentation an IDisposable

* Simplify SuppressInstrumentation

* Rename to SuppressInstrumentationScope

* Clean up comment

* Implicit operator instead of IsSuppressed property

* Make SuppressInstrumentationScope constructor internal

* Clean up some names

* Update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
2020-08-04 22:04:03 -07:00
Reiley Yang fd0cc21b39
Update the custom processor project (#996)
* update the processor project

* simply code

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 21:20:43 -07:00
Reiley Yang 79acec1bc6
Add custom exporter project (#1004)
* Add custom exporter project'

* manually resolve merge conflict

* update codecov ignore list
2020-08-04 21:03:43 -07:00
Alan West 362c1fe8b9
Add gRPC attributes for ASP.NET Core (#803)
* Change gRPC test project name and namespace

* Use SpanAttributeConstants in GrpcClientTests

* Add test for Grpc.AspNetCore instrumentation

* Add gRPC attributes for ASP.NET Core

* Prevent parallel execution of gRPC client and server test suites

* Add wait logic from AspNetCore tests ensuring end callback gets invoked

* Partial class for gRPC test to resolve test conflicts

Co-authored-by: Michael Goin <michaelgoin@gmail.com>

* Make "grpc" a const

* Set http.status_code attribute even on a gRPC invocation

* Fix GrpcFixture

* Add checks for http.* attributes to ASP.NET Core gRPC test

* Fix merge snafu

* Update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Michael Goin <michaelgoin@gmail.com>
2020-08-04 20:21:17 -07:00
Eddy Nakamura c3500d2ff1
Enable FxCop - part 01 (#997)
* Enable FxCop

* removing useless toString()

* Enable FxCop - 1

* updating order

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 20:04:28 -07:00
Reiley Yang 0bcf363e0d
Add custom sampler project (#1001)
* add custom sampler project

* add comment
2020-08-04 19:58:13 -07:00
Eddy Nakamura 8948470937
Creating CompositePropagator (#923)
* Creating CompositePropagator

Adding ActivityContext to interface

Adding tests

Updating CompositePropagator + tests

updating comments

Improving performance when size is 0

updating tests

updating default tracestate for empty

MikeGoldsmith review

adding more tests to exemplify usage

Feature/composite propagator refactor (#1)

* Added TestPropagator and switched a couple tests to use it.

* removing extra classes

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>

updating changelog and constructor

MikeGoldsmith comments

updating logic

* checking value

* adding inverted test

* updating tests

* removing tracecontext and b3 tests

* testing only aspnet to merge

* Revert "testing only aspnet to merge"

This reverts commit 43ca7d074b.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 17:26:56 -07:00
Eddy Nakamura 53a579f507
Updating exporters to use TagObjects instead of Tags (#1000)
* Update ZipkinExporter to use TagObjects instead of Tags

* Updating JaegerExporter to use TagObjects

* Updating OtlpExporter to use TagObjects

* removing unused using

* Removing duplicated logic

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 17:10:29 -07:00
Reiley Yang 4f8c351420
minor clean up (#1002)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 14:51:59 -07:00
Eddy Nakamura 5cdfd30284
Updating ActivityProcessor (#975)
* Updating ActivityProcessor

updating tests

updating tests - 2

updating merge

updating tests - 3

updating tests - 4

using inrange instead of equal

updating tests

* updating to inRange

* following docs.microsoft

* updating tests and changelog

* Adding in changelog custom behavior

* Removing duplicated IDisposable

* forcing dispose

* updating tests

* moving to single instead of equal one

* returning to default

* setting more time to pass tests

* forcing dispose

* reiley's suggestions

* reverting order

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 14:40:30 -07:00
Eddy Nakamura da8cd0d5c8
Adding array of primitives to TelemetrySpan (#999)
* Adding array of primitives to TelemetrySpan

* updating tests

* removing baggage methods
2020-08-04 13:57:48 -07:00
Cijo Thomas 80edb939e4
HttpStatusCode as int instead of string (#998)
* HttpStatusCode to use int

* foramt

* format

* Cops arrested me
2020-08-04 09:17:03 -07:00
Reiley Yang bde64f2b6a
use absolute path for project includes (#993)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 07:23:47 -07:00
Eddy Nakamura 8f3fa541d0
Updating todos (#991)
* Updating todos

* updating isremote from propagators and from tests

* removing isremote validation when isvalid is false
2020-08-04 07:02:03 -07:00
Mikel Blanchard 9f660cc652
Send ActivityLinks to Jaeger as JaegerSpanRefType.FOLLOWS_FROM. (#970)
* Send ActivityLinks to Jaeger as JaegerSpanRefType.FOLLOWS_FROM.

* Markdown lint.

* Update CHANGELOG.md with PR link.

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Markdown lint attempt 2.

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-03 18:05:49 -07:00
Reiley Yang ca368e9748
treat warning as warning for debug build (#990) 2020-08-03 17:31:49 -07:00
Reiley Yang 90c5b3af11
Improve docs structure (#983)
* improve docs structure

* revert line ending

* adopt .net5-preview-8

* remove unused using
2020-08-03 16:46:48 -07:00
Alan West dfe5f91d1d
Add UseExporter config option to AspNetCore example app (#976)
* Add UseExporter command line option to AspNetCore example app

* Use appsettings.json

* Remove unused using
2020-08-03 14:48:34 -07:00
Cijo Thomas d2c93610e8
Update to preview 8 of DiagnosticSource and associated changes - part1 (#954)
* Initial make build fix commit

* change Link public API to accept ActivityTagsCollection

* Add more SetAttribute overload to support int bool float and bool

* changelog

* Replace AddTag with SetTag in Activity

* disable a test for temporary progress

* reformat

* url fix

* Update Diagnosticourcepackage

* version fix

* ActivityTagsCollection

* console exporter fix

* one basic test

* minor
2020-08-03 11:25:24 -07:00
Eddy Nakamura c6d020b49f
Adding XML comments - part 01 (#955)
* enabling cs1591 for OT project

Adding some xml comments - 1

Adding some xml comments - 2

changing some references to semantic

updating returns message from aggregator

Adding more comments

Adding dispose comments

undoing some changes

commenting rule

uncomment rule

* renaming from isdisposing to disposing

* updating comments

* cijo's comments

* updating texts

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-02 09:20:41 -07:00
Eddy Nakamura b74194757f
updating workflows (#973)
* updating workflows

* updating dotnet core workflow
2020-08-02 07:40:29 -07:00
Eddy Nakamura a326550305
Minor improvements to OT (#972)
Adding copyright header to files, and other changes

adding headers

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-02 06:48:58 -07:00