Commit Graph

1446 Commits

Author SHA1 Message Date
Reiley Yang df756ee50d
Upgrade stylecop to 1.2.0-beta.354 (#2602) 2021-11-12 11:20:41 -08:00
Phillip Carter 427e50a38a
Update SpanContext summary doc (#2603)
Erroneously mentioned it was a class when it's a struct.
2021-11-12 09:31:03 -08:00
Reiley Yang 4929bfd1ac
enable C# 10 (#2599) 2021-11-11 20:27:22 -08:00
yunl 4c22707a98
Update metrics benchmarks using net6.0 (#2591) 2021-11-10 16:06:28 -08:00
Cijo Thomas 9fed161c3a
Handle instrument disposal (#2585) 2021-11-10 09:43:13 -08:00
Reiley Yang bb2b743fc8
Realloc when run out of serialization buffer (#2584) 2021-11-09 21:54:22 -08:00
Reiley Yang f0311751d5
Do not export metrics description if it is empty (#2583) 2021-11-09 19:22:45 -08:00
Cijo Thomas 9ad2cfbec9
Metric description and unit to be treated as empty string when not provided (#2580) 2021-11-09 17:41:46 -08:00
Reiley Yang 5d32724792
Bump DiagnosticSource version to 6.0.0 (#2582) 2021-11-09 17:26:43 -08:00
Vishwesh Bankwar 4f697ee6c0
update rc versions to stable (#2581) 2021-11-09 17:00:44 -08:00
Reiley Yang 27b63614e3
Add unit as metric name suffix in PrometheusExporter (#2578) 2021-11-09 16:38:16 -08:00
Reiley Yang 0ed4ed64f0
consolidate/cleanup SA1000 (#2577) 2021-11-09 14:10:01 -08:00
Reiley Yang 11654f19e2
Solve PrometheusExporter race condition (step 1) (#2553)
* prom prototype

* minor refactor

* improve mem

* skeleton of the PrometheusSerializer

* a working server

* clear up test

* specialize netframework

* clean up

* update test

* fix unit test

* minor improvement

* comment

* escape metric names

* handle inf/nan

* minor name change

* nit

* more assertion

* patch for old frameworks

* add comment explaining why we use empty string if the label value is null

* Updated PrometheusExporterMiddleware for new PrometheusSerializer API.

* Added some exception handling.

* Test fix.

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2021-11-09 13:30:28 -08:00
Michael Maxwell 05990ae783
Throw on invalid histogram bounds (#2573) 2021-11-08 21:47:56 -08:00
Cijo Thomas 8029751d92
Metrics hotpath benchmark updates (#2571) 2021-11-08 09:54:43 -08:00
Michael Maxwell 7d6a22fe35
Unique test meter names (#2549) 2021-11-06 18:32:30 -07:00
Michael Maxwell c085504462
Replace use of TestExporter with InMemoryExporter (#2562) 2021-11-05 09:35:49 -07:00
Vishwesh Bankwar 4f930d5074
Enable .net6.0 build and add net6.0 target (#2559) 2021-11-04 08:33:35 -07:00
ndrwrbgs 02f2594a72
Remove unused new (found in disassembly in public nuget) (#2550)
* Remove unused new (found in disassembly in public nuget)

```
internal static void AddBatch(this ExportLogsServiceRequest request, Resource processResource, in Batch<OpenTelemetry.Logs.LogRecord> logRecordBatch)
{
	new Dictionary<string, InstrumentationLibraryLogs>();
	ResourceLogs resourceLogs = new ResourceLogs
	{
		Resource = processResource
	};```

* Remove now unused using

Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
2021-11-02 14:25:00 -07:00
Joao Grassi 1d16b0abc7
Add validation to instrument and view name (#2470) 2021-11-02 09:59:12 -07:00
Mikel Blanchard d9b2ea416e
Batch<T> public api additions to unblock users (#2542)
* Added a public ctor to Batch<T> to unblock user scenarios.

* Bug fixes and improvements.

* Unit test.

* CHANGELOG update

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-10-29 16:44:57 -07:00
Michael Maxwell ce46d001d5
Update opentelemetry-icon-color.png (#2544)
Tool used: paint.net
2021-10-28 18:17:58 -07:00
Utkarsh Umesan Pillai ac7b8d623e
Use HashSet for MetricSreamNames (#2545)
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
2021-10-28 17:52:09 -07:00
Utkarsh Umesan Pillai c2f65108e9
Rename tagKey totagKeys and tagValue to tagValues (#2546) 2021-10-28 17:37:41 -07:00
Michael Maxwell 2a221722a1
Use Guard class and Debug.Assert for recent developer changes (#2540)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-10-28 10:42:38 -07:00
Reiley Yang 87601de2da
Update exporter efficiency test to cover both delta and cumulative (#2541) 2021-10-28 10:18:12 -07:00
Michael Maxwell 9f635abe46
Losslessly compress PNG logo (#2539) 2021-10-27 18:44:45 -07:00
Reiley Yang 0c93744d4b
Add a simple memory efficient test for metrics SDK (#2530) 2021-10-27 10:31:01 -07:00
Robert Pająk d026232c15
Remove unnecessary try catch for SecurityException (#2531) 2021-10-27 07:39:13 -07:00
Reiley Yang 635028834c
Add exporter ForceFlush (#2525) 2021-10-26 20:25:12 -07:00
Robert Pająk 3aab1244f8
Consolidate environment variable parsing (#2500) 2021-10-26 14:54:02 -07:00
Reiley Yang 105c068928
improve code readability (#2516) 2021-10-26 13:00:46 -07:00
Michael Maxwell 433b7c8ad1
Guard.cs - Follow-up changes (#2501) 2021-10-26 07:57:34 -07:00
Reiley Yang b1fc7616b1
Minor improvements to the Metrics SDK (#2515)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-10-26 07:42:12 -07:00
Reiley Yang 6048a66d43
improve CompositeMetricReader.Dispose (#2514) 2021-10-26 07:30:38 -07:00
Reiley Yang 6267c24978
fix nits (#2512) 2021-10-25 16:33:37 -07:00
Reiley Yang d81ad4052f
clean up code (#2509) 2021-10-25 12:58:45 -07:00
Mikel Blanchard 884b224508
Example of how to solve collection concurrency using task completion source api. (#2506)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-10-25 09:58:53 -07:00
Reiley Yang 68a1761be6
Improve Dispose (#2508) 2021-10-25 09:46:38 -07:00
Cijo Thomas dd10802e00
Add Robert as approver (#2498) 2021-10-20 09:49:26 -07:00
Cijo Thomas 3f56b94199
Update README.md 2021-10-19 17:13:23 -07:00
Cijo Thomas a970ea661e
Add Robert as approver
@pellared  has been an active contributor to the project for few months now. He is already an approver and among top contributors to the [Auto-instrumentation](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation) efforts, which recently switched to be building on top of SDK from this repo. Robert's expertise in auto-instrumentation would be a welcome addition to this team!

Contributions include not only [PRs](https://github.com/open-telemetry/opentelemetry-dotnet/pulls?q=is%3Apr+author%3Apellared), but active engagement in reviews, responding to issues/slack conversations and SIG meetings (despite odd timings!)
2021-10-19 17:12:14 -07:00
Reiley Yang 6f3f7e5766
remove duplicated src from proj file (#2493) 2021-10-18 11:22:03 -07:00
Michael Maxwell 6e6afdbc36
Identified all exception throws in code base (#2416) 2021-10-18 10:29:54 -07:00
Reiley Yang 84bdf38fe1
Simplify code (#2491) 2021-10-18 10:12:08 -07:00
Mikel Blanchard d119447e07
Write directly to output stream in OtlpHttpTraceExportClient. (#2490) 2021-10-15 18:37:00 -07:00
Ralph Bodenner f8f201863a
Mention logs as an option for OTLP exporter (#2488)
* Mention logs as an option for OTLP exporter

Logs exporter recently landed here: https://github.com/open-telemetry/opentelemetry-dotnet/pull/1964

* Mention logs support, requiring separate package

* Relative link within repo

* Create README.md

* Fix relative path and line length

* Fix relative path

* NuGet badges

Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>

* Use a file name to fix path warning

* Prereq is implicit already w/NuGet dependency

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
2021-10-14 16:56:00 -07:00
yunl c7a27dca06
Minor improvement for the case that hashset is sufficient. (#2467) 2021-10-14 13:41:53 -07:00
Mikel Blanchard 32760fd47d
Prometheus: Benchmarks + Performance Improvements (#2471)
* Added PrometheusExporterMiddleware benchmark.

* Tweak.

* Clean up nits.

* Made the benchmarks more interesting.

* Prometheus exporter performance tweaks.

* Cleanup.

* Use the pool buffer to write to so we only call stream.WriteAsync once per line.

* Code review.

* Improved version of PrometheusMetricsFormatHelper.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-10-14 10:30:18 -07:00
Robert Pająk a3f0961b07
Update docs for batch span processor env vars (#2485) 2021-10-13 09:45:20 -07:00