Remove unnecessary getVersion overrides (#1004)
This commit is contained in:
parent
88eef8934e
commit
5bce79df36
|
@ -30,11 +30,6 @@ import javax.servlet.http.HttpServletRequest;
|
|||
public abstract class ServletHttpServerTracer<RESPONSE>
|
||||
extends HttpServerTracer<HttpServletRequest, RESPONSE, HttpServletRequest, HttpServletRequest> {
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
// TODO this violates convention
|
||||
protected URI url(HttpServletRequest httpServletRequest) throws URISyntaxException {
|
||||
|
|
|
@ -89,9 +89,4 @@ class SpringWebMvcServerTracer
|
|||
protected String getInstrumentationName() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
|
|
@ -77,11 +77,6 @@ public class AkkaHttpServerTracer
|
|||
return "io.opentelemetry.auto.akka-http-10.0";
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected Integer peerPort(HttpRequest httpRequest) {
|
||||
return null;
|
||||
|
|
|
@ -46,11 +46,6 @@ public class ArmeriaServerTracer
|
|||
return "io.opentelemetry.armeria-1.0";
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected Integer peerPort(ServiceRequestContext ctx) {
|
||||
SocketAddress socketAddress = ctx.remoteAddress();
|
||||
|
|
|
@ -88,11 +88,6 @@ public class GrizzlyHttpServerTracer
|
|||
return "io.opentelemetry.auto.grizzly-2.0";
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected Integer peerPort(HttpRequestPacket httpRequest) {
|
||||
return httpRequest.getRemotePort();
|
||||
|
|
|
@ -93,11 +93,6 @@ public class NettyHttpServerTracer
|
|||
return "io.opentelemetry.auto.netty-3.8";
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected Integer peerPort(Channel channel) {
|
||||
SocketAddress socketAddress = channel.getRemoteAddress();
|
||||
|
|
|
@ -64,11 +64,6 @@ public class NettyHttpServerTracer
|
|||
return "io.opentelemetry.auto.netty-4.0";
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected Getter<HttpRequest> getGetter() {
|
||||
return NettyRequestExtractAdapter.GETTER;
|
||||
|
|
|
@ -64,11 +64,6 @@ public class NettyHttpServerTracer
|
|||
return "io.opentelemetry.auto.netty-4.1";
|
||||
}
|
||||
|
||||
@Override
|
||||
protected String getVersion() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected Getter<HttpRequest> getGetter() {
|
||||
return NettyRequestExtractAdapter.GETTER;
|
||||
|
|
Loading…
Reference in New Issue