Replace `"messaging.operation"` with the constant (#1457)

This commit is contained in:
Vadim Shaigorodskiy 2020-10-23 18:54:33 +02:00 committed by GitHub
parent b683a6c417
commit 96eb67de6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions

View File

@ -8,6 +8,7 @@ package io.opentelemetry.instrumentation.api.typedspan;
import io.grpc.Context; import io.grpc.Context;
import io.opentelemetry.trace.Span; import io.opentelemetry.trace.Span;
import io.opentelemetry.trace.Tracer; import io.opentelemetry.trace.Tracer;
import io.opentelemetry.trace.attributes.SemanticAttributes;
public class MessagingConsumerSpan extends DelegatingSpan public class MessagingConsumerSpan extends DelegatingSpan
implements MessagingConsumerSemanticConvention { implements MessagingConsumerSemanticConvention {
@ -273,7 +274,7 @@ public class MessagingConsumerSpan extends DelegatingSpan
*/ */
@Override @Override
public MessagingConsumerSemanticConvention setMessagingOperation(String messagingOperation) { public MessagingConsumerSemanticConvention setMessagingOperation(String messagingOperation) {
delegate.setAttribute("messaging.operation", messagingOperation); delegate.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
return this; return this;
} }
@ -515,7 +516,7 @@ public class MessagingConsumerSpan extends DelegatingSpan
* this span describes. * this span describes.
*/ */
public MessagingConsumerSpanBuilder setMessagingOperation(String messagingOperation) { public MessagingConsumerSpanBuilder setMessagingOperation(String messagingOperation) {
internalBuilder.setAttribute("messaging.operation", messagingOperation); internalBuilder.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
return this; return this;
} }
} }

View File

@ -8,6 +8,7 @@ package io.opentelemetry.instrumentation.api.typedspan;
import io.grpc.Context; import io.grpc.Context;
import io.opentelemetry.trace.Span; import io.opentelemetry.trace.Span;
import io.opentelemetry.trace.Tracer; import io.opentelemetry.trace.Tracer;
import io.opentelemetry.trace.attributes.SemanticAttributes;
public class MessagingConsumerSynchronousSpan extends DelegatingSpan public class MessagingConsumerSynchronousSpan extends DelegatingSpan
implements MessagingConsumerSynchronousSemanticConvention { implements MessagingConsumerSynchronousSemanticConvention {
@ -280,7 +281,7 @@ public class MessagingConsumerSynchronousSpan extends DelegatingSpan
@Override @Override
public MessagingConsumerSynchronousSemanticConvention setMessagingOperation( public MessagingConsumerSynchronousSemanticConvention setMessagingOperation(
String messagingOperation) { String messagingOperation) {
delegate.setAttribute("messaging.operation", messagingOperation); delegate.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
return this; return this;
} }
@ -526,7 +527,7 @@ public class MessagingConsumerSynchronousSpan extends DelegatingSpan
*/ */
public MessagingConsumerSynchronousSpanBuilder setMessagingOperation( public MessagingConsumerSynchronousSpanBuilder setMessagingOperation(
String messagingOperation) { String messagingOperation) {
internalBuilder.setAttribute("messaging.operation", messagingOperation); internalBuilder.setAttribute(SemanticAttributes.MESSAGING_OPERATION, messagingOperation);
return this; return this;
} }
} }