Nikita Salnikov-Tarnovski
3a90673c99
Convert AwsSdk2 to Instrumenter API ( #4341 )
...
* Convert AwsSdk2 to Instrumenter API
2021-10-12 15:58:00 +03:00
Nikita Salnikov-Tarnovski
99f6bcde92
Convert AwsSdk1 to Instrumenter API ( #4315 )
...
* Convert AwsSdk1 to Instrumenter API
* Apply suggestions from code review
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Polish
* Polish and tests
* Polish
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-10-08 10:48:41 -07:00
Trask Stalnaker
dafc97f96e
Simplify gradle files ( #4292 )
2021-10-04 21:53:35 -07:00
Trask Stalnaker
6aaf5ef9e6
Remove dynamo db.name attribute ( #4208 )
2021-09-27 21:58:26 -07:00
Mateusz Rzeszutek
085066edb3
Add some testcontainers dependencies to dependencyManagement dep set ( #4185 )
2021-09-22 14:53:45 -07:00
Matthew Ho
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
Trask Stalnaker
d90d7c80f3
Use new HelperResourceBuilder ( #3976 )
...
* Use new HelperResourceBuilder
* Use latest to avoid merge conflict
2021-08-27 09:48:16 -07:00
Trask Stalnaker
20c72f3e98
Format kotlin gradle files ( #3942 )
...
* Add ktlint for kotlinGradle
* ktlint fails on wildcard imports
* Auto-format kotlin gradle files
2021-08-25 13:43:57 +09:00
Trask Stalnaker
3525733ea8
Enable strict context check in tests by default ( #3822 )
2021-08-23 17:40:02 -07:00
Mateusz Rzeszutek
5c71d28ed7
Remove deprecated Config methods ( #3908 )
2021-08-23 16:44:54 -07:00
Lauri Tulmin
77dc1ecf27
Fix warning in build scripts ( #3739 )
2021-08-02 19:37:35 +03:00
Lauri Tulmin
6269eb57b4
Fix aws-sdk latest dep tests ( #3646 )
2021-07-21 18:51:39 +03:00
Anuraag Agrawal
f601863d12
Merge Java TraceUtils into extension and switch to Instrumenter API. ( #3532 )
...
* Merge Java TraceUtils into extension and switch to Instrumenter API.
* Woah
2021-07-10 13:21:12 +09:00
Mateusz Rzeszutek
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
Mateusz Rzeszutek
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
Anuraag Agrawal
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
Anuraag Agrawal
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
Anuraag Agrawal
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
Anuraag Agrawal
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
Anuraag Agrawal
b7bfbf0cc6
Migrate instrumentation-library / common to plugins ( #3320 )
2021-06-15 11:54:48 -07:00
Anuraag Agrawal
7ad9e7a50b
Move shaded testing dependencies to internal package. ( #3305 )
2021-06-15 13:10:19 +03:00
Anuraag Agrawal
224dc51e93
Migrate java.gradle to conventions plugin ( #3289 )
...
* Migrate java.gradle to convention plugin.
* Switch to java-conventions
* Remove old file
* Fix
* Fix merge
* Missing paragraph
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-15 08:10:39 +09:00
Trask Stalnaker
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
Trask Stalnaker
b25ac0f1ad
Clean up old operation name terminology ( #3282 )
2021-06-13 22:10:36 -07:00
Trask Stalnaker
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
Anuraag Agrawal
f91e35616f
Migrate remaining usages of TestHttpServer to Armeria. ( #3231 )
...
* Migrate remaining usages of TestHttpServer to Armeria.
* Remove unused.
* Shade netty tcnative to allow TLS on Java 8
2021-06-10 09:28:44 +09:00
Trask Stalnaker
ac30b3c185
Add SuppressWarnings("unused") on Advice classes ( #3207 )
...
* Add SuppressWarnings unused on Advice classes
* And in doc
2021-06-07 16:00:21 +09:00
Anuraag Agrawal
c3dedbb64e
Enable all errorprone checks ( #3155 )
...
* Enable all errorprone checks
* Fixes
* Finish
* Finish
* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
Anuraag Agrawal
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
Anuraag Agrawal
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
Mateusz Rzeszutek
6fb3ec0501
Do not use arrays in InstrumentationModule ( #3057 )
...
* Do not use arrays in InstrumentationModule
* add missing cast
2021-05-24 13:51:07 +02:00
Mateusz Rzeszutek
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
Anuraag Agrawal
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
Anuraag Agrawal
abeca79e24
Some Gradle optimizations ( #2949 )
...
* Gradle optimizations
* Finish
2021-05-11 17:45:54 +09:00
Trask Stalnaker
10db083e77
Update to OTel API/SDK 1.2.0 ( #2945 )
...
* Update to OTel API/SDK 1.2.0
* TCP.IP -> tcp_ip
* Fix smoke tests
2021-05-10 10:14:07 -07:00
Mateusz Rzeszutek
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
Lauri Tulmin
9f8371e77c
Use locale insensitive lower/upper case conversion ( #2838 )
2021-04-22 11:24:13 +09:00
Trask Stalnaker
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
Trask Stalnaker
c17b803b71
Use isHelperClass over additionalHelperClassNames ( #2796 )
2021-04-14 09:38:16 -07:00
Trask Stalnaker
9bd028f767
Remove unnecessary genericness ( #2797 )
2021-04-14 00:01:28 -07:00
Trask Stalnaker
d741dc48b9
Minor rename of javaagent unit test modules ( #2784 )
2021-04-13 12:36:30 +03:00
Anuraag Agrawal
a4ea1c9db2
Update to OTel 1.1.0 ( #2744 )
...
* Update to OTel 1.1.0
* Use transform safe logger
* Finish
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-04-08 16:01:16 +09:00
Trask Stalnaker
9926288342
Clarify empty type instrumentations ( #2740 )
...
* Add comment for EmptyTypeInstrumentation
* Clarify use of empty type instrumentations
2021-04-07 10:03:24 +03:00
Mateusz Rzeszutek
1406855bb7
Revert "Prevent duplicate telemetry when using both library and auto instrumentation ( #2661 )" ( #2689 )
2021-04-01 16:11:15 -07:00
Trask Stalnaker
d5e526b9f3
Cache config values in instrumentations ( #2681 )
...
* Cache config values in instrumentations
* Bring back defaultEnabled()
* comment
* one problem
2021-03-31 22:54:20 -07:00
Mateusz Rzeszutek
30434696ae
Prevent duplicate telemetry when using both library and auto instrumentation ( #2661 )
...
* Prevent duplicate telemetry when using both library and auto instrumentation
* Add unit test
* Fix Oshi tests
* Fix couchbase 3.1 tests
2021-03-31 10:57:04 -07:00
Anuraag Agrawal
dcd316da7a
Enable strict context check and fix some context issues. ( #2637 )
...
* Enable strict context check and fix some context issues.
* Drift
* Drift and cache
* Exclude grizzly include akka
* Grizzly, scala
* ForkJoin worker
* webflux comment, grizzly typo
* Give up on akka for now
* threadpool
* Fallback on grizzly, wait for completion in executor cancellation tests
* Hystrix
* ratpack
* Cleanups
2021-03-29 08:08:11 +03:00
Lauri Tulmin
4ad9ed5c32
Reimplement finding open ports ( #2629 )
2021-03-25 10:41:20 -07:00
Anuraag Agrawal
f3482a629d
Add protocol-core to muzzle dependencies for aws sdk v2. ( #2602 )
...
* Add protocol-core to muzzle dependencies.
* What does this condition mean?
* Syntax
2021-03-19 11:48:58 +02:00
Jakub Wach
4e7d43e5cc
Apache Camel - S3 to SQS propagation impl + tests ( #2583 )
...
* Apache Camel - S3 to SQS propagation impl + tests
* code review - added unit test
* code review - proper unit tests
* code review
2021-03-19 08:33:29 +02:00
Jakub Wach
fcc7004353
Camel instrumentation - SNS propagation impl + tests ( #2562 )
...
* Camel instrumentation - SNS propagation impl + tests
* code review
2021-03-17 15:03:47 +02:00
Mateusz Rzeszutek
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
Anuraag Agrawal
63ad9b2a35
Remove aws sdk v1 tests that rely too much on implementation detail of SDK without really testing anything. ( #2557 )
2021-03-11 11:47:12 -08:00
Jakub Wach
04b9b64e53
AWS SDK - S3 - SNS - SQS propagation tests ( #2549 )
...
* AWS SDK - S3 - SNS - SQS propagation tests
* code review
2021-03-11 13:46:33 +02:00
Anuraag Agrawal
100a446e31
Use reflection to access json serializers. ( #2555 )
...
* Use reflection to access json serializers.
* git add
* Fix
2021-03-11 16:51:18 +09:00
Anuraag Agrawal
71d3f09c80
Extract library instrumentation for AWS SDK v1 ( #2525 )
...
* Extract library instrumentation for AWS SDK v1
* Drift
2021-03-10 12:36:12 +09:00
Jakub Wach
e013c381f2
AWS SDK - S3 to SQS propagation test ( #2518 )
...
* AWS SDK - S3 to SQS propagation test
* code review changes - got rid of thread.sleep
2021-03-09 18:47:06 +02:00
Mateusz Rzeszutek
3dff44874f
Fix RestTemplateInterceptor so that it calls endExceptionally() on exception ( #2516 )
2021-03-08 09:36:47 -08:00
Anuraag Agrawal
eff96a2fb3
Use reflection to get request metadata instead of instrumentation. ( #2508 )
2021-03-08 15:20:38 +09:00
Anuraag Agrawal
96606711ac
Only set aws header attribute name once. ( #2509 )
2021-03-05 11:00:07 -08:00
Mateusz Rzeszutek
72ffb3b7c5
Make BaseTracer fields private ( #2492 )
...
* Make BaseTracer fields private
By making `tracer` private we're forcing all tracer implementation to use the `spanBuilder()` utility method and pass the parent context manually.
2021-03-05 10:54:00 -08:00
Jakub Wach
9a5bc66329
AWS SDK - SNS to SQS tracing propagation test ( #2483 )
2021-03-04 13:33:22 -08:00
Anuraag Agrawal
7efa58d6f0
Use correct value for operation in aws-sdk v1 ( #2488 )
2021-03-04 19:32:42 +09:00
Anuraag Agrawal
926a1fb621
Migrate AWS SDK v2 to new library API pattern. ( #2487 )
2021-03-04 19:32:13 +09:00
Trask Stalnaker
47ee860e96
Hide non-specd attributes for aws-sdk-2.2 ( #2434 )
2021-03-03 20:49:45 -08:00
Anuraag Agrawal
12baba1adc
Use dynamic resolution of SQS to allow working without it. ( #2421 )
2021-03-02 10:30:02 -08:00
Trask Stalnaker
62f2611486
Update instrumentation names ( #2433 )
2021-03-01 19:34:25 -08:00
Trask Stalnaker
03bfaee5eb
Move rest of non-specd attributes to experimental ( #2402 )
2021-02-26 20:50:47 -08:00
Jakub Wach
17aae4dfaa
AWS SDK instrumentation - DynamoDB attributes ( #2262 )
...
* AWS SDK instrumentation - DynamoDB attributes
* aws sdk attributes mapping - dynamoDb
* some clean-up, swithced to AWS SDK marshalling for SdkPojos
* more tests, slight refactoring of different request type fields handling
* code review changes
* code review changes
* code review changes
2021-02-22 11:38:35 +02:00
Anuraag Agrawal
000df967ce
Update to SDK 0.17.0 ( #2338 )
...
* Update to SDK 0.17.0
* Finish
* ottrace
2021-02-19 15:51:55 +09:00
Anuraag Agrawal
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
Mateusz Rzeszutek
facaf8e46f
Remove all remaining direct AgentTestRunner usages ( #2196 )
...
* Remove all remaining direct AgentTestRunner usages
* Fix jaxws compilation failure
2021-02-05 16:14:26 +01:00
Mateusz Rzeszutek
93b3a3b289
testing-common refactoring: replace direct AgentTestRunner usage with… ( #2134 )
...
* testing-common refactoring: replace direct AgentTestRunner usage with spock spec
* Updated instrumentation docs
* Fix reactor-core library tests
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
2021-02-01 11:32:25 +01:00
Anuraag Agrawal
1ebb58a596
Update to SDK 0.15.0 ( #2137 )
...
* Update to SDK 0.15.0
* Fix lightstep test
2021-01-29 21:30:22 +09:00
Jakub Wach
77922d4834
SQS propagation for AWS SDK 1.1 ( #2114 )
2021-01-29 10:21:12 +02:00
Anuraag Agrawal
6b13bcca63
Use X-Ray propagator for aws sdk 1.1 instrumentation ( #2117 )
...
* Use X-Ray propagator for aws sdk 1.1 instrumentation
* Cleaner
* Fix
* Copy over doc
2021-01-28 16:01:07 +09:00
Anuraag Agrawal
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
Pavol Loffay
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
Anuraag Agrawal
8d74baa2e4
Run tests with javaagent. ( #1643 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-04 13:13:24 -08:00
Mateusz Rzeszutek
cd58ac816e
Muzzle should add SPI classes defined in helperResourceNames as references ( #1918 )
2020-12-16 21:54:04 -08:00
Trask Stalnaker
49c2a36811
HTTP client instrumentation cleanup: aws-sdk ( #1911 )
2020-12-15 09:06:28 +02:00
Trask Stalnaker
e2264222ce
HTTP client instrumentation cleanup, part 0 ( #1893 )
2020-12-14 16:34:06 -08:00
Anuraag Agrawal
c741eaa501
Shade trace propagators so they can be injected in instrumentation th… ( #1892 )
...
* Shade trace propagators so they can be injected in instrumentation that benefits from a hard-coded propagation format
* Runtime shade too
2020-12-14 07:52:21 +02:00
Nikita Salnikov-Tarnovski
c0f9daf0bb
Fix test for latest version of AWS SDK ( #1878 )
2020-12-10 10:36:42 +02:00
Anuraag Agrawal
1f25259f47
Manually inject AWS SDK helpers since they are refrenced from resource file, not code. ( #1876 )
2020-12-10 17:36:24 +09:00
Anuraag Agrawal
3b8827b8ab
Update to SDK 0.12.0 ( #1830 )
...
* Update to SDK 0.12.0
* Update error message to the current world.
* Bump referenced smoke test versions
* fixes
* dependency hell
* Suppress unused call
* Bump missed smoke tests
* Bump image, bump smoke tests gRPC version
2020-12-07 17:16:47 +09:00
Anuraag Agrawal
c5a257619a
Make sure AWS SDK spans suppress client spans all the time. ( #1837 )
...
* Make sure AWS SDK spans suppress client spans all the time.
* Make more consistent with other instrumentation
* Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/client/NettyHttpClientTracer.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* more dragons
* Grammar
* README
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-12-07 17:10:43 +09:00
Trask Stalnaker
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
Trask Stalnaker
ca76c80820
Hardcode expected values in tests ( #1803 )
...
* DEFAULT_SPAN_NAME
* TEMP_DESTINATION_NAME
* LoggingContextConstants
* Remove unnecessary dependencies
* Hardcode expected normalized queries in tests
* Spotless
2020-11-30 09:16:59 +02:00
Trask Stalnaker
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
Trask Stalnaker
41bd489a77
Format groovy files ( #1793 )
2020-11-28 21:22:14 -08:00
Trask Stalnaker
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
Mateusz Rzeszutek
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
Anuraag Agrawal
412d9991be
Inject context for aws sdk 1.11 requests too. ( #1771 )
2020-11-26 15:25:37 +09:00
Anuraag Agrawal
9802539b07
Add an AWS SDK type instrumentation on an 'entry point' type of class… ( #1759 )
...
* Add an AWS SDK type instrumentation on an 'entry point' type of class to ensure helper resources are injected before clients are made.
* Update instrumentation/aws-sdk/aws-sdk-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/awssdk/v2_2/AwsSdkInitializationInstrumentation.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-25 18:21:06 +09:00
Anuraag Agrawal
737f78acfa
Inject context into AWS SDK 2.2 HTTP request from interceptor. ( #1763 )
2020-11-25 17:37:16 +09:00
Mateusz Rzeszutek
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
Trask Stalnaker
a5a36bd203
Use namespace for attributes put into user classes ( #1739 )
...
* Use namespace for attributes put into user classes
* Add dependency to remove duplication
2020-11-24 12:07:10 -08:00
Mateusz Rzeszutek
45646ff367
Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization() ( #1741 )
...
* Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization()
* Removed no longer needed comments & improved JavaDoc
* Improve TypeInstrumentation Javadoc
2020-11-24 14:27:58 +02:00
Trask Stalnaker
308a8f9b0f
Consistent equals implementations ( #1736 )
...
* Consistent equals implementations
* Use direct equals where previous behavior
2020-11-23 15:41:31 +02:00