I suspect that this was added in the original RocketMQ instrumentation
because it existed in the Kafka instrumentation, and not because there
was a need for it(?)
See #6957 for documentation on why it is needed in Kafka
Runtime metrics doesn't include the meter version. This adds it from the
utility method in the instrumentation-api
`EmbeddedInstrumentationProperties.findVersion`. I know I can read the
properties file for this module, but its repetitive to implement that in
many places.
This was discussed a long while back, but never documented (and recently
came up in #6889)
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Fixes#6932
Replaces #6933
@aaron-ai I finally understood what you meant in #6796 after seeing your
PR - initially I thought you were talking about some custom extension,
that's outside of this repository.
I added back the maven central fallback to the muzzle check plugin:
after investigating a bit, I found out that the repositories defined in
`settings.dependencyResolutionManagement` are not propagated at all (no
matter whether it's `afterEvaluate` or not) to the
`project.repositories`, and that the gradle issue
https://github.com/gradle/gradle/issues/17295 is still valid.
This may be a regression in 1.19.0 because you can no longer reconstruct
the original url for netty server spans (previously `http.host` was
captured which could be used).
While I was looking at issues
open-telemetry/opentelemetry-java-instrumentation#6694 and
open-telemetry/opentelemetry-java#2337, I saw that the code in
`io.opentelemetry.instrumentation.resources.ContainerResource` used
`null` several times as return value which isn't safe. Nowadays,
`Optional` is better suited to signal the absence of a result, so I
refactored `ContainerResource` to use `Optional`s instead of null.
On the way, I also refactored this class's unit tests into parameterised
tests to reduce test code duplication. These improvements should help
implementing a solution to
open-telemetry/opentelemetry-java-instrumentation#6694.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Calling `Mono#timeout()` with a timeout value smaller than the HTTP
client timeout caused the on request/response end callbacks to be simply
discarded; and the HTTP span was never finished.
Added new "Restrict pushes that create matching branches: UNCHECKED",
which I discovered is needed during contrib release.
Removed the old `v*` branch protections since we don't need to make any
more patch releases from those old branch names anymore.
Trask Stalnaker
dependabot[bot]
Aaron Ai
Lauri Tulmin
Mateusz Rzeszutek
jack-berg
王展城
Peter Findeisen
Etienne Dysli Metref
