Commit Graph

2447 Commits

Author SHA1 Message Date
Nikolay Martynov 212d4d3c71 Provide Java compiler with bootstrap classes for Java7
when compiling Java7-compatible sources.
2019-03-29 13:53:53 -04:00
Nikolay Martynov 4c8a790c3b DDTracer: minor javadoc fix 2019-03-29 09:42:52 -04:00
Tyler Benson 1100461783
Merge pull request #783 from DataDog/tyler/fix-content-length
Fix content length calculation for larger trace counts
2019-03-27 15:19:39 -07:00
Tyler Benson 2052647ec9 Fix content length calculation for larger trace counts
Failure to calculate this correctly causes the agent to drop the request.
2019-03-27 15:06:07 -07:00
Nikolay Martynov 722e6c4f68
Merge pull request #778 from DataDog/mar-kolya/some-java11-prep
Mar kolya/some java11 prep
2019-03-27 12:55:52 -04:00
Tyler Benson e4dcabed67 Begin 0.27.0 2019-03-27 09:29:28 -07:00
Tyler Benson c51ae3a248 Version 0.26.1 2019-03-27 09:06:59 -07:00
Tyler Benson 2065be101a
Merge pull request #782 from DataDog/tyler/status-mapping-config
Correct http status mapping config keys
2019-03-27 09:01:40 -07:00
Tyler Benson 347710a680 Correct http status mapping config keys
Use the properly documented and agreed upon config keys.
2019-03-27 08:43:10 -07:00
Nikolay Martynov 8fa354e198
Merge pull request #781 from DataDog/mar-kolya/fix-helper-injection
Fix helper injection in context provider
2019-03-26 16:16:36 -04:00
Nikolay Martynov 3b0e769e88 Fix helper injection in context provider
Currently helpers will not be injected if instrumentation doesn't
apply. Unfortunately it is possible for some classes to have context
fields added even if instrumentation is not allied (i.g. instrumented
classes are not used). Fix this by always injecting all helpers if we
inject context fields.
2019-03-26 15:53:34 -04:00
Nikolay Martynov 75643fe1e9 Do not generate tests tasks for current Java version 2019-03-26 15:06:55 -04:00
Tyler Benson bd4e05b41a Begin 0.27.0 2019-03-25 15:10:48 -07:00
Nikolay Martynov 510262d826 Force compilation with given scala version 2019-03-25 17:50:40 -04:00
Tyler Benson bc6b73f8e7 Version 0.26.0 2019-03-25 14:40:19 -07:00
Tyler Benson cfb7c19e20
Merge pull request #777 from DataDog/tyler/hibernate
Fix NPE in hibernate instrumentation and fix InstrumentationContext+Muzzle
2019-03-25 12:27:30 -07:00
Tyler Benson 004c44d70c Add tests confirming that Spring Data Repos aren’t working
The hibernate instrumentation doesn’t seem to work with Spring Data JPA.
2019-03-25 11:58:16 -07:00
Tyler Benson a73b8c36f0 Review changes. 2019-03-25 09:56:05 -07:00
Nikolay Martynov c46cf46a6d Update groovy version to avoid some bugs related to Java 11 2019-03-25 12:31:32 -04:00
Tyler Benson 26a0194b84 Prevent instrumentation’s Context from applying if Muzzle fails
This can cause problems if muzzle prevents an integration from loading because the class for the new field being added may not be injected.  This results in an error:

```
Caused by: java.lang.NoClassDefFoundError: datadog/trace/bootstrap/instrumentation/context/FieldBackedProvider$ContextAccessor$org$hibernate$Session$datadog$trace$bootstrap$instrumentation$hibernate$SessionState
```
2019-03-25 08:19:44 -07:00
Tyler Benson 63b5c094e7 Fix NPE in hibernate instrumentation
Also add each hibernate instrumentation project as a test dependency to the others.  This demonstrates a problem with muzzle and instrumentation context which currently causes the tests to fail.
2019-03-22 17:06:19 -07:00
Tyler Benson a88ebb5551
Merge pull request #770 from DataDog/mar-kolya/aws-sdk-v0-memory-leak
AWS v0: Close span non AWS SDK errors
2019-03-22 09:41:27 -07:00
Tyler Benson 25ea44e025
Merge pull request #776 from DataDog/tyler/cassandra
Fix cassandra supported version
2019-03-22 09:29:55 -07:00
Tyler Benson b22b11b9b0 Add timeout test for V2
Also make sure span is closed on error.
2019-03-21 18:08:35 -07:00
Tyler Benson 8d96729ae8 Fix instrumentation and add tests to verify. 2019-03-21 18:08:35 -07:00
Nikolay Martynov 3a3705f708 AWS v0: Close span non AWS SDK errors
Looks like AWS SDK doesn't call interceptor when non-sdk exception
occurs. This leads to leaking open spans. Fix that by instrumenting
http client.

Note: currently has no tests.
2019-03-21 18:08:35 -07:00
Tyler Benson e0d95ceb19 Fix cassandra supported version
and limit range check to <4.
The latest release (4.0) is not compatible with our instrumentation.
2019-03-21 17:57:08 -07:00
Will Gittoes c363f64b50
Merge pull request #773 from DataDog/willgittoes-dd/hibernate-fix
Improve selectivity of Hibernate instrumentation application
2019-03-22 10:08:26 +11:00
Tyler Benson 18c7916338
Merge pull request #756 from DataDog/mar-kolya/b3-headers
Implement B3 headers extraction and injection
2019-03-21 10:35:33 -07:00
Tyler Benson 849653c5d5 Improve and adjust code coverage 2019-03-21 09:55:21 -07:00
Tyler Benson f290734d52 Merge branch 'master' into mar-kolya/b3-headers
# Conflicts:
#	dd-trace-api/src/main/java/datadog/trace/api/Config.java
2019-03-21 08:33:56 -07:00
Tyler Benson f98884235f Review changes. 2019-03-21 08:10:36 -07:00
Will Gittoes af0f37861b
Support Hibernate 3.3 2019-03-21 13:38:16 +11:00
Tyler Benson 07463e04bd
Merge pull request #772 from DataDog/tyler/status-error-mapping
Implement Http Status error mapping via config
2019-03-20 19:14:17 -07:00
Will Gittoes c369fafe8c
Support muzzle testInverse = true 2019-03-21 12:17:24 +11:00
Tyler Benson 4187bf3eb0 code review changes. 2019-03-20 17:09:39 -07:00
Tyler Benson 2a49998180 Allow truncation for 128 bit B3 headers.
This is accepted practice in the Zipkin community, so we shouldn’t break this.
2019-03-20 16:02:32 -07:00
Nikolay Martynov 2c5d2ce70d Create TagContext during B3 headers extration 2019-03-20 12:28:39 -07:00
Nikolay Martynov 42cc3594dc Improve injection/extraction styles configuration 2019-03-20 12:28:39 -07:00
Nikolay Martynov 4eb7936245 Implement B3 headers extraction and injection 2019-03-20 12:28:39 -07:00
Tyler Benson e5e2c5b9dc
Merge pull request #710 from DataDog/tyler/size-limited-flushes
Change DDAgentWriter to use Disruptor
2019-03-20 11:03:56 -07:00
Will Gittoes 143abcbcf8
Merge pull request #769 from DataDog/willgittoes-dd/hibernate-3.5
Support Hibernate 3.5
2019-03-20 15:53:29 +11:00
Will Gittoes f94f22bcba
Dont load hibernate instrumentation unless correct version of hibernate is on the classpath 2019-03-20 15:52:49 +11:00
Tyler Benson 715af67e70 Implement Http Status error mapping via config
Using the following defaults:

* `DD_HTTP_CLIENT_ERROR_STATUSES=400-499`
* `DD_HTTP_SERVER_ERROR_STATUSES=500-599`
2019-03-19 17:11:48 -07:00
Will Gittoes 8c5158f8e9
Restructure hibernate integration 2019-03-20 11:00:42 +11:00
Tyler Benson 7ffcf5ad4d Change DDAgentWriter to use Disruptor
Serialize payloads as they arrive, send to agent when size exceeds 5MB.

If a flood of traces fills up the RingBuffer, we still count the traces that are discarded for stats reporting.

Do we want to allow configuration of the RingBuffer size?
2019-03-19 09:44:23 -07:00
Will Gittoes 4825a113f8
Add a couple of comments about the code structure 2019-03-19 16:28:27 +11:00
Will Gittoes b60c3bcc0a
Decouple common utils used in hibernate tracing from any specific version of hibernate 2019-03-19 14:40:16 +11:00
Will Gittoes 86d14280d2
Exclude hibernate-annotations from 3.5 latestDepTest 2019-03-19 09:56:39 +11:00
Will Gittoes 3b6c688ce8
Support Hibernate 3.5 2019-03-19 09:56:39 +11:00