Commit Graph

4146 Commits

Author SHA1 Message Date
Trask Stalnaker 2298885678 Merge tag 'v0.46.0' into dd-merge 2020-03-16 11:25:27 -07:00
Trask Stalnaker cecabe522a
Make tests pass on Windows (#217) 2020-03-12 19:42:21 -07:00
Han Zhang 5b1218cdb8
Update instrumentation to be compliant with HTTP semantic conventions (#227)
* Update HTTP client-side span names

* Add query and fragment to  http.url for HTTP client spans

* Add query and fragment to http.url for HTTP server spans

* Update HTTP server span names to be the matched route or resource

* Use net.peer.* instead of peer.* attributes
2020-03-12 18:49:52 -07:00
Tyler Benson f5c5e57020
Proof of Concept of "Typed Spans" (#195)
Primary goal is to maintain a simple and semantic interface for the code using it. See `HttpClientTracerDemonstration` for example usage.

* Add additional startSpan methods and restructure to allow tracer.extract at build time.

* Move classes into a different package structure to enable less visibility.

And move setter method to tracer.

* Add deprecation warnings to unused end methods
2020-03-12 18:33:49 -07:00
John Bley 1e1f3b57bb
Fix open-telemetry/opentelemetry-auto-instr-java#226 (#228) 2020-03-12 14:00:05 -07:00
Brian Devins-Suresh 3575e7b41c
Merge pull request #1312 from DataDog/devinsba/spring-ignores
Rework test logic for ignores. Add spring proxy to global ignore list
2020-03-12 16:46:06 -04:00
Brian Devins-Suresh a3fbcd6192 They need to fix the suggestions workflow... 2020-03-12 14:47:47 -04:00
Brian Devins-Suresh 9fe9be3f7c
Apply suggestions from code review
Co-Authored-By: Laplie Anderson <randomanderson@users.noreply.github.com>
2020-03-12 14:43:13 -04:00
Brian Devins-Suresh 98f58dbea9 Rework test logic for ignores. Add spring proxy to global ignore list 2020-03-12 14:33:02 -04:00
Laplie Anderson 7df5cfe3e3
Merge pull request #1311 from DataDog/landerson/helpers-to-bootstrap
Move common helper classes to bootstrap
2020-03-12 13:50:57 -04:00
Tyler Benson 060c05671e
Merge pull request #1160 from DataDog/tyler/stacktrace
Add config to capture stacktrace when a span duration exceeds threshold
2020-03-12 10:45:20 -07:00
Laplie Anderson 6411ee358f Remove Http*Decorators from method signatures in tests 2020-03-12 13:13:17 -04:00
Laplie Anderson 8332e177c2 Move decorator tests to bootstrap 2020-03-11 18:41:29 -04:00
Laplie Anderson 6cd530a541 Move decorators to bootstrap 2020-03-11 18:41:29 -04:00
Laplie Anderson 97b0e7a21f Move concurrent helpers to bootstrap 2020-03-11 18:37:03 -04:00
Laplie Anderson 0d6328a76e Add toString() for bootstrap placeholder 2020-03-11 18:37:03 -04:00
Tyler Benson e4ca33d487
Merge pull request #1307 from DataDog/tyler/onmethodexit
Improve consistency of `@Advice.OnMethodExit` params
2020-03-11 15:29:58 -07:00
Brian Devins-Suresh fe7d18b8da
Merge pull request #1310 from DataDog/devinsba/jms-latestDepTest-fix
JMS: Use a different queue per test
2020-03-11 16:28:48 -04:00
John Bley f30f5f0779
Fix 3 minor javadoc issues. (#225) 2020-03-11 13:25:39 -07:00
Brian Devins-Suresh db074b199a Make regular test less flaky too 2020-03-11 15:57:15 -04:00
Brian Devins-Suresh 00e331814d Use a different queue per test 2020-03-11 15:38:13 -04:00
Trask Stalnaker 5c4dc47710
Add JBoss logging support (#222) 2020-03-10 17:14:44 -07:00
Trask Stalnaker e5b83218ae
Rename elasticsearch modules (#221) 2020-03-10 16:51:07 -07:00
Trask Stalnaker dec9b95d87
Fix logback instrumentation (#218)
* Fix logback instrumentation

* Remove unnecessary shading
2020-03-10 16:34:09 -07:00
Trask Stalnaker d3a931384d
Add grouping modules (#220)
* Add mongo grouping module

* Add play and play-ws grouping modules

* Add netty grouping module

* Add jaxrs grouping module

* Add jaxrs-client grouping module

* Add jedis grouping module

* Add log4j grouping module

* Add couchbase grouping module

* Add aws-sdk grouping module

* Add apache-httpclient grouping module
2020-03-10 15:56:41 -07:00
Trask Stalnaker 08248e4f09
Fix link behavior (#223) 2020-03-10 15:08:22 -07:00
Tyler Benson 2f64edaea4 Make threshold based on average duration
This should help avoid too frequent of stacktraces when the configured threshold is a normal duration.
Alternatively, we could make it a percentage above the average.
2020-03-10 15:08:12 -07:00
Trask Stalnaker 0ae9ed8a48
Prevent DNS lookup by gRPC instrumentation (#224) 2020-03-10 14:53:04 -07:00
Tyler Benson 1cbb874c7c Replace FilteredStringWriter with direct StackTraceElement usage. 2020-03-10 13:18:22 -07:00
Tyler Benson 2b74487ed6 Add config to capture stacktrace when a span duration exceeds threshold
(But only when span is not errored or finished on a different thread.)

Use the following config:
```
-Ddd.trace.span.duration.stacktrace.millis=1000
```
(One second is the default, 0 disables.)
2020-03-10 13:18:22 -07:00
Tyler Benson e0b46da375 Improve consistency of `@Advice.OnMethodExit` params
And ordering of some `helperClassNames`
2020-03-10 13:11:22 -07:00
Laplie Anderson 872743db91
Merge pull request #1269 from DataDog/landerson/auto-versioning
Use plugin to automatically set version
2020-03-10 15:37:03 -04:00
Pontus Rydin e54ab56b3a
Implemented Apache Geode/Gemfire instrumentation (#215) 2020-03-10 11:18:36 -07:00
Tyler Benson 36c063c4b3
Merge pull request #1303 from trask/fix-for-spring-jms-listeners
Fix for Spring JMS listeners
2020-03-10 09:54:54 -07:00
Laplie Anderson 6d99b138d2 Don't create release tag 2020-03-10 12:26:46 -04:00
Laplie Anderson c14a9276b3 Add a release commit to match previous behavior 2020-03-10 12:26:46 -04:00
Laplie Anderson fa50a54552 Use plugin to automatically set version 2020-03-10 12:26:46 -04:00
Laplie Anderson ad818a1da4
Merge pull request #1305 from DataDog/landerson/fix-ignores-for-google
Fix ignores for com.google.inject
2020-03-10 11:54:48 -04:00
Trask Stalnaker cba031ddcb
Rename hibernate modules (#205)
* Rename hibernate modules

* Update tracer name

* Change from gradle inheritance to composition

This will make it possible to have empty "grouping" modules, e.g.
instrumentation:hibernate.

* Introduce empty hibernate grouping module
2020-03-09 15:33:21 -07:00
Trask Stalnaker 9715ed5d90
Fix the build (#219) 2020-03-09 14:45:57 -07:00
Laplie Anderson 7b5ebe3204
Merge pull request #1304 from DataDog/landerson/httprequest-attributes
Add traceId and spanId as request attributes
2020-03-09 17:43:59 -04:00
Laplie Anderson 645c4de2c9 Fix ignores for com.google.inject 2020-03-09 17:41:15 -04:00
Laplie Anderson 1a35ced75e Tomcat access log tests 2020-03-09 16:15:57 -04:00
Laplie Anderson 4dce8776e1 Add traceId/spanId as request attributes 2020-03-09 16:15:40 -04:00
John Bley 00ae1eca3d
Integrate SpotBugs into build (ignoreFailures=true), fix most found issues (#216)
* Integrate SpotBugs (FindBugs) into build.  Set ignoreFailures so spotted bugs do not break the build.

* Fix many SpotBugs-found items, mostly making things final, but also a redundant null check and a reliance on platform character encoding.  2 items remain which will need further work/review, but as ignoreFailures is set, they will not fail the check stage.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-03-09 10:47:49 -07:00
Tyler Benson b16f98dece
Merge pull request #1302 from trask/revert-removal-of-non-delegating-loader-check
Revert removal of non-delegating loader check
2020-03-09 10:44:14 -07:00
Trask Stalnaker 279af696f4 Improve test reliability 2020-03-09 09:30:31 -07:00
Trask Stalnaker 7761094280 Fix for Spring JMS listeners 2020-03-08 22:41:58 -07:00
Trask Stalnaker 5834b2cab1 Add comment explaining why keeping delegate check 2020-03-06 13:37:01 -08:00
Trask Stalnaker 0ca384d24c Revert "Remove non-delegating class loader check"
This reverts commit c63c981221.
2020-03-06 13:21:02 -08:00