jason plumb
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
Nikita Salnikov-Tarnovski
daeda5dcfc
Don't extract deprecated cassandra keyspace attribute ( #5041 )
2022-01-07 15:19:59 -08:00
Trask Stalnaker
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
Martin
d314d76fce
rename `newBuilder()` to `builder()` ( #4475 )
...
* rename `newBuilder()` to `builder()`
* rename `newBuilder()` to `builder()`
2021-10-22 20:50:43 -07:00
Martin
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
Nikita Salnikov-Tarnovski
efddb72cef
Convert AttributesExtractor to interface ( #4363 )
2021-10-14 08:36:47 +03:00
Trask Stalnaker
63a2383905
Split NetAttributesExtractor into NetClientAttributesExtractor and NetServerAttributesExtractor ( #4287 )
...
* Net Extractors
* Either request or response but not both
* Fix merge conflicts
* Separate by OnStart/OnEnd
* PeerServiceAttributes
* Fix test
* Restructure to client/server
* Fix merge conflict in main
* more
* peer.service
* Feedback
* peer.service is only for clients
* Fix merge conflict
* rename
* Armeria
* peer.service is only for clients
* rename
* WIP
* Sync Dubbo with Armeria
* More Dubbo and Armeria
* gRPC
* Revert some Dubbo changes
* more peer.service
* Fix test
* Fix merge
* Fixes
2021-10-07 15:40:15 -07:00
Trask Stalnaker
dafc97f96e
Simplify gradle files ( #4292 )
2021-10-04 21:53:35 -07:00
Matthew Ho
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
Mateusz Rzeszutek
4820ec4855
Add error parameter to EndTimeExtractor and AttributesExtractor#onEnd() ( #3988 )
2021-09-08 07:58:13 -07:00
Trask Stalnaker
20c72f3e98
Format kotlin gradle files ( #3942 )
...
* Add ktlint for kotlinGradle
* ktlint fails on wildcard imports
* Auto-format kotlin gradle files
2021-08-25 13:43:57 +09:00
Lauri Tulmin
ff5472a822
Limit number of concurrently running docker tests ( #3664 )
...
* Limit number of concurrently running docker tests
* rename heavy to testcontainers
* use shorter expression
2021-07-27 15:41:39 -07:00
Anuraag Agrawal
e0cb216610
Remove remaining usages of basic span asserts ( #3616 )
2021-07-19 10:09:44 -07:00
Anuraag Agrawal
f5ce4c03f8
Inline basic usages of basicSpan ( #3583 )
...
* Inline basic usages of basicSpan
* spock
2021-07-18 21:15:51 +03:00
Anuraag Agrawal
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
Trask Stalnaker
9e4da754c2
Use consistent logger field name ( #3515 )
2021-07-07 10:47:46 -07:00
Mateusz Rzeszutek
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
Anuraag Agrawal
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
Anuraag Agrawal
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
Anuraag Agrawal
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
Lauri Tulmin
3967c42cda
Propagate context to cassandra4 callbacks ( #3371 )
2021-06-21 13:12:57 -07:00
Anuraag Agrawal
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
Mateusz Rzeszutek
2f528e4166
Rename *Instrumenters to *Singletons ( #3335 )
2021-06-16 10:12:37 -07:00
Trask Stalnaker
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
Trask Stalnaker
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
Trask Stalnaker
e9c3df6dac
Static factory method ordering ( #3206 )
2021-06-07 15:29:30 -07:00
Trask Stalnaker
a78ed4c420
Rename some extractor request/response params ( #3202 )
2021-06-07 11:41:47 -07:00
Trask Stalnaker
ac30b3c185
Add SuppressWarnings("unused") on Advice classes ( #3207 )
...
* Add SuppressWarnings unused on Advice classes
* And in doc
2021-06-07 16:00:21 +09:00
Anuraag Agrawal
c3dedbb64e
Enable all errorprone checks ( #3155 )
...
* Enable all errorprone checks
* Fixes
* Finish
* Finish
* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
Trask Stalnaker
d986981d70
Update cassandra-4.0 to Instrumenter API ( #3126 )
...
* Update cassandra-4.0 to Instrumenter API
* Update cassandra-3.0 instrumentation to be consistent
2021-05-31 07:49:59 -07:00
Anuraag Agrawal
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
Trask Stalnaker
98b566959a
Make TypeInstrumentations top-level classes ( #3100 )
2021-05-27 13:27:28 -07:00
Trask Stalnaker
c8ecd9a619
Add response type parameter to db attributes extractor ( #3093 )
...
* Add response type parameter to DbAttributesExtractor
* AutoValue
* ResultSet
2021-05-26 23:13:33 -07:00
Anuraag Agrawal
c1452b907d
Fix merge conflict ( #3086 )
2021-05-26 18:28:36 +09:00
Trask Stalnaker
a6c3d80b50
Update cassandra-3.0 to Instrumenter API ( #3066 )
2021-05-25 21:45:03 -07:00
Mateusz Rzeszutek
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
Trask Stalnaker
85522cb2ed
Avoid loading advice classes in agent class loader ( #3008 )
...
* Lettuce 5.0
* Lettuce 4.0
* Ratpack
* Cassandra 4.0
* Grizzly
* KHttp
* External annotations
* Test
* Jdbc
* Method instrumentation
* OTel annotations
2021-05-16 20:07:20 -07:00
Anuraag Agrawal
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
Trask Stalnaker
65995388e6
Clean up Java 7 references ( #2931 )
...
* Clean up Java 7 references
* Use Java 8 stuff!
* Spotless
2021-05-09 14:16:42 +03:00
Mateusz Rzeszutek
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
Mateusz Rzeszutek
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
Anuraag Agrawal
94872b1ced
Move DB helpers to instrumentation-api ( #2511 )
...
* Move DB helpers to instrumentation-api
* Fix gradle config
* Remove legacy
2021-03-08 12:32:36 +09:00
Mateusz Rzeszutek
fbe55e04aa
Use low cardinality span names in Cassandra instrumentation ( #2423 )
2021-03-03 17:54:44 +01:00
Trask Stalnaker
62f2611486
Update instrumentation names ( #2433 )
2021-03-01 19:34:25 -08:00
Mateusz Rzeszutek
fd55ce226a
Refactor DatabaseClientTracer (in preparation for low-cardinality span names) ( #2398 )
...
* Refactor DatabaseClientTracer (in preparation for low-cardinality span names)
* spotless
2021-02-26 15:36:24 +01:00
Anuraag Agrawal
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
Frank Spitulski
71ceb7486c
cassandra table name should split out keyspace ( #2177 )
2021-02-03 17:20:19 +02:00
Frank Spitulski
9ded7188b8
feat(cassandra4): more attributes ( #1314 )
...
* feat(cassandra4): more attributes
fixes #1298
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/cassandra/cassandra-4.0/javaagent/src/test/groovy/CassandraClientTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* add error handling
* default idempotence
* embed session into onResponse to prevent need to overwrite default tags
* change javadoc according to spotless
* use shared table name extractor
* fix tests to account for SqlStatementSanitizer
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-02 18:12:55 +09:00
Mateusz Rzeszutek
93b3a3b289
testing-common refactoring: replace direct AgentTestRunner usage with… ( #2134 )
...
* testing-common refactoring: replace direct AgentTestRunner usage with spock spec
* Updated instrumentation docs
* Fix reactor-core library tests
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
2021-02-01 11:32:25 +01:00
Mateusz Rzeszutek
c61f3f2949
Use a single configuration property for db.statement sanitization ( #2125 )
...
* Use a single configuration property for db.statement sanitization
* spotless
2021-01-29 16:02:15 +09:00
Mateusz Rzeszutek
20dadc1b6d
Replace two JavaCC lexers with a single JFlex one ( #2113 )
2021-01-26 14:03:11 -08:00
jason plumb
7122c4b2a5
Rename "normalize" to "sanitize" ( #2087 )
...
* rename SqlNormalizer to SqlSanitizer (more descriptive).
* rename normalize to sanitize.
* rename in comments and messages
* rename in variable to sanitized
* rename normalized -> sanitized in tests
* fixed broken tests
* rename variable.
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2021-01-22 15:49:24 +09:00
Mateusz Rzeszutek
660f0e5225
Remove testing-common dependency on guava ( #2062 )
...
* Remove testing-common dependency on guava
* Use nano time
* Add guava dep to opentelemetry-api-metrics
2021-01-19 12:07:27 +09:00
Anuraag Agrawal
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
Anuraag Agrawal
3b88bb75ae
Use SemanticAttributes for DbSystem ( #1991 )
2021-01-07 18:59:56 -08:00
Lauri Tulmin
d409a48cb5
Avoid npe when cassandra test fails to start ( #1984 )
2021-01-06 13:41:56 +09:00
Anuraag Agrawal
8d74baa2e4
Run tests with javaagent. ( #1643 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-04 13:13:24 -08:00
Trask Stalnaker
4cbfb361e1
Use Context more in DatabaseClientTracer ( #1836 )
2020-12-07 09:15:15 +02:00
Trask Stalnaker
a2770c311e
Don't use ConfigUtils outside of AgentTestRunner tests ( #1796 )
...
* NetPeerUtilsTest
* RedisCommandNormalizerTest
* InstrumentationModuleTest
* HttpClientTracerTest
* Normalize test config properties
* Create ConfigBuilder in instrumentation-api
* Keep config properties compatible with SDK
2020-12-01 16:52:08 -08:00
Trask Stalnaker
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
Trask Stalnaker
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
Mateusz Rzeszutek
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
Mateusz Rzeszutek
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
Trask Stalnaker
d183692699
Enable checkstyle type var naming rule ( #1666 )
2020-11-19 11:00:31 -08:00
Trask Stalnaker
cecdfc2cd0
Update instrumentation names to be consistent ( #1671 )
...
* Update instrumentation names to be consistent
* Remove amqp from rabbitmq package name
2020-11-18 19:53:31 -08:00
Trask Stalnaker
2e51003900
Enable checkstyle overload method ordering rule for Google Java Style ( #1656 )
2020-11-17 14:41:14 -08:00
Mateusz Rzeszutek
1a23ac3027
Standardize instrumentation names in InstrumentationModules ( #1648 )
...
* Standardize instrumentation names in InstrumentationModules
* rename gradle modules:
* vertx-3.0 to vertx-web-3.0
* spark-web-framework-2.3 to spark-2.3
* add JavaDoc describing the naming rules to InstrumentationModule
2020-11-17 13:30:28 -08:00
Trask Stalnaker
b35c0b28cc
Java 7 and CircleCI cleanup ( #1654 )
...
* Java 7 and CircleCI cleanup
* Bring back and increment version instead
2020-11-17 10:36:23 +02:00
Trask Stalnaker
6d5ec329d6
Enable checkstyle for google style guide ( #1641 )
2020-11-16 18:46:59 -08:00
Mateusz Rzeszutek
d307ffc532
Refactor Instrumenters into InstrumentationModules - A, B, C ( #1556 )
...
* Refactor Instrumenters into InstrumentationModules - A, B, C
* Fixed some modules' names to match library/instrumentation gradle module
* Fix couchbase 2.6 muzzle
2020-11-09 15:42:41 +01:00
Anuraag Agrawal
d3b60a5e33
Rename TRACER to tracer() ( #1540 )
2020-11-02 20:49:51 -08:00
Anuraag Agrawal
c6eee70660
Update to latest snapshot. ( #1524 )
2020-10-29 18:54:09 -07:00
Mateusz Rzeszutek
e89942d430
Standardize DB query normalizer property names ( #1509 )
...
* Standardize DB query normalizer property names
And add normalizer configuration for Redis, Couchbase, Cassandra and Geode
* apply code review comments
2020-10-29 16:20:33 +02:00
Anuraag Agrawal
a2dccf2316
Update to latest SDK snapshot. ( #1479 )
2020-10-26 19:29:46 -07:00
Nikita Salnikov-Tarnovski
3db872e50f
Fix net.peer.* setting for Cassandra 4.+ ( #1482 )
2020-10-26 13:49:25 +02:00
Mateusz Rzeszutek
50990a7c17
Cassandra instrumentations should store normalised CQL queries as db.statement ( #1427 )
...
* Move `DbSystem` to package `...instrumentation.api.db`
* Move `SqlNormalizer` to `javaagent-api` package ...api.db.normalizer
* Refactor Cassandra tests so that they use testcontainers (and run on Java 11)
* Implement Cassandra statement normalization
2020-10-22 17:56:06 +02:00
Vadim Shaigorodskiy
9e8d663ba4
Remove apache httpclient version ( #1446 )
...
* Remove version from `apache-httpclient` instrumentation
Fixes : #1260
* Remove version from all instrumentation names and add instrumentation name to `spring-web`
Fixes : #1260
2020-10-22 14:22:44 +09:00
Trask Stalnaker
1b51d4a6b1
Rename packages ( #1367 )
2020-10-11 13:54:35 -07:00
Trask Stalnaker
4624584979
Update spotless config ( #1349 )
...
* Apply spotless to buildSrc
* Apply spotless
* Update spotless version
* Apply spotless
* Another spotless update
* Apply spotless
2020-10-09 07:21:28 +03:00
Ioannis Mavroukakis
f2de47a150
SpanAssert method names should reflect underlying Span method names ( #1307 )
2020-10-05 16:04:08 +09:00
Anuraag Agrawal
dadaac9a8c
Use 2-line license header to match SDK repo ( #1321 )
...
* Use 2-line license header to match SDK repo
* Apply change
2020-10-05 14:29:56 +09:00
Nikita Salnikov-Tarnovski
88707c3bb0
Review DB semantic conventions ( #1284 )
2020-10-01 11:17:09 -07:00
Nikita Salnikov-Tarnovski
e74ffe2e52
Remove support for java7 from buildscripts ( #1229 )
...
* Remove support for java7 from buildscripts
* Remove support for java7 from buildscripts
2020-09-23 15:40:21 +03:00
Tyler Benson
d7d46b2ef9
Add instrumentation for Guava ListenableFutures context propagation ( DataDog/dd-trace-java#1665 )
2020-09-01 10:31:23 -07:00
Helen Y
c4c4558b09
More refactoring ( #1040 )
2020-08-19 15:43:48 -07:00
Trask Stalnaker
0fb7614103
Use Futures.addCallback() and other cleanup ( #1050 )
...
* Use Futures.addCallback() and other cleanup
* muzzle
* Remove suppression
2020-08-19 15:20:35 +09:00
Anuraag Agrawal
bbfdbb39c0
Create abstraction for library dependencies for instrumentation. ( #977 )
...
* Create abstraction for library dependencies for instrumentation.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-08-19 08:57:31 +09:00
Trask Stalnaker
14ff14f2b1
Remove thread utils module ( #1017 )
...
* Remove thread-utils module
* No need for extra thread pool
2020-08-17 11:10:48 +03:00
Trask Stalnaker
7159d04b8d
Change groovy import order ( #1013 )
...
* Update docs
* Format all groovy code
* Organize imports
2020-08-15 23:19:27 -07:00
Trask Stalnaker
414213f2d1
Remove final from parameters ( #1003 )
2020-08-15 22:35:51 -07:00
Trask Stalnaker
f893ca540b
Scripted package renaming ( #988 )
2020-08-15 21:55:01 -07:00
Helen Y
bb235a0aa3
Update package name for tracers ( #991 )
2020-08-14 21:07:18 -07:00
Trask Stalnaker
7818e33178
Package renaming ( #970 )
2020-08-13 20:14:46 -07:00
Trask Stalnaker
b5fbf90977
Extract instrumentation api module ( #884 )
2020-08-09 22:52:33 -07:00
Helen Y
b659ee8223
Apply new database semantic attributes ( #823 )
2020-07-28 17:31:33 -07:00
Helen Y
44fcf8115b
Update database semantic conventions ( #785 )
2020-07-28 11:55:55 -07:00
Helen Y
86c438b154
Remove final from local variables ( #732 )
...
* Remove final from local variables
2020-07-20 13:53:34 +09:00
Alexey Zhokhov
f3421e91a0
Remove Lombok ( #672 )
...
* Gradle 6.5.1.
* Skip download javadoc and sources automatically in IntelliJ IDEA.
* Added mavenLocal to repositories.
* Removed Lombok usage.
* Removed duplicated idea config.
* Code format.
* Removed useless usage of Objects.requireNonNull.
* Use instanceof to comparing objects.
* Code format.
* Code format.
* Fixes after merge.
* Fixed sneakyThrow exception.
* Code format.
2020-07-18 15:52:55 +03:00
Nikita Salnikov-Tarnovski
9f1ffbe38c
Remove attribute `span.origin.type` ( #712 )
2020-07-16 10:00:45 -07:00
Nikita Salnikov-Tarnovski
23ae6980d5
Lettuce and Cassandra migrated from deprecated Decarator to new Tracer ( #681 )
...
* Lettuce and Cassandra migrated from deprecated Decarator to new Tracer
* Polish
* Polish
* Split a connection specific handling out of Lettuce database client tracers.
This eliminates the need of awkward method override in the common DatabaseClientTracer.
* Muzzle fix
* Format
2020-07-15 13:37:22 +03:00