e87d4ef161
Servlet3 instrumentation race consition fixes
...
* Do not set `asyncPropagate` on scope since it will be closed anyway.
* Close span once done with it in `TagSettingAsyncListener`.
* No point in explicit finishing span in 'finishOnClose' scope.
* Do not reattach listener in
`TagSettingAsyncListener#onStartAsync`. Listener is attached each
time by `Servlet3Advice#stopSpan` and reattaching listener in
`TagSettingAsyncListener#onStartAsync` causes multiple listeners to
be attached and race conditions to happen.
* Do not close span in `AsyncContextInstrumentation`. This leads to
span being written prematurely. This span will be closed in
`TagSettingAsyncListener` anyway, along with adding proper status code.
2018-11-27 17:17:56 -08:00
e46ab1d01d
Merge pull request #600 from DataDog/tyler/threadpool-errors
...
Improve error handling for ThreadPoolExecutorInstrumentation
2018-11-27 15:24:58 -08:00
2ab75e3e0b
Merge pull request #599 from DataDog/tyler/es-rest-test-fix
...
Remove ES-transport instrumentation from rest test
2018-11-27 15:22:25 -08:00
4199f924ac
Remove ES-transport instrumentation from rest test
...
It is generating an extra trace/span that in a realistic scenario would be generated by the server, not the client.
2018-11-27 13:02:44 -08:00
468ccab99a
Improve error handling for ThreadPoolExecutorInstrumentation
...
If other exceptions are thrown when trying to test the queue, it generates lots of log noise. This should handle it better.
2018-11-27 11:28:44 -08:00
1535a9ae38
Merge pull request #598 from DataDog/ark/revert-jmx-service-tagging
...
Revert "Add service name to default jmx tags"
2018-11-27 17:08:01 +00:00
6f61ddc67d
Merge pull request #594 from DataDog/mar-kolya/es-tests-stability
...
Improve stability of ES tests by avoiding unpredictable spans
2018-11-26 22:50:43 -08:00
ca2fae5e8e
Merge pull request #574 from DataDog/gary/remove-versionscan
...
Retire/remove version scan
2018-11-26 19:32:14 -05:00
90777f4b39
Retire/remove version scan
...
Remove version scan dead code and unnecessary classLoaderMatcher methods in instrumentations. Depends on #572
2018-11-26 18:21:56 -05:00
5bbc76f7b9
Merge pull request #572 from DataDog/gary/refactor-ratpack
...
Refactor Ratpack
2018-11-26 23:04:50 +00:00
477c2f92c8
Address comments and add onClose callback on context to close scope.
2018-11-26 17:26:48 -05:00
50c2af9abb
remove classloader matcher
2018-11-26 16:57:12 -05:00
51978d877f
remove version scan task from ci
2018-11-26 16:57:10 -05:00
bf30d73746
remove skipping of ratpack helper checks
2018-11-26 16:55:36 -05:00
4169e42cdc
replace version scan with muzzle block
2018-11-26 16:55:33 -05:00
6475f20308
Refactor Ratpack
...
Remove the use of the OT project and Execution managed scopes. Updated tests.
2018-11-26 16:55:18 -05:00
069880105d
Revert "Add service name to default jmx tags"
...
This reverts commit 1d2cc52747
2018-11-26 13:53:59 -08:00
467f14c359
Small fix in ES tests
2018-11-26 13:07:42 -08:00
cf033baf7e
Merge pull request #591 from henry-megarry/master
...
implementing add reference to work with opentracing-spring-cloud-starter
2018-11-26 20:06:06 +00:00
1b1527da93
Merge pull request #596 from DataDog/mar-kolya/set-gradle-heap
...
Mar kolya/set gradle heap
2018-11-26 19:39:40 +00:00
803309ad81
Merge pull request #593 from DataDog/mar-kolya/fix-kafka-latest-deps-tests
...
Do not force latest kafka-clients version since it may be incompatibl…
2018-11-26 17:54:34 +00:00
ed5692871d
Properly limit heap size for gradle child processes
2018-11-23 09:44:50 -05:00
80cd7cd500
Do testAnnotationProcessor deps.autoservice in modules with services in tests
...
Otherwise sometimes tests cannod discover services
2018-11-23 09:44:49 -05:00
ec24b8954a
Update io.franzbecker.gradle-lombok plugin
2018-11-23 09:44:49 -05:00
23203fb659
Improve stability of ES tests by avoiding unpredictable spans
2018-11-23 09:43:41 -05:00
7dae6df890
In kafka latest deps test make sure that kafka version matches kafka client libs
...
This seems to help with compatibility
2018-11-22 21:02:05 -05:00
e7f4385b0a
Merge pull request #592 from DataDog/mar-kolya/fix-springweb-tests-logs
...
Fix setup so springweb tests produce appropriate logs
2018-11-21 16:56:39 -05:00
fdffee8f5c
Fix Hysrix test to not poll queue and return null
...
Instead wait for value to appear
2018-11-21 16:25:34 -05:00
2852a6a97a
Fix setup so springweb tests produce appropriate logs
2018-11-21 16:03:19 -05:00
001c5f7349
implementing add reference to work with opentracing-spring-cloud-starter
2018-11-21 14:27:13 -06:00
f6bdb5503b
Merge pull request #590 from DataDog/mar-kolya/limit-jedis-latestdep
...
Limit Jedis latest dep tests to 2+ versions of Jedis
2018-11-21 12:24:45 -05:00
590ed30f56
Limit Jedis latest dep tests to 2+ versions of Jedis
...
Jedis 3 seems to have incompatible API changes
2018-11-21 11:43:13 -05:00
f4225ca2b4
Merge pull request #589 from DataDog/mar-kolya/remove-redundant-spark-tests
...
Remove redundant tests from SparkJava
2018-11-20 17:27:08 -05:00
a70da1d995
Remove redundant tests from SparkJava
...
Tests that create traces and do not assert on them may leave traces
behind for the next test causing errors.
2018-11-20 17:26:29 -05:00
f1fce3dae2
Merge pull request #588 from DataDog/mar-kolya/do-not-check-es-document-version
...
Do not check ES document version in Sping test
2018-11-20 15:23:55 -05:00
ca0a4a4458
Do not check ES document version in Sping test
...
ES may do things that change this version unexpectedly
2018-11-20 14:46:30 -05:00
cd9ab3daef
Merge pull request #587 from DataDog/mar-kolya/set-netty-continuation-once
...
Set netty continuation only once
2018-11-20 13:19:45 -05:00
165f05beba
Set netty continuation only once
...
Also remove continuation when getting it
2018-11-20 12:19:53 -05:00
c6a96387bb
Merge pull request #586 from DataDog/mar-kolya/better-handle-jetty-async
...
Better handle Jetty async calls
2018-11-19 18:35:57 -05:00
228e7e0d21
Better handle Jetty async calls
...
Do same thing we do for servlets
2018-11-19 14:17:01 -05:00
4c2b3e1a82
Begin 0.19.0
2018-11-16 16:35:45 -08:00
d1e8ed1202
Version 0.18.0
2018-11-16 16:04:00 -08:00
e888b170c4
Merge pull request #582 from DataDog/tyler/servlet-dispatch
...
Fix servlet async dispatch
2018-11-16 15:06:38 -08:00
e4a12409c8
Add recursive servlet dispatch tests.
2018-11-16 14:40:35 -08:00
7b6c25b399
Merge pull request #584 from DataDog/tyler/env-config
...
Add support for DD_TRACE_AGENT_PORT setting
2018-11-16 12:09:47 -08:00
59349586a5
Minor config test tweaks
2018-11-16 14:29:53 -05:00
93c046a664
Add support for DD_TRACE_AGENT_PORT setting
...
Makes this more consistent with other apm language clients.
2018-11-16 11:09:26 -08:00
e96752bbad
Remove need for tomcat user file config
2018-11-16 09:56:42 -08:00
817895b559
Extract shared tests into abstract parent
2018-11-16 09:22:47 -08:00
7d0aa4693e
Merge pull request #571 from DataDog/ark/fix-trace-counts
...
Ensure tracer traceCounter is always shared with DDApi
2018-11-16 17:05:57 +00:00
Nikolay Martynov
Tyler Benson
Tyler Benson
Andrew Kent
Gary Huang
Andrew Kent
henry-megarry