Commit Graph

1997 Commits

Author SHA1 Message Date
Nikolay Martynov 44aadf36ce
Merge pull request #619 from DataDog/mar-kolya/fix-memory-leak-in-weak-map
Mar kolya/fix memory leak in weak map
2018-12-05 17:32:42 -05:00
Nikolay Martynov 600674b03a Put back muzzle check for 'dd-' threads 2018-12-05 17:20:50 -05:00
Nikolay Martynov 7728f9918e Remove shutdown hook when DDTracer is shutdown
This is similar to the problem with weak map supplier and may lead to
a memory leak if we created/estroy many DDTracer objects.
2018-12-05 15:02:44 -05:00
Nikolay Martynov 0f4e0f40e4 Remove muzzle plugin check for dd clean up threads
This was needed to make sure that we are not leaving threads behind.
Threads were GCed before - but root cause was GC of executor
itself (see previous commit).

Now threads may stay between muzzle tasks if GC doesn't need to run
yes so this check actually creates false positives.
2018-12-05 15:02:44 -05:00
Nikolay Martynov 4deb68bfd7 Fix memory leak in WeakMapSuppliers.WeakConcurrent
The problem there is that it references JVM shutdown hook that keeps
reference to cleanup executor which potentially can keep references to
all sort of things - and this doesn't get cleaned up untill JVM
shutdown.

Solution is to remove shutdown hook when supplier is being GCed.
2018-12-05 15:02:40 -05:00
Nikolay Martynov 30712cdc87
Merge pull request #617 from DataDog/mar-kolya/java-concurrent-test-cleanup
Remove unused variable from AsyncChild classes
2018-12-05 12:35:19 -05:00
Nikolay Martynov 2e9b20ceb5 Remove unused variable from AsyncChild classes 2018-12-05 11:53:19 -05:00
Nikolay Martynov 5ab82fb85f
Merge pull request #615 from DataDog/mar-kolya/emable-ibm-jvm
Mar kolya/emable ibm jvm
2018-12-04 17:30:57 -05:00
Tyler Benson 94a3f7bb2b
Merge pull request #616 from DataDog/tyler/grpc
Enable gRPC instrumentation by default.
2018-12-04 14:28:58 -08:00
Nikolay Martynov c46763e0cb Enable IBM JVM tests 2018-12-04 17:12:44 -05:00
Nikolay Martynov 7cd3438d6b
Merge pull request #613 from DataDog/mar-kolya/improve-httpurl-connection
Improve HttpUrlConnection instrumentation
2018-12-04 17:12:01 -05:00
Tyler Benson 43e8c70098 Enable gRPC instrumentation by default. 2018-12-04 14:11:57 -08:00
Nikolay Martynov 0a3ecc1b90 Improve HttpUrlConnection instrumentation
Make sure we get one span per request
2018-12-04 16:54:48 -05:00
Tyler Benson 6cb9e0360d
Merge pull request #612 from DataDog/tyler/jms
Remove duplicate JMS spans from nested calls.
2018-12-04 11:25:56 -08:00
Tyler Benson 013e57c677 Add tests for Spring JMS Template 2018-12-04 10:54:53 -08:00
Nikolay Martynov 66570a2135 Add some synchronization into ES tests to make them more stable 2018-12-04 12:15:44 -05:00
Tyler Benson 3be4bbb7f0
Merge pull request #608 from DataDog/tyler/upgrades
Update misc versions.
2018-12-03 15:07:36 -08:00
Tyler Benson 74743be6e5 Remove duplicate JMS spans from nested calls. 2018-12-03 11:15:28 -08:00
Andrew Kent acda01a7fd Begin 0.20.0 2018-11-30 13:26:26 -08:00
Andrew Kent 81b33ef373 Version 0.19.0 2018-11-30 13:20:22 -08:00
Andrew Kent 12a1b0ce08
Merge pull request #610 from DataDog/ark/jmxfetch-new-gc-metrics
Configure jmxfetch to use new gc metrics
2018-11-30 18:54:31 +00:00
Andrew Kent 20b726bca7
Merge pull request #609 from DataDog/ark/aws-muzzle-ranges
Simplify AWS muzzle ranges
2018-11-30 18:53:05 +00:00
Tyler Benson 7939db06ae Test-sets plugin to 1.5.2 2018-11-30 10:20:12 -08:00
Andrew Kent c9471e289b Configure jmxfetch to use new gc metrics
This won't have any effect on jmx behavior. The next jmxfetch update
puts our desired metric names behind this feature flag. Enabling now
so we don't forget the next time we refresh jmxfetch.
2018-11-30 10:13:11 -08:00
Tyler Benson cb7d3bb6c6 System-rules to 1.19.0 2018-11-30 10:11:48 -08:00
Tyler Benson 983077d150 Move mock/assert deps out of common dependencies 2018-11-30 10:02:26 -08:00
Tyler Benson 272a2ace39 Lombok to 1.8.4 2018-11-30 09:40:05 -08:00
Tyler Benson c020f46906 Byte Buddy to 1.9.5 2018-11-30 09:36:31 -08:00
Andrew Kent 91f1bef6f4 Simplify AWS muzzle ranges
AWS Muzzle workaround is no longer needed with latest muzzle
optimizations.
2018-11-29 16:18:14 -08:00
Nikolay Martynov 8511fad147
Merge pull request #564 from DataDog/mar-kolya/executor-instrumentation-context-map
Make executor instrumentation using context storage
2018-11-29 15:34:12 -08:00
Nikolay Martynov 2e8dc9d08f Fix Ratpack tests that got broken by ExecutorInstrumentation refactoring
It turns out closing continuation also closes parent span. This is not
very good in cases when we end up not using continuation if
continuation in a state has already been setup.

This patch provides way to close continuation in a way that doesn't
affect parent scope.
2018-11-29 15:21:46 -08:00
Nikolay Martynov 4ec5ca394c Add code to wrap future returned by submit(Runnable) call 2018-11-29 15:18:46 -08:00
Nikolay Martynov 177c1432e3 Add tests to verify that fields are not injected when feature is disabled 2018-11-29 15:18:46 -08:00
Nikolay Martynov ad98ebc01f Add some comments and some other minor CR tweaks 2018-11-29 15:18:46 -08:00
Nikolay Martynov 1509286b15 Remove MapBackedProvider 2018-11-29 15:18:46 -08:00
Nikolay Martynov 118a61cc67 Add field backed context provider 2018-11-29 15:18:46 -08:00
Nikolay Martynov b89e73b3c0 Switch executor instrumentation to use context storage 2018-11-29 15:18:46 -08:00
Tyler Benson f47ed232f9
Merge pull request #607 from DataDog/tyler/misc
Misc small changes
2018-11-29 14:54:56 -08:00
Tyler Benson 442323d4d1 Add catch so instrumentation errors don’t interrupt primary execution. 2018-11-29 13:14:12 -08:00
Tyler Benson c9ec9ebd0f Add guard against null values in extract adapter. 2018-11-29 13:06:01 -08:00
Tyler Benson ae063e8a14 Add additional 404 tests for spring boot.
This one succeeds in applying routing, but returns a 404 response.
2018-11-29 11:32:49 -08:00
Tyler Benson 785860b6a7 Add null check for envelope in consumer delegate 2018-11-29 11:22:32 -08:00
Andrew Kent 1671a4560b
Merge pull request #601 from DataDog/ark/muzzle-gradle-plugin-memory-leak
Fix Muzzle Gradle Plugin Memory leak and optimize JVM for muzzle runs
2018-11-29 17:49:53 +00:00
Andrew Kent 3c4b480a18 Share tooling loader across muzzle runs 2018-11-28 13:01:01 -08:00
Andrew Kent e0d00078f9 Assert muzzle tooling invocations do not create orphaned dd threads 2018-11-28 12:05:47 -08:00
Andrew Kent 8cb9487546 Tune gradle JVM's max metaspace 2018-11-28 12:05:47 -08:00
Andrew Kent 6ee5fd27b0 Guard against invoking WeakConcurrent constructor 2018-11-28 12:05:47 -08:00
Tyler Benson 66b625c6a2
Merge pull request #604 from DataDog/tyler/rethrow-exception
Consumer delegate should rethrow the exception
2018-11-28 09:31:43 -08:00
Tyler Benson 2f319b9301 Consumer delegate should rethrow the exception
Previously the delegate would swallow the exception and not rethrow.

I also added a test to attempt to verify, but the exception doesn’t seem to be observable in the test.

(See #602)
2018-11-28 08:36:15 -08:00
Nikolay Martynov 1060429ba4
Merge pull request #595 from DataDog/mar-kolya/servlet-instrumentation-fixes
Servlet3 instrumentation race condition fixes
2018-11-27 17:45:20 -08:00