Commit Graph

3799 Commits

Author SHA1 Message Date
Laplie Anderson 52b5f611ea Add compiler settings for Intellij 2020-02-27 14:05:02 -05:00
Nikolay Martynov bc85e69aad
Merge pull request #1263 from DataDog/mar-kolya/dd-tags
Introduce dd.tags
2020-02-27 17:28:55 +01:00
Nikolay Martynov e8d13aad23
Merge pull request #1262 from DataDog/mar-kolya/upkeep
Upkeep
2020-02-27 15:55:16 +01:00
Nikolay Martynov 6e10eee6ee Use isEmpty 2020-02-27 15:53:48 +01:00
Nikolay Martynov 70bed6f4ac Remove javadoc from some inappropriate places 2020-02-27 15:53:47 +01:00
Nikolay Martynov 5a17e57e99 Provide `toString` for SafeExtendsClassMatcher 2020-02-27 15:53:46 +01:00
Nikolay Martynov 06b052c4d9 Minor cleanup 2020-02-27 15:53:45 +01:00
Nikolay Martynov 0752b07d92 Introduce dd.tags 2020-02-27 12:26:29 +01:00
Laplie Anderson 050298802a Begin 0.45.0 2020-02-26 16:27:50 -05:00
Laplie Anderson 7c11cc2803 Version 0.44.0 2020-02-26 16:05:53 -05:00
Tyler Benson 2ec0c1acb7
Merge pull request #1258 from DataDog/tyler/fix-whitelist-logging
Apply matcher if debug logging enabled to avoid confusing log output.
2020-02-26 08:57:17 -08:00
Nikolay Martynov 338f517db2
Merge pull request #1246 from DataDog/mar-kolya/improve-hash-calclulation-cache-pool
improve hash calculation cache pool
2020-02-26 16:22:38 +01:00
Tyler Benson eb8de0d3ab Apply matcher if debug logging enabled to avoid confusing log output.
Otherwise it was "Skipping" every unrelated class.
2020-02-25 18:04:27 -08:00
Nikolay Martynov 96f74d0fef Compare loader hashes 2020-02-25 21:53:12 +01:00
Nikolay Martynov 82dd2aa1b3 Revert "Make sure that same classloaders get same weak ref"
This reverts commit 50793e5244.
2020-02-25 21:47:42 +01:00
Nikolay Martynov 50793e5244 Make sure that same classloaders get same weak ref 2020-02-25 14:32:35 +01:00
Nikolay Martynov aefcc477cb Simplify TypePoolCacheKey equals
We have to check string equivalence regardless of classloader state
2020-02-25 11:58:18 +01:00
Nikolay Martynov 31b5652d10 Remove reference check from TypeCacheKey 2020-02-25 10:19:47 +01:00
Nikolay Martynov 41db97ea0f Merge branch 'master' into mar-kolya/improve-hash-calclulation-cache-pool 2020-02-25 10:18:25 +01:00
Tyler Benson 39e577ad97
Merge pull request #1250 from DataDog/tyler/test-matchers
Move matchers around and add unit tests.
2020-02-24 09:14:31 -08:00
Tyler Benson c13cb2e60f Move a few other classes. 2020-02-24 08:35:19 -08:00
Tyler Benson 3559ffb21c Add unit tests for matchers 2020-02-24 08:35:19 -08:00
Tyler Benson bd82166b58 Rename methods that don't require disambiguation. 2020-02-24 08:35:19 -08:00
Tyler Benson f70c35842d Move matchers to separate package and split matcher classes out 2020-02-24 08:31:12 -08:00
Nikolay Martynov 833f67816e
Merge pull request #1248 from DataDog/mar-kolya/reduce-superclass-matcher-exposure
Avoid calling superclass matcher where possible
2020-02-21 21:16:52 -05:00
Tyler Benson b27b30d913
Merge pull request #1247 from DataDog/tyler/bb-raw
Set ByteBuddy raw setting at startup
2020-02-21 16:30:24 -08:00
Nikolay Martynov b6d374e3a0 Avoid calling superclass matcher where possible
Saves about 100ms of startup time on test app
2020-02-21 15:08:39 -05:00
Tyler Benson ecf9bcc655
Make sure CallDepthThreadLocalMap is always reset (#1227)
Make sure CallDepthThreadLocalMap is always reset
2020-02-21 11:03:51 -08:00
Tyler Benson faccb0d483 Set ByteBuddy raw setting at startup
This reduces the complexity of TypeDefinitions.
```
Benchmark                                                             Mode  Cnt   Score   Error  Units
ClassRetransformingBenchmark.WithAgent.testTracedRetransform          avgt       22.450          ms/op
ClassRetransformingBenchmark.WithAgent.testUntracedRetransform        avgt        6.842          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testTracedRetransform    avgt       23.188          ms/op
ClassRetransformingBenchmark.WithAgentMaster.testUntracedRetransform  avgt        7.009          ms/op
```
It also improved startup time by about 1 sec.
2020-02-21 10:35:20 -08:00
Nikolay Martynov 1f8acafc42
Merge pull request #1245 from DataDog/mar-kolya/single-ignores-matcher
Single ignores matcher
2020-02-21 12:42:18 -05:00
Tyler Benson e4d29e37ef
Update JMH benchmarks (#1242)
Update JMH benchmarks
2020-02-21 09:38:34 -08:00
Nikolay Martynov 00c268e6d8 Add equivalence check to TypeCacheKey 2020-02-21 12:24:53 -05:00
Nikolay Martynov d4c6d86e6d Do not use zero for hashcode
Seems like this may have odd sideeffects
2020-02-21 12:24:09 -05:00
Nikolay Martynov f736c425ff TypeCacheKey are different if hash codes are different
And this is very easy to check
2020-02-21 12:23:41 -05:00
Nikolay Martynov 9d7682f776 Fix hashcode calculation in TypeCacheKey
Using potentially very large number for a mod is probably not very effective
2020-02-21 12:22:51 -05:00
Nikolay Martynov 27842d8479 Ignore cglib packaged with springboot 2020-02-21 11:56:45 -05:00
Nikolay Martynov 0c659770cc Collect all ignore matchers into one
This should allow us to optimize this as a single function later
2020-02-21 11:48:40 -05:00
Nikolay Martynov b1d314aff1 Specify types in jaxrs mtcher to help Idea with type inference 2020-02-21 11:34:25 -05:00
Nikolay Martynov e92d326052
Merge pull request #1236 from DataDog/mar-kolya/determine-agent-url-on-first-call
Determine agent URL version on first upload call
2020-02-21 07:04:49 -05:00
Lev Priima 51ca429915
Merge pull request #1235 from DataDog/lpriima/SkipClassLoaderMatcher#shouldSkipClass_by_switch
string-switch in SkipClassLoaderMatcher#shouldSkipClass(ClassLoader)
2020-02-20 21:20:06 -08:00
Lev Priima 52e0eb9d37 SkipClassLoaderMatcher use str-switch in shouldSkipClass(ClassLoader) 2020-02-20 21:02:42 -08:00
Tyler Benson 352469afde
Tomcat 10.0.0-M1 release seems to have some issues (#1243)
Tomcat 10.0.0-M1 release seems to have some issues
2020-02-20 20:51:05 -08:00
Tyler Benson a4f34f4088 Latest tomcat release seems to have some issues
Instrumentation muzzled: [jsp, jsp-compile] -- datadog.trace.instrumentation.jsp.JasperJSPCompilationContextInstrumentation on jdk.internal.loader.ClassLoaders$AppClassLoader@2c13da15
-- datadog.trace.instrumentation.jsp.JSPDecorator:39 Missing method getServletContext#()Ljavax/servlet/ServletContext;
2020-02-20 20:35:25 -08:00
Tyler Benson 5e37ca02f1
Merge pull request #1240 from DataDog/tyler/executor-matcher-reorder
Reorder java-concurrent matchers
2020-02-20 17:54:39 -08:00
Tyler Benson 660921517c
Remove costly matchers from ignore list (#1233)
Remove costly matchers from ignore list
2020-02-20 17:52:43 -08:00
Tyler Benson e1964e526e Update JMH benchmarks
Benchmark is run with `./gradlew :dd-java-agent:benchmark:jmh` -- after updating the absolute paths to the various agents in `ClassRetransformingBenchmark`.  Unfortunately I was unable to have it launch correctly with a relative path.
2020-02-20 17:30:36 -08:00
Trask Stalnaker 8949d6c05f Make sure CallDepthThreadLocalMap is always reset 2020-02-20 16:53:57 -08:00
Tyler Benson b805bf5994
Cache the result of toString in BigInteger (#1228)
Cache the result of toString in BigInteger
2020-02-20 16:10:31 -08:00
Tyler Benson da4f1dbc99
Merge pull request #1239 from DataDog/mar-kolya/change-profiling-url
Change profiling intake url
2020-02-20 16:08:38 -08:00
Heather D'Souza c0baa48487
Merge pull request #1231 from DataDog/heather.dsouza/disable_log_listeners
Create AgentBuilder with logging listeners only if in debug mode
2020-02-20 17:07:17 -05:00