7791be24e0
Remove implementations of host() and userAgent() in HTTP extractors ( #4299 )
...
* Remove implementations of host() and userAgent() in HTTP extractors
* fix broken headers copying
2021-10-05 10:25:45 -07:00
7473eff1e6
Extract HTTP request/response headers as span attributes ( #4237 )
...
* Extract HTTP request/response headers as span attributes
* fix muzzle
* code review comments
* fix compilation failure after merge conflict
* avoid using streams API when transforming the headers list
* fix liberty extractor
* fix spring webmvc extractor
2021-10-05 10:20:59 +02:00
506ae2b894
Flavor extractor ( #4274 )
2021-10-04 09:23:58 -07:00
92394ad9ae
Remove url from HttpServerAttributesExtractor ( #4209 )
...
* Remove url from HttpServerAttributesExtractor
* Remove UriBuilder
* Tracers too
* apache-camel
* Finatra
* jsp
* Ratpack
* Ratpack library
* Ratpack
* Spark
* Feedback
* Fix Undertow
* Vertx
* vertx-web
* play-2.4
* webflux
* jaxrs
* Spotless
* Update semantic-conventions.md
* Update smoke tests
* More realistic target
* Remove outdated doc
* Wording
2021-10-03 09:17:23 -07:00
c421b66d56
Remove unnecessary VirtualField#setIfNull() method ( #4262 )
2021-10-02 13:17:48 -07:00
c11b96e4d0
Make it possible to use InstrumentationContext (now VirtualField) fro… ( #4218 )
...
* Make it possible to use InstrumentationContext (now VirtualField) from library instrumentation
* fix tests
* fix javadocs
* fix some more tests
* code review comments
* setIfNull, computeIfNull
2021-10-01 11:13:11 +02:00
3f1ec4d034
Delete unused servlet tracer code ( #4243 )
2021-09-30 14:09:44 +03:00
8e54d540bb
Convert liberty instrumentation to instrumenter api ( #4205 )
...
* Convert liberty instrumentation to instrumenter api
* review comment
2021-09-28 09:22:55 -07:00
ba3370e054
Build servlet mapping resolver only when needed ( #4197 )
...
* Build servlet mapping resolver only when needed
* move factory interface to boot loader to ensure that everybody has the same class for it
* spotless
* Helper classes should not look up ContextStore on each access
2021-09-27 18:04:22 +03:00
a277a8b636
Separate HTTP client/server AttributesExtractors ( #4195 )
2021-09-24 10:06:23 -07:00
8066f2787c
Add context customizer hook to Instrumenter API ( #4167 )
...
* Add context customizer hook to Instrumenter API
* Use in tomcat instrumentation
* Some of servlet
* Use in rest of servlet
* Feedback
2021-09-22 14:54:04 -07:00
dc4ddf7932
Remove ContextStore.Factory interface; use Supplier instead ( #4157 )
2021-09-17 13:00:23 -07:00
59439cb464
Make servlet context path key private ( #4125 )
...
* Make servlet context path key private
* remove accidentally added files
* fix servlet2.2
* use non capturing lambda
* Update instrumentation/servlet/servlet-common/library/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* use method reference
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-09-16 10:23:29 -07:00
15277cf8f5
Convert servlet instrumentation to instrumenter api ( #4078 )
...
* Convert servlet to instrumenter api
* make classes final
* Remove some tracer files
* remove xxx
* fix liberty and wildfly exception smoke test
* fix async smoke test on liberty
* Apply suggestions from code review
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* generic TextMapGetter for servlets
* not going to use http.route for servlets
* simplify
* add servlet timeout in attribute extractor
* move classes from library to javaagent
* remove unneeded dependency
* make method private
* move helper class initialization to singleton, remove helpers that don't have any methods, add shouldStart checks
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/ServletRequestContext.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* add import
* rename methods that start and end spans
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-09-13 10:12:34 -07:00
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
0c2aa5eae1
Remove outdated section from servlet instrumentation readme ( #4074 )
2021-09-09 08:07:33 -07:00
dca77b6ae3
Remove unused method ( #4058 )
2021-09-07 14:56:12 -07:00
65335962de
Remove capturing lambda (optimization) ( #4014 )
...
* Remove capturing lambda
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/servlet/ServerSpanNameSupplier.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/servlet/ServerSpanNameTwoArgSupplier.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jsf/jsf-common/library/src/main/java/io/opentelemetry/instrumentation/jsf/JsfServerSpanNaming.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* checkstyle
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-08-30 20:26:00 -07:00
c91eda59b5
Small reduction in context lookups ( #4006 )
2021-08-30 09:02:52 -07:00
a2928663f4
Strict context check for tomcat and jetty ( #3923 )
2021-08-24 11:45:53 -07:00
3525733ea8
Enable strict context check in tests by default ( #3822 )
2021-08-23 17:40:02 -07:00
5c71d28ed7
Remove deprecated Config methods ( #3908 )
2021-08-23 16:44:54 -07:00
ec344b3184
Small simplification of servlet/tomcat tests ( #3710 )
...
* Small simplification of servlet/tomcat tests
* Spotless
2021-08-09 09:24:21 -07:00
d73e030000
Fix NullPointerException on tomcat ( #3705 )
...
* Fix NullPointerException on tomcat
* remove commented out line
* instrument CoyoteAdapter
2021-07-28 12:10:14 -07:00
e0cb216610
Remove remaining usages of basic span asserts ( #3616 )
2021-07-19 10:09:44 -07:00
f5ce4c03f8
Inline basic usages of basicSpan ( #3583 )
...
* Inline basic usages of basicSpan
* spock
2021-07-18 21:15:51 +03:00
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
9e4da754c2
Use consistent logger field name ( #3515 )
2021-07-07 10:47:46 -07:00
b304cc2912
Deprecate CallDepth.reset() and get() ( #3511 )
...
* Deprecate CallDepth.reset() and get()
* Don't pass CallDepth around
2021-07-07 09:24:50 -07:00
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
5d6be8764e
Remove jetty-server exclude ( #3453 )
2021-07-01 09:12:26 +09:00
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
bcb282a220
Conform to google style guide checkstyle ( #3399 )
2021-06-24 10:53:23 +03:00
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
b7bfbf0cc6
Migrate instrumentation-library / common to plugins ( #3320 )
2021-06-15 11:54:48 -07:00
7ad9e7a50b
Move shaded testing dependencies to internal package. ( #3305 )
2021-06-15 13:10:19 +03:00
0a21abe15a
Remove glassfish-testing module ( #3301 )
2021-06-15 09:03:57 +03:00
9f31a057b6
Refactor span names class ( #3281 )
...
* spanNameForMethod
* spanNameForClass
* Cache simple name using ClassValue
2021-06-14 11:56:40 -07:00
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
dc316609ee
Remove unnecessary final on params and local vars ( #3283 )
...
* Remove unnecessary final on params and local vars
* Fix gwt
* Keep final for non-initialized var
* Keep final for non-initialized var
* Keep final for non-initialized var
2021-06-14 07:13:11 +03:00
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
84cc044ddf
Migrate remaining test client calls to Armeria and remove testing-com… ( #3250 )
2021-06-11 11:51:23 -07:00
60aaff8972
Migrate HttpServerTest to Armeria ( #3240 )
...
* Migrate HttpServerTest to Armeria
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-11 08:56:02 +09:00
2436499a09
Update to Errorprone 2.7 ( #3181 )
...
* Update to errorprone 2.7
* ToString
* Finish
2021-06-04 10:40:55 +09:00
c8dc9d52a6
Move app servers to runtime dependencies. ( #3178 )
...
* Move app servers to runtime dependencies.
* Add CDI API
2021-06-04 10:01:43 +09:00
b8aec6a671
Remove no longer needed NameMatchers class ( #3179 )
2021-06-03 14:36:36 -07:00
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
796976a0f1
Workaround glassfish resolution error. ( #3116 )
2021-05-28 11:56:34 +09:00
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
c49a0bb114
Limit latest dep version for glassfish test ( #3109 )
2021-05-27 21:31:45 +09:00
df078f95a9
Extract HttpServerTest INDEXED_CHILD span attribute collection logic ( #3095 )
...
* Extrawct HttpServerTest INDEXED_CHILD span attribute collection logic
* Adjust whitespace
* Fix context issue with JAX-RS
* Rerun tests
2021-05-27 11:18:11 +03:00
fd132d463d
Change Async Servlet span end logic to fix race condition on Undertow ( #2992 )
...
* Attach servlet async listener with asyncStart instrumentation
* Exclude Spring packages containing servlet request classes from global ignores
* Exclude Tapestry HSR proxy with global ignore
* Improve comments.
* Fix for Liberty - request response when adding async listener
* Removed unused methods
* Explicit response to async listeners on all servlet engines
* Attach response to request on Jetty
* Fix broken build due to rebase, improved a comment
* Address PR comments
* Added a comment.
* Addressed PR comments
2021-05-25 20:46:37 -07:00
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
2675364897
Remove span isRecording check from servlet advice ( #3022 )
2021-05-18 08:51:24 +09:00
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
406eabef20
Simplify servlet advice ( #2972 )
...
* Simplify servlet advice
* fix sampling
* Trigger Build
* use the same logic as previously, maybe this helps agains glassfish smoke-test failure
2021-05-14 18:49:32 +03:00
f413e5a3aa
Remove RequestDispatcherAdvice ( #2942 )
2021-05-12 21:37:48 -07:00
abeca79e24
Some Gradle optimizations ( #2949 )
...
* Gradle optimizations
* Finish
2021-05-11 17:45:54 +09:00
83c7a40211
Fix potential test flakiness ( #2943 )
2021-05-09 17:04:44 -07:00
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
1579d59abd
Copy servlet3 tests to servlet5 ( #2918 )
2021-05-06 11:47:49 -07:00
357140c081
Server span naming for servlet filters ( #2887 )
...
* Server span naming for servlet filters
* wildfly default servlet has empty mappings
* jetty11 requires java11
* try a differnt way to disable jetty11 tests on java8
* Update instrumentation/servlet/servlet-5.0/javaagent/src/test/groovy/TomcatServlet5FilterMappingTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* review fix
* rework to use InstrumentationContext
* remove debugging code
* move MappingResolver to avoid ClassCastException on wildfly
* Update instrumentation/servlet/servlet-3.0/javaagent/src/test/groovy/TomcatServlet3FilterMappingTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* review fixes
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-06 13:25:17 +03:00
109318b404
Implement concurrency test for Async Servlets ( #2899 )
2021-05-04 12:54:20 +03:00
1824e36b96
Better server span name for Grails and Wicket ( #2814 )
2021-04-22 14:16:54 -07:00
46c1212236
Remove forward and include spans ( #2816 )
2021-04-22 11:36:53 -07:00
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
9bd028f767
Remove unnecessary genericness ( #2797 )
2021-04-14 00:01:28 -07:00
078603caf5
Generate InstrumentationModule#contextStore() with muzzle ( #2775 )
2021-04-13 20:05:01 -07:00
819efb573f
Run glassfish tests with headless ( #2781 )
2021-04-12 15:54:54 -07:00
38e98ebdad
Implement concurrent test for Vert.x http server ( #2749 )
...
* Implement concurrent test for Vert.x http server
* Format
2021-04-08 09:27:11 +03:00
3bd46091bc
Clean up request dispatcher instrumentation ( #2724 )
2021-04-06 13:36:38 -07:00
7027006f66
Request handlers and test images for Tomcat 10 and Jetty 11 (Servlet API 5) ( #2703 )
...
* Tomcat 10 and Jetty 11 handlers with Servlet API 5
* Jetty 11 and Tomcat 10 Windows images
2021-04-05 09:45:02 -07:00
86ec1d7211
Concurrent server test ( #2680 )
...
* Concurrent server test
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-04-05 14:12:07 +03:00
cc47da585b
New Instrumenter API ( #2596 )
...
* Instrumenter
* Spotless
* More instrumenter
* More
* Instrumenter API
* New Instrumenter API - InstrumenterBuilder (#20 )
* New Instrumenter API - InstrumenterBuilder
* New Instrumenter API - InstrumenterBuilder - code review comments
* Start doccing
* Docs
* Most tests
* Last test
* Stick with current hostName lookup for now
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* New Instrumenter API - code review comments (#21 )
* Doc
* Checkstyle
* Cleanups
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-04-05 15:45:07 +09:00
69c2644774
Servlet 5 API, reorganize servlet modules ( #2609 )
...
* Servlet 5.0 API support, refactored other servlet modules
* Include correct servlet instrumentation module for grails tests
* Reapply spotless after rebase
* Fix checkstyle
* Spotless
* Addressed PR suggestions
* Fixed files in wrong package.
* Fixed mixed up instrumentation names.
* Fixed incomplete instrumentation name.
* Addressed PR suggestions
* Addressed PR suggestions
2021-03-23 14:11:43 +02:00
811259376e
Update servlet attr names to match log attr names ( #2593 )
2021-03-18 14:03:06 +02:00
f3ba2302eb
Remove unnecessary libs from the javaagent shadowJar ( #2566 )
...
* Remove unnecessary libs from the javaagent shadowJar
And make it a bit lighter: 36 MB -> 21 MB
* Apply code review comments
* Remove unnecessary kotlin exclusion
2021-03-16 10:47:05 +01:00
29790d8472
Low cardinality name for servlet span ( #2417 )
2021-03-04 12:39:37 -08:00
8242a01b3a
Clean up and document BaseTracer ( #2482 )
2021-03-04 11:21:46 +01:00
e39b0b44c9
Fix flaky tomcat access log tests ( #2448 )
2021-03-01 17:41:44 +02:00
b4c8354b56
Hide non-specd attributes behind experimental flag ( #2376 )
2021-02-24 12:33:21 -08:00
1ca7276593
Remove HttpServerTest.testExceptionBody and redirectHasBody ( #2346 )
2021-02-19 15:57:11 +02:00
bc77ab0c82
jetty 9.4 behave differently from earlier versions ( #2335 )
2021-02-18 15:38:45 -08:00
80f389c778
Instrument all jetty handlers ( #2320 )
2021-02-18 11:51:48 +02:00
ee090aee1e
Support library instrumentations with HttpServerTest & HttpClientTest ( #2299 )
2021-02-16 09:05:23 -08:00
e76d3b19d1
Fix ServletContextPath.prepend for app server spans ( #2089 )
...
* ServletContextPath.prepend doesn't work when server span is created from app server integration
* move ServletContextPath context creation to servlet-common, make servlet2&3 depend on servlet-common so that it would be used in tests that depend on servlet3
* fix failing test
* add servlet-common dependency to modules that depend on servlet3
* add servlet-common dependency to mojarra and myfaces
* run context path instrumentation after servlet instrumentation
* add servlet-common dependency to wicket
* move servlet context path handling
* enable jetty instrumentation for all handlers
* run springmvc tests with tomcat integration, fix peer port and peer ip reporting on tomcat
* jetty integration is now enabled for all handlers
* update expected span name
* Revert "jetty integration is now enabled for all handlers"
This reverts commit 82cbb663f5c034496fc58a3d077600
2021-02-15 23:34:15 -08:00
0adeb85f43
Refactor InMemoryExporter and move some of its methods … ( #2264 )
...
* Refactor InMemoryExporter and move some of its methods to spock base class & junit extension
* codenarc
* spotless
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix armeria library tests
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-15 17:36:14 +01:00
0fbdcad1dd
Make BaseTracer#startSpan() return Context ( #2232 )
...
* Make BaseTracer#startSpan() return Context
* Update instrumentation/apache-camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/CamelEventNotifier.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
* Add Javadocs to BaseTracer
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-12 12:12:40 +01:00
ecf64c25f3
Remove BaseTracer#startScope() method ( #2224 )
...
* Remove BaseTracer#startScope() method
* fix compilation failure
2021-02-10 11:39:38 +01:00
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
93b3a3b289
testing-common refactoring: replace direct AgentTestRunner usage with… ( #2134 )
...
* testing-common refactoring: replace direct AgentTestRunner usage with spock spec
* Updated instrumentation docs
* Fix reactor-core library tests
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
2021-02-01 11:32:25 +01:00
4c1144ce78
Distinguish between the various servlet tracers for easier debugging. ( #1979 )
...
* Distinguish between the various servlet tracers for easier debugging.
* change to use the `common` suffix for that module
* Update instrumentation/servlet/servlet-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/Servlet2HttpServerTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3HttpServerTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/dispatcher/RequestDispatcherTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/http/HttpServletResponseTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-01-20 16:33:13 +02:00
9825ab0afa
Instrument jsf action calls ( #2018 )
2021-01-19 21:34:41 -08:00
660f0e5225
Remove testing-common dependency on guava ( #2062 )
...
* Remove testing-common dependency on guava
* Use nano time
* Add guava dep to opentelemetry-api-metrics
2021-01-19 12:07:27 +09:00
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
11ad12289b
Jetty server span handling ( #2029 )
2021-01-14 09:31:57 -08:00
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
5f816c5d43
Enable servlet forward and include tests ( #1968 )
2021-01-06 11:01:47 -08:00
2b97c42e01
Improve servlet22 response status handling ( #1985 )
...
* imporve servlet22 response status handling
* Update instrumentation/servlet/servlet-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/Servlet2Advice.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-06 14:02:51 +09:00
8d74baa2e4
Run tests with javaagent. ( #1643 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-04 13:13:24 -08:00
79433966fb
Liberty server span handling ( #1929 )
...
* Liberty server span handling
* review fixes
* review fixes
* add doc about using compile stubs
* Update instrumentation/liberty/liberty/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/liberty/LibertyInstrumentationModule.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
* Update instrumentation/liberty/liberty/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/liberty/ThreadLocalContext.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
* add links to advice classes
* add commnet, remove unneeded dependency
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2020-12-22 15:00:58 +02:00
0888711574
Add support for Undertow server runtime ( #1917 )
...
* Add support for Undertow server runtime
* Polish
* Damn be classloaders
* Fix correct span name
* Polish
2020-12-22 14:13:50 +02:00
4ddc2d28f9
correct link in javadoc ( #1956 )
2020-12-22 14:12:43 +02:00
135ba344cb
Tomcat server handlers ( #1902 )
...
* Tomcat server handler with passing integration and smoke tests.
* Update server span name from the servlet integration instead of trying to mimic it from the server handler.
* Cleanup and more javadocs.
* Use Java8BytecodeBridge in advice code.
* Use Java8BytecodeBridge in advice code.
* Use earliest version for compilation and muzzling.
* Use consistent instrumentation name.
* Record throwables only if the context is managed by something else.
* Getting scope handling right. Moved server span renaming logic via AppServerBridge to the ServletHttpServerTracer.
* codenarc
* more PR comments addressed
* Pass Method to startServerSpan
2020-12-16 16:59:54 +02:00
fa09451aea
Prefix custom attributes with instrumentation name ( #1784 )
2020-12-03 20:56:31 -08:00
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
0bd85d7b7f
Pass around context more instead of span (HttpServerTracer) ( #1810 )
2020-12-01 14:49:01 -08:00
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
41bd489a77
Format groovy files ( #1793 )
2020-11-28 21:22:14 -08:00
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
45646ff367
Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization() ( #1741 )
...
* Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization()
* Removed no longer needed comments & improved JavaDoc
* Improve TypeInstrumentation Javadoc
2020-11-24 14:27:58 +02:00
79f76c78ad
Move java files to java source folder and groovy files to groovy source folder ( #1735 )
...
* Move java files to java source folder
* Move groovy files to groovy source folder
* Too much
* Move another one back
* Codenarc
* Move test resource to where test is
* Spotless
2020-11-23 15:42:04 +02:00
e092e87d6b
Remove disabled by default servlet instrumentation ( #1684 )
2020-11-19 11:22:02 -08:00
80b068b459
Instrument java.servlet.Filter directly ( #1606 )
...
* Instrument filter directly
* Remove some additional ignores
* Fix OncePerRequestFilter not being instrumented itself
2020-11-18 19:59:28 -08:00
cecdfc2cd0
Update instrumentation names to be consistent ( #1671 )
...
* Update instrumentation names to be consistent
* Remove amqp from rabbitmq package name
2020-11-18 19:53:31 -08:00
1a23ac3027
Standardize instrumentation names in InstrumentationModules ( #1648 )
...
* Standardize instrumentation names in InstrumentationModules
* rename gradle modules:
* vertx-3.0 to vertx-web-3.0
* spark-web-framework-2.3 to spark-2.3
* add JavaDoc describing the naming rules to InstrumentationModule
2020-11-17 13:30:28 -08:00
6d5ec329d6
Enable checkstyle for google style guide ( #1641 )
2020-11-16 18:46:59 -08:00
9d2db827b9
Refactor Instrumenters into InstrumentationModules - R, S, T, V ( #1576 )
2020-11-09 18:48:52 -08:00
71f91877ab
Fix muzzle and add missing helper classes ( #1585 )
...
* Fix muzzle
* Fix jdbc instrumentation
* Fix jms instrumentation
* Fix couchbase instrumentation
* Fix servlet instrumentation
2020-11-08 13:54:00 -08:00
d3b60a5e33
Rename TRACER to tracer() ( #1540 )
2020-11-02 20:49:51 -08:00
c6eee70660
Update to latest snapshot. ( #1524 )
2020-10-29 18:54:09 -07:00
dfda406fee
Migrates to using a context when span is started ( #1525 )
...
* Return Context when starting span to preserve baggage.
Co-authored-by: Marcin Grzejszczak <marcin.grzejszczak@gmail.com>
* Use bridge
Co-authored-by: Marcin Grzejszczak <marcin.grzejszczak@gmail.com>
2020-10-29 13:50:54 +02:00
f046e598c6
Add context root to the front of the route in the span name ( #1418 )
...
* Add application root to span name
* Reduce duplicate context lookups
* Use servlet path as route
* Test against jetty instrumentation
* Add JAX-RS context path test
* Fix JAX-RS 1.0 span names
2020-10-27 14:21:10 -07:00
a2dccf2316
Update to latest SDK snapshot. ( #1479 )
2020-10-26 19:29:46 -07:00
7244dbf188
Remove unnecessary overrides ( #1477 )
2020-10-25 21:46:14 -07:00
3565775b00
Format groovy ( #1475 )
...
* Apply Intellij format to groovy
* spotless
2020-10-26 11:47:12 +09:00
f6ad05b8e3
Update to latest SDK snapshot ( #1384 )
...
* Update to latest SDK snapshot
* Use published snapshot
* Fixes
* Cleans
* spotless
* Most
* Clean
* Merge
* Temporarily remove context interop
* WIP
* Prepare for intercepting propagated span
* Bump SDK
* IDE updates
* Lots
* compileJava
* Done?
* bar
* Spot
* drugs
* Groovy--
* green for me
* Spot
* Remove grpc import
* Scrub
2020-10-25 15:14:32 +09:00
9e8d663ba4
Remove apache httpclient version ( #1446 )
...
* Remove version from `apache-httpclient` instrumentation
Fixes : #1260
* Remove version from all instrumentation names and add instrumentation name to `spring-web`
Fixes : #1260
2020-10-22 14:22:44 +09:00
57301e3fe7
Rename "integration" to "instrumentation" ( #1412 )
...
* Rename integration to instrumentation
* Revert doc changes, need to wait for release
* spotless
2020-10-19 14:36:30 +09:00
7ecc9bb37b
Rename "auto" to "javaagent" in modules ( #1370 )
2020-10-13 12:32:13 -07:00
c739f7db6b
Remove unnecessary scopes ( #1351 )
2020-10-11 14:31:37 -07:00
1b51d4a6b1
Rename packages ( #1367 )
2020-10-11 13:54:35 -07:00
409530629f
Refactor all tests that use Config so that they don't fail locally ( #1310 )
...
* Refactor all tests that use Config so that they don't fail locally
* Use ConfigUtils in tests for all config-related things
* Fix spotless and codenarc
* Fix spotless
* PR comments: remove unnecessary config
2020-10-08 20:01:31 +03:00
9523f9ffe6
fix and/or ignore spotbugs errors ( #1325 )
2020-10-06 19:39:17 -07:00
5bba5d8482
Update to latest snapshot ( #1331 )
...
* Update to latest snapshot
* Update to latest snapshot
* instrumentation-api
* spotless
2020-10-06 17:47:41 +09:00
f2de47a150
SpanAssert method names should reflect underlying Span method names ( #1307 )
2020-10-05 16:04:08 +09:00
dadaac9a8c
Use 2-line license header to match SDK repo ( #1321 )
...
* Use 2-line license header to match SDK repo
* Apply change
2020-10-05 14:29:56 +09:00
f2194a928c
Update to latest snapshot. ( #1304 )
2020-10-04 19:41:10 -07:00
57ead9532a
Fix typos in servlet docs ( #1302 )
...
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
2020-10-02 17:31:15 +03:00
7b1b399a29
Convert more decorators to tracers ( #1275 )
...
* More decorators to tracers
* Convert more decorators to tracers
* Fixes
2020-09-29 09:41:09 +03:00
8954f222c0
Update to the latest opentelemetry-java 0.9.0-SNAPSHOT ( #1266 )
2020-09-26 20:44:28 -07:00
7e41b516ee
Review semantic convention for Http Server spans ( #1207 )
...
* Review semantic convention for Http Server spans
* Polish
2020-09-16 09:52:11 +03:00
912a159c19
Update to latest SDK snapshot. ( #1202 )
2020-09-15 17:49:10 +09:00
79b2ce3a90
Fix Servlet instrumentation for servlet-api 3.1+ - remove output stream wrapper ( #1167 )
2020-09-09 15:31:05 +03:00
fbd4018e4b
Don't run latest deps test for servlet-common ( #1051 )
2020-08-19 14:55:09 +09:00
bbfdbb39c0
Create abstraction for library dependencies for instrumentation. ( #977 )
...
* Create abstraction for library dependencies for instrumentation.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-08-19 08:57:31 +09:00
7159d04b8d
Change groovy import order ( #1013 )
...
* Update docs
* Format all groovy code
* Organize imports
2020-08-15 23:19:27 -07:00
414213f2d1
Remove final from parameters ( #1003 )
2020-08-15 22:35:51 -07:00
f893ca540b
Scripted package renaming ( #988 )
2020-08-15 21:55:01 -07:00
bb235a0aa3
Update package name for tracers ( #991 )
2020-08-14 21:07:18 -07:00
f940b2d2de
Use OpenTelemetry.getTracer() shortcut ( #965 )
2020-08-14 07:11:06 +03:00
7818e33178
Package renaming ( #970 )
2020-08-13 20:14:46 -07:00
e26801482c
Add document describing current problem with context propagation ( #910 )
...
* Add document describing current problem with context propagation
* Update docs/contributing/inter-thread-context-propagation.md
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update docs/contributing/inter-thread-context-propagation.md
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* More clarifications
* More clarifications
* Better example
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-08-12 20:33:07 +03:00
b5fbf90977
Extract instrumentation api module ( #884 )
2020-08-09 22:52:33 -07:00
46dfa263af
Remove HttpServerTestAdvice ( #897 )
...
* Remove HttpServerTestAdvice
* Trying to fix
2020-08-06 13:05:55 +03:00
303d8f427f
Add response generic parameter to HttpServerTracer ( #870 )
2020-08-03 12:52:55 -07:00
5dc2ca350a
Update config property prefix from ota to otel ( #841 )
...
* Update config property prefix from ota to otel
* more
* format
* more
2020-07-31 08:29:29 +03:00
adab0efcd6
feat(tags): http ( #827 )
...
flavour, user agent, client ip
2020-07-29 23:57:12 -07:00
f6594e1a67
Use Span.recordException for logging throwable ( #813 )
...
* Use Span.recordException
* Fix tests
* Cleanup
* Update instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Spotless (IntelliJ acts weird with groovy files for me :()
* Update for merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-07-28 14:44:42 +09:00
688733ad43
Update OTel snapshot to 723 for recordException ( #786 )
...
* Update OTel snapshot to 723 for recordException
* Fix various servlet issues
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-07-27 14:32:05 +09:00
fcf4319aac
Faster tests ( #725 )
...
🎉
2020-07-22 10:10:34 -07:00
d6e39f89e6
feat(servlet): content length ( #726 )
2020-07-21 20:24:32 -07:00
86c438b154
Remove final from local variables ( #732 )
...
* Remove final from local variables
2020-07-20 13:53:34 +09:00
d8355c672d
Docs for writing new instrumentation... ( #652 )
...
* Docs for writing new instrumentation
2020-07-19 14:21:19 +09:00
f3421e91a0
Remove Lombok ( #672 )
...
* Gradle 6.5.1.
* Skip download javadoc and sources automatically in IntelliJ IDEA.
* Added mavenLocal to repositories.
* Removed Lombok usage.
* Removed duplicated idea config.
* Code format.
* Removed useless usage of Objects.requireNonNull.
* Use instanceof to comparing objects.
* Code format.
* Code format.
* Fixes after merge.
* Fixed sneakyThrow exception.
* Code format.
2020-07-18 15:52:55 +03:00
9f1ffbe38c
Remove attribute `span.origin.type` ( #712 )
2020-07-16 10:00:45 -07:00
763779e08a
Move servlet instrumentations around ( #601 )
2020-07-08 16:43:36 -07:00
b78abac82c
#598 Rename "tags" to "attributes" ( #645 )
2020-07-07 21:03:41 -07:00
a62801649f
More fixes for Gradle warnings ( #643 )
...
* More gradle deprecation warnings fixed
* More gradle deprecation warnings fixed
* More fixes
* More fixes
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2020-07-07 15:02:07 +03:00
3a4470f800
Server spans ( #634 )
...
* Milestone 1
* Netty 4.1 done
* Netty 4.0 done
* Netty 3.8 done
* All tests pass
* Test fix
* Last proper server tracers done
* Format fix
* Tests fixed
* Polish
* Polish
2020-07-07 13:48:51 +03:00
4f48cf6565
Remove response -> request context store ( #630 )
...
* Simplify response to request context store
* Remove response to request context store
* Fix test
2020-07-05 14:39:38 +03:00
4a943c8411
Use Spotless for formatting ( DataDog/dd-trace-java#1619 )
2020-06-30 11:15:48 -07:00
45dc02d964
Fix Spring handler mapping affecting character encoding ( DataDog/dd-trace-java#1595 )
2020-06-30 11:13:20 -07:00
de1fb295cb
Now publish all instrumentations as well. ( #565 )
...
* Now publish all instrumentations as well.
Changed groupId to `io.opentelemetry.instrumentation`.
Removed `opentelemetry` from auto-exporters' artifactIds.
Some instrumentations will need moving around to have better names, e.g. servlets. Should I do it right away?
* Polish
* Unify names of published artifacts
* Renamed some modules
* Fix CI config
* Rename project-reactor back to reactor
2020-06-27 08:57:24 +03:00
bfd7f4428d
Propagate full Context while processing http server requests ( #573 )
...
* Propagate full Context while processing http server requests
2020-06-26 20:13:12 +03:00
874b157fe5
Newline between license and package. ( #581 )
2020-06-25 13:31:16 -07:00
9a52f6708e
Gradle dependencies cleanup ( #556 )
...
* Bootstrap fixed
* Tooling fixed
* Testing fixed
* All instrumentation tests pass
* All tests pass
* Fix test
* Muzzle workaround
* Muzzle fix
* Update instrumentation/trace-annotation/trace-annotation.gradle
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-06-24 12:01:14 +03:00
4e836f1c72
Replace remaining named disjunctions with namedOneOf or namedNoneOf ( DataDog/dd-trace-java#1584 )
2020-06-23 14:08:45 -07:00
0fad251165
Introduce matcher for membership of a set of names ( DataDog/dd-trace-java#1583 )
2020-06-23 14:08:45 -07:00
126c972864
Optimization for expensive type matcher ( #558 )
2020-06-22 19:17:34 -07:00
4a26bd3ce7
Simplify setting of user.principal attribute ( #509 )
2020-06-13 12:11:03 +03:00
4b665dcbe2
Changed instrumentation tracer" TRACER.startSpan() to never return `null` ( #499 )
2020-06-12 16:15:38 -07:00
1b29184e7c
Make rootDir usage consistent ( DataDog/dd-trace-java#1518 )
2020-06-11 10:14:02 -07:00
8ee54389da
Try to fix flaky test by replacing list comparison with set comparison ( #480 )
2020-06-08 20:00:38 +03:00
357fb6e989
Deduplicate servlets ( #469 )
...
* Servlet instrumentations unified
* Grizzly migrated
* Fix tests after merge
* Polish and fix tests
* Polish and fix tests
* Muzzle fixes
* Muzzle fixes
* Muzzle fixes
* Test fixes
* One more check fixed
* Stop using SpanWithScope
* Test fix
* Compilation fix
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update agent-bootstrap/src/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/HttpServerTracer.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Polish
* Tracer does not manage scope anymore
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-06-08 10:49:58 +03:00
3bb17e1c3c
Remove deprecated usage from internal instrumentation ( DataDog/dd-trace-java#1441 )
2020-05-26 11:54:55 -07:00
e9096bb60d
Fix java google format ( #439 )
2020-05-26 08:42:48 +03:00
6c8cd2e7f2
Change names of servlet based server spans ( #428 )
...
* Add documentation describing non-obvious points of Servlet instrumentations
* Change names of servlet based server spans
2020-05-25 12:53:12 -07:00
6d0d3f54ce
Enable the following instrumentation by default: grizzly, jetty, spark-java ( #407 )
2020-05-17 10:19:35 -07:00
fbf31d3a39
Don't listen 0.0.0.0 in tests ( DataDog/dd-trace-java#1434 )
2020-05-14 11:50:31 -07:00
f540ae8fc1
Add null servlet context check ( DataDog/dd-trace-java#1414 )
2020-05-14 11:50:30 -07:00
6d1a58d151
Merge tag 'v0.50.0' into correct-history
2020-05-05 12:41:08 -07:00
9568ba079b
Use Builder::setAttribute whenever possible ( #348 )
2020-04-27 13:51:34 -07:00
Mateusz Rzeszutek
Trask Stalnaker
Lauri Tulmin
Matthew Ho
Anuraag Agrawal
Ago Allikmaa
Nikita Salnikov-Tarnovski
John Watson
Pavol Loffay
Vladimir Šor
Vadim Shaigorodskiy
Ioannis Mavroukakis
Pavol Loffay
Helen Y
Frank Spitulski
Frank Spitulski
Alexey Zhokhov
Sergei Malafeev
Tyler Benson
Laplie Anderson
Richard Startin
Lev Priima
Pontus Rydin