315ae67fd2
Merge branch 'twilio' of github.com:darylrobbins/dd-trace-java into twilio
...
* 'twilio' of github.com:darylrobbins/dd-trace-java:
Updates to handle async calls, which have broken all tests
Missed Gradle file
WIP Twilio SDK Instrumentation
# Conflicts:
# dd-java-agent/instrumentation/twilio/src/main/java/datadog/trace/instrumentation/twilio/TwilioClientDecorator.java
# dd-java-agent/instrumentation/twilio/src/main/java/datadog/trace/instrumentation/twilio/TwilioInstrumentation.java
# dd-java-agent/instrumentation/twilio/src/test/groovy/test/TwilioClientTest.groovy
Merge branch 'twilio' of github.com:darylrobbins/dd-trace-java into twilio
Improved unit testing
* 'twilio' of github.com:darylrobbins/dd-trace-java:
Updates to handle async calls, which have broken all tests
Missed Gradle file
WIP Twilio SDK Instrumentation
# Conflicts:
# dd-java-agent/instrumentation/twilio/src/main/java/datadog/trace/instrumentation/twilio/TwilioClientDecorator.java
# dd-java-agent/instrumentation/twilio/src/main/java/datadog/trace/instrumentation/twilio/TwilioInstrumentation.java
# dd-java-agent/instrumentation/twilio/src/test/groovy/test/TwilioClientTest.groovy
Fix sleep times and choose Java7-friendly test dependencies
Corrected test assertion
2019-04-16 13:56:44 -07:00
13aa267d84
WIP Twilio SDK Instrumentation
...
Missed Gradle file
Updates to handle async calls, which have broken all tests
2019-04-16 13:56:44 -07:00
e3d97b0984
WIP Twilio SDK Instrumentation
...
Missed Gradle file
Updates to handle async calls, which have broken all tests
Fixed instrumentation and augmented tests
2019-04-16 13:46:43 -07:00
0315c976af
Fixes for ratpack.
2019-04-16 13:29:26 -07:00
b343fe4551
Split peer connection details different generic argument
2019-04-16 08:34:43 -07:00
bf05984208
Server tags should report peer, not self hostname/port
...
Previously this was not obvious and incorrect.
2019-04-16 08:21:01 -07:00
dc2e435de9
Merge pull request #797 from DataDog/tyler/ratpack
...
Update ratpack instrumentation and remove default disabled.
2019-04-16 08:14:10 -07:00
f4a17ba4c5
Remove tests that relied on inner knowledge of the class. Feature still tested with cglib test.
2019-04-12 17:12:50 +02:00
ff021f34db
Add minor fixes to comments and typos as per code reviewer suggestions
2019-04-12 16:51:49 +02:00
c6863f0ca3
Use groovy class reference style in Spock tests
2019-04-11 16:06:46 +02:00
e8435b165d
Fixed typo in comment
2019-04-11 15:49:10 +02:00
3a6fedda14
Add context getter/setter methods to an object only if not already defined
...
Class `FieldBackedProvider` uses ByteBuddy to add a field and its respective getters and setters to store the context object.
Assuming that we have a class `A` that implements runnable and that we wrap with a `FieldBackedProvider`
`Runnable` interfaces, if later on we use a cglib's `Enancher` class on `A` then the our mechanism will kick in again and try
to add the methods again. This causes a `java.lang.ClassFormatError: Duplicate method name "get__datadogContext$java$lang$Runnable" with signature "()Ljava.lang.Object;"`
to be thrown because CGLIB already copied over those methods from the original class `A` to the newly created class.
With this commit we now check that method were not previously defined before adding them, and if they were then we avoid adding them
again.
The reason why it wasn't faiing before is that we only checked on context field existence, not methods and cglib do not copy over fields, it copies only methods. E.g.
```
public class Main {
public static class A {
private String name = "hey";
public String getName() {
return this.name;
}
}
public static void main(String[] args) {
System.out.println("----- 'A' declared fields -----");
A s = new A();
for (Field f : s.getClass().getDeclaredFields()) {
System.out.println("field: " + f.getName());
}
for (Method m : s.getClass().getDeclaredMethods()) {
System.out.println("method: " + m.getName());
}
System.out.println("----- Proxy declared fields -----");
Enhancer enhancer = new Enhancer();
enhancer.setSuperclass(A.class);
enhancer.setCallback((FixedValue) () -> null);
A proxy = (A) enhancer.create();
for (Field f : proxy.getClass().getDeclaredFields()) {
System.out.println("field: " + f.getName());
}
for (Method m : proxy.getClass().getDeclaredMethods()) {
System.out.println("method: " + m.getName());
}
}
}
```
Results in:
```
----- 'A' declared fields -----
field: name
method: getName
----- Proxy declared fields -----
field: CGLIB$BOUND
field: CGLIB$FACTORY_DATA
field: CGLIB$THREAD_CALLBACKS
field: CGLIB$STATIC_CALLBACKS
field: CGLIB$CALLBACK_0
field: CGLIB$CALLBACK_FILTER
method: equals
method: toString
method: hashCode
method: clone
method: getName
method: newInstance
method: newInstance
method: newInstance
method: setCallbacks
method: CGLIB$SET_STATIC_CALLBACKS
method: CGLIB$SET_THREAD_CALLBACKS
method: getCallback
method: getCallbacks
method: CGLIB$STATICHOOK1
method: CGLIB$BIND_CALLBACKS
method: setCallback
```
2019-04-11 15:45:43 +02:00
c4ac5b94ec
Fix span relationships and other review issues.
2019-04-10 17:31:22 -07:00
e41769232e
Fix AWS instrumentation warning in Idea
...
Idea complains about duplicates root because we run latest dep tests
and 'later version' tests from the same dir. This is ultimately
TestSetd plugin bug by the looks of it, but we can work around it by
swapping old and new version tests.
Also run both old and new version tests under 'test' task.
2019-04-09 10:50:07 -04:00
a11b888d7a
Update ratpack instrumentation and remove default disabled.
2019-04-08 18:26:08 -07:00
229e8ef51b
Fix JMXFetch log level
2019-04-08 09:48:49 -07:00
6fd630831f
Stop using `scopeManager().activate(span, true)`
2019-04-08 11:54:47 -04:00
f4791a17df
Use decorators in Netty's ChannelFutureListenerInstrumentation
2019-04-08 11:35:13 -04:00
7b53cebd3d
Fix some compiler warnings
2019-04-05 12:58:54 -04:00
a5b5d236e1
Use Scope when opening span in netty instrumentation
2019-04-05 11:13:53 -04:00
e678a62e5b
Use scope when opening JMS span
2019-04-05 11:13:53 -04:00
4119059e70
Jaxrs: use scope when span is opened
2019-04-05 11:13:53 -04:00
0e7418fde6
AWS v2: use scope when span is created
2019-04-05 11:13:53 -04:00
480a14b170
OkHttp: rearrange scope code a bit
2019-04-05 11:13:53 -04:00
1af7487201
Wrap Rabbitmq channel span into scope
2019-04-05 11:13:53 -04:00
743ab327b0
Wrap GRPC span start into scope
2019-04-05 11:13:53 -04:00
a1e23dfb86
Make sure span is opened and closed with scope in Cassandra
2019-04-05 11:13:53 -04:00
bddee3d6e2
Make sure span is opened and closed with scope in Mongo
2019-04-05 11:13:53 -04:00
f3e1eb4f5d
Make sure span is opened and closed with scope in Couchbase
2019-04-05 11:13:53 -04:00
2bba4c5591
Make sure span is opened and closed with scope in spymemcached
2019-04-05 11:13:53 -04:00
bfb48f31c1
Make sure span is opened and closed with scope in http_url_connection
2019-04-05 11:13:53 -04:00
997832ba4e
Limit hibernate integration tests to 5.x.x since we do not support 6+
2019-04-05 10:43:16 -04:00
93621fac17
Specify hibernate latest dep test deps for 4.0 tests
2019-04-05 09:26:14 -04:00
c104be1fa7
Add compile dep on scala to make Idea happy
2019-04-03 13:59:25 -04:00
e3488d23a2
Netty: do not use deprecated constants
2019-04-03 13:58:54 -04:00
a245ec4949
Upgradle gradle
2019-04-03 12:56:15 -04:00
de980c2d52
Merge pull request #787 from DataDog/mar-kolya/compiler-config-fix
...
Mar kolya/compiler config fix
2019-04-01 09:15:39 -04:00
212d4d3c71
Provide Java compiler with bootstrap classes for Java7
...
when compiling Java7-compatible sources.
2019-03-29 13:53:53 -04:00
2c282552dc
Fix comment
2019-03-29 17:26:43 +01:00
ff17ed166b
Fix code style in cassandra integration
2019-03-29 16:38:32 +01:00
dfecfc8329
Fixed typo in comments (follow-up)
2019-03-29 14:15:25 +01:00
1e69fb7234
Have cassandra integration to work with recent versions of Guava.
...
Recent versions of Guava removed method 'Futures::transform(input, function)' in favor of 'Futures::transform(input, function, executor)'.
This commit manually retrieve the executor as it was done in Guava 20 in the overloaded method.
See: 65f6b4f4b1/guava/src/com/google/common/util/concurrent/AbstractTransformFuture.java (L58)
2019-03-29 13:42:46 +01:00
3b0e769e88
Fix helper injection in context provider
...
Currently helpers will not be injected if instrumentation doesn't
apply. Unfortunately it is possible for some classes to have context
fields added even if instrumentation is not allied (i.g. instrumented
classes are not used). Fix this by always injecting all helpers if we
inject context fields.
2019-03-26 15:53:34 -04:00
004c44d70c
Add tests confirming that Spring Data Repos aren’t working
...
The hibernate instrumentation doesn’t seem to work with Spring Data JPA.
2019-03-25 11:58:16 -07:00
a73b8c36f0
Review changes.
2019-03-25 09:56:05 -07:00
26a0194b84
Prevent instrumentation’s Context from applying if Muzzle fails
...
This can cause problems if muzzle prevents an integration from loading because the class for the new field being added may not be injected. This results in an error:
```
Caused by: java.lang.NoClassDefFoundError: datadog/trace/bootstrap/instrumentation/context/FieldBackedProvider$ContextAccessor$org$hibernate$Session$datadog$trace$bootstrap$instrumentation$hibernate$SessionState
```
2019-03-25 08:19:44 -07:00
63b5c094e7
Fix NPE in hibernate instrumentation
...
Also add each hibernate instrumentation project as a test dependency to the others. This demonstrates a problem with muzzle and instrumentation context which currently causes the tests to fail.
2019-03-22 17:06:19 -07:00
b22b11b9b0
Add timeout test for V2
...
Also make sure span is closed on error.
2019-03-21 18:08:35 -07:00
8d96729ae8
Fix instrumentation and add tests to verify.
2019-03-21 18:08:35 -07:00
3a3705f708
AWS v0: Close span non AWS SDK errors
...
Looks like AWS SDK doesn't call interceptor when non-sdk exception
occurs. This leads to leaking open spans. Fix that by instrumenting
http client.
Note: currently has no tests.
2019-03-21 18:08:35 -07:00
e0d95ceb19
Fix cassandra supported version
...
and limit range check to <4.
The latest release (4.0) is not compatible with our instrumentation.
2019-03-21 17:57:08 -07:00
c363f64b50
Merge pull request #773 from DataDog/willgittoes-dd/hibernate-fix
...
Improve selectivity of Hibernate instrumentation application
2019-03-22 10:08:26 +11:00
af0f37861b
Support Hibernate 3.3
2019-03-21 13:38:16 +11:00
07463e04bd
Merge pull request #772 from DataDog/tyler/status-error-mapping
...
Implement Http Status error mapping via config
2019-03-20 19:14:17 -07:00
c369fafe8c
Support muzzle testInverse = true
2019-03-21 12:17:24 +11:00
e5e2c5b9dc
Merge pull request #710 from DataDog/tyler/size-limited-flushes
...
Change DDAgentWriter to use Disruptor
2019-03-20 11:03:56 -07:00
f94f22bcba
Dont load hibernate instrumentation unless correct version of hibernate is on the classpath
2019-03-20 15:52:49 +11:00
715af67e70
Implement Http Status error mapping via config
...
Using the following defaults:
* `DD_HTTP_CLIENT_ERROR_STATUSES=400-499`
* `DD_HTTP_SERVER_ERROR_STATUSES=500-599`
2019-03-19 17:11:48 -07:00
8c5158f8e9
Restructure hibernate integration
2019-03-20 11:00:42 +11:00
7ffcf5ad4d
Change DDAgentWriter to use Disruptor
...
Serialize payloads as they arrive, send to agent when size exceeds 5MB.
If a flood of traces fills up the RingBuffer, we still count the traces that are discarded for stats reporting.
Do we want to allow configuration of the RingBuffer size?
2019-03-19 09:44:23 -07:00
4825a113f8
Add a couple of comments about the code structure
2019-03-19 16:28:27 +11:00
b60c3bcc0a
Decouple common utils used in hibernate tracing from any specific version of hibernate
2019-03-19 14:40:16 +11:00
86d14280d2
Exclude hibernate-annotations from 3.5 latestDepTest
2019-03-19 09:56:39 +11:00
3b6c688ce8
Support Hibernate 3.5
2019-03-19 09:56:39 +11:00
5a04c58c55
Merge pull request #765 from DataDog/willgittoes-dd/hibernate-5
...
Add support for Hibernate 4.3+ ProcedureCall
2019-03-19 09:56:03 +11:00
63e0c0f032
Support Unix Domain Socket proxy to send traces
2019-03-15 11:36:44 -07:00
071c16a839
Merge pull request #768 from DataDog/tyler/metrics-double
...
Agent doesn’t like getting floats.
2019-03-15 07:55:25 -07:00
472262149c
Apply timeout and retry to test
...
This test seems to hang a lot in java 7.
2019-03-14 15:44:32 -07:00
192eb894a4
Fix Trace Search + Analytics integration config key
2019-03-14 10:54:43 -07:00
30401bfed8
Fix test
2019-03-13 14:20:58 +11:00
54401083ce
Fix version of hsqldb
2019-03-13 14:09:49 +11:00
474f196c2f
fix style
2019-03-13 13:57:05 +11:00
2ceeb4dc14
Additional instrumentation for hibernate 4.3 and 5.x onwards
2019-03-13 13:52:33 +11:00
ca708db5da
Remove trace injection into AWS requests
...
I don’t think these are helping us and we may still risk messing up the signed request if this happens too late.
2019-03-12 14:08:27 -07:00
bb7923571e
Merge pull request #764 from DataDog/tyler/memcache-decorator
...
Migrate Memcache instrumentation to Decorator
2019-03-12 14:01:47 -07:00
bca5614508
Migrate Memcache instrumentation to Decorator
2019-03-12 11:47:25 -07:00
d30d715dc8
Migrate Spring Web{flux} instrumentation to Decorator
2019-03-12 09:38:53 -07:00
d31965ff5a
Merge pull request #761 from DataDog/tyler/rabbit-decorator
...
Migrate RabbitMQ instrumentation to Decorator
2019-03-12 08:08:22 -07:00
736f1787cc
Merge pull request #703 from DataDog/willgittoes-dd/hibernate-integration
...
Hibernate integration
2019-03-12 15:00:04 +11:00
a3925b556c
Get rid of unneeded try/catch block
2019-03-12 14:07:37 +11:00
817f5e3f8e
Merge pull request #762 from DataDog/tyler/play-decorator
...
Migrate Play instrumentation to Decorators
2019-03-11 19:27:03 -07:00
69d31cc03a
Restrict derby version
...
Lastest version requires Java 9+, so we can’t test against it for now.
2019-03-12 11:52:39 +11:00
e1915c35bf
Merge fixes for Hibernate
2019-03-12 10:46:30 +11:00
bf110640e8
Merge branch 'master' into willgittoes-dd/hibernate-integration
2019-03-12 09:39:58 +11:00
ee1d385c7b
Restrict derby version
...
Lastest version requires Java 9+, so we can’t test against it for now.
2019-03-11 14:27:10 -07:00
d90a3c47ae
Restrict derby version
...
Lastest version requires Java 9+, so we can’t test against it for now.
2019-03-11 14:26:58 -07:00
2146678d0a
Migrate RabbitMQ instrumentation to Decorator
2019-03-11 14:09:06 -07:00
b8affc472d
Migrate Play instrumentation to Decorators
2019-03-11 11:54:28 -07:00
e3b871afb5
Merge pull request #758 from DataDog/tyler/okhttp-decorator
...
Migrate OkHttp Instrumentation to Decorators
2019-03-11 09:46:40 -07:00
0d23ab3169
Merge pull request #752 from DataDog/arbll/add-uds-support
...
Add UDS support for jmxfetch.
2019-03-11 08:22:51 -07:00
81f78db0ff
Support hibernate 4.0
2019-03-11 17:22:05 +11:00
600f2e267f
Enable integration for hibernate 4.3
2019-03-11 16:20:27 +11:00
b40483c974
Add "hibernate" as the primary instrumentation name
2019-03-11 14:07:26 +11:00
c500d4b236
Migrate OkHttp Instrumentation to Decorators
2019-03-08 15:12:29 -08:00
446591240c
Avoid race in TestHttpServer port selection
...
I notice occasionally some of the instrumentation tests fail due to port
conflicts in TestHttpServer, esp when using the `--parallel` option in
gradle. I think the previous method is subject to a race where two
concurrent workers will both get the same port from `randomOpenPort()`.
2019-03-06 12:55:02 -05:00
576e554445
Migrate Mongo to Decorator
2019-03-05 20:50:06 -05:00
7ed7ce7518
Fix muzzle
2019-03-06 10:39:46 +11:00
01f4666ac4
Simplify testing multiple session implementations
2019-03-06 10:28:18 +11:00
e05429a9ff
Rename to hibernate-5
2019-03-06 10:12:52 +11:00
00865dab88
Review comments: Replace un-needed instrumentation by just propagating scope not spans
2019-03-06 10:05:21 +11:00
d054790161
Merge pull request #754 from DataDog/mar-kolya/increase-docker-timeout
...
Increase docker container timeout in tests to help with stability on …
2019-03-04 14:40:27 -05:00
44919b4dbe
Merge pull request #751 from DataDog/tyler/netty-decorator
...
Migrate Netty instrumentation to Decorator
2019-03-04 09:26:11 -08:00
9272f88fe6
Increase docker container timeout in tests to help with stability on underpowered machines running builds
2019-03-04 11:59:41 -05:00
084c2eb51f
Migrate Netty instrumentation to Decorator
2019-03-04 08:16:25 -08:00
8594e55530
Upgrade JMXFetch to the latest version
2019-03-04 08:48:04 -05:00
15df2cd8f4
add uds support
2019-03-04 14:18:53 +01:00
9e3fda549d
More codenarc fixes
2019-03-01 13:53:51 +11:00
ffa140f444
codenarc doesnt know how to parse datatables
2019-03-01 13:12:14 +11:00
644d26f4a9
Change muzzle tests
2019-03-01 12:53:51 +11:00
bfc1042c3a
Additional test for OrmClientDecorator
2019-03-01 12:33:57 +11:00
e098e6bd64
Migrate kafka instrumentation to Decorator.
2019-02-28 16:27:31 -08:00
e6d593eabe
JAXB deprecated from default Java classpath in later JVMs, but required for tests
2019-03-01 10:49:49 +11:00
65cb8af873
Fix tests that verify that cancelling job cancels continuation
2019-02-28 18:44:39 -05:00
339784c4eb
Merge pull request #744 from DataDog/tyler/jms-decorator
...
Migrate JMS instrumentation to Decorator
2019-02-28 15:32:31 -08:00
1f60904321
Merge pull request #743 from DataDog/tyler/jetty-decorator
...
Migrate Jetty instrumentation to Decorator
2019-02-28 14:59:45 -08:00
afc517f0c3
Review comments
2019-03-01 09:42:07 +11:00
fc40c9617a
Migrate JSP instrumentation to Decorator
...
Remove span kind and type from generated spans since these classify more as specialized @Trace spans.
2019-02-28 14:30:28 -08:00
5668e6006f
Migrate Jetty instrumentation to Decorator
2019-02-28 13:54:37 -08:00
50b4e1623e
Migrate JMS instrumentation to Decorator
2019-02-28 13:52:29 -08:00
50279d64fe
Span type should only be an attribute and not inherited
...
Previously we were inheriting from the parent and also often setting as a tag.
Apply default span assertion to verify the spanType is being checked properly. (Include error state too.)
2019-02-28 12:39:51 -08:00
3029d3d85c
Merge pull request #741 from DataDog/mar-kolya/tomcat-classloadin-instrumentation
...
Add instrumentation for Tomcat webapp classloading
2019-02-28 13:48:40 -05:00
aa031cc708
Add instrumentation for Tomcat webapp classloading
2019-02-28 12:58:08 -05:00
d53d3fe4c8
Add @Retry to tests that fail randomly in CI.
...
Should eventually revisit this to try and remove them.
Latest failure was on:
```
at ExecutorInstrumentationTest.#poolImpl '#name' reports after canceled jobs(ExecutorInstrumentationTest.groovy:202)
```
2019-02-27 20:56:47 -08:00
3334affc42
Add test for OrmClientDecorator
2019-02-28 15:38:25 +11:00
133460a79a
Stop making hard references in HelperInjector
...
Also make awaitGC interruptable.
2019-02-27 19:09:01 -08:00
093387bb01
Review comments and additional testing
2019-02-28 11:04:31 +11:00
f7e8980d08
Add null check on span type
...
Null spanTypes cause the tag to be removed.
2019-02-27 15:35:15 -08:00
9c9e74e0d0
Missing helpers
2019-02-27 13:37:03 -08:00
a413b0d08d
Review changes.
2019-02-27 12:39:03 -08:00
1644de3969
Migrate Jax-rs client instrumentation to Decorator
2019-02-27 09:40:08 -08:00
4e9449db81
Migrate Jax-rs annotation instrumentation to Decorator
2019-02-27 09:40:08 -08:00
cd9dc94b24
Migrate Hystrix instrumentation to Decorator
2019-02-27 09:40:08 -08:00
34242e4849
Migrate method tracing instrumentation to Decorator
2019-02-27 09:40:08 -08:00
d842612697
Migrate Jedis/Lettuce instrumentation to Decorator
2019-02-27 09:04:52 -08:00
9e81bba3fa
Review comments
2019-02-27 08:41:32 -08:00
c0e5baebda
Support stored procedures
2019-02-27 16:17:27 +11:00
044ff75e07
Neaten decorator pattern a bit
2019-02-27 09:35:10 +11:00
c46909e59f
Migrate JDBC instrumentation to Decorator
2019-02-26 11:16:35 -08:00
99f2d97cd5
review fixes
2019-02-26 08:32:43 -08:00
a33b6ddaa0
Implement trace origin header and propagation support
2019-02-26 08:26:31 -08:00
2c2f81ea34
Merge pull request #733 from DataDog/mar-kolya/remove-unused-function
...
Remove unused testing function
2019-02-26 11:18:11 -05:00
e17e029540
Merge pull request #732 from DataDog/tyler/httpurlconnection-decorator
...
Migrate HttpURLConnection instrumentation to Decorator
2019-02-26 08:13:46 -08:00
0aba752787
Merge pull request #726 from blockmar/hystrix-tags
...
Hystrix metadata added to tags and Command Group included in resource name
2019-02-26 08:05:56 -08:00
15bca28539
Remove unused testing function
2019-02-26 10:31:31 -05:00
079fcd6a56
Use a Dectorator for the Hibernate instrumentation
2019-02-26 17:31:42 +11:00
8985d6fd07
Merge branch 'master' into willgittoes-dd/hibernate-integration
2019-02-26 12:03:08 +11:00
8ffb9a63b0
Add hibernate.Criteria instrumentation
2019-02-26 12:02:40 +11:00
678df7b43d
Migrate HttpURLConnection instrumentation to Decorator
2019-02-25 14:48:15 -08:00
adb2eb9b55
Migrate gRPC instrumentation to Decorator
2019-02-25 13:17:28 -08:00
8d601b7f0d
Get methodName directly by annotation. Applied Google formatting.
2019-02-25 09:45:10 +01:00
b95ff2eb8e
Hibernate: instrument querying
2019-02-25 10:17:14 +11:00
2f3f2d4e04
Merge pull request #728 from DataDog/tyler/static-import-decorators
...
Rename and static import decorators instance
2019-02-22 15:51:21 -08:00
461e01270c
Merge pull request #729 from DataDog/tyler/license-cleanup
...
Remove unnecessary license checker
2019-02-22 15:28:02 -08:00
93e38f6f0d
Rename and static import decorators instance
...
In the instrumentation it reads better.
2019-02-22 13:44:34 -08:00
7e82f5b197
Remove unnecessary license checker
2019-02-22 13:42:43 -08:00
db47fde8d1
Group Elasticsearch instrumentation into common folder
...
Also migrate to decorator.
2019-02-22 13:28:11 -08:00
f04d113ecb
Make decorators public and add tests
2019-02-22 09:42:53 -08:00
5c9ddd6923
POC for hystrix metadata as tags in Hystrix Instrumentation
2019-02-22 15:59:32 +01:00
dd35372a72
Add Cassandra decorator
2019-02-21 15:43:12 -08:00
9c8e689b6d
Add decorator for couchbase instrumentation
2019-02-21 15:27:26 -08:00
2e4d8e94d6
Merge pull request #724 from DataDog/tyler/exclude-macro
...
Exclude groovy macro package from instrumentation
2019-02-21 12:37:22 -08:00
8f9ea87ef6
Merge pull request #723 from DataDog/tyler/aws-decorators
...
Migrate AWS SDK instrumentation to decorators
2019-02-21 12:37:05 -08:00
0d9e6ad97a
Merge pull request #722 from DataDog/tyler/akka-apache-decorators
...
Akka and Apache HttpClient migrate to decorators
2019-02-21 12:27:53 -08:00
fb304a110d
Migrate AWS SDK instrumentation to decorators
2019-02-21 12:11:42 -08:00
49faeca145
Exclude groovy macro package from instrumentation
...
It generates a lot of noise when running tests and likely shouldn’t be instrumented.
2019-02-21 11:35:21 -08:00
dfe5cb57b2
Servlet migrate to decorators
2019-02-20 17:35:41 -08:00
13e708ec42
Akka and Apache HttpClient migrate to decorators
2019-02-20 17:02:05 -08:00
a98c22ac3a
Introduce base decorators
2019-02-20 16:11:18 -08:00
4dd4ee0c05
Trace Analytics Config
...
Also make the instrumentation names a sorted list so the evaluation order is consistent.
2019-02-20 10:56:14 -08:00
a7ebc9b3db
Deprecate WEB_SERVLET type
2019-02-20 08:42:39 -08:00
8512b841e6
Fix how we evaluate if customlogger is on classpath
...
Resources must replace `.` -> `/` and add `.class` to the end.
2019-02-15 15:00:25 -08:00
2d0636e158
Merge pull request #712 from DataDog/mar-kolya/limit-es-rest-tests
...
Limit ES-rest tests to 6.x.x versions
2019-02-15 09:54:34 -05:00
8d5aed7512
Merge pull request #705 from DataDog/tyler/synthetic-ignore
...
Exclude several type identifications from instrumentation
2019-02-14 16:46:59 -08:00
dd7981871f
Limit ES-rest tests to 6.x.x versions
...
It looks like beta 7.x.x was released and our instrumentation doesn't
work with it at the moment.
2019-02-14 17:43:44 -05:00
62e127896a
Merge pull request #706 from DataDog/mar-kolya/webflux-fixes
...
Improve webflux instrumentation
2019-02-14 17:41:59 -05:00
8e1382b4e4
Improve webflux integration
...
Add support for tracing Mono/Flux
2019-02-14 16:59:59 -05:00
13005d72cb
Add reactor-core instrumentation
2019-02-14 16:59:56 -05:00
c65c79207a
Remove `isSynthetic()` ignore
...
There’s concern that this will cause classes to be skipped that we do want to instrument.
2019-02-14 08:45:02 -08:00
7481a141c4
Added instrumentation to attach State to all Query objects, so they can be instrumented
2019-02-13 22:13:32 +11:00
b68563f5d1
Make tests work for StatelessSession as well as Session
2019-02-13 15:08:53 +11:00
e019fcbda5
Instrument SharedSessionContract instead of Session
2019-02-12 16:53:09 -08:00
180ba619a2
Move SessionFactory instrumentation into its own class
2019-02-13 10:32:09 +11:00
984f6aff68
Tests for Session methods
2019-02-12 17:22:43 +11:00
cd2467c76b
Use a generic Session MethodAdvice to instrument all synchronous Session methods; also support re-entrant Session methods
2019-02-12 17:01:37 +11:00
ccee63574d
Exclude several type identifications from instrumentation
...
I considered excluding Interfaces too, but that would break people that added `@Trace` to their default methods.
Just a hunch, but I don’t think we want to instrument classes marked as synthetic, for example proxies. We may want to extend this to our method matchers (and maybe exclude native methods too).
We might want to instrument enums/annotations, but that seems unlikely.
2019-02-11 16:23:08 -08:00
5bc3ec82c2
Merge pull request #697 from DataDog/tyler/gradle-upgrade
...
Upgrade Gradle to 4.10.3
2019-02-11 16:01:35 -08:00
05731c3c45
Log when test starts
...
This is helpful to see what logs belong to what test
2019-02-11 12:21:20 -05:00
bae2d7dde8
Allow non-wrapped tasks in disabled executors
...
Some executors cannot handle tasks that have been wrapped into
`{Runnable,Callable}Wrapper` because they require certain subclass of
`{Callable,Runnable}` in order to work. We have a test that
effectively disables instrumentation for such executors.
This change makes sure that tasks that do not need to be
wrapped (which essentially means anything that is not lambda) still
get traced in such executors. One notable example of affected executor
type is `ScheduledThreadPoolExecutor`.
2019-02-11 11:47:34 -05:00
724a59c347
Get initial hibernate tests working
2019-02-11 20:55:28 +11:00
e8f0eaf85e
Add basic Hibernate integration
2019-02-11 14:47:21 +11:00
3a0a471dd5
Close future's continuation on cancel even if future itself was not cancelled
2019-02-08 20:13:32 -05:00
9d830a3dab
Do not close parent scope when closing continuation in concurrent execution state
2019-02-08 20:13:32 -05:00
0802bb864c
Merge pull request #696 from DataDog/tyler/jmxfetch-config
...
JMXFetch bundled integrations disabled by default
2019-02-07 09:48:32 -08:00
931e6ff8af
Merge pull request #688 from DataDog/mar-kolya/webflux-fixes
...
Fix webflux integration to not rely in active span
2019-02-07 12:45:50 -05:00
000c0e4644
Upgrade Gradle to 4.10.3
...
Also try to improve build time performance by reducing the required configuration:
https://blog.gradle.org/preview-avoiding-task-configuration-time
2019-02-07 09:43:36 -08:00
4414dc2ad5
JMXFetch bundled integrations disabled by default
...
Enable each individually by setting `-Ddd.integration.<integration_name>.enabled=true`.
2019-02-06 13:00:52 -08:00
6de4f1b0ba
Merge pull request #694 from DataDog/mar-kolya/split-service-http-client-suggestions
...
Mar kolya/split service http client suggestions
2019-02-05 16:07:54 -05:00
a46d6a2e8f
Use config inheritance in `withConfigOverride`.
...
This moves us forward to abstract 'Config' and away from depending in
specific config data source (e.g. system properties).
2019-02-05 15:51:05 -05:00
65cece6741
Fix code coverage ignores.
2019-02-05 12:15:14 -08:00
12e7efc0b9
Review fixes
2019-02-05 11:58:36 -08:00
bbcd2f6949
Move other Utils to utils package
2019-02-05 11:43:05 -08:00
6aa371d790
Encapsulate config override reflection
2019-02-05 11:30:07 -08:00
6cebabbada
Move integrations config to Config class.
2019-02-05 08:20:49 -08:00
1a54e8179a
Add setting to set service name by domain for http clients
...
This will allow better metric collection and identification of trends for individual services/hosts.
This is not enabled by default because it can result in a high cardinality of services.
2019-02-05 08:20:49 -08:00
a086f38f2f
Fix webflux integration to not rely in active span
...
Netty event loop instrumentation doesn't allow us to attribute work to
correct span so we have to maintain that manually.
2019-02-05 10:38:21 -05:00
f84e510f3e
Increase timeouts in JMS test to try to make it more stable
2019-02-05 10:10:49 -05:00
f3d3d1269a
Merge pull request #692 from DataDog/mar-kolya/netty-4.0-improve-test
...
Make test results in netty-4.0 client tests more readable
2019-02-05 09:35:55 -05:00
b25784e7a2
Make test results in netty-4.0 client tests more readable
2019-02-04 15:39:42 -05:00
4953a6c417
Skip clojure.lang.DynamicClassLoader
...
Not doing this seems to cause issues with Clojure protocols.
An application instrumented with the dd-java-agent that will
otherwise run fine will fail with ClassNotFoundException for
classes pertaining to Clojure protocols.
2019-02-04 07:12:29 -06:00
9353f82063
Merge pull request #686 from DataDog/tyler/jboss-jmxfetch
...
Initialize JMXFetch if configured log manager is on sys classpath
2019-01-31 15:24:55 -08:00
88d190d95b
Test for customlogmanager=false
2019-01-31 14:53:58 -08:00
558cd9a3b7
Merge pull request #683 from DataDog/willgittoes-dd/hystrix-operation-name
...
Hard-code Hystrix operation (span) name, leaving the resource name dynamic
2019-02-01 09:44:29 +11:00
99e4e52600
Fix style
2019-02-01 09:29:05 +11:00
e293ed477d
Fix tests.
2019-01-31 14:25:19 -08:00
f7abb2ac04
Initialize JMXFetch if configured log manager is on sys classpath
...
Some applications set java.util.logging.manager but never actually initialize the logger.
Check to see if the configured manager is on the system classpath.
If so, it should be safe to initialize jmxfetch which will setup the log manager.
2019-01-31 13:31:48 -08:00
c89b00f682
Elaborate on comment.
2019-01-31 11:14:06 -08:00
ea0dedcee7
Allow setting dd.app.customlogmanager=false to disable jboss check
2019-01-31 10:53:20 -08:00
ee8a26d4dc
Replace jboss classpath check with ENV check for jmxfetch delay
...
Some applications seem to have this jboss class on the classpath, but don’t actually use it. When coupled with not actually using JUL, this means that we may never actually start JMXFetch.
Checking for JBOSS_HOME instead should be safer.
2019-01-31 10:42:43 -08:00
a44b59bb14
Hard-code Hystrix operation (span) name, leaving the resource name dynamic
2019-01-31 14:30:08 +11:00
5941a93ad4
Merge pull request #679 from DataDog/willgittoes-dd/es-rest-6.4
...
Add support for Elasticsearch rest client 6.3 and above
2019-01-31 11:02:59 +11:00
57bae1688e
Review comments
2019-01-31 09:15:30 +11:00
bb2fbb30b8
Add logging to JMXFetch initialization delay
...
Otherwise it’s difficult to determine why JMXFetch isn’t being initialized.
2019-01-30 10:39:29 -08:00
56aaccb0c2
Remove commented code
2019-01-30 17:42:41 +11:00
f15a2ffd79
Add support for ES rest client 6.3 and above
2019-01-30 17:39:20 +11:00
2971d1b0d3
Ensure the copyMetricConfigs task runs after processResources
...
Otherwise there seems to be a race condition which results in the metric config files being overwritten.
2019-01-28 13:43:07 -08:00
ee3788bfdc
Merge pull request #672 from DataDog/mar-kolya/more-forkjoin-instrumentations
...
More ForkJoin instrumentations
2019-01-28 14:01:03 -05:00
f8aed7aec7
Provide seprate instrumentation names for Akka and Scala ForkJoin instrumentations
2019-01-28 11:29:59 -05:00
f7844f763c
Instrument Akka and Scala ForkJoinTask and ForkJoinPool
2019-01-25 16:15:48 -05:00
a3219639a0
netty 4.0: improve request uri parsing
2019-01-25 15:58:25 -05:00
d4943eb2b6
netty 4.0: do not modify headers in aws request
2019-01-25 15:58:22 -05:00
5029660418
netty 4.0: consolidate netty config names
2019-01-25 15:50:28 -05:00
03bcdc97cc
Move awaitGC to common utility package
2019-01-25 10:32:09 -08:00
b3ad700b34
Merge pull request #666 from DataDog/mar-kolya/aws-sdk2
...
Initial AWS2 SDK instrumentation
2019-01-25 13:01:32 -05:00
a0dee2cd88
Merge pull request #674 from DataDog/mar-kolya/catch-exception-in-servlet-context-getter
...
Catch exception in servlet context getter.
2019-01-25 12:55:32 -05:00
4fb94b8368
AWS2 SDK: Remove class loader matcher that is no longer needed
2019-01-25 12:53:00 -05:00
58b67071e5
Merge pull request #673 from DataDog/tyler/fix-jmx-script
...
Makedir before creating file, Fail build if script errors
2019-01-25 09:51:13 -08:00
6563a711c2
Merge pull request #671 from DataDog/osgi-fix
...
Improve OSGi class loader instrumentation
2019-01-25 12:48:45 -05:00
4ba0adfab3
Catch exception in servlet context getter.
...
Request may finish after check has been perform but before context has
been read leading to exception in some implementations.
2019-01-25 12:28:58 -05:00
020fe44ea6
Makedir before creating file, Fail build if script errors
2019-01-25 09:27:40 -08:00
62402a6426
AWS SDK2 instrumentation
2019-01-25 12:02:31 -05:00
04fbb5085f
Improve OSGi class loader instrumentation
...
It turns out that Eclipse's OSGi implementation has two problems:
* It doesn't respect system properties by default
* It has tricky classloader implementation that loads bootstrap
classes from the classloader-has-delegation-to-bootstrap check but
doesn't load bootstrap classes from 'normal' code.
This should address second problem and make Eclipse's OSGi
implementation 'safe' by default.
2019-01-25 08:52:07 -05:00
76999fc9f9
Improve AWS1.x SDK integration
...
For AWS11.x SDK make sure that http client span is actually a child of
aws span.
2019-01-24 17:28:03 -05:00
7b0e3ffd1c
netty 4.1: consolidate netty config names
2019-01-24 17:28:03 -05:00
cb1313ea9a
netty 4.1: do not modify headers in aws request
2019-01-24 17:28:03 -05:00
07d10e2374
netty 4.1: improve request uri parsing
2019-01-24 17:28:03 -05:00
6ab5b121f5
Handle ForkJoinTask in concurrent instrumentation
2019-01-24 17:28:00 -05:00
146a16df25
Upgrade weak-lock-free to 0.15
2019-01-24 11:44:28 -08:00
6471a1a81e
Add $ separate to state field name
2019-01-23 22:32:00 -05:00
af15b17f1c
Remove unnecessary helper from FutureInstrumentation
2019-01-23 22:31:59 -05:00
e9745e6775
Log active span in test assert
2019-01-23 22:31:59 -05:00
63779c7816
Merge pull request #639 from DataDog/tyler/jmxfetch
...
Embedding existing jmx integrations with git submodule
2019-01-23 15:58:13 -08:00
1df20cf52c
Upgrade to latest version of jmxfetch
...
This includes the ability to load config from resources.
2019-01-23 13:29:32 -08:00
c93d146965
Update shadow plugin to 4.0.4
2019-01-22 11:13:18 -08:00
0a89074f60
Merge pull request #653 from marcoferrer/instrument-kt-coroutine-scheduler
...
Add support for instrumenting kotlin coroutine schedulers
2019-01-22 10:31:32 -08:00
5096ac35b6
address ci errors
2019-01-21 14:12:44 -05:00
7819430620
add mavenCentral to plugin repos
2019-01-21 12:26:46 -05:00
d7319cd76d
add tests for kt cancellation and channels
2019-01-21 11:59:54 -05:00
5f70ebfec5
Merge pull request #657 from DataDog/ark/fix-log-manager-test-race-condition
...
Play nice with Java's LogManager across all JVMs
2019-01-18 19:50:12 +00:00
af306f376b
Comments explaining jmxfetch delay
2019-01-18 10:56:21 -08:00
097c557651
Delay jmxfetch init when custom log manager is used by client's app
2019-01-16 12:18:29 -08:00
fe3ebceba9
Add jackson smile dep for old ES tests.
2019-01-16 13:27:04 -05:00
4c4b12e1d6
Expand custom logman tests to handle three different logman cases
2019-01-16 10:06:41 -08:00
6ffaa9e04f
Remove jre logging integration
2019-01-16 08:59:10 -08:00
3295739e28
Fix race conditions in custom log manager test
...
Fix two race conditions in the custom log manager test.
- Remove possibility of false positives by blocking until jmx thread
sends statsd metrics
- Disable logging in test to avoid deadlock in jmxfetch which can
occur when the JVM shuts down too quickly
2019-01-16 08:57:59 -08:00
1b1f620318
Improve Vertx test stability
...
By actiually waiting for test server to start listening.
2019-01-11 12:14:17 -05:00
63c28cef31
add kotlin test config to java-concurrent project
2019-01-09 19:20:31 -05:00
a31abc67e9
add support for instrumenting kotlin coroutine schedulers
2019-01-09 19:04:42 -05:00
cc8db0b11f
Workaround module bug by skipping LogManager$Cleaner instrumentation
2019-01-09 15:03:43 -08:00
f63d40fe55
Use git submodules to load metrics.yaml files
2019-01-08 10:13:18 -08:00
249951aa7a
Add README
2019-01-08 09:36:08 -08:00
de166e5ecb
First pass at embedding existing jmx integrations
...
Using copy/paste from integrations-core. Will depend on a new jmxfetch release with https://github.com/DataDog/jmxfetch/pull/205 before this will work.
2019-01-08 09:36:07 -08:00
354cbfcb2d
Concurent instrumentation tests: block thread before starting tracing
...
Otherwise blocking thread is pretty much useless since we may still
get spans if threads are executed quickly enough.
2019-01-08 12:30:18 -05:00
06bd670f0a
Remove unused class
2019-01-08 12:30:10 -05:00
93b018b4cc
Use port 61 for unused port in akka tests
...
This port is in low range and is not assigned so nothing should really
be listening on it on any host.
2019-01-08 12:04:50 -05:00
7da0cc7f50
Merge pull request #645 from DataDog/tyler/instrumenter-signature
...
Apply proper generic signature for Instrumenter.Default transformers()
2019-01-07 14:18:52 -08:00
c18b299606
Also exclude test coverage from instrumentation
2019-01-04 15:25:36 -08:00
6d7415fed2
Don’t run coverage on projects that use shadow
...
It was breaking on dd-java-agent where it has duplicate classes across different jars. These projects are excluding everything anyway.
2019-01-04 15:25:36 -08:00
6a09f6e2b9
Moves all ittests to be tests under dd-java-agent.
...
This was weird having it as a separate project. Reduces the number of top level directories.
There weren’t any existing tests in dd-java-agent’s test directory, so this seemed like a good place to put them.
2019-01-04 15:25:36 -08:00
fe52180bfc
Apply proper generic signature for Instrumenter.Default transformers()
...
Previously it was missing the MethodDescription portion.
2019-01-04 15:25:12 -08:00
93116e4e12
Avoid downloading so many AWS dependencies for the entire SDK
...
Only specify the deps we need for the tests.
2019-01-04 13:42:51 -08:00
d02e0d8e47
Fix akka latest dep test failure
2019-01-03 19:13:48 -05:00
ad2d5d6cb7
Merge pull request #638 from DataDog/mar-kolya/fix-akka-101
...
Fix Akka 10.1 support
2018-12-28 13:30:42 -05:00
be919a0145
Fix Akka 10.1 support
2018-12-28 13:12:33 -05:00
82dcc3ce6c
Merge pull request #629 from DataDog/ark/jmx-tagging
...
Add languages tag to jmx/runtime tags
2018-12-28 09:34:20 -08:00
8b910b46d1
Update tests for `language` tag in root span
2018-12-27 16:00:47 -08:00
3ef347f00f
Use safeHasSuperType instead of isSubTypeOf
2018-12-27 10:33:43 -08:00
471d8c4410
Properly capture callable statement queries
...
CallableStatement is a sub type of PreparedStatement. Previously we were only matching methods that returned exactly PreparedStatement.
2018-12-21 14:03:33 -08:00
e9f1436522
Additional continuable-scope tests
2018-12-19 17:12:58 -08:00
2861d87071
slf4j MDC autoinjection integration
2018-12-19 17:09:00 -08:00
4dc3528097
Add post-match hook to default instrumenter api
2018-12-19 17:07:43 -08:00
571d9cf077
Merge pull request #632 from DataDog/ark/remove-errorprone
...
remove errorprone
2018-12-19 20:58:26 +00:00
d0f3cfa3d6
Use asm bundled by bytebuddy in field-backed provider
...
JVM's ASM is not bundled with the agent and may not be present at runtime.
2018-12-19 12:37:47 -08:00
513cccd698
Change shell script to work with play
...
- Added an argument to the script to take [play-zip|jar] to distinguish between the frameworks to test
- Updated README
- Cleanup
2018-12-14 11:19:17 -05:00
d3b7910950
Add work logic to play server
2018-12-14 11:19:15 -05:00
34658aabcb
Play Server Performance Testing
...
Set up gradle sub project
2018-12-14 11:18:58 -05:00
0b92413d4a
Move JvmBootstrapTest into a fork inside a groovy test
2018-12-12 20:17:48 -08:00
d0120b9419
Assert logger constructor exists before applying instrumentation
...
This adds muzzle functionality to the logger
instrumentation. Assertions are manually set up because auto-creation
of references is not possible for non-default instrumenters.
2018-12-12 20:01:52 -08:00
0240ad5154
Move default instrumentation declarations to Instrumenter.Default
2018-12-11 18:01:40 -08:00
1004ee4ef7
Patch java.util.logging.Logger for safe use with jmxfetch
2018-12-11 17:26:02 -08:00
d60ecf0a62
Upgrade jmxfetch to latest version
...
Manually tested against wildfly. No startup bugs. New jvm metrics are
autoreported.
2018-12-10 10:58:35 -08:00
70b60939f4
Merge pull request #622 from DataDog/gary/fix-ratpack-test
...
Fix Flaky Ratpack Fork Test
2018-12-09 15:27:44 -05:00
a04b30107f
Change scope handling
2018-12-07 12:40:18 -05:00
cb419997af
Merge pull request #623 from DataDog/mar-kolya/jms-test-improvements
...
Small improvement for jms tests to hopefully make them more stable
2018-12-07 11:58:29 -05:00
2d28b5129e
Merge pull request #621 from DataDog/mar-kolya/fix-wildfly-startup
...
Fix wildfly startup by injecting context classes into bootstrap package
2018-12-07 10:44:42 -05:00
3225c8fd03
Fix wildfly startup by injecting context classes into bootstrap package
2018-12-07 09:56:04 -05:00
c1e21e328b
Small improvement for jms tests to hopefully make them more stable
2018-12-07 09:40:29 -05:00
26c354dad2
Fix Flaky Ratpack Fork Test
...
Ratpack tests occasionally fail with the handler span and manually started span out of order. This will ensure that if a span is manually started inside of the handler then it will be finished after the handler span is finished, which is when the request has been responded to.
2018-12-07 00:49:37 -05:00
2c85b5cbb8
Restore RabbitMQ latestDepTest to use latest version
...
Since spring-rabbit no longer uses a dependency with a snapshot build.
2018-12-07 00:16:03 -05:00
600674b03a
Put back muzzle check for 'dd-' threads
2018-12-05 17:20:50 -05:00
4deb68bfd7
Fix memory leak in WeakMapSuppliers.WeakConcurrent
...
The problem there is that it references JVM shutdown hook that keeps
reference to cleanup executor which potentially can keep references to
all sort of things - and this doesn't get cleaned up untill JVM
shutdown.
Solution is to remove shutdown hook when supplier is being GCed.
2018-12-05 15:02:40 -05:00
30712cdc87
Merge pull request #617 from DataDog/mar-kolya/java-concurrent-test-cleanup
...
Remove unused variable from AsyncChild classes
2018-12-05 12:35:19 -05:00
2e9b20ceb5
Remove unused variable from AsyncChild classes
2018-12-05 11:53:19 -05:00
94a3f7bb2b
Merge pull request #616 from DataDog/tyler/grpc
...
Enable gRPC instrumentation by default.
2018-12-04 14:28:58 -08:00
7cd3438d6b
Merge pull request #613 from DataDog/mar-kolya/improve-httpurl-connection
...
Improve HttpUrlConnection instrumentation
2018-12-04 17:12:01 -05:00
43e8c70098
Enable gRPC instrumentation by default.
2018-12-04 14:11:57 -08:00
0a3ecc1b90
Improve HttpUrlConnection instrumentation
...
Make sure we get one span per request
2018-12-04 16:54:48 -05:00
6cb9e0360d
Merge pull request #612 from DataDog/tyler/jms
...
Remove duplicate JMS spans from nested calls.
2018-12-04 11:25:56 -08:00
013e57c677
Add tests for Spring JMS Template
2018-12-04 10:54:53 -08:00
66570a2135
Add some synchronization into ES tests to make them more stable
2018-12-04 12:15:44 -05:00
3be4bbb7f0
Merge pull request #608 from DataDog/tyler/upgrades
...
Update misc versions.
2018-12-03 15:07:36 -08:00
74743be6e5
Remove duplicate JMS spans from nested calls.
2018-12-03 11:15:28 -08:00
12a1b0ce08
Merge pull request #610 from DataDog/ark/jmxfetch-new-gc-metrics
...
Configure jmxfetch to use new gc metrics
2018-11-30 18:54:31 +00:00
20b726bca7
Merge pull request #609 from DataDog/ark/aws-muzzle-ranges
...
Simplify AWS muzzle ranges
2018-11-30 18:53:05 +00:00
c9471e289b
Configure jmxfetch to use new gc metrics
...
This won't have any effect on jmx behavior. The next jmxfetch update
puts our desired metric names behind this feature flag. Enabling now
so we don't forget the next time we refresh jmxfetch.
2018-11-30 10:13:11 -08:00
983077d150
Move mock/assert deps out of common dependencies
2018-11-30 10:02:26 -08:00
91f1bef6f4
Simplify AWS muzzle ranges
...
AWS Muzzle workaround is no longer needed with latest muzzle
optimizations.
2018-11-29 16:18:14 -08:00
2e8dc9d08f
Fix Ratpack tests that got broken by ExecutorInstrumentation refactoring
...
It turns out closing continuation also closes parent span. This is not
very good in cases when we end up not using continuation if
continuation in a state has already been setup.
This patch provides way to close continuation in a way that doesn't
affect parent scope.
2018-11-29 15:21:46 -08:00
4ec5ca394c
Add code to wrap future returned by submit(Runnable) call
2018-11-29 15:18:46 -08:00
177c1432e3
Add tests to verify that fields are not injected when feature is disabled
2018-11-29 15:18:46 -08:00
ad98ebc01f
Add some comments and some other minor CR tweaks
2018-11-29 15:18:46 -08:00
1509286b15
Remove MapBackedProvider
2018-11-29 15:18:46 -08:00
118a61cc67
Add field backed context provider
2018-11-29 15:18:46 -08:00
b89e73b3c0
Switch executor instrumentation to use context storage
2018-11-29 15:18:46 -08:00
442323d4d1
Add catch so instrumentation errors don’t interrupt primary execution.
2018-11-29 13:14:12 -08:00
c9ec9ebd0f
Add guard against null values in extract adapter.
2018-11-29 13:06:01 -08:00
ae063e8a14
Add additional 404 tests for spring boot.
...
This one succeeds in applying routing, but returns a 404 response.
2018-11-29 11:32:49 -08:00
785860b6a7
Add null check for envelope in consumer delegate
2018-11-29 11:22:32 -08:00
3c4b480a18
Share tooling loader across muzzle runs
2018-11-28 13:01:01 -08:00
6ee5fd27b0
Guard against invoking WeakConcurrent constructor
2018-11-28 12:05:47 -08:00
2f319b9301
Consumer delegate should rethrow the exception
...
Previously the delegate would swallow the exception and not rethrow.
I also added a test to attempt to verify, but the exception doesn’t seem to be observable in the test.
(See #602 )
2018-11-28 08:36:15 -08:00
e87d4ef161
Servlet3 instrumentation race consition fixes
...
* Do not set `asyncPropagate` on scope since it will be closed anyway.
* Close span once done with it in `TagSettingAsyncListener`.
* No point in explicit finishing span in 'finishOnClose' scope.
* Do not reattach listener in
`TagSettingAsyncListener#onStartAsync`. Listener is attached each
time by `Servlet3Advice#stopSpan` and reattaching listener in
`TagSettingAsyncListener#onStartAsync` causes multiple listeners to
be attached and race conditions to happen.
* Do not close span in `AsyncContextInstrumentation`. This leads to
span being written prematurely. This span will be closed in
`TagSettingAsyncListener` anyway, along with adding proper status code.
2018-11-27 17:17:56 -08:00
e46ab1d01d
Merge pull request #600 from DataDog/tyler/threadpool-errors
...
Improve error handling for ThreadPoolExecutorInstrumentation
2018-11-27 15:24:58 -08:00
4199f924ac
Remove ES-transport instrumentation from rest test
...
It is generating an extra trace/span that in a realistic scenario would be generated by the server, not the client.
2018-11-27 13:02:44 -08:00
468ccab99a
Improve error handling for ThreadPoolExecutorInstrumentation
...
If other exceptions are thrown when trying to test the queue, it generates lots of log noise. This should handle it better.
2018-11-27 11:28:44 -08:00
6f61ddc67d
Merge pull request #594 from DataDog/mar-kolya/es-tests-stability
...
Improve stability of ES tests by avoiding unpredictable spans
2018-11-26 22:50:43 -08:00
90777f4b39
Retire/remove version scan
...
Remove version scan dead code and unnecessary classLoaderMatcher methods in instrumentations. Depends on #572
2018-11-26 18:21:56 -05:00
477c2f92c8
Address comments and add onClose callback on context to close scope.
2018-11-26 17:26:48 -05:00
50c2af9abb
remove classloader matcher
2018-11-26 16:57:12 -05:00
51978d877f
remove version scan task from ci
2018-11-26 16:57:10 -05:00
bf30d73746
remove skipping of ratpack helper checks
2018-11-26 16:55:36 -05:00
4169e42cdc
replace version scan with muzzle block
2018-11-26 16:55:33 -05:00
6475f20308
Refactor Ratpack
...
Remove the use of the OT project and Execution managed scopes. Updated tests.
2018-11-26 16:55:18 -05:00
467f14c359
Small fix in ES tests
2018-11-26 13:07:42 -08:00
1b1527da93
Merge pull request #596 from DataDog/mar-kolya/set-gradle-heap
...
Mar kolya/set gradle heap
2018-11-26 19:39:40 +00:00
80cd7cd500
Do testAnnotationProcessor deps.autoservice in modules with services in tests
...
Otherwise sometimes tests cannod discover services
2018-11-23 09:44:49 -05:00
23203fb659
Improve stability of ES tests by avoiding unpredictable spans
2018-11-23 09:43:41 -05:00
7dae6df890
In kafka latest deps test make sure that kafka version matches kafka client libs
...
This seems to help with compatibility
2018-11-22 21:02:05 -05:00
fdffee8f5c
Fix Hysrix test to not poll queue and return null
...
Instead wait for value to appear
2018-11-21 16:25:34 -05:00
2852a6a97a
Fix setup so springweb tests produce appropriate logs
2018-11-21 16:03:19 -05:00
590ed30f56
Limit Jedis latest dep tests to 2+ versions of Jedis
...
Jedis 3 seems to have incompatible API changes
2018-11-21 11:43:13 -05:00
a70da1d995
Remove redundant tests from SparkJava
...
Tests that create traces and do not assert on them may leave traces
behind for the next test causing errors.
2018-11-20 17:26:29 -05:00
ca0a4a4458
Do not check ES document version in Sping test
...
ES may do things that change this version unexpectedly
2018-11-20 14:46:30 -05:00
cd9ab3daef
Merge pull request #587 from DataDog/mar-kolya/set-netty-continuation-once
...
Set netty continuation only once
2018-11-20 13:19:45 -05:00
165f05beba
Set netty continuation only once
...
Also remove continuation when getting it
2018-11-20 12:19:53 -05:00
228e7e0d21
Better handle Jetty async calls
...
Do same thing we do for servlets
2018-11-19 14:17:01 -05:00
e4a12409c8
Add recursive servlet dispatch tests.
2018-11-16 14:40:35 -08:00
e96752bbad
Remove need for tomcat user file config
2018-11-16 09:56:42 -08:00
817895b559
Extract shared tests into abstract parent
2018-11-16 09:22:47 -08:00
cde02e1ae5
Fix servlet async dispatch
...
Finish existing trace and propagate to the next request.
Improve dispatch testing.
2018-11-16 08:55:11 -08:00
3835157c4f
Merge pull request #577 from DataDog/tyler/spring-auth
...
Set user.principal in a way spring security can be covered
2018-11-16 08:52:42 -08:00
1064e35788
Apply standard tag name and update spring-web test deps version.
2018-11-16 08:06:40 -08:00
31b2e0f9b0
Merge pull request #578 from DataDog/tyler/components
...
Apply component tag more consistently
2018-11-15 13:02:39 -08:00
465e237522
Do not set component in AWS instrumentation that later get rewritten anyway
2018-11-15 13:21:49 -05:00
6126d6632e
Add vertx latestDepTest
2018-11-15 09:58:21 -08:00
6f05cff023
Add test for UrlConnection error on file protocol
2018-11-15 12:31:42 -05:00
cbb29069fe
Apply component tag more consistently
2018-11-14 11:31:40 -08:00
0bb20abfce
Set user.principal in a way spring security can be covered
...
Improve tests.
2018-11-14 11:30:05 -08:00
5381461da2
Apply limits for Elasticsearch
...
6.5 has api changes that break our tests.
2018-11-14 10:55:18 -08:00
b58b54dab9
Limit Lettuce/Webflux versions and fix test for tomcat 9+
2018-11-12 12:33:34 -08:00
51dfd2b184
Fix latestDepTests for Jetty
2018-11-12 11:05:02 -08:00
5e194ef06c
Fix latestDepTests for Kafka Streams, Netty, and Okhttp
2018-11-12 08:15:24 -08:00
a2a194d48a
Fix latestDepTest for JSP instrumentation.
...
Normalize jsp.requestUrl tag value because Tomcat 9 seems to add relative path symbols of jsp files.
Tomcat 9 doesn't automatically create a connector, causing failures in latestDepTest. Tomcat 9 also seems to have small changes that effect some of the tests, such as changing the exception type and also removal of the exception message in one of the tests.
2018-11-12 08:15:24 -08:00
9bd2b86d2e
Add assertion to ensure latestDepTest dependencies are different from test.
2018-11-12 08:15:24 -08:00
9d7d40565a
Limit AMQP LatestDepTest to use last working version
...
Makes AMQP LatestDepTest not use the latest version because it uses a snapshot version of spring, causing error when downloading.
2018-11-09 11:09:04 -05:00
98efa8aaa3
Merge pull request #566 from DataDog/mar-kolya/specify-scala-dependency
...
Mar kolya/specify scala dependency
2018-11-05 21:05:54 -05:00
9c652cc5b2
Remove duplicate class names from ExecutorInstrumentation
2018-11-05 12:55:32 -05:00
b8276ac70b
Specify Scala dependency in single place
2018-11-05 12:55:32 -05:00
1667e590b9
Log Java and JVM version info.
2018-11-02 17:12:00 -07:00
3c0ba56d2c
Make context maps 'global' for a given key class name
...
This ensures that different instrumenters using same key class can see
each others state
2018-11-02 12:59:30 -04:00
98df97af3e
First iteration on a better context store api
...
Separate context storage from actual fetching/putting
2018-11-02 10:46:57 -04:00
387068caf8
Merge pull request #558 from DataDog/ark/helper-injector-classloader
...
Inject dynamic classes into bootstrap class loader
2018-11-01 22:19:49 +00:00
d0b00e0dc0
Inject all map holder classes into the bootstrap
2018-11-01 15:05:20 -07:00
13a8add2e7
Merge pull request #559 from DataDog/mar-kolya/add-lost-jdbc-statement-logging
...
Catch `AbstractMethodError` when trying to unwrap jdbc connection
2018-11-01 11:50:44 -04:00
15024915bf
Catch `AbstractMethodError` when trying to unwrap jdbc connection
...
jdts throws this exception since they just have 'stub' umplementation.
2018-11-01 09:57:18 -04:00
5f0f6f1474
Inject dynamic classes into topmost class loader
2018-10-31 16:11:52 -07:00
e83c379992
Merge pull request #557 from DataDog/mar-kolya/add-lost-jdbc-statement-logging
...
Add logging in jdbc instrumentation when we cannot unwrap connection
2018-10-31 15:55:03 -04:00
8a066de772
Add logging in jdbc instrumentation when we cannot unwrap connection
2018-10-31 13:38:37 -04:00
6198662984
Merge pull request #555 from marcoferrer/grpc-tracing-kotlin-exception-support
...
Catch and log throwables to support kotlin exception handling
2018-10-31 03:44:15 +00:00
1bd97a0f90
catch and log throwables to support kotlin exception handling
2018-10-30 23:00:29 -04:00
5824eb83b8
Merge pull request #537 from DataDog/ark/instrumentation-context-outline
...
instrumentation context map-backed impl
2018-10-29 18:48:23 +00:00
Daryl Robbins
Daryl Robbins
Tyler Benson
Tyler Benson
Luca Abbati
Nikolay Martynov
Will Gittoes
Will Gittoes
Ben Keith
Arthur Bellal
Anders Blockmar
Daniel Solano Gómez
Marco Ferrer
Andrew Kent
Andrew Kent
Gary Huang