Commit Graph

8185 Commits

Author SHA1 Message Date
Trask Stalnaker c40d3235c0
Update change log for 1.19.0 release (#6859) 2022-10-12 13:11:09 -07:00
Lauri Tulmin 279ab34ba9
Fix regression in webflux http client concurrency test (#6858)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6857
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6856
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6854
Looks like a regression from
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/6836
2022-10-12 09:21:49 -07:00
jack-berg aeac361816
Upgrade to otel java 1.19.0 (#6757)
Working PR to capture all the changes required to update to otel java
1.19.0. The new log API force allows
`:instrumentation-appender-api-internal` and
`:instrumentation-appender-sdk-internal`, but necessitates a decent
amount of refactoring as a result.

The PR points at the `1.19.0-SNAPSHOT`, which I'll update upon
publication.

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-10-12 09:19:37 -07:00
Trask Stalnaker c5cd8d67a3
Fix create website pull request (#6852) 2022-10-11 18:07:56 -07:00
dependabot[bot] d58965457c
Bump gradle-nullaway-plugin from 1.3.0 to 1.4.0 in /conventions (#6839) 2022-10-11 21:34:22 +00:00
dependabot[bot] 3806e4f295
Bump error_prone_annotations from 2.15.0 to 2.16 in /dependencyManagement (#6847) 2022-10-11 14:20:34 -07:00
dependabot[bot] 59940699c7
Bump error_prone_test_helpers from 2.15.0 to 2.16 in /dependencyManagement (#6840) 2022-10-11 20:56:08 +00:00
jack-berg fcd5876e1a
Add HTTP client and server tests (#6836)
Resolves #6835.
2022-10-11 20:12:48 +00:00
dependabot[bot] 56fa7eedee
Bump gradle-errorprone-plugin from 2.0.2 to 3.0.1 in /conventions (#6841) 2022-10-11 12:55:30 -07:00
dependabot[bot] 6c23d98387
Bump error_prone_core from 2.15.0 to 2.16 in /dependencyManagement (#6849) 2022-10-11 12:52:42 -07:00
Trask Stalnaker 45f95efc81
Update byte buddy from 1.12.17 to 1.12.18 (#6851)
I will rebase the dependabot PRs after this is merged, so that
dependabot won't mark these versions internally as ignored
2022-10-11 12:41:13 -07:00
jack-berg d5aadbab04
Split out :instrumentation:netty:netty-4.1 library (#6820)
Resolves #6734. Builds on #6811.
2022-10-10 16:01:14 -07:00
Mateusz Rzeszutek 77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans (#6828)
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client)
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
Lauri Tulmin 418c414de9
Remove vaadin latest deps restriction (#6829)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6551
2022-10-07 12:14:06 -07:00
Mateusz Rzeszutek 709ab76dd2
Add @theletterf as docs codeowner (#6830)
cc @theletterf
2022-10-07 12:08:34 -07:00
Malte 7117f4226d
ISSUE-2674 Strip sensitive data from the url (#6417)
Fixes #2674 by replacing basic auth information as part of the URL with
`username:password`.

Co-authored-by: Malte <MALPI@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-10-07 13:18:23 +02:00
Trask Stalnaker 5184a523b6
Add test for null httpcontext (#6823)
follow-up to #6792
2022-10-07 12:39:50 +03:00
Lauri Tulmin 5daf453e1d
Remove latest dep restriction from vertx-http-client-4.0 (#6827)
Should have been part of
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/6809,
forgot to add this file.
2022-10-07 11:31:57 +02:00
dependabot[bot] d0782b54da
Bump auto-value-annotations from 1.9 to 1.10 in /dependencyManagement (#6822) 2022-10-06 23:34:40 +00:00
jason plumb d9b25d34df
Guard against null HttpContext (#6792)
Resolves #6787

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-10-06 16:03:03 -07:00
Trask Stalnaker f4c5719c99
Allow auto-merge on PRs (#6812)
This seems nice for after pushing `spotlessApply` on an otherwise
approved and passing PR. I just enabled it and tried it on #6774.

(somewhat related to #6743)

Btw, I thought this was helpful explanation

> After you enable auto-merge for a pull request, if someone who does
not have write permissions to the repository pushes new changes to the
head branch or switches the base branch of the pull request, auto-merge
will be disabled. For example, if a maintainer enables auto-merge for a
pull request from a fork, auto-merge will be disabled after a
contributor pushes new changes to the pull request.


https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge
2022-10-06 16:02:27 -07:00
dependabot[bot] 7e6310255b
Bump auto-value from 1.9 to 1.10 in /dependencyManagement (#6821) 2022-10-06 16:00:00 -07:00
Trask Stalnaker 586261d25a
Run context customizers before span start instead of after (#6634)
...so that they can have access to the parent span context, and so that
their additions to the context will be visible to span processors
2022-10-06 12:11:17 -07:00
jack-berg 1fcea2017b
Publish :instrumentation:netty:netty-4-common as library instrumentation (#6811)
Related to #6734. Builds on #6805.

I'll follow it up by splitting out `:instrumentation:netty:netty-4.1` in
a separate PR.
2022-10-06 08:50:25 -07:00
Mateusz Rzeszutek 891ec8c491
Rename restlet-1.0 to restlet-1.1 (#6814) 2022-10-06 08:49:55 -07:00
Mateusz Rzeszutek ab0c875015
Link RabbitMQ receive span with the producer span (#6808)
Similar to #6804, but for RabbitMQ.
Also changed the span kind of the receive span to `CONSUMER`, to match
the spec.
2022-10-06 12:20:19 +03:00
Trask Stalnaker 6f6af66c04
Update to slf4j 2.0.2 (#6774)
~testLatestDeps is failing, see #6791~
2022-10-06 01:28:53 +00:00
Trask Stalnaker 06b6f0a2f2
Split out separate spotless CI check (#6743)
To make it clearer when the only problem with a PR is spotless (and may
follow-up with a comment-driven automation to apply spotless to a PR)
2022-10-05 17:17:01 -07:00
Mateusz Rzeszutek 0e84d10e58
Fix Restlet v2 `Message#getAttributes` calls (#6796)
Fixes #6563
2022-10-05 13:29:05 -07:00
Lauri Tulmin d9eff461d8
Fix instrumentation for vert.x 4.3.4 (#6809)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6790
2022-10-05 09:26:48 -07:00
jack-berg 4c91ec9f42
Publish :instrumentation:netty:netty-common as library instrumentation (#6805)
Related to #6734.

This first stage splits out the shared utilities in
`:instrumentation:netty:netty-common`. I'll follow it up by splitting
out `:instrumentation:netty:netty-4-common`,
`:instrumentation:netty:netty-4.1` in separate PRs. If there is
appetite, I can also split out library instrumentation for
`:instrumentation:netty:netty-4.0` and
`:instrumentation:netty:netty-3.8`, though I have no need for these.
2022-10-05 09:24:44 -07:00
Mateusz Rzeszutek f195ec0624
Link JMS receive span with the producer span (#6804)
Resolves #6779

In JMS you can have either the consumer receive span or the consumer
process span (unlike Kafka, where the process span is always there and
the receive span is just an addition) - in scenarios where polling
(receive) is used, I think it makes sense to add links to the producer
span to preserve the producer-consumer connection. Current messaging
semantic conventions don't really describe a situation like this one,
but the https://github.com/open-telemetry/oteps/pull/220 OTEP mentions
that links might be used in a scenario like this one - which makes me
think that adding links here might be a not that bad idea.
2022-10-05 09:11:28 -07:00
dependabot[bot] da3eecfd9f
Bump testcontainers-bom from 1.17.3 to 1.17.5 in /dependencyManagement (#6806) 2022-10-04 17:17:56 -07:00
dependabot[bot] 5f75a5060b
Bump asm-tree from 9.3 to 9.4 in /conventions (#6801)
Bumps asm-tree from 9.3 to 9.4.


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.ow2.asm:asm-tree&package-manager=gradle&previous-version=9.3&new-version=9.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2022-10-04 15:29:15 +02:00
dependabot[bot] d69a8b18c7
Bump asm from 9.3 to 9.4 in /conventions (#6802)
Bumps asm from 9.3 to 9.4.


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.ow2.asm:asm&package-manager=gradle&previous-version=9.3&new-version=9.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-04 13:47:10 +02:00
Trask Stalnaker dc7e072a56
Fix testLatestDeps (#6791) 2022-09-30 15:43:07 -07:00
Trask Stalnaker 6416a141cb
Use spock bom (#6785) 2022-09-30 12:04:48 +03:00
Trask Stalnaker 93a578b8db
Enable testLatestDeps in PRs (#6744)
but do not make it a required check.

The reason for my change of mind here is:

When new library versions are released which break testLatestDeps, the
quick fix is to temporarily limit the upper bound, but it's not clear
what the quick fix is if we end up merging in a change which breaks
testLatestDeps (short of reverting the change, which then potentially
requires reengaging the contributor after they have moved on from the
PR).
2022-09-29 10:59:26 -07:00
Trask Stalnaker 0d32150059
Assert on instrumentation version (#6773)
To catch issues like #6770
2022-09-29 10:53:10 +03:00
Trask Stalnaker 8fd7ef61db
Make otel gradle-plugins dependency clearer (#6775)
Follow-up to
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/6736#issuecomment-1259265400
2022-09-29 10:52:35 +03:00
Aaron Ai 4e59f10687
Rearrange the file structure of RocketMQ instrumentation (#6762)
Fixes #6761
2022-09-28 13:45:59 -07:00
Lauri Tulmin 73cadd38fe
Correct instrumentation name for jaxrs-2.0-annotations (#6770)
Related to
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6733
2022-09-28 12:47:45 -07:00
Lauri Tulmin 3e89a8ab31
Delete deprecated configuration flags (#6771) 2022-09-28 12:33:57 -07:00
Trask Stalnaker 0e0bbf6564
Small daemon threads implementation clean up (#6740) 2022-09-28 12:05:39 +03:00
Aaron Ai bd6831ca43
Introduce explicit dependency for quarkus:sourcesJar (#6769)
Fixes #6768
2022-09-28 12:04:48 +03:00
Lauri Tulmin e526338fc3
Fix akka-http and tomcat10 latest dep tests (#6766)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6760
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6759
2022-09-27 15:45:04 -07:00
dependabot[bot] 7f3cfabaa8
Bump snakeyaml from 1.32 to 1.33 in /dependencyManagement (#6756)
Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.32
to 1.33.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-27 12:55:38 +03:00
Fabien Crespel 7cb57e1fb1
Fix directory separator in ProcessResource attributes (#6716)
The separator char used to build the Java executable path in
ProcessResource is wrong: `File.pathSeparatorChar` is the PATH variable
separator (`:` on Linux, `;` on Windows), the right one for directories
is `File.separatorChar` (`/` on Linux, `\` on Windows).

Note that this issue was already present in
[sdk-extensions-resources](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/resources/src/main/java/io/opentelemetry/sdk/extension/resources/ProcessResource.java#L64)
before it was moved here; should it be fixed there too?
2022-09-26 16:17:21 -07:00
yingziisme 4057dcc04a
Fix testLatestDeps in dubbo instrumentation (#6754)
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2022-09-26 10:03:31 -07:00
Trask Stalnaker 6fdea85873
Remove unnecessary CI steps (#6742)
Since tests aren't run on assemble, these shouldn't be needed.
2022-09-25 13:12:10 +03:00