open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,947 Commits 77 Branches 113 Tags 276 MiB
Commit Graph

19 Commits

Author SHA1 Message Date
Lauri Tulmin f887fb870d
Dubbo: don't create spans for calls inside the same jvm (#7761) 
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7520
Invoking a dubbo service, like in
d7e2417ae7/demo-business-provider/src/main/java/cn/zewade/business/controller/BusinessController.java (L20),
creates a client span (and a server span on the receiving end). If the
caller and service are on the jvm this call doesn't go through remoting
and will be handled with regular java calls. Now when the initially
called service calls another service, like in
https://github.com/zewade/opentelemetry-dubbo-demo/blob/main/demo-business-provider/src/main/java/cn/zewade/business/dubbo/BusinessDubboServiceImpl.java#L25,
that second call will also attempt to create a client span. This second
client span will be suppressed which will also suppress context
propagation.
 2023-02-09 08:46:39 +02:00
Lauri Tulmin 652c3a8bf4
Fix flaky dubbo tests (#7726) 
https://ge.opentelemetry.io/scans/tests?search.buildOutcome=success&search.tags=CI&search.timeZoneId=Europe/Tallinn&tests.container=io.opentelemetry.instrumentation.apachedubbo.v2_7.DubboTraceChainTest&tests.sortField=FLAKY&tests.test=test%20that%20context%20is%20propagated%20correctly%20in%20chained%20dubbo%20calls&tests.unstableOnly=true

https://ge.opentelemetry.io/scans/tests?search.buildOutcome=success&search.tags=CI&search.timeZoneId=Europe/Tallinn&tests.container=io.opentelemetry.instrumentation.apachedubbo.v2_7.DubboTest&tests.sortField=FLAKY&tests.unstableOnly=true
Something has changed in later versions of dubbo that causes failures
when more than one test is run.
 2023-02-03 12:46:29 +01:00
Trask Stalnaker 94e2248940
Use new semantic attribute constants (#6946) 2022-10-23 09:32:03 -07:00
yingziisme 4057dcc04a
Fix testLatestDeps in dubbo instrumentation (#6754) 
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
 2022-09-26 10:03:31 -07:00
yingziisme d26e456d1b
fix bugs with dubbo (#6640) 
1. fix NullPointerException with dubbo getMetadata request

2. fix dubbo trace passing problem

the trace is third-demo -> consumer-demo -> provider-deme, but the
parent of provider-demo is third-demo.
wrong data like this
<img width="1994" alt="image"
src="https://user-images.githubusercontent.com/22729740/190597029-ea26569e-96b4-4e30-8ac3-46ead3871b92.png">

after fixed 
<img width="2015" alt="image"
src="https://user-images.githubusercontent.com/22729740/190596923-d65f8646-377d-47ab-9e65-6d75f1407ce0.png">

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
 2022-09-23 15:48:48 +02:00
Trask Stalnaker f1774cabe2
Update net semantic convention changes (#6268) 
* New net conventions: option a

* Feedback + sock.family + sock.peer.name

* peer.service + tests

* server net attributes attempt 1

* server net attributes attempt 2

* Javadoc

* Revisions

* Apply to instrumentations

* Feedback

* One more default method

* Spotless

* Fix javadoc
 2022-08-18 09:02:23 -07:00
Lauri Tulmin ae2a908256
Run tests with dubbo3 (#6247) 
* Run tests with dubbo3

* remove muzzle limit

* fill peer name on dubbo 3
 2022-07-01 08:14:23 -07:00
YuDong Tang f269ef75ba
change rpc type in apache dubbo (#5432) 
* change rpc type in apache dubbo

* fix dubbo test

* fix test
 2022-04-01 11:49:10 +03:00
Lauri Tulmin e9c1efece2
Update to Groovy 4 (#5532) 
* Update to Groovy 4

* exclude spock from grails tests, update comment

* Update instrumentation/grails-3.0/javaagent/build.gradle.kts

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2022-03-09 15:07:41 -08:00
Trask Stalnaker ce4cef76f9
Clean up groovy assertions (#4805) 2021-12-05 23:23:58 -08:00
Matthew Ho 6967484a97
Update groovy import order to match default IntelliJ (#1708) (#4047) 
* Update groovy import order to match default IntelliJ (#1708)

* organized imports for .groovy files to follow default IntelliJ import settings

* updated intellij-setup.md

* Spotless

* drift

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2021-09-11 11:53:08 -07:00
Trask Stalnaker 20c72f3e98
Format kotlin gradle files (#3942) 
* Add ktlint for kotlinGradle

* ktlint fails on wildcard imports

* Auto-format kotlin gradle files
 2021-08-25 13:43:57 +09:00
Anuraag Agrawal f5ce4c03f8
Inline basic usages of basicSpan (#3583) 
* Inline basic usages of basicSpan

* spock
 2021-07-18 21:15:51 +03:00
Anuraag Agrawal d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. (#3582) 2021-07-15 10:30:34 -07:00
Anuraag Agrawal 761b9c280b
Migrate instrumentation gradle files to kotlin (#3414) 
* Migrate instrumentation gradle files to kotlin

* Convert

* Muzzle
 2021-06-28 17:27:12 +09:00
Anuraag Agrawal 785dc6adf2
Rename build files to build.gradle (#3409) 
* Rename build files to build.gradle

* Rename smoke-tests

* Fix already broken
 2021-06-25 16:10:31 +09:00
Anuraag Agrawal deb0e255cf
Use plugins block everywhere for applying plugins (#3386) 
* Use plugins block everywhere for applying plugins

* Actually it's library instrumentation
 2021-06-24 11:13:35 +09:00
Anuraag Agrawal 224dc51e93
Migrate java.gradle to conventions plugin (#3289) 
* Migrate java.gradle to convention plugin.

* Switch to java-conventions

* Remove old file

* Fix

* Fix merge

* Missing paragraph

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2021-06-15 08:10:39 +09:00
Trask Stalnaker 935eeae544
Update folder structure (#3174) 
* Update apache-dubbo-2.7 folder structure

* Update logback-1.0 folder structure
 2021-06-02 23:46:52 -07:00