Commit Graph

423 Commits

Author SHA1 Message Date
Bogdan Drutu c24e4a9636
Some minor cleanups (#627)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-23 19:48:40 -07:00
Bogdan Drutu bcc6202531
Add @jkwatson to CODEOWNERS (#624) 2019-10-23 09:24:26 -07:00
Bogdan Drutu b4e007cbf9
Remove util/Links.java (#623)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-22 19:40:30 -07:00
Bogdan Drutu d6befaf711
Remove special timestamp definition (#619)
* Remove sepcial timestamp definition

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update api/src/main/java/io/opentelemetry/trace/Span.java

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* ./gradlew goJF

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* fix build

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-22 18:14:55 -07:00
Bogdan Drutu 7c0af113a1
Remove util/Events. (#622)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-22 17:32:11 -07:00
Bogdan Drutu 238d42a093
Fix build and add more tests (#621)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-22 17:02:59 -07:00
John Watson 60ba3b7547 Add named tracers to the API (#584)
* A rough idea of how named tracers might look in the API.

* update to require at least a name for the tracer

* Introduce another layer of factory for the provider

* remove convenience tracer methods from the OpenTelemetry class.

* Update api/src/main/java/io/opentelemetry/trace/spi/TracerFactoryProvider.java

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Update api/src/main/java/io/opentelemetry/trace/TracerFactory.java

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add clarifying javadoc, per PR review

* reverse who calls whom
2019-10-21 17:36:17 -07:00
Carlos Alberto Cortez a10e918e59 Move InMemorySpanExporter to exporters/ (#618) 2019-10-21 17:33:16 -07:00
Carlos Alberto Cortez 0ff6da3771
Add tests for TraceShim/TracerShim. (#603)
* Add tests for TraceShim/TracerShim.

Although we have the extensive testbed section,
we need some basic tests for non-exotic scenarios,
and this is part of that intention.
2019-10-18 03:54:07 +02:00
Bogdan Drutu 39a0664dbf
Move Probability sampler to Samplers. (#616)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-14 17:57:49 -07:00
Bogdan Drutu 9c60dc1a09
Move utils from API to SDK. (#613)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-14 17:45:33 -07:00
Bogdan Drutu 5133f0482d
Update README.md (#615) 2019-10-14 17:41:17 -07:00
Bogdan Drutu 4ffa516a6a
Move utils/Samplers from API to SDK Samplers (#614)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-14 15:34:51 -07:00
Bogdan Drutu a02b6d3927
Fix OpenTracingShim to run with SDK without baggages. (#608)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-14 08:44:57 -07:00
Bogdan Drutu 12ca38aa2f
Remove setRecordEvents option from the Span.Builder (#606)
* Remove setRecordEvents option from the Span.Builder

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix build, remove unnecessary overrides

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-12 11:32:54 -07:00
Bogdan Drutu a52617b14e
Move traceconfig proto helper out of SDK and remove protobuf dependency (#611)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-11 16:13:19 -07:00
Bogdan Drutu 6e278bb7c5
Restore gradle modules deleted when rebase (#610)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-11 16:09:57 -07:00
Bogdan Drutu 7c95af2a0e
Rename isRecordingEvents to isRecording (#607)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-11 16:09:28 -07:00
Bogdan Drutu 86f0ed3a21
Move TraceProtoUtils to otprotocol artifact. (#593)
* Move TraceProtoUtils to otprotocol artifact.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix settings.gradle

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-11 13:23:12 -07:00
Bogdan Drutu 8973bc371a
Cleanup and update dependencies. (#602)
* Cleanup and update dependencies.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix build

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix build

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-11 08:49:03 -07:00
Carlos Alberto Cortez 0612372fd4 Add explicit timestamp support for Span start/end. (#571)
* Allow explicit Timestamp values for Span start/end.

* Update the code after merging master.

* Set end/start options only for the API.

* Add a clarification on setStartTimestamp().

* Make EndSpanOptions.getDefault() package private for now.
2019-10-11 08:34:45 -07:00
Jason Plumb 3c197e6023 remove protobuf from timestamp converter and friends. (#604)
* remove protobuf from timestamp converter and friends.

* remove unnecessary method
2019-10-11 08:25:38 -07:00
Carlos Alberto Cortez 2f50f54cd2
Move the InMemory artifact to exporters. (#600) 2019-10-11 05:56:30 +02:00
Carlos Alberto Cortez f15bb4a7ea Expose the global telemetry objects as sdk ones. (#598) 2019-10-10 11:04:17 -07:00
Carlos Alberto Cortez 16a45ff740
Update the inline docs for InMemoryTracing. (#599)
We now use SpanData, not the proto representation.
2019-10-10 19:29:59 +02:00
John Watson d80eb04f94 Create a Logging span exporter (#592)
* a simple logging span exporter
2019-10-10 19:03:55 +02:00
John Watson 49637552ac Fix the logging of the error message to use the JUL proper formatting. (#597) 2019-10-10 19:02:48 +02:00
John Watson 9ac45a79cd Catch exceptions from the propagation and http trace context. (#595)
This will make us conform to the open tracing interface, properly.
2019-10-10 16:40:21 +02:00
Pavol Loffay ba1819996f Test SDK and OpenTracing shim interoperability (#586)
* Test SDK and OpenTracing shim interoperability

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
2019-10-09 19:26:04 +02:00
Carlos Alberto Cortez 79333431a8
Update the README. (#550)
* Update the README.

Include Release Schedule and Snapshots info.
2019-10-06 22:09:17 +02:00
John Watson 08d58837c1 Convert the export system to use SpanData (#587)
* SpanData Export refactoring

* getting our span data exporter work to use the new SpanData implementation

* getting up to date with the moved Timestamp

* Update post rebase

* A few cleanups from PR comments

* A few more cleanups.
2019-10-05 00:39:30 -04:00
Bogdan Drutu 6d37bd6065
Reduce compile dependencies for API/SDK. (#577)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-05 00:33:37 -04:00
Jason Plumb 58aa8d3468 Per spec change, allow start digit and @. (#563)
* Per spec change, allow start digit.  Fixes #562

* reject multiple at signs

* reformat

* remove redundant check
rename method to match its usage

* return to a negatively named method that is more clear

* add a todo to benchmark the key validation code

* formatting
2019-10-04 12:37:02 -04:00
Pavol Loffay fe19a23c9e Report span which is recording events (#503)
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
2019-10-02 07:11:40 -07:00
Bogdan Drutu 08c6d52109
Remove all APIs that allow passing context or other entries from the Context. (#582)
* Allow passing Context to all metrics

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Remove all versions that accept Context

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-10-01 20:10:43 -07:00
John Watson 9ac8d2d5ee Add a method to the ReadableSpan to get the SpanData copy (#583)
* add ReadableSpanAdapter as the next step toward leveraging SpanData.

* move the conversion into a method on the ReadableSpan interface.

* replace the tests that use protobuf spans to use SpanData

* remove unused method

* get rid of an un-needed interface method

* Update sdk/src/main/java/io/opentelemetry/sdk/trace/RecordEventsReadableSpan.java

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
2019-10-01 18:08:22 -07:00
Carlos Alberto Cortez 6124f626f9
OT Shim baggage support (#482)
* Initial implementation of our OT shim's baggage support.
* Have a base class to contain TelemetryInfo.
2019-10-01 02:19:25 +02:00
Bogdan Drutu ddc53dbcc8
Remove unnecessary dependency in proto on API. (#581)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-30 13:44:49 -07:00
Bogdan Drutu 1aa49037df
Update errorprone, remove stale disabled checks. (#579)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-30 11:43:23 -07:00
Bogdan Drutu 9b294a6741
Remove -Xlint:-deprecation from compiler options (#578)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-30 08:54:16 -07:00
John Watson bdf4a6d57c Timestamp moved underneath the SpanData PR. (#572)
this fixes that.
2019-09-27 10:36:33 -07:00
John Watson 1d68d86135 Add the SpanData class, for future use in export (#567)
* Add the SpanData class, for future use in export

* address code review comments

* add missing javadocs

* reformat

* Let's see how this feels with the context removed and the 4 fields added instead.

* add missing javadocs

* Get the default values in place for collections and parentSpanId.
Write a test for the SpanData

* add junit runwith

* move spandata up to the trace package

* Update sdk/src/main/java/io/opentelemetry/sdk/trace/SpanData.java

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
2019-09-27 09:32:49 -07:00
Bogdan Drutu 9a6c1d69d1
Move timestamp to common because it is shared by trace and metrics (#570)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-26 18:08:37 -07:00
Bogdan Drutu 29298b638b
Add builders for gauge, counter and observer metrics (#569)
* Add builders for gauge, counter and observer metrics

* Update sdk/src/test/java/io/opentelemetry/sdk/metrics/AbstractCounterBuilderTest.java

Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
2019-09-26 17:15:00 -07:00
Bogdan Drutu a86f034e85
Add tests for observer and all uncovered methods. (#568)
* Add tests for observer and all uncovered methods.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* More tests and update names

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-26 16:17:02 -07:00
Bogdan Drutu 2e779bb2e1
Add metrics data and metric descriptor, to avoid using proto (#564)
* Add metrics data and metric descriptor, to avoid using proto

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix review comments.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-26 12:53:11 -07:00
Bogdan Drutu 85e4fe3b66
Add a no-op abstract observer builder to avoid duplicate code (#565)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-24 17:12:41 -07:00
Bogdan Drutu 1ee12511b3
Small cleanup to remove some duplicate code. (#561)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-24 12:40:26 -07:00
Bogdan Drutu 577a448f49
Remove Set from Counters, based on specs only Add. (#560)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2019-09-24 12:25:10 -07:00
Bogdan Drutu 81f283f20f
Remove Add from Gauges, based on specs only Set. (#559)
* Remove Add from Gauges, based on specs only Set.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update GagueDouble handle name in the example.

* Update handle name in GaugeLong example.
2019-09-24 12:17:54 -07:00