Commit Graph

1461 Commits

Author SHA1 Message Date
John Watson f2ee66281e
changelog updates for Dec 15 2020 (#2313)
* changelog updates for Dec 15 2020

* add an entry I missed
2020-12-15 19:12:09 -08:00
John Watson 76e10c5102
CONTRIBUTING.md update with some more best practices. (#2301)
* add a section on class member ordering, since it's not covered in the google style guide

* add an item about toString methods

* add a note about final fields coming before non-final
2020-12-16 11:21:16 +09:00
Bogdan Drutu dbb1ae91f9
Deprecate metrics from opentelemetry-api, add a global version in metrics api (#2279)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-15 15:14:50 -08:00
John Watson eccbfebf38
Another option for release versioning proposal (#2250)
* Add rationale and description of the release and versioning strategy.

* typo fix

* alternate version of the versioning strategy that tags the version rather than the artifact.

* add context for clarity

* Update docs/rationale.md

Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>

* add some additional flavor about internals and mention the bom in an example

Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2020-12-15 14:12:59 -08:00
Bogdan Drutu 37afb33659
Split global functionality into a separate class (#2233) (#2239)
This ensure clear separation of functionality. This PR does not change any functionality, it just restructures the code to separate global functionality from
the Default implementation. Also helps to ensure that Global initialization does not happen by mistake when working only with the default implementation.

Also it helps with methods like `OpenTelemetry.get()` and `OpenTelemetry.set()` to understand they are interacting with global instance

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-15 13:05:46 -08:00
Bogdan Drutu 25bf879df7
Split global functionality into a separate class (#2233)
This ensure clear separation of functionality. This PR does not change any functionality, it just restructures the code to separate global functionality from
the Default implementation. Also helps to ensure that Global initialization does not happen by mistake when working only with the default implementation.

Also it helps with methods like `OpenTelemetry.get()` and `OpenTelemetry.set()` to understand they are interacting with global instance

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-15 10:27:35 -08:00
Anuraag Agrawal 44186bc110
Suppress checkstyle javadoc check from non-main source sets. (#2307)
* Suppress checkstyle javadoc check from non-main source sets.

* Update checkstyle-suppressions.xml
2020-12-15 09:39:33 -08:00
Anuraag Agrawal 36062bf4b1
Exclude SemanticAttributes from coverage. (#2303) 2020-12-15 08:43:43 -08:00
Frank Spitulski c108f62158
fix(semantic-attributes): update to dec 14 2020 master (#2302) 2020-12-15 08:42:33 -08:00
Anuraag Agrawal e802b8ab35
Detect invalid use of makeCurrent in Kotlin coroutine. (#2227)
* Detect invalid use of makeCurrent in Kotlin coroutine.

* Fix and check suspending function too.

* Newline

* Doc

* Some comments

* teency
2020-12-15 15:09:34 +09:00
Anuraag Agrawal 3701a8bdf6
Move DaemonThreadFactory to internal package. (#2288) 2020-12-14 21:06:00 -08:00
Anuraag Agrawal 262dd7a866
Use key as AttributeKey.toString (#2175)
* Use key as AttributeKey.toString

* Fix / more tests

* Add toString test for SpanWrapper

* Quote string values

* Fix
2020-12-15 12:49:45 +09:00
Anuraag Agrawal 13e6485a63
Add Context.toString (#2289) 2020-12-15 11:57:36 +09:00
Anuraag Agrawal 7ff20f6db6
Move Sampler builder to top level (#2291)
* Move Sampler builder to top level

* Hide implementation class

* Ordering
2020-12-15 10:16:08 +09:00
Anuraag Agrawal 91dc119181
Move Sdk to be prefix of implementation classes instead of suffix/midfix. (#2292) 2020-12-14 11:59:28 -08:00
dengliming acd063c302
Fix comment and remove import (#2300) 2020-12-14 11:55:35 -08:00
Anuraag Agrawal f626cb9705
Move export processor builders to top level. (#2286) 2020-12-14 11:38:03 -08:00
Anuraag Agrawal cd226f14c4
Move exporter builders to top level. (#2294) 2020-12-14 11:32:57 -08:00
Anuraag Agrawal 4403923bed
Migrate AWS mock server tests to junit5. (#2287) 2020-12-14 10:20:19 -08:00
Anuraag Agrawal 6f97da1261
Make AttributeKey compare normally with both type/key. (#2284)
* Make AttributeKey compare normally with both type/key.

* Say hi to murphy
2020-12-14 09:56:56 -08:00
Bogdan Drutu 8a8799ec9e
Small nit in internal members order (#2232)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-12 16:18:38 -08:00
Bogdan Drutu 634a9d9f72
Call point constructor with the value got instead of getting the value again (#2278)
Not a problem in the Double version where this is implemented correctly.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-11 21:01:26 -08:00
Bogdan Drutu c8f1f27f07
Remove OpenTelemetryBuilder interface, every implementation will have it's own builder (#2275)
This PR also fixes the DefaultOpenTelemetry builder to be it's own class and not a sub-class.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-12 13:09:58 +09:00
jason plumb 5e891ccad9
make imports consistent with other files in this package. (#2280) 2020-12-11 15:38:42 -08:00
Bogdan Drutu d4bddd1fdf
Change MetricData to be consistent with protos, move creation to the Aggregation (#2274)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-11 11:04:12 -08:00
Nikita Salnikov-Tarnovski 4a400fed2c
Some example of possible SDK configuration (#2263)
* Some example of possible SDK configuration

* Format
2020-12-11 18:12:13 +09:00
Prashant Srivastava f88e207f09
Adding instructions to run benchmarks (#2271)
* benchmark readme for opentelemetry-sdk

* benchmark instructions for all the modules

* Fixing typo
2020-12-11 14:40:16 +09:00
Bogdan Drutu 59f54bdb9f
Introduce accumulator concept (#2269)
The code already existed as part of the instrument, but it was extracted in a separate concept,
and all Sync/Async instruments look very similar: Descriptor + Accumulator.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 18:04:41 -08:00
Bogdan Drutu 63aa8e91ab
Move the building/registration logic down the stack to avoid duplicate code (#2267)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 10:25:11 -08:00
Bogdan Drutu ca1f31dfb5
Use standard Java interfaces instead of defining custom ones (#2261)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 09:16:24 -08:00
Bogdan Drutu 252f8f385f
Change bound factory to accept Aggregator (#2258)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 08:21:16 -08:00
Bogdan Drutu 78d1ad5cce
Remove unnecessary generic argument from AsynchronousInstrument (#2260)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 08:20:36 -08:00
Bogdan Drutu 5d269502c7
Avoid passing the meter SDK instance if unnecessary (#2259)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 08:09:16 -08:00
Bogdan Drutu 8fc66bf36e
Change AbstractSynchronousInstrument to accept a bound factory instead of abstract method (#2257)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 20:35:03 -08:00
Bogdan Drutu 396fa44601
Change ComponentRegistry to be a final class that accepts a factory method (#2256)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 20:26:06 -08:00
Bogdan Drutu feedef2366
Rename accumulator to processor to match Go (#2255)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 20:19:31 -08:00
Anuraag Agrawal 56235a1114
Move TraceConfig.Builder to the top level (#2241)
* Move TraceConfig.Builder to the top level

* Remove builder
2020-12-09 19:54:07 -08:00
Bogdan Drutu 583b2cc68b
Remove unused fields from AbstractInstrument (#2254)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 17:15:43 -08:00
John Watson 49ef0fd67e
Make JavaVersionSpecific non-public. (#2253) 2020-12-10 09:07:46 +09:00
John Watson c5e951ecba
fix some out-of-date javadoc (#2252) 2020-12-09 14:56:39 -08:00
John Watson fd0b522dee
Update some out-of-date/broken docs (#2251) 2020-12-09 14:24:10 -08:00
jason plumb bd4e93187a
Add caching for sanitized labels in the Prometheus MetricAdapter. (#2211)
* cache sanitized labels

* rollback

* address PR feedback
2020-12-09 13:39:54 -08:00
Bogdan Drutu ae63b9fbe7
Update types to reflect the names in proto (#2243)
* Update types to reflect the names in proto

NON_MONOTONIC_SUM will be soon merged with SUM and offer the "isMonotonic" as a property.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update names to follow, type + aggregation pattern

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 13:13:32 -08:00
Bogdan Drutu 658ab98610
Remove all implementations of the InstrumentAccumulator, kepp only the AllLabels (#2248)
This PR fixes a small bug where the AllLabels implementation was expecting "unmapped" boolean, which was passed correctly by the Sync instruments, but incorrectly by the Async.
This causes an unnecessary allocation for all the async instruments recordings.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 13:12:15 -08:00
Anuraag Agrawal f199e133fa
Implement more Span default methods. (#2242)
* Implement more Span default methods.

* A bit more
2020-12-09 13:08:52 -08:00
jason plumb 9d344a407e
remove test dependency on grpc (#2249) 2020-12-09 13:08:22 -08:00
Prashant Srivastava 4c886ddc20
Span benchmark with OTLP exporter and collector (#2214)
* Refactored benchmark to use OTLP exporter and collector

* Refactoring to add  benchmarks with Simple and Batch span processors

* Removing otlp exporter from the collector config

* Using setTraceConfig to set the initial config rather than update it

* Spotlessapply
2020-12-09 13:03:20 -08:00
jason plumb 6af53c226d
Update README for extensions propagators (#2207)
* Update README for extensions propagators for #2067.

* OpenTracing -> LightStep OpenTracing

* Update extensions/trace-propagators/README.md

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>

* b3 and jaeger are supported here.

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2020-12-09 11:42:31 -08:00
Bogdan Drutu d9260d0656
Rename batcher to instrumentaccumulator, remove active batcher (not used) (#2245)
* Rename batcher to instrumentaccumulator, remove active batcher (not used)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix tests, add back check for has records

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 11:27:20 -08:00
dependabot[bot] 681579c30b
Bump burrunan/gradle-cache-action from v1.5 to v1.6 (#2240)
Bumps [burrunan/gradle-cache-action](https://github.com/burrunan/gradle-cache-action) from v1.5 to v1.6.
- [Release notes](https://github.com/burrunan/gradle-cache-action/releases)
- [Changelog](https://github.com/burrunan/gradle-cache-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/burrunan/gradle-cache-action/compare/v1.5...feb985ecf49f57f54f31920821a50d0394faf122)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-09 07:19:42 -08:00