* Unwrap `ExceptionInfo` and `ExceptionWithTraceback`
Instead of reporting the `ExceptionInfo` and `ExceptionWithTraceback`
wrappers raised by Celery, report the exceptions that they wrap.
This ensures that the exception in the OpenTelemetry span has a type
and traceback that are meaningful and relevant to the developer.
* Fix typo
The exception is expected, not excepted. Well, I guess it is also
excepted, because it's an exception, but you get what I mean.
* Reformat file with `black`
Reformat the `__init__.py` file in the Celery instrumentation using
`black`, fixing a CI linter error.
* Address review feedback
Use the VERSION attribute exposed by Billiard to decide whether to
import ExceptionWithTraceback.
Add a test for a failing task and check that the exceptions' type
and message are preserved.
* Amend ExceptionWithTraceback import
* Use a weak reference to sqlalchemy Engine to avoid memory leak
Closes#1761
By using a weak reference to the `Engine` object, we can avoid the memory leak as disposed `Engines` get properly deallocated. Whenever `SQLAlchemy` is uninstrumented, we only trigger a removal for those event listeners which are listening for objects that haven't been garbage-collected yet.
* Made a mistake in resolving the weak reference
* Fixed formatting issues
* Updated changelog
* Added unit test to check that engine was garbage collected
* Do not save engine in EngineTracer to avoid memory leak
* Add an empty line to satisfy black formatter
* Fix isort complaints
* Fixed the issue when pool name is not set and =None
* Fix formatting issue
* Rebased after changes in a recent commit
* Updated PR number in changelog
---------
Co-authored-by: Shalev Roda <65566801+shalevr@users.noreply.github.com>
* fix(grpc): Allow gRPC connections via Unix socket
This commit addresses issue #1832.
The way `NET_PEER_IP` and `NET_PEER_PORT` are retrieved raises a `ValueError`
when gRPC connections are handled via Unix sockets.
```py
ip, port = (
context.peer().split(",")[0].split(":", 1)[1].rsplit(":", 1)
)
```
When using an address like `unix:///tmp/grpc.sock` the value of `context.peer()` is `"unix:"`.
Substituting that in the function above...
```py
ip, port = "unix:".split(",")[0].split(":", 1)[1].rsplit(":", 1)
ip, port = ["unix:"][0].split(":", 1)[1].rsplit(":", 1)
ip, port = "unix:".split(":", 1)[1].rsplit(":", 1)
ip, port = ["unix", ""][1].rsplit(":", 1)
ip, port = "".rsplit(":", 1)
ip, port = [""] # ValueError
```
I "addressed" the issue by guarding the retrieval of `net.peer.*` values under
an `if` statement that checks if we are using a Unix socket.
I extended the `server_interceptor` tests to run against TCP and Unix socket configurations.
---
**Open Questions**
- [ ] The socket tests will fail on Windows. Is there a way to annotate that?
- [ ] Are there other span values we should be setting for the unix socket?
* Update CHANGELOG
* Add placeholder attributes for linter
* fix lint
---------
Co-authored-by: Matt Oberle <mattoberle@users.noreply.github.com>
Co-authored-by: Shalev Roda <65566801+shalevr@users.noreply.github.com>
* Add http.server.response.size metric to ASGI implementation.
Add new unit tests.
* Update changelog.
* Fix linting by disabling too-many-nested-blocks
* Put new logic in a new method
* Refactor the placement of new logic.
* Fixed the unit tests in FastAPI and Starlette
* Update changelog.
* FIx lint errors.
* Refactor getting content-length header
* Refactor getting content-length header
---------
Co-authored-by: Shalev Roda <65566801+shalevr@users.noreply.github.com>
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
* Add support for confulent_kafka until 2.1.1 version
* Include 2.1.1 version
* update CHANGELOG.md
* run: 'tox -e generate'
* resolve comments
* update top version to 2.2.0
---------
Co-authored-by: Ran Nozik <ran@gethelios.dev>
Leighton Chen
OpenTelemetry Bot
Liudmila Molkova
Diego Hurtado
Margaret Yu
André "decko" de Brito
Jeremy Voss
Allen Kim
João Thallis
Noemi
mattcontinisio
Javier Fernández Rodríguez
Raphael Philipe Mendes da Silva
Jakub Warczarek
Thomas LÉVEIL
Tristan Sloughter
Alexandre Papin
Marc Dougherty
Mario Jonke
Tammy Baylis
Rytis Bagdziunas
Shalev Roda
Vivanov98
Nimrod Shlagman
Iman Shafiei
Matt Oberle
dependabot[bot]
Michael
Iman Shafiei
Pablo Collins
David Gonoradsky
Akochavi