Fix system name for MySQL (#2276)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This commit is contained in:
parent
7d8f29d80e
commit
92ffed6952
|
|
@ -0,0 +1,22 @@
|
||||||
|
# Use this changelog template to create an entry for release notes.
|
||||||
|
#
|
||||||
|
# If your change doesn't affect end users you should instead start
|
||||||
|
# your pull request title with [chore] or use the "Skip Changelog" label.
|
||||||
|
|
||||||
|
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
|
||||||
|
change_type: bug_fix
|
||||||
|
|
||||||
|
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
|
||||||
|
component: db
|
||||||
|
|
||||||
|
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
|
||||||
|
note: Fix the `db.system.name` attribute value for MySQL which was incorrectly pointing to `microsoft.sql_server`.
|
||||||
|
|
||||||
|
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
|
||||||
|
# The values here must be integers.
|
||||||
|
issues: [ 2276 ]
|
||||||
|
|
||||||
|
# (Optional) One or more lines of additional information to render under the primary note.
|
||||||
|
# These lines will be padded with 2 spaces and then inserted directly into the document.
|
||||||
|
# Use pipe (|) for multiline entries.
|
||||||
|
subtext:
|
||||||
|
|
@ -28,7 +28,7 @@ The Semantic Conventions for *MySQL* extend and override the [Database Semantic
|
||||||
|
|
||||||
Spans representing calls to a MySQL Server adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md).
|
Spans representing calls to a MySQL Server adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md).
|
||||||
|
|
||||||
`db.system.name` MUST be set to `"microsoft.sql_server"` and SHOULD be provided **at span creation time**.
|
`db.system.name` MUST be set to `"mysql"` and SHOULD be provided **at span creation time**.
|
||||||
|
|
||||||
**Span kind** SHOULD be `CLIENT`.
|
**Span kind** SHOULD be `CLIENT`.
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -229,7 +229,7 @@ groups:
|
||||||
brief: >
|
brief: >
|
||||||
Spans representing calls to a MySQL Server adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md).
|
Spans representing calls to a MySQL Server adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md).
|
||||||
note: |
|
note: |
|
||||||
`db.system.name` MUST be set to `"microsoft.sql_server"` and SHOULD be provided **at span creation time**.
|
`db.system.name` MUST be set to `"mysql"` and SHOULD be provided **at span creation time**.
|
||||||
attributes:
|
attributes:
|
||||||
- ref: db.namespace
|
- ref: db.namespace
|
||||||
sampling_relevant: true
|
sampling_relevant: true
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue