Commit Graph

420 Commits

Author SHA1 Message Date
Bertrand Martin b3414fcb7f Issue #3236 Update attribute requirement levels in hardware metrics semconv (#3258)
Fixes #3236

## Changes

* Update attributes requirement levels in
`specification\metrics\semantic_conventions\hardware-metrics.md`
* Minor wording corrections
2023-03-24 19:29:20 -05:00
Tristan Sloughter 13e82eae88 erlang/elixir: add stacktrace representation to table (#3313)
Adds the functions to use for stacktrace representation in Erlang/Elixir
to the semantic conventions table for exceptions.
2023-03-24 12:05:38 -06:00
Alexander Wert efa4181f83 Added AWS S3 semantic conventions (#3251) 2023-03-22 08:29:16 -07:00
Sourabh Jain 006e3b4091 Add Cosmosdb attributes for open telemetry (#3097) 2023-03-21 10:49:17 -07:00
Liudmila Molkova 139842c9e0 BREAKING: remove messaging.destination.kind and messaging.source.kind values (#3214)
Fixes #3170, #3265, #3249

## Changes

~~We currently allow `topic` or `queue` on `messaging.destination.kind`.
While it's common in messaging world to have one or another, messaging
semantic conventions can be applied to AMPQ communication (which does
not have topic/queue terminology), [socket.io](https://socket.io/), and
potentially other less traditional messaging use-cases.~~

It's unclear how `messaging.destination.kind` and
`messaging.source.kind` could be used. The distinction between queue and
topic is significant for messaging and distributed systems, but not for
tracing.

In either case, tracing backends should expect to process traces from 0+
messaging and 0+ messaging consumers. In either case, message consumers
can be simultaneous or consequent and there could be many of them.

The only known case (Solace) where it could be useful is when messaging
system allows having queues and topic with the same name on the same
broker, and it could be used to distinguish one from another.

Based on messaging SIG discussion, the attributes are removed for the
time being until we understand if and how they are useful.

Depending on messaging system queues or topics behavior vary a lot and
in future it would makes more sense to represent actual behavior with
individual attributes such as:
- auto-settlement (at-most-once or at least once guarantees)
- settlement for individual messages or offsets
- broadcast or unicast
- etc
2023-03-21 10:51:55 -06:00
Liudmila Molkova e22e6d4674 Make markdown-link-check work again (#3327)
Link check is broken due to
https://github.com/tcort/markdown-link-check/issues/246, pinning
previous version until it's fixed
2023-03-21 08:19:14 -06:00
Peter Liu 1bae921042 Add `toc` for metric http semconv (#3318)
## Changes

Add `toc` for metric http semconv markdown file

Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
2023-03-16 22:52:38 -04:00
Trask Stalnaker b7e8b54419 BREAKING rename `net.app.protocol.(name|version)` to `net.protocol.(name|version)` and replace `http.flavor` with `net.protocol.(name|version)` (#3272) 2023-03-10 10:15:15 -08:00
Patrice Chalin ade0ab600a [editorial] Use path, not external URL, for link to spec page; and fix broken link (#3310) 2023-03-10 07:39:32 -08:00
jack-berg 12328be1c2 Metric units should use UCUM case sensitive variant (#3306) 2023-03-08 10:57:55 -08:00
Tyler Yahn d28c963926 Fix grammatical number of metric semconv units (#3298) 2023-03-08 09:17:29 -08:00
Jamie Danielson 40a91717ba Show relationship between http target and route in example usage (#3292)
## Changes

Clarify relationship between `http.target` and `http.route` by using the
same pattern in the example usage. Having different patterns for the
attribute values distorts the relationship between the two attributes.

A similar pattern is seen in the docs for
[`aws-lambda.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/instrumentation/aws-lambda.md#api-gateway-request-proxy-lambda-tracing-passive),
where `http.target` is `/pets/10` and `http.route` is `/pets/{petId}`.
It's a minor adjustment but should help provide clarity for new users.

---------

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
2023-03-08 09:12:28 -08:00
Trask Stalnaker 489fea52c8 net.peer.name clarification for HTTP client semconv (#3276)
Fixes #3273

## Changes

Clarifies that if an HTTP client request is explicitly made to an IP
address, e.g. `http://x.x.x.x:8080`, then
`net.peer.name` SHOULD be the IP address `x.x.x.x`.
2023-03-06 09:33:35 -06:00
Haddas Bronfman c7c60cae12 Expand pool.name in semantic conventions (#3050)
according to the discussion here:
https://github.com/open-telemetry/opentelemetry-specification/issues/3038
I'm updating the `pool.name attribute`
2023-03-03 10:59:56 -06:00
Trask Stalnaker c9ff781e94 Make net.sock.host.port conditionally required (#3246) 2023-03-02 14:01:52 -08:00
Trask Stalnaker 6d7b233c80 Rename http.user_agent to user_agent.original (#3190)
Fixes #3180

## Changes

Renames `http.user_agent` to `user_agent.original`.
2023-03-02 14:47:29 -06:00
Trask Stalnaker 47cabcf799 Rename Optional attribute requirement level to Opt-In (#3228) 2023-03-01 15:13:24 -08:00
Matthew Wear f839f1ed9a clarify how to collect host.id for non-containerized systems (#3173) 2023-02-28 18:17:04 +01:00
Trask Stalnaker 90a7dae56c Remove mention of net.transport from http semantic conventions (#3244)
Based on @lmolkova's
https://github.com/open-telemetry/opentelemetry-specification/issues/3215#issuecomment-1439068151

## Changes

Removes mention of `net.transport` from http semantic conventions.

---------

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2023-02-28 10:52:04 -05:00
Tigran Najaryan e9d9309590 Update build-tools to 1.16.0 (#3259)
build-tools 1.16.0 was just released and is necessary to unblock
https://github.com/open-telemetry/opentelemetry-specification/pull/3190
2023-02-27 17:39:23 -05:00
Tyler Benson 2447fb063f Expand scope of `faas.id` to `cloud.resource_id` (#3188)
## Changes
As per the discussion on #3188, we determined it is better to move
rather than remove as this attribute is still important for some systems
despite it containing duplicated information.
2023-02-27 12:13:13 -06:00
Antoine Toulme 12481fef89 add semantic conventions for heroku (#3075)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2023-02-27 10:23:29 +01:00
Trask Stalnaker a0691c65ed Rename nonheap to non_heap (#3250)
Fixes
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7876
(the implementation used `non_heap`, which seems better)

## Changes

Renames JVM metric attribute value from `nonheap` to `non_heap`.

---------

Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
2023-02-24 09:59:43 -06:00
Trask Stalnaker 85ec713c1c Metric requirement levels (#3237) 2023-02-23 08:22:54 -08:00
Joshua Carpeggiani 0f2a834cda Add Connect RPC to semantic conventions (#3116)
* Add connect_rpc to rpc.yaml

* Add connect rpc into rpc-metrics and rpc markdown

* Add Connect RPC change to CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2023-02-21 09:50:35 -05:00
Tyler Benson 0d0b9d0a7d Rename `faas.execution` to `faas.invocation_id` and change units for `faas.max_memory` (#3209) 2023-02-20 09:29:24 -06:00
Patrice Chalin 1971550982 [editorial] Fix Tencent Cloud link (#3231) 2023-02-20 10:29:04 +01:00
Tigran Najaryan 702cf2cdf3 Rename Logs API to Logs Bridge API to prevent confusion (#3197)
We keep seeing confusion about what Logs API is. There was a proposal [1]
to use the term Bridge API to help prevent the confusion.

Please take a look and comment on whether you think this renaming helps
and is reasonable.

[1] https://github.com/open-telemetry/opentelemetry-specification/pull/3187#issuecomment-1424431424
2023-02-16 14:55:56 -05:00
Patrice Chalin 6086a26696 Update exceptions.md (#3217) 2023-02-16 05:42:42 -06:00
Martin Knechtel 8290599ccd Get rid of double negation in Events semantic conventions (#3159)
* getting rid of double negation

* Update specification/logs/semantic_conventions/events.md

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

---------

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
2023-02-15 14:56:19 -05:00
Armin Ruech a0f96da61f Fix rpc examples to include grpc namespace (#3211) 2023-02-15 09:12:30 -08:00
Liudmila Molkova 3a0a197f4c Use attribute_group for cross-signal HTTP attributes (#3183) 2023-02-13 16:00:14 -08:00
Tyler Benson 30ef366d8a Update aws lambda spec to remove X-Ray Env propagation (#3166)
* Update aws lambda spec to remove X-Ray Env propagation

Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators.
2023-02-10 10:57:34 -06:00
Carlos Alberto Cortez 1781e9270e Add 1.1.8.0 Schema. (#3175) 2023-02-07 13:01:58 -06:00
Trask Stalnaker 2165c692f9 Http route should contain application root (#3164) 2023-02-06 12:50:01 -08:00
Trask Stalnaker 27e087b3b6 Add http metrics yaml (#3158)
* Add http metrics yaml

* Update change log

* Fix notes

* Fix link

* Remove unnecessary field
2023-02-06 12:54:51 -05:00
Trask Stalnaker 9170ccaeeb Changes to http span name (#3165) 2023-02-03 08:33:10 -08:00
Armin Ruech 912809fb42 Enable semantic convention tooling for metrics (#3119) 2023-01-24 08:52:53 -08:00
Ben B e35ad2b9d5 [semantic_conventions/resource] fix google platform openshift naming (#3095) 2023-01-23 14:56:48 -08:00
Michael Murphy b45d32f1ed Add cloud spanner and mssql compact to db specifications (#3105) 2023-01-23 16:18:51 -06:00
Martin Costello ebcf353c33 Remove rogue bracket (#3108) 2023-01-17 09:54:55 -08:00
Carlos Alberto Cortez 54ca902e06 Update the 1.17 Schema to reference the proper changes PR (#3099) 2023-01-12 20:01:16 -06:00
v-electrolux 708df51809 Add ClickHouse in the database group (#3011) 2023-01-03 19:40:09 -06:00
jordigh 4de43114a4 Suggest column # as an extra source code attribute (#3029) 2023-01-02 18:01:32 -06:00
Liudmila Molkova a7ede6fbfa Refactor messaging attributes and specify per-message attributes (#2957) 2022-12-22 17:04:53 -06:00
Armin Ruech 41f5b5508b Clarify common HTTP attributes apply to both clients and servers (#3044) 2022-12-16 21:48:49 +01:00
Patrice Chalin 90a6aeee14 [editorial] Metrics hardware sem. conv. front matter (#3045) 2022-12-16 13:17:23 -06:00
Carlos Alberto Cortez 3f3308305b Add 1.16.0 Schema. (#3016) 2022-12-08 00:37:22 +01:00
Ben B 656644592a [resource] add openshift platform to all supported cloud providers (#2985) 2022-12-06 16:52:30 +01:00
Bertrand Martin 0204860d46 Update semconv for hardware metrics to use `direction` attributes (#2942) 2022-12-06 00:17:54 +01:00