There are changes required for the ember upgrade but additional changes
for individual libs are also present. Commit has been squashed, see
individual commits if needed.
There are a bunch of HBS changes as well. These are to deal with a
couple new rules and there impact is low. The button one has bitten us a
few time so this seemed great to add IMO.
update ember 3.12.4
ember 3.13
fixes for new eslint rules
ember 3.13->3.14
ember3.14->3.16
ember3.16->3.20
3.20 lint rules
yarn upgrade
update ember-optional-feature
update deps that can go to patch versions
upgrade major versions that are possible
update ansi_up
only reset term var if we're not destroying
prevents new ember 'same computation' error
update async
upgrade dot-object
new-catalog - add set to deal with new warning
marked-down - drop call into next to ensure its called at the correct time
upgrade ember-assign
update ember-cli-clipboard
remove unused & deprecated ember-cli-release
remove unused drag-drop lib
use set on tracked prop
update ember-flatpickr && cli-test-loader
upgrade ember-href-to
update filesaver
update liquid-fire and ipaddr
upgrade jsondiffpatch
upgrade marked
upgrade semver
update xterm
Update ember-basic-dropdown
the library has changed quite a bit and no longer provides an addon for the content-item where we handling the click event to close the dropdown,
thus click events must be added manually to the items being clicked to close the dropdown.
udpate dompurify
fix page header project styles
Bump ember api store, remove npm-run-all
Autofix button types from hbs linting
this change looks large but only adds `type` button to any buttons that dont have a type, which should help to reduce weird side effects
more hbs lint changes for no-negate-condition
turned off a couple rules that could be too much to test right now
- Make table sorting work with scheduled scans
- Make the cis table fit on laptop screen
- Add an appropriate placeholder for the scheduled scans cron field
rancher/rancher#25937rancher/rancher#25939
We're removing the CIS skip button because we decided the current UX
is poort and we don't want to spend a tremendous amount of effort
making a marginally better UX in the short time we have left.
We also removed the 19 of 59 from the main CIS page as the total was
misleading and wasn't actionable.
rancher/rancher#25863
- Added Set Alert button
- This will set the appropriate options for cis
- Added Set Schedule button
- This will scroll the settings into view
- Added a modal so profiles can be picked
This refactoring removed code duplication and
provides a more cohesive experience across all
of the pages that you can run a scan.
This will also now check and ensure the following
- there aren't running ClusterScans
- this isn't a windows cluster
- systemProject is available
- the cluster is active
- the action link is available
When the above isn't the case Run CIS Scan will not be present in
the cluster action drop downs and the Run CIS Scan but
will be disabled on the CIS Scans and CIS Scan Detail
pages.
rancher/rancher#24759rancher/rancher#25298
Improving the UX of CIS based on the feedback that was received during
the review.
- Sort scans by date so newest will be on top.
- Details should be sorted by state in Fail, Skipped, Pass order
- Add a Run CIS Scan action to the cluster menu.
We validating the security scan config appropriately when
a version was already present in the skip list. This now
ensures a version exists before verifying that it contains an array.
We were also replacing the existing skip object in the
security-scan-config which prevented us from storing
multiple versions at a time. We now extend the object
instead using the spread operator.
rancher/rancher#24733rancher/rancher#24742
When the user doesn't have access to the systemProject we just
return an empty configMap so the page can proceed without error.
We also disable the runScan button if the systemProject isn't available.
rancher/rancher#24644
Because the scan will ignore an invalid config map I'm removing
the validation from run scan so the UI can run the scan without issue.
rancher/rancher#24496
The new API required that I pass null instead of an empty array
as the skiplist if nothing is supposed to be skipped when
running a scan.
Updated the color of the running state to info instead of success
as requested.
We provide an error notification when the security config is malformed and
the user attempts to run a scan. We also prevent the scan from running.
We also added a default sort by 'id' on the scan detail table.
rancher/rancher#24495rancher/rancher#24496
On the CIS Scans page we now show a notification which informs the user
that CIS scans are only available on RKE clusters. The notification is all that is
shown on the page since the user cannot actually run a scan or view any
scans.
rancher/rancher#24433
Westly Wright
Cody Jackson