mirror of https://github.com/vllm-project/vllm.git
253 lines
11 KiB
Markdown
253 lines
11 KiB
Markdown
# Contributing to vLLM
|
|
|
|
Thank you for your interest in contributing to vLLM! Our community is open to everyone and welcomes all kinds of contributions, no matter how small or large. There are several ways you can contribute to the project:
|
|
|
|
- Identify and report any issues or bugs.
|
|
- Request or add support for a new model.
|
|
- Suggest or implement new features.
|
|
- Improve documentation or contribute a how-to guide.
|
|
|
|
We also believe in the power of community support; thus, answering queries, offering PR reviews, and assisting others are also highly regarded and beneficial contributions.
|
|
|
|
Finally, one of the most impactful ways to support us is by raising awareness about vLLM. Talk about it in your blog posts and highlight how it's driving your incredible projects. Express your support on social media if you're using vLLM, or simply offer your appreciation by starring our repository!
|
|
|
|
## Job Board
|
|
|
|
Unsure on where to start? Check out the following links for tasks to work on:
|
|
|
|
- [Good first issues](https://github.com/vllm-project/vllm/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22)
|
|
- [Selected onboarding tasks](gh-project:6)
|
|
- [New model requests](https://github.com/vllm-project/vllm/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22new-model%22)
|
|
- [Models with multi-modal capabilities](gh-project:10)
|
|
|
|
## License
|
|
|
|
See <gh-file:LICENSE>.
|
|
|
|
## Developing
|
|
|
|
Depending on the kind of development you'd like to do (e.g. Python, CUDA), you can choose to build vLLM with or without compilation.
|
|
Check out the [building from source][build-from-source] documentation for details.
|
|
|
|
For an optimized workflow when iterating on C++/CUDA kernels, see the [Incremental Compilation Workflow](./incremental_build.md) for recommendations.
|
|
|
|
### Building the docs with MkDocs
|
|
|
|
#### Introduction to MkDocs
|
|
|
|
[MkDocs](https://github.com/mkdocs/mkdocs) is a fast, simple and downright gorgeous static site generator that's geared towards building project documentation. Documentation source files are written in Markdown, and configured with a single YAML configuration file.
|
|
|
|
#### Install MkDocs and Plugins
|
|
|
|
Install MkDocs along with the [plugins](https://github.com/vllm-project/vllm/blob/main/mkdocs.yaml) used in the vLLM documentation, as well as required dependencies:
|
|
|
|
```bash
|
|
pip install -r requirements/docs.txt
|
|
```
|
|
|
|
!!! note
|
|
Ensure that your Python version is compatible with the plugins (e.g., `mkdocs-awesome-nav` requires Python 3.10+)
|
|
|
|
#### Verify Installation
|
|
|
|
Confirm that MkDocs is correctly installed:
|
|
|
|
```bash
|
|
mkdocs --version
|
|
```
|
|
|
|
Example output:
|
|
|
|
```console
|
|
mkdocs, version 1.6.1 from /opt/miniconda3/envs/mkdoc/lib/python3.10/site-packages/mkdocs (Python 3.10)
|
|
```
|
|
|
|
#### Clone the `vLLM` repository
|
|
|
|
```bash
|
|
git clone https://github.com/vllm-project/vllm.git
|
|
cd vllm
|
|
```
|
|
|
|
#### Start the Development Server
|
|
|
|
MkDocs comes with a built-in dev-server that lets you preview your documentation as you work on it. Make sure you're in the same directory as the `mkdocs.yml` configuration file, and then start the server by running the `mkdocs serve` command:
|
|
|
|
```bash
|
|
mkdocs serve
|
|
```
|
|
|
|
Example output:
|
|
|
|
```console
|
|
INFO - Documentation built in 106.83 seconds
|
|
INFO - [22:02:02] Watching paths for changes: 'docs', 'mkdocs.yaml'
|
|
INFO - [22:02:02] Serving on http://127.0.0.1:8000/
|
|
```
|
|
|
|
#### View in Your Browser
|
|
|
|
Open up [http://127.0.0.1:8000/](http://127.0.0.1:8000/) in your browser to see a live preview:.
|
|
|
|
#### Learn More
|
|
|
|
For additional features and advanced configurations, refer to the official [MkDocs Documentation](https://www.mkdocs.org/).
|
|
|
|
## Testing
|
|
|
|
??? note "Commands"
|
|
|
|
```bash
|
|
pip install -r requirements/dev.txt
|
|
|
|
# Linting, formatting and static type checking
|
|
pre-commit install --hook-type pre-commit --hook-type commit-msg
|
|
|
|
# You can manually run pre-commit with
|
|
pre-commit run --all-files
|
|
|
|
# To manually run something from CI that does not run
|
|
# locally by default, you can run:
|
|
pre-commit run mypy-3.9 --hook-stage manual --all-files
|
|
|
|
# Unit tests
|
|
pytest tests/
|
|
|
|
# Run tests for a single test file with detailed output
|
|
pytest -s -v tests/test_logger.py
|
|
```
|
|
|
|
!!! tip
|
|
Since the <gh-file:docker/Dockerfile> ships with Python 3.12, all tests in CI (except `mypy`) are run with Python 3.12.
|
|
|
|
Therefore, we recommend developing with Python 3.12 to minimise the chance of your local environment clashing with our CI environment.
|
|
|
|
!!! note
|
|
Currently, the repository is not fully checked by `mypy`.
|
|
|
|
!!! note
|
|
Currently, not all unit tests pass when run on CPU platforms. If you don't have access to a GPU
|
|
platform to run unit tests locally, rely on the continuous integration system to run the tests for
|
|
now.
|
|
|
|
## Issues
|
|
|
|
If you encounter a bug or have a feature request, please [search existing issues](https://github.com/vllm-project/vllm/issues?q=is%3Aissue) first to see if it has already been reported. If not, please [file a new issue](https://github.com/vllm-project/vllm/issues/new/choose), providing as much relevant information as possible.
|
|
|
|
!!! important
|
|
If you discover a security vulnerability, please follow the instructions [here](gh-file:SECURITY.md#reporting-a-vulnerability).
|
|
|
|
## Pull Requests & Code Reviews
|
|
|
|
Thank you for your contribution to vLLM! Before submitting the pull request,
|
|
please ensure the PR meets the following criteria. This helps vLLM maintain the
|
|
code quality and improve the efficiency of the review process.
|
|
|
|
### DCO and Signed-off-by
|
|
|
|
When contributing changes to this project, you must agree to the <gh-file:DCO>.
|
|
Commits must include a `Signed-off-by:` header which certifies agreement with
|
|
the terms of the DCO.
|
|
|
|
Using `-s` with `git commit` will automatically add this header.
|
|
|
|
!!! tip
|
|
You can enable automatic sign-off via your IDE:
|
|
|
|
- **PyCharm**: Click on the `Show Commit Options` icon to the right of the `Commit and Push...` button in the `Commit` window.
|
|
It will bring up a `git` window where you can modify the `Author` and enable `Sign-off commit`.
|
|
- **VSCode**: Open the [Settings editor](https://code.visualstudio.com/docs/configure/settings)
|
|
and enable the `Git: Always Sign Off` (`git.alwaysSignOff`) field.
|
|
|
|
### PR Title and Classification
|
|
|
|
Only specific types of PRs will be reviewed. The PR title is prefixed
|
|
appropriately to indicate the type of change. Please use one of the following:
|
|
|
|
- `[Bugfix]` for bug fixes.
|
|
- `[CI/Build]` for build or continuous integration improvements.
|
|
- `[Doc]` for documentation fixes and improvements.
|
|
- `[Model]` for adding a new model or improving an existing model. Model name
|
|
should appear in the title.
|
|
- `[Frontend]` For changes on the vLLM frontend (e.g., OpenAI API server,
|
|
`LLM` class, etc.)
|
|
- `[Kernel]` for changes affecting CUDA kernels or other compute kernels.
|
|
- `[Core]` for changes in the core vLLM logic (e.g., `LLMEngine`,
|
|
`AsyncLLMEngine`, `Scheduler`, etc.)
|
|
- `[Hardware][Vendor]` for hardware-specific changes. Vendor name should
|
|
appear in the prefix (e.g., `[Hardware][AMD]`).
|
|
- `[Misc]` for PRs that do not fit the above categories. Please use this
|
|
sparingly.
|
|
|
|
!!! note
|
|
If the PR spans more than one category, please include all relevant prefixes.
|
|
|
|
### Code Quality
|
|
|
|
The PR needs to meet the following code quality standards:
|
|
|
|
- We adhere to [Google Python style guide](https://google.github.io/styleguide/pyguide.html) and [Google C++ style guide](https://google.github.io/styleguide/cppguide.html).
|
|
- Pass all linter checks. Please use `pre-commit` to format your code. See
|
|
<https://pre-commit.com/#usage> if `pre-commit` is new to you.
|
|
- The code needs to be well-documented to ensure future contributors can easily
|
|
understand the code.
|
|
- Include sufficient tests to ensure the project stays correct and robust. This
|
|
includes both unit tests and integration tests.
|
|
- Please add documentation to `docs/` if the PR modifies the user-facing behaviors of vLLM.
|
|
It helps vLLM users understand and utilize the new features or changes.
|
|
|
|
### Adding or Changing Kernels
|
|
|
|
When actively developing or modifying kernels, using the [Incremental Compilation Workflow](./incremental_build.md) is highly recommended for faster build times.
|
|
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.
|
|
|
|
- Make sure custom ops are registered following PyTorch guidelines:
|
|
[Custom C++ and CUDA Operators](https://pytorch.org/tutorials/advanced/cpp_custom_ops.html#cpp-custom-ops-tutorial)
|
|
and [The Custom Operators Manual](https://docs.google.com/document/d/1_W62p8WJOQQUzPsJYa7s701JXt0qf2OfLub2sbkHOaU).
|
|
- Custom operations that return `Tensors` require meta-functions.
|
|
Meta-functions should be implemented and registered in Python so that dynamic
|
|
dims can be handled automatically. See above documents for a description of
|
|
meta-functions.
|
|
- Use [torch.library.opcheck()](https://pytorch.org/docs/stable/library.html#torch.library.opcheck)
|
|
to test the function registration and meta-function for any registered ops.
|
|
See `tests/kernels` for examples.
|
|
- When changing the C++ signature of an existing op, the schema must be updated
|
|
to reflect the changes.
|
|
- If a new custom type is needed, see the following document:
|
|
[Custom Class Support in PT2](https://docs.google.com/document/d/18fBMPuOJ0fY5ZQ6YyrHUppw9FA332CpNtgB6SOIgyuA).
|
|
|
|
### Notes for Large Changes
|
|
|
|
Please keep the changes as concise as possible. For major architectural changes
|
|
(>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue
|
|
(RFC) discussing the technical design and justification. Otherwise, we will tag
|
|
it with `rfc-required` and might not go through the PR.
|
|
|
|
### What to Expect for the Reviews
|
|
|
|
The goal of the vLLM team is to be a *transparent reviewing machine*. We would
|
|
like to make the review process transparent and efficient and make sure no
|
|
contributor feels confused or frustrated. However, the vLLM team is small, so we
|
|
need to prioritize some PRs over others. Here is what you can expect from the
|
|
review process:
|
|
|
|
- After the PR is submitted, the PR will be assigned to a reviewer. Every
|
|
reviewer will pick up the PRs based on their expertise and availability.
|
|
- After the PR is assigned, the reviewer will provide status updates every 2-3
|
|
days. If the PR is not reviewed within 7 days, please feel free to ping the
|
|
reviewer or the vLLM team.
|
|
- After the review, the reviewer will put an `action-required` label on the PR
|
|
if there are changes required. The contributor should address the comments and
|
|
ping the reviewer to re-review the PR.
|
|
- Please respond to all comments within a reasonable time frame. If a comment
|
|
isn't clear or you disagree with a suggestion, feel free to ask for
|
|
clarification or discuss the suggestion.
|
|
- Note that not all CI checks will be executed due to limited computational
|
|
resources. The reviewer will add `ready` label to the PR when the PR is
|
|
ready to merge or a full CI run is needed.
|
|
|
|
## Thank You
|
|
|
|
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM.
|
|
All of your contributions help make vLLM a great tool and community for everyone!
|