Jhon Honce
22d5b2e305
V2 enable ps tests
...
* Combine cobra.Command helper functions into validate package
from registry and common packages
* Introduce ChoiceValue for flags
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 15:51:37 -07:00
OpenShift Merge Robot
99f8cfc2dc
Merge pull request #5956 from jwhonce/wip/version
...
V2 restore podman -v command
2020-04-29 20:50:43 +02:00
OpenShift Merge Robot
a2127efbf8
Merge pull request #6042 from baude/systemtestfinal
...
enable final system test
2020-04-29 20:33:40 +02:00
baude
e1f1dee006
enable final system test
...
Signed-off-by: baude <bbaude@redhat.com>
2020-04-29 12:01:18 -05:00
OpenShift Merge Robot
06dce0c770
Merge pull request #5949 from jwhonce/jira/796
...
V2 Restore images list tests
2020-04-29 18:53:06 +02:00
Jhon Honce
6a586992c1
V2 restore podman -v command
...
* Removed extra spaces and improved error message
* Updated tests to use gomega matchers
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 09:15:24 -07:00
Jhon Honce
a9cc13448e
V2 Restore images list tests
...
* Fix history --quiet formatting
* Fix image inspect --format=json
* Fix image list --sort
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 08:24:56 -07:00
OpenShift Merge Robot
27aa3a7837
Merge pull request #6039 from vrothberg/enable-search-tests
...
Enable search tests
2020-04-29 17:04:22 +02:00
OpenShift Merge Robot
d1196d08d0
Merge pull request #6010 from TomSweeneyRedHat/dev/tsweeney/ctrimagefixes
...
Update podmanimage files to adjust perms on containers.conf for rootless
2020-04-29 16:59:37 +02:00
OpenShift Merge Robot
620baafa07
Merge pull request #5853 from cevich/unify_in_podman_build
...
Unify in_podman container packaging & VM packaging
2020-04-29 16:38:24 +02:00
Valentin Rothberg
5ee3af2d03
enable search tests
...
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:18 +02:00
Valentin Rothberg
2d10471b8d
pull/search options: tls verify -> skip
...
Change the logic in the options from tls-verify to skipping
verification. It require a constant brain yoga to translate
from doing verification (CLI logic) to skipping it (c/image logic).
As the code is using c/image, let's make it consistent.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:12 +02:00
OpenShift Merge Robot
c5a035b032
Merge pull request #6038 from giuseppe/v2-enable-copy
...
test: enable cp tests
2020-04-29 16:26:07 +02:00
OpenShift Merge Robot
a76a99352a
Merge pull request #6037 from vrothberg/enable-push-tests
...
Enable push tests
2020-04-29 16:20:44 +02:00
OpenShift Merge Robot
6246165f16
Merge pull request #6036 from giuseppe/fix-rootlessport-panic
...
rootlessport: use two different channels
2020-04-29 16:07:44 +02:00
OpenShift Merge Robot
de77e4b3f1
Merge pull request #6031 from mheon/release_191_in_master
...
Update release notes and README for 1.9.1 release
2020-04-29 16:05:11 +02:00
Giuseppe Scrivano
b74508fff0
test: enable cp tests
...
and fix them to use a distinct directory. I've seen a test failing as
it was using the same directory as another test, that is not related
to v2 itself.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 15:40:31 +02:00
Valentin Rothberg
5c108f75eb
login system test: enable "push ok"
...
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 15:23:30 +02:00
OpenShift Merge Robot
a22dacfa1b
Merge pull request #6035 from giuseppe/move-rootless-open-before-fork
...
rootless: move ns open before fork
2020-04-29 15:07:07 +02:00
Valentin Rothberg
4177641875
enable the push e2e tests
...
With the recent changes, push is working now.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:35:48 +02:00
Valentin Rothberg
d6d1e3860c
push: fix --tls-verify
...
Fix --tls-verify parsing and make the associated options reflect the
correct logic. Other commands are affected as well but will be fixed
later.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:33:00 +02:00
Valentin Rothberg
46b185942c
push: simplify cmd
...
The indirection via a 2nd variable isn't needed.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:14:02 +02:00
Giuseppe Scrivano
6d545bb2f7
rootlessport: use two different channels
...
The same channel is written to by two different goroutines.
Use a different channel for each of them so to avoid writing to a
closed channel.
Closes: https://github.com/containers/libpod/issues/6018
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 12:35:23 +02:00
Giuseppe Scrivano
b8db112436
specgen: honor slirp4netns
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 12:13:05 +02:00
Giuseppe Scrivano
89d4940a37
rootless: move ns open before fork
...
commit 788fdc685b
introduced a race
where the target process dies before the child process opens the
namespace files. Move the open before the fork so if it fails the
parent process can attempt to join a different container instead of
failing.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 11:44:24 +02:00
Valentin Rothberg
854293a59a
push: fix push with one argument
...
When doing a `podman push $IMG`, $IMG acts as the source and the
destination.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 11:42:36 +02:00
OpenShift Merge Robot
3e912f711b
Merge pull request #6022 from vrothberg/enable-inspect-tests
...
enable inspect tests
2020-04-29 11:21:47 +02:00
OpenShift Merge Robot
62a4befe04
Merge pull request #5998 from vrothberg/generate-systemd
...
generate systemd
2020-04-29 11:19:15 +02:00
OpenShift Merge Robot
4e21d09f98
Merge pull request #6029 from rhatdan/env
...
User specified environment happen after other environments are set
2020-04-29 08:52:14 +02:00
Valentin Rothberg
8700c2fd03
enable inspect tests
...
A surprisingly big change. A core problem was that `podman inspect`
allows for passing containers AND images with the default `--type=all`.
This only worked partially as the data was processed in isolation which
caused various issues (e.g., two separate outputs instead of one) but it
also caused issues regarding error handling.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:25:31 +02:00
Valentin Rothberg
b2414b580e
generate systemd
...
Implement `podman generate systemd` for Podman v2 and enable associated
tests.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:22:18 +02:00
Matthew Heon
af0d99f942
Update release notes and README for 1.9.1 release
...
Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-04-28 18:08:59 -04:00
TomSweeneyRedHat
9229312f2a
Update podmanimage files to adjust perms on containers.conf for rootless
...
Adding the changes to the Podman image Docker/Containerfiles similar
to @rhatdan 's changes in https://github.com/containers/buildah/pull/2332
In short it changes the perms on containers.conf so it can be used by a
rootless user.
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-04-28 17:52:14 -04:00
OpenShift Merge Robot
bf4efc1953
Merge pull request #6026 from baude/v2forcesystemtests
...
system tests must pass
2020-04-28 23:29:20 +02:00
OpenShift Merge Robot
dcac908bbe
Merge pull request #6011 from sujil02/podman-save-issue-5234
...
Fixes podman save fails when specifying an image using a digest fixes-5234
2020-04-28 23:10:20 +02:00
OpenShift Merge Robot
30b27819d0
Merge pull request #5991 from sujil02/pod-rm-test
...
Fix typos in messages pod rm
2020-04-28 22:40:09 +02:00
Daniel J Walsh
e84beeaf94
User specified environment happen after other environments are set
...
When using varlink we want to make sure that user specified environment variables
take precedence over http-proxy environment.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-28 16:29:01 -04:00
Brent Baude
517bc28360
system tests must pass
...
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 15:17:00 -05:00
Sujil02
38eb9f4a3d
Fixes podman save fails when specifying an image using a digest #5234
...
Adds check to parse normalized name and create docker archive dst reference
for tagged untagged image. Relevant test case added.
Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 16:16:30 -04:00
Sujil02
b3cfb20aa2
Fix typos in rm messages
...
Fix typos in pod rm messages
Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 15:57:40 -04:00
OpenShift Merge Robot
23be7b5049
Merge pull request #6024 from baude/v2checkmediatypew
...
check image media/manifest type for healthchecks
2020-04-28 19:21:50 +02:00
OpenShift Merge Robot
8f57f312d6
Merge pull request #6020 from giuseppe/fix-exec
...
v2, podman: fix create tests
2020-04-28 19:19:12 +02:00
Brent Baude
a255075fe8
check image media/manifest type for healthchecks
...
before looking up a healthcheck in an image, check to make sure it is a dockerv2schema image.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 11:49:58 -05:00
OpenShift Merge Robot
4ed125f7b5
Merge pull request #5907 from sujil02/systemprune-v2
...
Adding system prune for podman v2
2020-04-28 18:11:39 +02:00
OpenShift Merge Robot
5077aece7e
Merge pull request #5954 from lsm5/usable-Makefile-for-packaging
...
Makefile: install targets should not depend on build targets
2020-04-28 17:28:57 +02:00
Giuseppe Scrivano
e8e00133c1
test: enable exec tests
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 15:32:59 +02:00
Giuseppe Scrivano
a9aa9e2f78
pkg, specgen: do not hardcode user=0 in the config if not specified
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 15:25:59 +02:00
OpenShift Merge Robot
e9a1726f50
Merge pull request #6007 from baude/v2intvolumes
...
enable volume integration tests
2020-04-28 15:25:16 +02:00
Giuseppe Scrivano
c999f9daf2
specgen: remove dead code
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 14:30:55 +02:00
Giuseppe Scrivano
e76c8527dc
cmd: set correct parent for container exec
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 14:15:39 +02:00