Commit Graph

862 Commits

Author SHA1 Message Date
Anton Troshin db712e7eed
Fixing e2e tests, podman and scheduler fail with mariner images (#1450)
* Fix standalone e2e tests
Fix podman e2e install
Fix scheduler start failure on standalone mariner image variant

Signed-off-by: Anton Troshin <anton@diagrid.io>

* fix test

Signed-off-by: Anton Troshin <anton@diagrid.io>

* revert

Signed-off-by: Anton Troshin <anton@diagrid.io>

* Fix podman machine settings
Add cleanups
Remove parallel tests
Fix mariner volume mount location
Remove old build tags

Signed-off-by: Anton Troshin <anton@diagrid.io>

---------

Signed-off-by: Anton Troshin <anton@diagrid.io>
2024-10-01 09:19:35 -07:00
Josh van Leeuwen e08443b9b3
Remove Docker client dependency from standalone run (#1443)
Signed-off-by: joshvanl <me@joshvanl.dev>
2024-08-15 13:53:26 -07:00
Yaron Schneider 027f5da3e1
update redis version (#1439)
Signed-off-by: yaron2 <schneider.yaron@live.com>
2024-07-25 09:58:14 -07:00
Yaron Schneider fecf47d752
pin bitnami chart version for redis (#1437)
Signed-off-by: yaron2 <schneider.yaron@live.com>
2024-07-23 15:49:14 -07:00
Anton Troshin ad67ce58c4
Add dapr scheduler server to the status command (#1434)
Signed-off-by: Anton Troshin <anton@diagrid.io>
2024-07-22 16:38:06 -07:00
Cassie Coyle e72f95393c
Fix Scheduler Data Dir Permissions Issue (#1432)
* fix w/ @joshvanl & anton

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* add a .

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
2024-07-19 11:49:08 -07:00
Josh van Leeuwen 16a513ba7a
Change scheduler container data dir from `/var/run/...` to `/var/lib`. (#1429)
Signed-off-by: joshvanl <me@joshvanl.dev>
2024-07-18 16:29:43 -07:00
Josh van Leeuwen 30d888f4e6
Fix dapr init scheduler (#1428)
* Add E2E to validate scheduler after init.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Adds dapr_scheduler verify container

Signed-off-by: joshvanl <me@joshvanl.dev>

* Assert eventually TCP connect

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix eventually t check

Signed-off-by: joshvanl <me@joshvanl.dev>

* Write etcd-data-dir to custom path with volume

Signed-off-by: joshvanl <me@joshvanl.dev>

* Adds Helpers to test funcs

Signed-off-by: joshvanl <me@joshvanl.dev>

* Adds container name to TCP check

Signed-off-by: joshvanl <me@joshvanl.dev>

* Use rc.3 for scheduler

Signed-off-by: joshvanl <me@joshvanl.dev>

* Print container logs on failed TCP conn

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix params

Signed-off-by: joshvanl <me@joshvanl.dev>

* Use b

Signed-off-by: joshvanl <me@joshvanl.dev>

* Addfs `dev` flag to rc init

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix version check

Signed-off-by: joshvanl <me@joshvanl.dev>

* Skip TCP check on slim mode

Signed-off-by: joshvanl <me@joshvanl.dev>

* Remove debug test code

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: joshvanl <me@joshvanl.dev>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
2024-07-18 12:50:16 -07:00
Josh van Leeuwen 29d29ab549
Give scheduler a default volume, making it resilient to restarts by (#1423)
* Give scheduler a default volume, making it resilient to restarts by
default

Signed-off-by: joshvanl <me@joshvanl.dev>

* Remove dapr_scheduler volume on uninstall, gated by `--all`

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix containerErrs in standaone.go

Signed-off-by: joshvanl <me@joshvanl.dev>

* Do not attempt to delete scheduler volume if no container runtime

Signed-off-by: joshvanl <me@joshvanl.dev>

* Increase upgrade test timeout to 40m

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2024-07-17 12:13:51 -07:00
Yaron Schneider ddf43a5f55
update link (#1426)
Signed-off-by: yaron2 <schneider.yaron@live.com>
2024-07-16 23:42:12 -07:00
Josh van Leeuwen ad3442b252
dapr_scheduler: Adds scheduler-volume flag (#1422)
* dapr_scheduler: pre-create data dir

Signed-off-by: joshvanl <me@joshvanl.dev>

* Adds --scheduler-volume to specify volume for data directory

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
2024-07-12 08:22:34 -07:00
Mike Nguyen ed0d3af2d0
fix: scheduler host address passed to runtime (#1421)
* fix: scheduler host address passed to runtime

Signed-off-by: mikeee <hey@mike.ee>

* fix: scheduler client stream initialised for 1.14<

Signed-off-by: mikeee <hey@mike.ee>

* fix: modify scheduler host address validation

if the scheduler container is not active, the scheduler flag will
not be passed to the runtime

Signed-off-by: mikeee <hey@mike.ee>

* fix: lint and refactor

Signed-off-by: mikeee <hey@mike.ee>

---------

Signed-off-by: mikeee <hey@mike.ee>
2024-07-10 09:37:34 -07:00
Artur Souza 762e2bb4ac
Fix check for version to contain scheduler. (#1417)
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
2024-07-05 20:16:40 -07:00
Cassie Coyle fd1d8e85bf
Distributed Scheduler CLI Changes (#1405)
* wip

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm scheduleJob logic. keep only init/uninstall logic

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* Fixes install and uninstall of scheduler in standalone mode.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fixing path for Go tools in Darwin.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fix Go bin location for MacOS.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fix min scheduler version to be 1.14.x

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Use env var to pass scheduler host.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fix CLI build to work with latest MacOS runners from GH

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
2024-07-03 14:58:55 -07:00
dependabot[bot] 4881ca11d7
Bump golang.org/x/net from 0.21.0 to 0.23.0 (#1401)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.21.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.21.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-14 20:01:32 +05:30
Josh van Leeuwen 619cd9cd84
Update dependencies for v1.13.0-rc.6 release (#1383)
* Update dependencies for v1.13.0-rc.1 release

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update tests/e2e/upgrade/upgrade_test.go

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* Update github.com/dapr/go-sdk to v1.9.1

Signed-off-by: joshvanl <me@joshvanl.dev>

* Ping go-sdk to joshvanl main fork

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update and fix e2e tests in standalone mode

Signed-off-by: joshvanl <me@joshvanl.dev>

* Set correct rc version

Signed-off-by: joshvanl <me@joshvanl.dev>

* Revert go.mod to keep requires for kube & docker auth

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update dapr/dapr to v1.13.0-rc.2

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update to use rc to 2

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update github.com/dapr/go-sdk to main

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update to 1.13.0-rc.6

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix func name call

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2024-02-16 11:37:37 -08:00
dependabot[bot] 3ea5f9c6b2
Bump github.com/opencontainers/runc from 1.1.5 to 1.1.12 (#1380)
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.5 to 1.1.12.
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Changelog](https://github.com/opencontainers/runc/blob/v1.1.12/CHANGELOG.md)
- [Commits](https://github.com/opencontainers/runc/compare/v1.1.5...v1.1.12)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/runc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-07 13:20:32 +05:30
dependabot[bot] 1da8760f11
Bump github.com/lestrrat-go/jwx/v2 from 2.0.12 to 2.0.19 (#1377)
Bumps [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx) from 2.0.12 to 2.0.19.
- [Release notes](https://github.com/lestrrat-go/jwx/releases)
- [Changelog](https://github.com/lestrrat-go/jwx/blob/develop/v2/Changes)
- [Commits](https://github.com/lestrrat-go/jwx/compare/v2.0.12...v2.0.19)

---
updated-dependencies:
- dependency-name: github.com/lestrrat-go/jwx/v2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-23 20:33:22 -08:00
twinguy 2380446870
fix default installation directory permissions (#1375)
Signed-off-by: Kenny Meador <kenny.meador@outlook.com>
Signed-off-by: Kenny Meador <kmeador@dollargeneral.com>
Co-authored-by: Kenny Meador <kmeador@dollargeneral.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2024-01-23 16:00:06 +05:30
Luis Rascão 50e1dffec0
Fix flaky upgrade test (#1368)
* Fix flaky upgrade test

Signed-off-by: Luis Rascao <luis.rascao@gmail.com>

* fixup! Fix flaky upgrade test

Signed-off-by: Luis Rascao <luis.rascao@gmail.com>

---------

Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2024-01-23 15:25:30 +05:30
Mukundan Sundararajan f5eb4fda6c
fix upload artifact name conflict (#1373)
* fix upload test report name

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix linter errors

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix upload artifacts version and name conflicts

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix typo

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix typo

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

---------

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2024-01-18 02:07:09 -08:00
Pravin Pushkar c7e8612b11
Upgrade go to 1.21 (#1331)
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
2023-12-18 23:36:54 -08:00
Stuart Leeks 668bab451d
Add --run-file support for stdin (#1364)
If the run-file argument is speficied as '-', read the config file from stdin

Signed-off-by: Stuart Leeks <stuartle@microsoft.com>
2023-11-22 07:04:02 -08:00
dependabot[bot] a339bdf491
Bump google.golang.org/grpc from 1.57.0 to 1.57.1 (#1362)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.57.0 to 1.57.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.57.0...v1.57.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-26 12:48:03 +05:30
dependabot[bot] ac0a3cb06f
Bump golang.org/x/net from 0.15.0 to 0.17.0 (#1356)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0.
- [Commits](https://github.com/golang/net/compare/v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-12 23:35:55 +05:30
Mukundan Sundararajan d55944ccec
Merge pull request #1358 from mukundansundar/merge_rel_1.12_master
Merge rel 1.12 master
2023-10-12 04:54:22 -07:00
Mukundan Sundararajan 02eec8bbc8
Merge branch 'master' into merge_rel_1.12_master 2023-10-12 04:15:14 -07:00
Mukundan Sundararajan 1d60280de4
update dapr runtime to v1.12.0 (#1357)
* update dapr runtime to v1.12.0

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix dashboard version

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

---------

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-10-12 07:45:22 +05:30
Shubham Sharma 0c1c275972
Upgrade runtime and go-sdk versions (#1355)
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
2023-10-11 13:15:09 +05:30
Mukundan Sundararajan bb2c3a7f66
Merge pull request #1350 from mukundansundar/merge_rel_1.12_master
Merge release 1.12 master
2023-10-04 00:15:03 -07:00
Pravin Pushkar 7a09fd6b9c
Merge branch 'master' into merge_rel_1.12_master 2023-10-04 09:30:30 +05:30
hdget a08eebb5db
create dapr install dir before copy (#1112)
Signed-off-by: hdget <hdget@qq.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
2023-10-03 13:17:49 -07:00
Pravin Pushkar a38a44d27b
update runtime RC to RC.5 (#1353)
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
2023-10-03 09:37:51 -07:00
Mukundan Sundararajan 6a85f487e7 Merge branch 'release-1.12' into merge_rel_1.12_master 2023-10-03 17:51:00 +05:30
Mukundan Sundararajan df8f242fc8
add appconfig default config for dev mode multi-app run k8s (#1352)
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-10-03 17:34:40 +05:30
Mukundan Sundararajan 3fe6d8fffd
Merge branch 'master' into merge_rel_1.12_master 2023-09-29 10:44:21 -07:00
Mukundan Sundararajan 0ebded24f7
upgrade k8s client (#1349)
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-09-29 18:06:56 +05:30
Pravin Pushkar 504d4eadba
Removing preview feature for dapr run -f (#1348)
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
2023-09-27 09:03:24 -07:00
Marc Duiker 235f40cf81
Add holopin.yml config (#1344)
Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
2023-09-21 10:41:53 +05:30
Josh van Leeuwen 0c99afb4db
Updates dapr/dapr to v1.12 (#1342)
* Updates the Dapr version to v1.12.0-rc.1

Signed-off-by: joshvanl <me@joshvanl.dev>

* Use correct rc tag name

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix string match on `HTTP server is running on port x`

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix error string check for `internal gRPC server`

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update dapr/dapr to 1.12.0-rc.3

Signed-off-by: joshvanl <me@joshvanl.dev>

* Rolling restart the sidecar injector during a restart

Signed-off-by: joshvanl <me@joshvanl.dev>

* Linting

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix string matching on dapr app output logs

Signed-off-by: joshvanl <me@joshvanl.dev>

* Increase e2e tests `20m` -> `25m`

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
2023-09-20 18:19:32 +05:30
Mukundan Sundararajan 41f324016e
adding e2e test for multi app run k8s (#1336)
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-09-04 20:28:08 +05:30
Mukundan Sundararajan a15a3eb856
Initial implementation of multi app run for Kubernetes Dev (#1333)
* initial commit for multi-app run k8s impl

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix import

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* move runfileconfig

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* add protobuf conflict warn env

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* Add pubsub component. Check before component creation.

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix e2e

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix e2e

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix e2e

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* address review comments.

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

---------

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-09-04 08:42:58 +05:30
Pravin Pushkar 6738eefe2b
Multiapp run and stop implementation for windows (#1315)
* windows impl for multiapp run

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Uncommenting run on windows

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix static checks

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Kill children and grand children forcefully

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* ommiting tests for wiondows

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* rename method

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* shut down all processes

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Use job handle and named evens together to kill the processes

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* lint fix

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* revert wait to kill

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Adding E2E for windows template file run

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* rename job name

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* build failure

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

---------

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-08-30 11:06:40 +05:30
Pravin Pushkar 4d586752bc
Self Hosted E2E - fail-fast set to false (#1334)
* fail-fast set to false

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* add TODO

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

---------

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
2023-08-30 10:39:15 +05:30
Anton Troshin 60f50e3497
Add health and metrics port mapping for placement stand-alone mode (#1323)
* Add health and metrics port mapping for placement stand-alone mode

Signed-off-by: Anton Troshin <anton@diagrid.io>

* move ports declaration to const

Signed-off-by: Anton Troshin <anton@diagrid.io>

* Fix linter check: appendCombine: can combine chain of 3 appends into one (gocritic)

Signed-off-by: Anton Troshin <anton@diagrid.io>

---------

Signed-off-by: Anton Troshin <anton@diagrid.io>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2023-08-09 00:17:49 +05:30
Alessandro (Ale) Segala 650fd6fe8d
Add APP_PROTOCOL env (#1318)
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
2023-08-07 12:37:34 +05:30
Pravin Pushkar 31b9ea27ae
add release doc (#1325)
* add release doc

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Update release.md

Sample PR

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Update docs/development/release.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

---------

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
2023-07-05 07:42:24 -07:00
Mohit Pal Singh 2751f5fa74
Fix for Quote in username errors dapr init #972 (#1322)
* Fix for Quote in username errors dapr init #972

Signed-off-by: mrmtheboss <starktony239@gmail.com>

* addressed a GitHub Actions Check failure

Signed-off-by: mrmtheboss <starktony239@gmail.com>

* Addressed Shubham's comments

Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>

* Addressed Shubham's new comments

Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>

* Addressed a GitHub actions failure

Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>

* Update utils/utils.go

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>

* Added Unit test for SanitizeDir() in utils/utils_test.go

Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>

* Addressed a GitHub actions failure

Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>

* Update comment.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

---------

Signed-off-by: mrmtheboss <starktony239@gmail.com>
Signed-off-by: Mohit Pal Singh <mohit.pal.singh@outlook.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: mrmtheboss <starktony239@gmail.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
2023-06-26 11:50:24 -07:00
Vishal Yadav a4f924f49d
Adding warning for uninstall all while container runtime not running (#1310)
Signed-off-by: Vishal Yadav <vishalydv.me@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
2023-06-20 10:10:57 +05:30
Shivam Kumar Singh 7da8bd7b15
shivam-51: Add log file paths to dapr list 1228 (#1296)
* shivam-51: Add log file paths to dapr list 1228

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Minor type fix.

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Add condition for log file in dapr list

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Add tests

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Complete tests

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Fix failing e2e tests

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Use constants

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Add success tests

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Add proper assert in test

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

* Fix typo

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>

---------

Signed-off-by: Shivam Kumar Singh <shivamhere247@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-06-13 18:34:03 +05:30